From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.66]) by mx.groups.io with SMTP id smtpd.web12.1693.1582175949374298128 for ; Wed, 19 Feb 2020 21:19:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp.com header.s=selector2 header.b=gFG8VPO6; spf=pass (domain: nxp.com, ip: 40.107.21.66, mailfrom: gaurav.jain@nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYS2NlTuXG/DsVL5ghPfRH91pIedQyPlS5Klt5ijiw/FwgZRFdQ7wqe65nFCPdL6jZfgwqfS4UqRCC2CfgoB70uHhaRU+pc9PQ4Rg6havQKNwRGgdA5Dmz1myKx+d6QqmWhQLoBTuesphBkisrL4MVrJl855Q9Lm0uCPwamrnNf0LR3V0xAR3PQoLJGE7UkpGXEuj48o5z7xvSzea+CorxSTjEFj0UJYWv+5EavzMrzgYy6OCEYi7NrYCW8Id5e0LGp662iIgzlmBCTZgLQdoIc8+gsmgIk7l5EqZicubIt1I3oYvAq15kCdD8LspBlNjq4tfU/aIbiO/npeL0DqfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnD5BPvbNE9VSyv2MP4WquLBganYYmKNANSdAs4hHjc=; b=OaqpYQ+8kux+AZvxoZ7mMa1+8Cc29iEXbgQhrz7u52LQ7XXMRvuTpQEQk76njfm8uui+7IKQasFxby1CF4JnG1/43wBOTHES0lFBROUJw7NAvudwGm83jqCyJ+obS5VENMsr0d8IxiKG7egf26fw75o0iHN4wf+vq+KGN8bOrVcfYm1GctBxQIAluKUORN7mdvzVtukpry+Q51rx7w5gXGPamkcuNqFC9qLcxKrYoYlXnGYQ302/a680SWiAyNzdpSuoY3RQV1Ct71m2tx7C1I2IA6jNJPU7N/jDGUvH5pvsr1dr9fl4qZ36wZc9VDqiOy624JcjW5/BNrYiI3mf6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnD5BPvbNE9VSyv2MP4WquLBganYYmKNANSdAs4hHjc=; b=gFG8VPO6sdAPWqz2d+jnch+fPL609Xx4DLlBtIJN/0MkHJAXqIjWIWg7uVfwcV3DEWizc9jV2IL1ooTJqaGPDlMv1in64qD8oIHUtafM4aN4icqMoEPlxpA5HW52Yqbs8+pl2dEe+YBC6DDuMDGBXbuyW73l9topyeKyYyPYP0E= Received: from AM6PR04MB4087.eurprd04.prod.outlook.com (52.135.167.157) by AM6PR04MB5750.eurprd04.prod.outlook.com (20.179.2.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22; Thu, 20 Feb 2020 05:19:07 +0000 Received: from AM6PR04MB4087.eurprd04.prod.outlook.com ([fe80::ba:58fb:7ae:6af1]) by AM6PR04MB4087.eurprd04.prod.outlook.com ([fe80::ba:58fb:7ae:6af1%4]) with mapi id 15.20.2729.033; Thu, 20 Feb 2020 05:19:06 +0000 From: "Gaurav Jain" To: "Gao, Liming" , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel , Pankaj Bansal Subject: Re: [EXT] RE: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test. Thread-Topic: [EXT] RE: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test. Thread-Index: AQHV5imfb/MMSG80ZE6cvqfTjP+XZagiOzaAgAFSzBA= Date: Thu, 20 Feb 2020 05:19:06 +0000 Message-ID: References: <20200218122354.17591-1-gaurav.jain@nxp.com> <348c0fde5e8b4c0db25526eb69a27743@intel.com> In-Reply-To: <348c0fde5e8b4c0db25526eb69a27743@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=gaurav.jain@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3893c1b3-ee19-469e-0d8f-08d7b5c4689d x-ms-traffictypediagnostic: AM6PR04MB5750:|AM6PR04MB5750: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:962; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM;SFS:(10001)(10009020)(4636009)(39860400002)(376002)(136003)(396003)(366004)(346002)(199004)(189003)(8676002)(33656002)(66446008)(316002)(76116006)(66556008)(64756008)(66946007)(66476007)(8936002)(81166006)(81156014)(54906003)(7696005)(110136005)(86362001)(44832011)(53546011)(6506007)(5660300002)(52536014)(4326008)(9686003)(478600001)(55016002)(26005)(71200400001)(45080400002)(2906002)(186003)(966005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR04MB5750;H:AM6PR04MB4087.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B/Mzwx+eaLOoOvCJjhVz0ZB+vRjQseEElWhEJgRKpzBRkystyjOOclfS6kbed2eMaiiVJNlv4qFvXhKUbXlOv2fQ0ixVzxlEgyM+BwgZ++cx0DZdcSo9pTjiLa94HmaZeRKH0AP0rJ61eEtMP+RA7ez1JBIwMtZKOp9XaFRPlfup/tQ7SI5rYZPqqhNhO8I9QeWAOfqo6iXyYI2/1BwRD/7mLCWG6RqR9GLwWPklR2jQ8zZ8PsZLHbkPUARTJYQneUD3B+xdVZrrMiKVMxV8P2iT7XIYj5y0RRhcmLyYjfGHtm++MPyfcskQnHfMHjnZilhbWPEXjZMnnBsUjqH7i8bRYoO00tWY5zduoeAp7msMknTy1e5Ib8uYJs42k7Tu0yP/SOP2hf3MsTmxANFieHsrSdWg4TcAHs9gLuAQoYiN+ffmHs3dMok0zjenBqJdjL2VwFIiHjY9+wINkhldC0DBotbihHFy/VcEdJIfjxB+8mbeUVmvDBQfSO1qRjKXxb6qjflUhE6ymFMTM7TRfcnt4y3gdottJdh+cKRqwrNW3xR8BrFMxs4bKj0bvoUFOj2RNByLhGwGhZRH5BCdHcL99SQCv5BJj39dRtJMGzDKXK6saWcdjojOhorWYdN5 x-ms-exchange-antispam-messagedata: ug5zvZIl0Si7KAGHrpOvgQCyRUWQgtNzznxIlDtHjNvzUgo8nZ0PZax5+QZCYLoa8WbtMXW3bR+kfKQQVPv+RIwr4DKyCTv46QkpPd6qXHYyP5saWg6tMEXAxPKUK8byWmnfrIa9R59xHWj9mrUCMg== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3893c1b3-ee19-469e-0d8f-08d7b5c4689d X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 05:19:06.7026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VO0JiD28OhO3MuvnyMPUisrzw1oK5N00oNM2v4Cs/rwnIsAf6k2i5CA66Uus082BilDxGYZNf5gxx9VEXfsIlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5750 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > Gaurav: > Does this patch catch to edk2 stable tag 202002? Yes Thanks Gaurav > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, February 19, 2020 2:36 PM > To: devel@edk2.groups.io; Gaurav Jain > Cc: Leif Lindholm ; Ard Biesheuvel > ; Pankaj Bansal > Subject: [EXT] RE: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Assert= s in > SCT Runtime Services test. >=20 > Caution: EXT Email >=20 > Gaurav: > Does this patch catch to edk2 stable tag 202002? >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gaurav > > Jain > > Sent: Tuesday, February 18, 2020 8:24 PM > > To: devel@edk2.groups.io > > Cc: Leif Lindholm ; Ard Biesheuvel > > ; Pankaj Bansal ; > > Gaurav Jain > > Subject: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Asserts in SCT > Runtime Services test. > > > > ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test. > > SCT Test expect return as Invalid Parameter. > > So removed ASSERT(). > > > > Added Time Validity Checks in SetWakeupTime. > > > > Signed-off-by: Gaurav Jain > > --- > > Changes in v2: > > - reverted changes related to valid range of years. > > --- > > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > > b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > > index 08fb9b0100b6..70a0d78125b9 100644 > > --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > > +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > > @@ -85,10 +85,6 @@ IsDayValid ( > > IN EFI_TIME *Time > > ) > > { > > - ASSERT (Time->Day >=3D 1); > > - ASSERT (Time->Day <=3D mDayOfMonth[Time->Month - 1]); > > - ASSERT (Time->Month !=3D 2 || IsLeapYear (Time) || Time->Day <=3D 2= 8); > > - > > if (Time->Day < 1 || > > Time->Day > mDayOfMonth[Time->Month - 1] || > > (Time->Month =3D=3D 2 && !IsLeapYear (Time) && Time->Day > 28))= { > > @@ -113,6 +109,7 @@ IsTimeValid( > > Time->Hour > 23 || > > Time->Minute > 59 || > > Time->Second > 59 || > > + Time->Nanosecond > 999999999 || > > !IsValidTimeZone (Time->TimeZone) || > > !IsValidDaylight (Time->Daylight)) { > > return FALSE; > > @@ -254,6 +251,9 @@ SetWakeupTime ( > > OUT EFI_TIME *Time > > ) > > { > > + if (Time =3D=3D NULL || !IsTimeValid (Time)) { > > + return EFI_INVALID_PARAMETER; > > + } > > return LibSetWakeupTime (Enabled, Time); } > > > > -- > > 2.17.1 > > > > > >=20