From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.55]) by mx.groups.io with SMTP id smtpd.web11.761.1660897591156089825 for ; Fri, 19 Aug 2022 01:26:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=PBpbN1c1; spf=pass (domain: arm.com, ip: 40.107.21.55, mailfrom: rohit.mathew@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Hdq+exAA8rolqO6H5NDibLVq8sh7j9o+mRmE7itClJvR5XJykeOXzINmb2hLeLfxOtW54YARuuDGa8WDGPEAdsGF53cHkftkCx/6BwZ5bitfBlBKZAEQ7y5AOFRRc8Rwchoc01OWCCrxUhZ/vbJgle7vYIFCgmdTLSy8oX503NWVyicz/7WkPeUKLyiAP36ys9GIpFv7Qj4mH8W+NV2bqLPRaJxieqcJZFlKfXc2ziMgDyR4Wf7ZWCa3X6WG6t33S6qp5WiCFM7XZWvoBJ9NkBWiTjXc0QA2P2LdgDGqAyoq9Rf6zC0MGCM2MEVD5Ben37xiETYsPVyB/u+pUtyuJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RcmGC6Yc9hxFKPw0ZohQtQUfPTq0tfVffIcVJjsVh1g=; b=NEB8D6Hh4PEvrwGJ92KzWzgIfhb0euwNxolNT1CvE6mdO3nH2S4lo62NW+RtKzlYP5W8CG4IU+gaQC9xmn9I8dAKvQWC6bSyLz1W9QRbyxw8VzQ4DxrmaT2JiRC4KpIcb1sbDsLg2PpRMKK9pTm5EQCZCirmDvuoEFmvZTg95AUWBXtJUryjiVgq7BvH7JcVeAvJSVsQVpv6gf12Q8OSQ4xfXaFP/aidBbTjUFw36Dpjr+1thCPQ4WjPOdkiS8i51FvlfaTThA/rJpuQUuXGJlcfaqEz68Ntg5oXK+F/0oM7h2r3DY0KOcHmowO6QPbGwH6Hv0jS6NNx/hO236xgAA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcmGC6Yc9hxFKPw0ZohQtQUfPTq0tfVffIcVJjsVh1g=; b=PBpbN1c12EfUev9dEg/LG94nbLLZpoGZXi0TeVGq11zlrS37A7bxBKV5uuLyoRfQ9boEXCZArdglP6dTze+hJTXWe1UhHF482g0MdjLF0TWepKfI8PNTXUHu1EKdsXn5Y74ZpAPQklS3fuOhcgaSRhkmTBR/qpZ5EnLb+WPce9Y= Received: from AM5PR0701CA0057.eurprd07.prod.outlook.com (2603:10a6:203:2::19) by PAXPR08MB6686.eurprd08.prod.outlook.com (2603:10a6:102:13e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Fri, 19 Aug 2022 08:26:27 +0000 Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::4c) by AM5PR0701CA0057.outlook.office365.com (2603:10a6:203:2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.9 via Frontend Transport; Fri, 19 Aug 2022 08:26:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Fri, 19 Aug 2022 08:26:26 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 19 Aug 2022 08:26:25 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0df8038721cb.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0A323177-276F-4ACC-97E5-0336F861FB43.1; Fri, 19 Aug 2022 08:26:16 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0df8038721cb.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 19 Aug 2022 08:26:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eb2Defuh2KpHWxhObDKCrfgx+oTqb1PFdRBkk2NFSWX62+WuIlm0/ZmFiWadTHyJAFLKRrT6oOPC158aQoWkz/+SZzjayRdlxPu3lrLbKt5YYUc7uFcGYFs7OsBm8xYESbke2ILj/BPPVPQtLjKOQWShVvPiv9cjldacSZ1PnqyAz6sqiGXu7FXELHgv2n4dIEjiGBBMUtkmtjW80r8B6U6z1beHFl039zNAFlbkXk/N4/L8Vc3gXUzm9nVPaSEz7DRsf4asvL1F/UyqrK3tgc5dNtoOc32R3lobLtwJZuuIVt1v2VMfXWXhfscUV5ogfK9WuTWl+k7gRJgvn/3cMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RcmGC6Yc9hxFKPw0ZohQtQUfPTq0tfVffIcVJjsVh1g=; b=Q1+reqOKAmJBj7q28mH80p0S4Iqnuyu9CQwweT42RKXiFRK6neJKXxDGwWJH7vrzDeVMnWXQCTDZ9OoHExA+w82fd3rB1pfT/wEmjCFGjnm0gy+7EFaYO4RzHh0nfnWoST+EwO7eVhPrr8XQ2PPtOG1lGAK6VyIm/wZmWqhboovuwKse927oYycwS5N2erkyQTv4V6iLF62YhVn4eLZRb73y8VbofApvyEE89gFqXhZpTsxS6HZI/6FrMnE1DQvSUqKFykEcZVs3j9aTDQsI0IfPE+5gZnUPXVRQee7DNSk5k592JTCNs9rf1Y7l+p/9L4e+jOvZo1A8LqwTeAtF2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcmGC6Yc9hxFKPw0ZohQtQUfPTq0tfVffIcVJjsVh1g=; b=PBpbN1c12EfUev9dEg/LG94nbLLZpoGZXi0TeVGq11zlrS37A7bxBKV5uuLyoRfQ9boEXCZArdglP6dTze+hJTXWe1UhHF482g0MdjLF0TWepKfI8PNTXUHu1EKdsXn5Y74ZpAPQklS3fuOhcgaSRhkmTBR/qpZ5EnLb+WPce9Y= Received: from AM6PR08MB3783.eurprd08.prod.outlook.com (2603:10a6:20b:8a::13) by PR3PR08MB5819.eurprd08.prod.outlook.com (2603:10a6:102:92::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 19 Aug 2022 08:26:12 +0000 Received: from AM6PR08MB3783.eurprd08.prod.outlook.com ([fe80::2012:400b:f926:7801]) by AM6PR08MB3783.eurprd08.prod.outlook.com ([fe80::2012:400b:f926:7801%6]) with mapi id 15.20.5546.016; Fri, 19 Aug 2022 08:26:12 +0000 From: "Rohit Mathew" To: "devel@edk2.groups.io" , "username@nvidia.com" , Sami Mujawar , Alexei Fedorov , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" CC: Swatisri Kantamsetti , Thomas Abraham , Thanu Rangarajan , nd Subject: Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table Thread-Topic: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table Thread-Index: AQHYsb2ZZQdbvCQTB0Go+zl5ZNUfvK21Lnkw Date: Fri, 19 Aug 2022 08:26:12 +0000 Message-ID: References: <7f8a5c9bbdf1a1f01c6fc822fa298067d280079a.1660667637.git.swatisrik@nvidia.com> In-Reply-To: <7f8a5c9bbdf1a1f01c6fc822fa298067d280079a.1660667637.git.swatisrik@nvidia.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0F10A07293C75A49AE60284499197C5F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d6cd16c4-a1b5-4342-9fba-08da81bc8231 x-ms-traffictypediagnostic: PR3PR08MB5819:EE_|VE1EUR03FT017:EE_|PAXPR08MB6686:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /d5nCq6yJEcXRb5+AIyoYA5D2XJRSM7SGoRlxg3fMP8a4EuIH/sraczjStNC70NOAt2h16W+0i9/cJGKpmX5twwwRLAv+wwxAgKP2zizSG3GFQJPowgyZJCKz/AfYI28rW5pNU5DIaGsu08YXPZ9GK8UVkoMSAKbhnr5wCBp9lyTOBOjeleCaLtu2L+zRQGpwery+hnsbtMcFmbP1yNs3EtAIpRcROm1qf/uxxP3/pkD/XFWtSL8QWAPGbzbVnwf5Wpx/kwr7A3B5+kEVjEYCDUKOKzWQi80IirZ+3m1HYV83AgOKZjLdx8jolGsFixvfY57IhoR7nFvBNbjbos4wZ62ljNcz6VjeryHGKz8L0R2py1BxBSg1VVj1cSTMyo+7wskC2Ukz0o01K1U6irYLU/Iumkv82p8MVTLneBD2f1Lot7pulhYgYZy6ft8AQCpXLkpthr6Uh0I2JolXmgM1yJB66O/8HnNwG4ORkv0rY3d2F1cixqNkdmpYMvly8NDzlPEkg70whhoKe/rLb6veX4Vet6ac31veKqZU1LjxKB0J3mNgLLrblGujAj7/FtQJWZRDBg3ZfiMwx2KQ8l/K57vCyabHbzrNxU31y5BHdlAWeEPq+1y6cWFq5P8J7FzMbPiG2MPHnHHAbmQydYJLgMt/SYBxy0M+ebGAGMHp2yTfgp0aLzUVovw5GHV7Q69vc/fMvc+YSuZJO5YjFlxSAmLjcRGzuxst9UbT9LBZh+LosVThg6v3FkiZ1bYxLWQfecruzJKz7pqSVd8g+gvLkYq5MJjomuGywsOhYnsbGv0RsRPBMYQ3NwvcXiOW6r8IsJZjLvF+xfGlXqq04wsIg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3783.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(366004)(136003)(376002)(5660300002)(54906003)(38100700002)(38070700005)(122000001)(8936002)(186003)(83380400001)(4326008)(55016003)(316002)(71200400001)(66476007)(66446008)(64756008)(52536014)(76116006)(110136005)(8676002)(66556008)(66946007)(19627235002)(478600001)(33656002)(966005)(2906002)(6506007)(7696005)(86362001)(9686003)(53546011)(41300700001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5819 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Rohit.Mathew@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ad080dd3-0296-4cfd-c482-08da81bc79f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Fe5Pt4jNnrhoTAUlxbYW+q5zLXLPvXZMjNaWbpS0kKBhCS4Ph0Fupv2EXV7bzVWc+C7ehgLXQGXn54XLs0w+FtJfRnHKWUr4zDYa66eomzIyQ3TswmkCqSc+EqiFriIcrHrBKDJG5H69A+u52fo5HKTgox6wZDjsD5BYqP/VfJ6qu5DajMaeJAJu0II8QnwhlrFa7uWT9lqx183x0bWTKqGClfW9uXfECULqaZhDWKyLpLnINLQ4VrT8y8Sr8FTAqi6QRy/VR4LWuO8eY0rMK9UZKcQ7VHbQcjAkqki79ao6IH3sF+rn6G5/hbWWDqU3X2iL1vNHI6EnSIBfpCAafQCaNCfV7/Y2JFAqnHqQ61XJO+nEhzU6DKY4YsDk8XUOUWgU3MLE4V67fbRHI950lPTWEhsGVoZPpW63UUA/IU/SR4L06jMwCR8AvSjEJ4gQoSAYoapXfRoKpYTZo3wPXPj7HbzwXfx3Pdt7I32tYR06Is5DYpVtNr+FmTtRgPmwZNHX16BGan0opSluwDddITyFRSXkh3L5HMxXCNznDh9rkhWPTTzvJURh6PZJqrvNPAAHQJXpJioz6oLokoYY2pNaLHh2JWYPnoD4YZqTEcnMAk9Gv88j83pAqDLy3E/8+F8ul37mI97UN+EKg07UyGVwJjYVnTK9BKTA/vdebhNkmLhm8iSLUano0YhyDuzCitUdJDDTrYMpS3MQkFdIEele59jywlMV21QfdYVm2j63YQrp2CZOruIJXkn/xU/lvIoZXaSgjP8KdkxpJUJjciOclis/r+OP1kASaxts7N4Uu4wsc8PDYwGcZKe9z/xGKrwL+3eyScOXDkOm1GcCw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(36840700001)(40470700004)(46966006)(966005)(47076005)(33656002)(53546011)(70586007)(70206006)(336012)(7696005)(8676002)(4326008)(6506007)(52536014)(5660300002)(41300700001)(9686003)(26005)(478600001)(40460700003)(8936002)(86362001)(55016003)(186003)(110136005)(316002)(54906003)(19627235002)(2906002)(40480700001)(81166007)(356005)(82310400005)(82740400003)(36860700001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 08:26:26.3024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6cd16c4-a1b5-4342-9fba-08da81bc8231 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6686 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Swatisri, Thanks for the patch. Please find my comments inline marked [Rohit] - > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Name > via groups.io > Sent: 16 August 2022 21:18 > To: devel@edk2.groups.io; Sami Mujawar ; > Alexei Fedorov ; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com > Cc: Swatisri Kantamsetti > Subject: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table >=20 > From: Swatisri Kantamsetti >=20 > Added MPAM table header, MSC and Resource Node info structures >=20 > Signed-off-by: Swatisri Kantamsetti > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 5 ++ > MdePkg/Include/IndustryStandard/Mpam.h | 69 > ++++++++++++++++++++++++ > 2 files changed, 74 insertions(+) > create mode 100644 MdePkg/Include/IndustryStandard/Mpam.h >=20 > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index fe5ebfac2b..e54f631186 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -2952,6 +2952,11 @@ typedef struct { > /// > #define > EFI_ACPI_6_4_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SI > GNATURE SIGNATURE_32('P', 'P', 'T', 'T') >=20 > +/// > +/// "MPAM" Memory System Resource Partitioning And Monitoring Table > /// > +#define > +EFI_ACPI_6_4_MEMORY_SYSTEM_RESOURCE_PARTITIONING_MONITORI > NG_TABLE_STRUC > +TURE_SIGNATURE SIGNATURE_32('M', 'P', 'A', 'M') > + > /// > /// "PSDT" Persistent System Description Table /// diff --git > a/MdePkg/Include/IndustryStandard/Mpam.h > b/MdePkg/Include/IndustryStandard/Mpam.h > new file mode 100644 > index 0000000000..e0f75f0114 > --- /dev/null > +++ b/MdePkg/Include/IndustryStandard/Mpam.h > @@ -0,0 +1,69 @@ > +/** @file > + ACPI Memory System Resource Partitioning And Monitoring (MPAM) > + as specified in ARM spec DEN0065 > + > + Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved. > + Copyright (c) 2022, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef _MPAM_H_ > +#define _MPAM_H_ > + > +#pragma pack(1) > + > +/// > +/// Memory System Resource Partitioning and Monitoring Table (MPAM) > /// > +typedef struct { > + EFI_ACPI_DESCRIPTION_HEADER Header; > + UINT32 NumNodes; > + UINT32 NodeOffset; > + UINT32 Reserved; > +} > +EFI_ACPI_6_4_MEMORY_SYSTEM_RESOURCE_PARTITIONING_MONITORI > NG_TABLE_HEADE > +R; [Rohit] Shouldn't the header be followed by MSC node body type as defined i= n MPAM ACPI 1.0, section 2, table 3 - The MPAM table and section 2.1, table= 4 - MSC Node body? > + > +/// > +/// MPAM Revision (as defined in ACPI 6.4 spec.) /// #define > +EFI_ACPI_6_4_MEMORY_SYSTEM_RESOURCE_PARTITIONING_MONITORI > NG_TABLE_REVIS > +ION 0x01 > + > +/// > +/// Memory System Controller Node Structure /// > + > +typedef struct { > + UINT16 Length; > + UINT16 Reserved; > + UINT32 Identifier; > + UINT64 BaseAddress; > + UINT32 MmioSize; > + UINT32 OverflowInterrupt; > + UINT32 OverflowInterruptFlags; [Rohit] Would it be better to have a type (possibly bitfield struct) instea= d of a plain UINT32 for Flags? (MPAM ACPI 1.0, section 2.1.1, table 5 - Int= errupt flags) > + UINT32 Reserved1; > + UINT32 OverflowInterruptAff; > + UINT32 ErrorInterrupt; > + UINT32 ErrorInterruptFlags; [Rohit ] Same comment as before above. > + UINT32 Reserved2; > + UINT32 ErrorInterruptAff; > + UINT32 MaxNRdyUsec; > + UINT64 LinkedDeviceHwId; > + UINT32 LinkedDeviceInstanceHwId; > + UINT32 NumResourceNodes; > +} EFI_ACPI_6_4_MPAM_MSC_NODE; > + > +/// > +/// Resource Node Structure > +/// > + > +typedef struct { > + UINT32 Identifier; > + UINT8 RisIndex; > + UINT16 Reserved1; > + UINT8 LocatorType; > + UINT64 Locator; [Rohit ] Shouldn't " Locator " field be 12 bytes in size, possibly a separa= te type? (MPAM ACPI 1.0, section 2.2, table 7 - Resource node and section 2= .3.2 table 10 - locator descriptor) > + UINT32 NumFuncDep; > +} EFI_ACPI_6_4_MPAM_RESOURCE_NODE; [Rohit] Since "NumFuncDep" field is part of EFI_ACPI_6_4_MPAM_RESOURCE_NODE= type and this could be non-zero, should we also need the type for function= al dependency descriptors? (MPAM ACPI 1.0, section 2.2.1, table 8 - Functio= nal dependency descriptor) [Rohit] Also, could some of the commonly used macros be added to this heade= r, please? (location types, MPAM interrupt mode, interrupt types, affinity = type, etc) > + > +#pragma pack() > + > +#endif > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20 Regards, Rohit