Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

["Rohit Mathew" <rohit.mathew@arm.com>]

Hi Pierre

> -----Original Message-----
> From: Rohit Mathew
> Sent: Monday, August 7, 2023 1:45 PM
> To: Pierre Gondois <pierre.gondois@arm.com>; devel@edk2.groups.io
> Cc: Thomas Abraham <thomas.abraham@arm.com>; Sami Mujawar
> <Sami.Mujawar@arm.com>; James Morse <James.Morse@arm.com>; Ray Ni
> <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; nd
> <nd@arm.com>
> Subject: RE: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM
> Parser
> 

For this snippet

> >>> +
> >>> +    if (Status != EFI_SUCCESS) {
> >>> +      return Status;
> >>> +    }
> >>> +
> >>> +    // Reset locator to start of the locator descriptor.
> >>> +    InterconnectOffsetPtr = (UINT64 *)Locator;
> >>> +
> >>> +    // If offset field has been set, parse the interconnect description table.
> >>
> >> if ((
> >> (without extra spaces)
> >
> > [Rohit] Ack.
> >

[Rohit] I just realized that uncrustify was adding the spaces here. This is my command.
.pytool/Plugin/UncrustifyCheck/mu-uncrustify-release_extdep/Linux-x86/uncrustify -c .pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F files --replace --no-backup --if-changed

> >>
> >>> +    if (  (*LocatorType == EFI_ACPI_MPAM_LOCATION_INTERCONNECT)
> >>> +       && (InterconnectOffsetPtr != NULL))
> >>> +    {
> >>> +      Status = ParseInterconnectDescriptorTable (
> >>> +                 Ptr,
> >>> +                 AcpiTableLength,
> >>> +                 Offset,
> >>> +                 *InterconnectOffsetPtr
> >>> +                 );
> >>> +
> >>> +      if (Status != EFI_SUCCESS) {
> >>> +        return Status;
> >>> +      }
> >>> +    }
> >>> +
> >>> +    ResourceIndex++;
> >>> +  }
> >>> +
> >>> +  return EFI_SUCCESS;
> >>> +}
> >>> +

Regards,
Rohit


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107643): https://edk2.groups.io/g/devel/message/107643
Mute This Topic: https://groups.io/mt/99066188/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-