From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"adr.her.arc.95@gmail.com" <adr.her.arc.95@gmail.com>
Cc: "Adrián Herrera" <adr.her.arc.95@gmail.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH] Platform/ARM/VExpressPkg: Fix unused but set
Date: Mon, 26 Apr 2021 17:58:14 +0000 [thread overview]
Message-ID: <AM6PR08MB37845A7739C6DEEFDB82429584429@AM6PR08MB3784.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2c5c5a650d650fddf2c3f1b435cec070da4e825f.1619206925.git.adr.her.arc.95@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]
Hi Adrian,
Thank you for this patch.
The changes look good to me. Can you let me know which compiler toolchain flagged up this error/build crash, please?
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Adrián Herrera via groups.io <adr.her.arc.95=gmail.com@groups.io>
Date: Saturday, 24 April 2021 at 03:58
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Adrián Herrera <adr.her.arc.95@gmail.com>
Subject: [edk2-devel] [PATCH] Platform/ARM/VExpressPkg: Fix unused but set
Remove unused but set variables in GetArmNameSpaceObject. These caused a
build crash due to -Werror=unused-but-set-variable.
Signed-off-by: Adrián Herrera <adr.her.arc.95@gmail.com>
---
.../ConfigurationManagerDxe/ConfigurationManager.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index e99fbb654f..d169cd2c5d 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -721,8 +721,6 @@ GetArmNameSpaceObject (
UINTN Smmuv3Count;
UINTN ItsGroupCount;
UINTN ItsIdentifierArrayCount;
- UINTN RootComplexCount;
- UINTN DeviceIdMappingArrayCount;
UINTN PciConfigSpaceCount;
if ((This == NULL) || (CmObject == NULL)) {
@@ -739,15 +737,11 @@ GetArmNameSpaceObject (
Smmuv3Count = 1;
ItsGroupCount = 1;
ItsIdentifierArrayCount = ARRAY_SIZE (PlatformRepo->ItsIdentifierArray);
- RootComplexCount = 1;
- DeviceIdMappingArrayCount = ARRAY_SIZE (PlatformRepo->DeviceIdMapping);
PciConfigSpaceCount = 1;
} else {
Smmuv3Count = 0;
ItsGroupCount = 0;
ItsIdentifierArrayCount = 0;
- RootComplexCount = 0;
- DeviceIdMappingArrayCount = 0;
PciConfigSpaceCount = 0;
}
--
2.30.0
[-- Attachment #2: Type: text/html, Size: 6671 bytes --]
prev parent reply other threads:[~2021-04-26 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 19:43 [PATCH] Platform/ARM/VExpressPkg: Fix unused but set Adrián Herrera
2021-04-26 17:58 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB37845A7739C6DEEFDB82429584429@AM6PR08MB3784.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox