public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre Gondois <Pierre.Gondois@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"leif@nuviainc.com" <leif@nuviainc.com>,
	"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	"sean.brogan@microsoft.com" <sean.brogan@microsoft.com>,
	"Bret.Barkelew@microsoft.com" <Bret.Barkelew@microsoft.com>,
	nd <nd@arm.com>
Subject: Re: [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
Date: Thu, 22 Apr 2021 10:02:49 +0000	[thread overview]
Message-ID: <AM6PR08MB378469829F31232A9230F79584469@AM6PR08MB3784.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210421122048.11729-7-Pierre.Gondois@arm.com>

[-- Attachment #1: Type: text/plain, Size: 7593 bytes --]

Hi Pierre,

I have a few minor comments marked inline as [SAMI].
With those changed.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
From: Pierre Gondois <Pierre.Gondois@arm.com>

Add ArmPkg.ci.yaml to configure the CI for the
ArmPkg.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 ArmPkg/ArmPkg.ci.yaml | 222 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 222 insertions(+)
 create mode 100644 ArmPkg/ArmPkg.ci.yaml

diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
new file mode 100644
index 000000000000..ba502cd647c9
--- /dev/null
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -0,0 +1,222 @@
+## @file
+# CI configuration for ArmPkg
+#
+# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+    ## options defined .pytool/Plugin/LicenseCheck
+    "LicenseCheck": {
+        "IgnoreFiles": []
+    },
+
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        ## Both file path and directory path are accepted.
+        "IgnoreFiles": [
+            "Library/ArmSoftFloatLib/berkeley-softfloat-3"
+        ]
+    },
+
+    ## options defined .pytool/Plugin/CompilerPlugin
+    "CompilerPlugin": {
+        "DscPath": "ArmPkg.dsc"
+    },
+
+    ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+    "HostUnitTestCompilerPlugin": {
+        "DscPath": "" # Don't support this test
+    },
+
+    ## options defined .pytool/Plugin/CharEncodingCheck
+    "CharEncodingCheck": {
+        "IgnoreFiles": []
+    },
+
+    ## options defined .pytool/Plugin/DependencyCheck
+    "DependencyCheck": {
+        "AcceptableDependencies": [
+            "ArmPlatformPkg/ArmPlatformPkg.dec",
+            "ArmPkg/ArmPkg.dec",
+            "EmbeddedPkg/EmbeddedPkg.dec",
+            "MdeModulePkg/MdeModulePkg.dec",
+            "MdePkg/MdePkg.dec",
+            "ShellPkg/ShellPkg.dec"
[SAMI] Can this list be sorted in alphabetical order, please?
[/SAMI]
+        ],
+        # For host based unit tests
+        "AcceptableDependencies-HOST_APPLICATION":[
+            "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+        ],
+        # For UEFI shell based apps
+        "AcceptableDependencies-UEFI_APPLICATION":[],
+        "IgnoreInf": []
+    },
+
+    ## options defined .pytool/Plugin/DscCompleteCheck
+    "DscCompleteCheck": {
+        "IgnoreInf": [],
+        "DscPath": "ArmPkg.dsc"
+    },
+
+    ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+    "HostUnitTestDscCompleteCheck": {
+        "IgnoreInf": [""],
+        "DscPath": "" # Don't support this test
+    },
+
+    ## options defined .pytool/Plugin/GuidCheck
+    "GuidCheck": {
+        "IgnoreGuidName": [],
+        "IgnoreGuidValue": [],
+        "IgnoreFoldersAndFiles": [],
+        "IgnoreDuplicates": [],
+    },
+
+    ## options defined .pytool/Plugin/LibraryClassCheck
+    "LibraryClassCheck": {
+        "IgnoreHeaderFile": []
+    },
+
+    ## options defined .pytool/Plugin/SpellCheck
+    "SpellCheck": {
+        "AuditOnly": False,
+        "IgnoreFiles": [
+            "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
+        ],                           # use gitignore syntax to ignore errors
+                                     # in matching files
+        "ExtendWords": [
+          "api's",
+          "ackintid",
[SAMI] Can this list be sorted in alphabetical order, please?
[/SAMI]
+          "actlr",
+          "aeabi",
+          "ashldi",
+          "ashrdi",
+          "ccidx",
+          "ccsidr",
+          "clidr",
+          "clrex",
+          "clzsi",
+          "cpuactlr",
+          "csselr",
+          "ctzsi",
+          "cygdrive",
+          "cygpaths",
+          "datas",
+          "dcmpeq",
+          "dcmpge",
+          "dcmpgt",
+          "dcmple",
+          "dcmplt",
+          "ddisable",
+          "divdi",
+          "divsi",
+          "dmdepkg",
+          "drsub",
+          "eoi'ed",
[SAMI] I don’t think there is such a word. Should the original text be fixed?
[/SAMI]
+          "fcmpeq",
+          "fcmpge",
+          "fcmpgt",
+          "fcmple",
+          "fcmplt",
+          "ffreestanding",
+          "frsub",
+          "hisilicon",
+          "iccbpr",
+          "icciar",
+          "iccicr",
+          "icciidr",
+          "iccpmr",
+          "icdicer",
+          "icdicfr",
+          "icdictr",
+          "icdiser",
+          "icdisr",
+          "icdsgir",
+          "icenabler",
+          "intid",
+          "ipriority",
+          "irouter",
+          "isenabler",
+          "istatus",
+          "itargets",
+          "lable",
+          "ldivmod",
+          "ldmdb",
+          "ldmia",
+          "ldrbt",
+          "ldrex",
+          "ldrexb",
+          "ldrexd",
+          "ldrexh",
+          "ldrhbt",
+          "ldrht",
+          "ldrsb",
+          "ldrsbt",
+          "ldrsh",
+          "lshrdi",
+          "moddi",
+          "modsi",
+          "mpidr",
+          "muldi",
+          "mullu",
+          "nonshareable",
+          "nsacr",
+          "nsasedis",
+          "nuvia",
+          "oldit",
+          "readc",
+          "revsh",
+          "rfedb",
+          "sctlr",
+          "smccc",
+          "smlabb",
+          "smlabt",
+          "smlad",
+          "smladx",
+          "smlatb",
+          "smlatt",
+          "smlawb",
+          "smlawt",
+          "smlsd",
+          "smlsdx",
+          "smmla",
+          "smmlar",
+          "smmls",
+          "smmlsr",
+          "sourcery",
+          "srsdb",
+          "stmdb",
+          "stmia",
+          "strbt",
+          "strexb",
+          "strexd",
+          "strexh",
+          "strht",
+          "switchu",
+          "tpidrurw",
+          "ttbcr",
+          "typer",
+          "ucmpdi",
+          "udivdi",
+          "udivmoddi",
+          "udivsi",
+          "uefi's",
+          "uldiv",
+          "umoddi",
+          "umodsi",
+          "usada",
+          "vlpis",
+          "writec"
+        ],                          # words to extend to the dictionary for this package
+        "IgnoreStandardPaths": [    # Standard Plugin defined paths that
+            "*.asm", "*.s"          # should be ignore
+        ],
+        "AdditionalIncludePaths": [] # Additional paths to spell check
+                                     # (wildcards supported)
+    }
+}
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[-- Attachment #2: Type: text/html, Size: 21800 bytes --]

  reply	other threads:[~2021-04-22 10:03 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-21 12:20 ` [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003 PierreGondois
2021-04-22  9:40   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
2021-04-22  9:40   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
2021-04-21 19:13   ` [edk2-devel] " brbarkel
2021-04-26 16:40     ` PierreGondois
2021-04-26 20:58       ` [EXTERNAL] " Bret Barkelew
2021-04-22  9:51   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
2021-04-21 19:14   ` [edk2-devel] " brbarkel
2021-04-22  9:52   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 05/12] ArmPkg: Correct small typos PierreGondois
2021-04-22  9:53   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
2021-04-22 10:02   ` Sami Mujawar [this message]
2021-04-27 14:30     ` PierreGondois
2021-04-21 12:20 ` [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
2021-04-22 10:05   ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
2021-04-22 10:07   ` Sami Mujawar
2021-04-26 20:54   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
2021-04-22 10:07   ` Sami Mujawar
2021-04-26 20:55   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
2021-04-22 10:08   ` Sami Mujawar
2021-04-26 20:56   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-22 10:09   ` Sami Mujawar
2021-04-26 20:58   ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
2021-04-22 10:09   ` Sami Mujawar
2021-04-26 20:57   ` [EXTERNAL] " Bret Barkelew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR08MB378469829F31232A9230F79584469@AM6PR08MB3784.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox