Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar From: Pierre.Gondois@arm.com Date: Wednesday, 21 April 2021 at 13:21 To: devel@edk2.groups.io , Sami Mujawar , leif@nuviainc.com , ardb+tianocore@kernel.org , sean.brogan@microsoft.com , Bret.Barkelew@microsoft.com Subject: [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec From: Pierre Gondois Some library headers are missing/incorrect in ArmPkg.dec. This makes the 'LibraryClassCheck' CI test fail. This patch adds/corrects them. According to .pytool/Readme about the 'LibraryClassCheck' test: This test scans at all library header files found in the `Library` folders in all of the package's declared include directories and ensures that all files have a matching LibraryClass declaration in the DEC file for the package. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3254 Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3258 Signed-off-by: Pierre Gondois --- ArmPkg/ArmPkg.dec | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index a8a22c649ff8..496f588bd0ca 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -2,7 +2,7 @@ # ARM processor package. # # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -29,14 +29,20 @@ [Includes.common] [LibraryClasses.common] ArmLib|Include/Library/ArmLib.h ArmMmuLib|Include/Library/ArmMmuLib.h - SemihostLib|Include/Library/Semihosting.h + SemihostLib|Include/Library/SemihostLib.h DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h ArmDisassemblerLib|Include/Library/ArmDisassemblerLib.h ArmGicArchLib|Include/Library/ArmGicArchLib.h - ArmMtlLib|ArmPlatformPkg/Include/Library/ArmMtlLib.h + ArmMtlLib|Include/Library/ArmMtlLib.h ArmSvcLib|Include/Library/ArmSvcLib.h OpteeLib|Include/Library/OpteeLib.h StandaloneMmMmuLib|Include/Library/StandaloneMmMmuLib.h + ArmGenericTimerCounterLib|Include/Library/ArmGenericTimerCounterLib.h + ArmGicLib|Include/Library/ArmGicLib.h + ArmHvcLib|Include/Library/ArmHvcLib.h + OemMiscLib|Include/Library/OemMiscLib.h + ArmSmcLib|Include/Library/ArmSmcLib.h + [Guids.common] gArmTokenSpaceGuid = { 0xBB11ECFE, 0x820F, 0x4968, { 0xBB, 0xA6, 0xF7, 0x6A, 0xFE, 0x30, 0x25, 0x96 } } -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.