From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.49]) by mx.groups.io with SMTP id smtpd.web12.8358.1619529757732869100 for ; Tue, 27 Apr 2021 06:22:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=dH+nNSwr; spf=pass (domain: arm.com, ip: 40.107.6.49, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=acaySSgOH1Isx2HW57KQfqX+WgOT+Hi+c/Bq93ZChvk=; b=dH+nNSwranO+MjXMLr9+o6cotopKBa7QN6wg/tH9N368LegzNfexSBwd3HHQM9sS/JDHzOjo5KodI2OEzsG+jNW2UfVDDybnazPKak4xh5ZaVfMvxFwO/wgKPSxlBJKP7yemUgFfX16RC5EyniI7Slpx7FshsmYhY1n/v0WlkvE= Received: from AM5PR0601CA0040.eurprd06.prod.outlook.com (2603:10a6:203:68::26) by DB7PR08MB3244.eurprd08.prod.outlook.com (2603:10a6:5:17::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 27 Apr 2021 13:22:34 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::fa) by AM5PR0601CA0040.outlook.office365.com (2603:10a6:203:68::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend Transport; Tue, 27 Apr 2021 13:22:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Tue, 27 Apr 2021 13:22:33 +0000 Received: ("Tessian outbound 47ca92dabae7:v90"); Tue, 27 Apr 2021 13:22:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b17e30689b47a3eb X-CR-MTA-TID: 64aa7808 Received: from 57dd854600c6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7FAA5895-885D-459D-A258-3E26F91868E1.1; Tue, 27 Apr 2021 13:22:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 57dd854600c6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Apr 2021 13:22:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YER98drZeIMuH5YlbkRxZIg4MA7Nd3ambuVvD79IS/a4vtqJvThosCbbB2kXSse3XkttZpS5reUyEOdMqUls7XGXX+hXXvBt0DZEMLkb2jgVJuf/SXn5g1xEQt3jjKybXLtruXlN20CAjsvQ0jQKeBIoKwtEuzcxZsYGn6bPctIbh8mlVo1JmeBDukDL1CBBQa1Ub9Yf+wTYHcmxPZ31FJk1Eg+pu1RzL001xrII+3XoshVvSc/+e/QQUTK+BDIEkGgKNxWXVufVFoy+2T9AvXGWHnm2utlzYlHWaM4FzAvoAHuOg6SKXLTZbY1Q5dJNR5biecxDQIIC6FmcvgqJoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=acaySSgOH1Isx2HW57KQfqX+WgOT+Hi+c/Bq93ZChvk=; b=PnBaX0BmTPjVU+xYju4gv0IakT6OHHYTsJqfmDRwu0GtZ3vwUgFEzGzNf0jIN3z3PkKKu3PgFZJeBU/6QERuJRtnWooZ7h66/O7UMdQb0xDw+vKVcBNkboGE3g1hTIj0aXz1ujqF4YQU0v4fz9jhP1Bxs1sd9rilo92oBJo4Bq2JRkaJ4bDUND21/bHspBE7EyK1m10vnVWuDAXrV7ZhBDCKsYGlwWmvxZ5E/uvSSzrEiC3xqU8FkPXCLaf37JU3HNXSIzRLC2NGnXqBfgKA9g0osvmM3m6pPatcV6h9HBzRnVxSft88+YVm/i5E3YyQnKWx6vtRZXWAtKbAIegigg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=acaySSgOH1Isx2HW57KQfqX+WgOT+Hi+c/Bq93ZChvk=; b=dH+nNSwranO+MjXMLr9+o6cotopKBa7QN6wg/tH9N368LegzNfexSBwd3HHQM9sS/JDHzOjo5KodI2OEzsG+jNW2UfVDDybnazPKak4xh5ZaVfMvxFwO/wgKPSxlBJKP7yemUgFfX16RC5EyniI7Slpx7FshsmYhY1n/v0WlkvE= Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3141.eurprd08.prod.outlook.com (2603:10a6:209:4a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Tue, 27 Apr 2021 13:22:19 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::1cd5:e144:5ad7:eb0]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::1cd5:e144:5ad7:eb0%6]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 13:22:19 +0000 From: "Sami Mujawar" To: Bret Barkelew , "devel@edk2.groups.io" , "rebecca@nuviainc.com" , Samer El-Haj-Mahmoud , Ard Biesheuvel , "leif@nuviainc.com" CC: "rfc@edk2.groups.io" , "Yao, Jiewen" , Rahul Kumar , nd , Jose Marinho Subject: Re: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe Thread-Topic: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe Thread-Index: AQHWzeRyYZqCLJUFX02S9tXdLQTHUKnuMRqAgABLzSCAOVk4gIAB8aSAgJTdJoCAAMQDaoAIwY8AgAAEs4CAAP9rlw== Date: Tue, 27 Apr 2021 13:22:19 +0000 Message-ID: References: <70a4f9e7-952c-cf05-bca7-009ee5b2cd3f@nuviainc.com> <06a2aa56-d4ec-3db2-0e82-12211daa5fa7@nuviainc.com> <985081eb-5e3e-fc33-6afa-c9c121412973@nuviainc.com> ,, In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-26T21:45:24.9009420Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged Authentication-Results-Original: microsoft.com; dkim=none (message not signed) header.d=none;microsoft.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [81.131.179.80] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 6d367a9b-ea12-4194-de57-08d9097f847d x-ms-traffictypediagnostic: AM6PR08MB3141:|DB7PR08MB3244: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fcykzASYSk0z+1nL+oyqX7JGKZhJDVH9Vl0DTFAAgyZ1b3EdQnyFZHrPD2fkCh9YzhHsQae7dhIU2cY4vdOYyKRaZGdHTADRhUw8wrnmhqFcL0D7gINoVHLn73qPrC/+7q3JHS4tm0CbWSdJl+OyixI4SSZzcPro1OTcf8cCZGKSJ7iNXcXCr4swRIMBstZIWMPS3FpGZhVaTcUv2CaVr6nidiSqxgqBop/ZlzcMnc8qAMOzAdnOVjSgtaW4JkoDqKmGNnXYEkD45IRnoTF+FaBtiEAdfzNAcjN61TxF0Ah+AyJ5M3HqHLmmllkqIxGVpTbrSaK3fSuPJY7Fks5/9toKW6VAxQ1DFtagEuaeV58Ft5TmLPqDGpjvJFRMufqzeaRwAyDvU5YK5BBLm56Jv6MYpUUp7/9TduN7F7TmXbNvBI3KZHI8nMyNE8KWCQXtBkfHso1cBrFI9N/BdRASxyrhWh++NXpoc0xgs/6G76Lv0xq2bbTRyaLUGWu18Kx7MwJioB4KCJp3i/FC1N+JA5wUCz2fpyhGfdmW5AAPV3y497HG9Z74s9U4FpHlYhafOadlCIMmkSY4Q8DH1ueM9siBaX2Tj7nIoPxYVA3Sm1iU6C1g5PXIW+Zqr++dYUM/Md/ievT2fbsNTG1O17UmvJ2yMuwqtD337SaYw5NhDkVJI/Y894kEsSqwy2lNPUWl X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(166002)(55016002)(33656002)(8936002)(2906002)(54906003)(9686003)(45080400002)(9326002)(66946007)(966005)(66556008)(26005)(4326008)(186003)(110136005)(6506007)(122000001)(8676002)(316002)(38100700002)(19627235002)(66446008)(71200400001)(53546011)(5660300002)(83380400001)(52536014)(64756008)(86362001)(91956017)(76116006)(478600001)(66476007)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?yx+PgTdzfmC/nBCXPSD4OcfbYdtmJpEwpsuxrD/J/e7GHChGDCJU3tMr?= =?Windows-1252?Q?4j/G5Lzs/iI+BnU3rbPZs+TfVlXR3s4nmY4EIe+rr1yiVWgdw2lac7Zz?= =?Windows-1252?Q?c3eLb5jGIJf0zBvzpXcRLOXWGoBef3v3Z2TE8VKlwG83bVAViNiRR8rZ?= =?Windows-1252?Q?94jxUkoJwrpV52+9PBSkLxkKlegpumPWp9cn6fofEq6wUuAsVT+y3+XO?= =?Windows-1252?Q?ZWEa8hulpQHTrg31v24VEyeBbjzCmLUPbiKZs6rAYSfosvj+bKqUUZx7?= =?Windows-1252?Q?kn7vZx/gRwrR2PG2tTnYzsA8lQAJ5y2QiYMJNKoh5E47yDqsbzm+TA9w?= =?Windows-1252?Q?6y5IAthJ4FWbivvrP72hRPscM1cnNfeRL4EJyyrUYCF5Us/dCwrWOF5S?= =?Windows-1252?Q?X3sfyH1J2hdbtkXeB1SlI39+BFQ3swc4LIOxGviI/s7ggEnIVk0xv3Yy?= =?Windows-1252?Q?uCR3pBc6sASxN3G3SJwGFtbRhwi/SkfpGwXhwRCnrGuwWb/vTe3z47Sv?= =?Windows-1252?Q?FMydW+YhRcRaeR6FlUl7b8+NBFYVsMa4Z94gRC4WRXCeN3jWT5kzhzir?= =?Windows-1252?Q?oi2DSFht3ad6pqsnC9Dnts+jeKAtH+TKFjgxanB8rlue6X7lDoxWbbDw?= =?Windows-1252?Q?oH1gXY4R8awtHcfeG700yJ/M2nHN3KO4CNlA0jVaVDNsyN2FEjr9lIle?= =?Windows-1252?Q?ORZLxIJem5E8lLNHHNhefCP6fLr46dlSMmlctaKUkJ5YJtgZXOTMF99O?= =?Windows-1252?Q?WcmDbtcuD+Tbr2MVsrD243wvWTI1R6+XUgAoUK39sB14XNULbbxOSIU4?= =?Windows-1252?Q?7KdyehVORfNgJOGLJXGmCHrO1Cwm1qAeYMOtoruvWxMjy1oWC0wqKsll?= =?Windows-1252?Q?WqoP+gKnTMyHvSifGHuPaqxoLsCQwS6fsAxtUq59d0yUvIzWcM+rxqr9?= =?Windows-1252?Q?9Souguo7FMxqIfyQGZj3P+5WTVAdGdDExFrgKi2cv2ZHCUNubFo/WvZq?= =?Windows-1252?Q?wUfwrKEzMfGjwuB+uzBio2Wm8cqwrA09nLejEh3z7goCSeytOZlqmTGF?= =?Windows-1252?Q?rFqLjoL3dGfc/84ZwQTGhReuBr2KrIO32upD5PQjANAKaYusV71ezEAz?= =?Windows-1252?Q?s7nQcauFWjjT0DRPSSe6L1GZMkFgb+CbbhTGKtECSoJ5Arp5i2J4XB81?= =?Windows-1252?Q?V8Nuua0Fr8G8wyEueqVdNrUEcE4cHoyV8YCtLe3OmgasoeKEDQzttfxJ?= =?Windows-1252?Q?iDcdp4HzyiWmmZ3AychW9KCA3+8FfLOfzF40j/3knQFH8pgq4YGFPNBS?= =?Windows-1252?Q?wPUrQPm7UEJNDHADGCjWuVOpStA1LNx9L3xtMpKw2KKHeBErG5HOrdvh?= =?Windows-1252?Q?NwGwqnaxFzjG5uiC+pRzbVuVYqT/BKOVCI6vb1jWlJ+RwV0PkS+1LI9U?= =?Windows-1252?Q?EcKi/BafLFHehweq9eXNsw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3141 Original-Authentication-Results: microsoft.com; dkim=none (message not signed) header.d=none;microsoft.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ae60207-887d-46f2-d6a5-08d9097f7c36 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tW/H8Bxoa02Ub09r+lyVnJnvi2sxVpV/X8WyK+rtAWTgGS5sRNcjAS5ooaL+/+dypnOxIaujmo31tKmAh8fgs4F+Gm/HEVL4eGtJzQ2g+GEAOGIasc2vmcOviKfVU7zwcA8K72vwWKjDGwWq92MW6C8eHG7SYQyfEWCT+/hs+unpCVMXPFeKlSMY/zTrvBD4RJxCqVLwINZWsrKZf/p+xK8x8HnmrHnLmnAohWn6F7qXXmWA+JcvFu5+9Y2uGG3wewsNkAdEU/52QbiHmPlToukdp3pWZHL7v0M0h338o1ydD6UreBQgfHJDnsjCH7SltnQgy8H9Flk9rDh3Eq9BfkWUMG/lm2XJCqrslf4ozn0smqdbtk0324HbEC86QyTnTrhcBpc8HFVlqTJn5mj+HRLxhR6Pisv6X3RWq7KQ2JGtKFs5IolS6MKRAOj64JWixI9qff3WgZ17RewRzioK+PqIu28y0U5UDRRC8EAfvJeTNIjrSsVzIbPJ7I5r+1lUejfmadzSAWLly33F2DwTZ8efVRmllL4cYMhJY/Y5GYpW7F0Ff/jp/qOzhkLkncQ9Lb7gFptsf4rvZURDcrBTQYo7tL4nOeIfHumHgBN/emZPBuLaD2WOZfoV4c9+hBsRjxesPZMo0frkKXx/Tqn7rwogESnvcWEyUZvDO8uzOVD6lfA4R0rNzdVXV2JjFEyzjgTKLNoXWlBeVsYe8wddWbKvA/WXc7jSDnEJyLbRUN4jBUJyJKEQjPjZfpRE7s9pp475EY/Msti0wA9/FXCLTg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(46966006)(36840700001)(316002)(110136005)(52536014)(55016002)(8936002)(356005)(82310400003)(966005)(4326008)(2906002)(47076005)(9686003)(82740400003)(478600001)(81166007)(86362001)(33656002)(70206006)(7696005)(336012)(5660300002)(186003)(83380400001)(166002)(26005)(54906003)(45080400002)(8676002)(53546011)(6506007)(19627235002)(34020700004)(70586007)(36860700001)(9326002)(30864003)(450100002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2021 13:22:33.5694 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d367a9b-ea12-4194-de57-08d9097f847d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3244 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM6PR08MB378497C8BEAC56351E5B667084419AM6PR08MB3784eurp_" --_000_AM6PR08MB378497C8BEAC56351E5B667084419AM6PR08MB3784eurp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Rebecca, I agree MdePkg/Library/BaseRngLib can be refactored to support both x86 an= d AArch64. BaseRngLib would then be a RngLib instance that uses CPU instructions to p= rovide random numbers. Regards, Sami Mujawar From: Bret Barkelew Date: Monday, 26 April 2021 at 22:45 To: devel@edk2.groups.io , rebecca@nuviainc.com , Sami Mujawar , Samer El-Haj-Mahmo= ud , Ard Biesheuvel ,= leif@nuviainc.com Cc: rfc@edk2.groups.io , Yao, Jiewen , Rahul Kumar , nd , Jose Marinho = Subject: RE: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR= etc.) to RngDxe I vote the latter. - Bret From: Rebecca Cran via groups.io Sent: Monday, April 26, 2021 2:29 PM To: Sami Mujawar; devel@edk2.groups.io; Samer El-Haj-Mahmoud; Ard Biesheuvel; leif@nuviainc.com Cc: rfc@edk2.groups.io; Yao, Jiewen; Rahul Kumar; nd; Jose Marinho Subject: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc= .) to RngDxe Hi Sami, I've been looking through the design document again, and was wondering if the work I previously did will just slot in? Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not labeled as being in BaseRngLib)? Or would it still make sense to refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND) and aarch64 (using RNDR)? -- Rebecca Cran On 4/22/21 3:30 AM, Sami Mujawar wrote: > Hi Rebecca, > > I have been working on the following modules (See slide 11 in =93EDKII - > Proposed update to RNG implementation.pdf > =94): > > 1. TrngLib|FwTrnglib (Arm Firmware TRNG) > 2. DrbgLib stack =96 with support for DrbgAlgorithmLib|CRT_DRBG & > AesLib|ArmAesInstructionLib. > > I plan to post patches for (a) in the next fortnight. Following this I > plan to update the proposal with the interface definitions for the > various library interfaces in the DrbgLib Stack. > > I have not looked at RngLib|RNDR as I believe you were interested in > implementing the part. Kindly let me know if you plan to implement this > and the platform you would be using for testing. It looks like the > FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these > could be used for testing as well. Please feel free to get in touch > should you need any help with the model parameters or if you face any > issues. > > Regards, > > Sami Mujawar > > *From: *Rebecca Cran > *Date: *Tuesday, 20 April 2021 at 21:04 > *To: *Sami Mujawar , devel@edk2.groups.io > , Samer El-Haj-Mahmoud > , Ard Biesheuvel , > leif@nuviainc.com > *Cc: *rfc@edk2.groups.io , Jiewen Yao > , Rahul Kumar , nd > , Jose Marinho > *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to > RngDxe > > Hi Sami, > > I was wondering if you're still collecting feedback on the design, or if > you have a plan and schedule for the implementation? > > -- > Rebecca Cran > > On 1/15/21 7:51 PM, Sami Mujawar wrote: > > Hi All, > > > > I have shared some initial thoughts on the RNG implementation updates > at > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2= .groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Pr= oposed%2520update%2520to%2520RNG%2520implementation.pdf&data=3D04%7C01%= 7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988= bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpbGZ= sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1= 000&sdata=3DQ8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&reserv= ed=3D0 > > > > > Kindly let me know your feedback or if you have any queries. > > > > Regards, > > > > Sami Mujawar > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Rebecca Cran via groups.io > > Sent: 14 January 2021 09:05 PM > > To: Sami Mujawar ; devel@edk2.groups.io; Samer > El-Haj-Mahmoud ; Ard Biesheuvel > ; leif@nuviainc.com > > Cc: rfc@edk2.groups.io; Jiewen Yao ; Rahul > Kumar ; nd > > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to > RngDxe > > > > On 12/10/20 4:26 AM, Sami Mujawar wrote: > > > >> I am working on the TRNG FW API interface and will share more detail= s > >> for the discussion soon. > >> > >> We had some thoughts about streamlining the RngDxe implementations a= nd > >> would like to share some diagrams for the discussion. > >> > >> My diagrams are in Visio that I can export as JPG images. However, I= am > >> open to switching to any other suggested tool. > > > > Hi Sami, > > > > I don't see any further discussions on this. Have you made any progre= ss > > with sharing the design documents or scheduling a review? > > > --_000_AM6PR08MB378497C8BEAC56351E5B667084419AM6PR08MB3784eurp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Hi Rebec= ca,

&nb= sp;

I agree = MdePkg/Library/BaseRngLib can be refactored to support both x86 and = AArch64.

BaseRngLib would then be a RngLib instance that use= s CPU instructions to provide random numbers.

 

Regards,

 

Sami Mujawar

&nb= sp;

From: Bret Barkelew <= Bret.Barkelew@microsoft.com>
Date: Monday, 26 April 2021 at 22:45
To: devel@edk2.groups.io <devel@edk2.groups.io>, rebecca@nuvi= ainc.com <rebecca@nuviainc.com>, Sami Mujawar <Sami.Mujawar@arm.co= m>, Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesh= euvel <Ard.Biesheuvel@arm.com>, leif@nuviainc.com <leif@nuviainc.c= om>
Cc: rfc@edk2.groups.io <rfc@edk2.groups.io>, Yao, Jiewen <= jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd &l= t;nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
Subject: RE: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for AR= M (RNDR etc.) to RngDxe

I vote the latter.

 

- Bret

 

From: Rebecca Cran via groups.io
Sent: Monday, April 26, 2021 2:29 PM
To: Sami Mujawar; devel@edk2.groups.io; = Samer El-Haj-Mahmoud; Ard Biesheuvel; leif@nuviainc.com
Cc: rfc@edk2.groups.io; <= a href=3D"mailto:jiewen.yao@intel.com"> Yao, Jiewen; Rahul Kumar= ; nd; Jose Marinho
Subject: [EXTERNAL] Re: [edk2-devel] RFC: Adding support for ARM (R= NDR etc.) to RngDxe

 

Hi Sami,

I've been looking through the design document again, and was wondering if the work I previously did will just slot in?

Were you thinking the "RngLib|RNDR" would go into ArmPkg (since = it's not
labeled as being in BaseRngLib)? Or would it still make sense to
refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND)
and aarch64 (using RNDR)?

--
Rebecca Cran
 


On 4/22/21 3:30 AM, Sami Mujawar wrote:
> Hi Rebecca,
>
> I have been working on the following modules (See slide 11 in =93EDKI= I -
> Proposed update to RNG implementation.pdf
> <https://nam06.safelinks.protect= ion.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FD= esigns%2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2= 520implementation.pdf&amp;data=3D04%7C01%7Cbret.barkelew%40microsoft.co= m%7C676a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1= %7C0%7C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI= joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DQ8ka83ReO2= aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=3D0>=94): >
>  1. TrngLib|FwTrnglib (Arm Firmware TRNG)
>  2. DrbgLib stack =96 with support for DrbgAlgorithmLib|CRT_DRBG=  &
>     AesLib|ArmAesInstructionLib.
>
> I plan to post patches for (a) in the next fortnight. Following this = I
> plan to update the proposal with the interface definitions for the > various library interfaces in the DrbgLib Stack.
>
> I have not looked at RngLib|RNDR as I believe you were interested in =
> implementing the part. Kindly let me know if you plan to implement th= is
> and the platform you would be using for testing. It looks like the > FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these=
> could be used for testing as well. Please feel free to get in touch <= br> > should you need any help with the model parameters or if you face any=
> issues.
>
> Regards,
>
> Sami Mujawar
>
> *From: *Rebecca Cran <rebecca@nuviainc.com>
> *Date: *Tuesday, 20 April 2021 at 21:04
> *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io=
> <devel@edk2.groups.io>, Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuv= el@arm.com>,
> leif@nuviainc.com <leif@nuviainc.com>
> *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao
> <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com&= gt;, nd
> <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
> *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) t= o
> RngDxe
>
> Hi Sami,
>
> I was wondering if you're still collecting feedback on the design, or= if
> you have a plan and schedule for the implementation?
>
> --
> Rebecca Cran
>
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>  > Hi All,
>  >
>  > I have shared some initial thoughts on the RNG implementat= ion updates
> at
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.g= roups.io%2Fg%2Fdevel%2Ffiles%2FDesigns%2F2021%2F0116%2FEDKII%2520-%2520Prop= osed%2520update%2520to%2520RNG%2520implementation.pdf&amp;data=3D04%7C0= 1%7Cbret.barkelew%40microsoft.com%7C676a9101f67845dbdc8908d908fa4cd1%7C72f9= 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550693569385394%7CUnknown%7CTWFpb= GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7= C1000&amp;sdata=3DQ8ka83ReO2aG8yTVrgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&= amp;reserved=3D0
> <https://nam06.safelinks.protection.ou= tlook.com/?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Ffiles%2FDesigns= %2F2021%2F0116%2FEDKII%2520-%2520Proposed%2520update%2520to%2520RNG%2520imp= lementation.pdf&amp;data=3D04%7C01%7Cbret.barkelew%40microsoft.com%7C67= 6a9101f67845dbdc8908d908fa4cd1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7= C637550693569385394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l= uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DQ8ka83ReO2aG8yTV= rgpTAVxczJVjl2JBH3ksHo2%2BSHk%3D&amp;reserved=3D0>
>  >
>  > Kindly let me know your feedback or if you have any querie= s.
>  >
>  > Regards,
>  >
>  > Sami Mujawar
>  >
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On= Behalf Of
> Rebecca Cran via groups.io
>  > Sent: 14 January 2021 09:05 PM
>  > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.= groups.io; Samer
> El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel <= br> > <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
>  > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.co= m>; Rahul
> Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
>  > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RND= R etc.) to
> RngDxe
>  >
>  > On 12/10/20 4:26 AM, Sami Mujawar wrote:
>  >
>  >> I am working on the TRNG FW API interface and will sha= re more details
>  >> for the discussion soon.
>  >>
>  >> We had some thoughts about streamlining the RngDxe imp= lementations and
>  >> would like to share some diagrams for the discussion.<= br> >  >>
>  >> My diagrams are in Visio that I can export as JPG imag= es. However, I am
>  >> open to switching to any other suggested tool.
>  >
>  > Hi Sami,
>  >
>  > I don't see any further discussions on this. Have you made= any progress
>  > with sharing the design documents or scheduling a review?<= br> >  >
>






 

--_000_AM6PR08MB378497C8BEAC56351E5B667084419AM6PR08MB3784eurp_--