From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.56]) by mx.groups.io with SMTP id smtpd.web08.5960.1616928756169714879 for ; Sun, 28 Mar 2021 03:52:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Av/gQtWZ; spf=pass (domain: arm.com, ip: 40.107.0.56, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QcsG/IztaXAeLt4txScE5wUFLui0DvFUOvhJMq+XYfk=; b=Av/gQtWZs/2BVNi6702BejQjZA9mHqxQqDs5qR7WbqEjqFz374VuWv9GJNyeykhAuf6IgbSKKBFsHKKQwpPv58wFPKNnBP0+lQaAxo+WXf7vjnbQZ+1DkYnIjDuzSZ31hLyVUopvzvygjGOLqnooU3X3+0mIrwhyaYmMLb1uw58= Received: from AM5PR1001CA0071.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::48) by AS8PR08MB5990.eurprd08.prod.outlook.com (2603:10a6:20b:296::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Sun, 28 Mar 2021 10:52:33 +0000 Received: from AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::26) by AM5PR1001CA0071.outlook.office365.com (2603:10a6:206:15::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Sun, 28 Mar 2021 10:52:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT016.mail.protection.outlook.com (10.152.16.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Sun, 28 Mar 2021 10:52:33 +0000 Received: ("Tessian outbound 24fdfdedd45c:v89"); Sun, 28 Mar 2021 10:52:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 651fb866b4b687a3 X-CR-MTA-TID: 64aa7808 Received: from 762b63dc262d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0BA485FA-F2C7-4214-A30E-BB5E085F487C.1; Sun, 28 Mar 2021 10:52:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 762b63dc262d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 28 Mar 2021 10:52:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6XlB2OcP7d+r/MXyCpUZ5E3iUubYYxWd4WfKyAS9ypSluHVs2TKn2ZAPt8lMb1K4PrPnArxA+XtCA6HTyCDq9aHveoFBnF6vauqVPsaDytikCO1cv9zc07D9eyQUiewTT6KQsgdqR6rC+lXMOuVdcOcI5I+yZUDWzvz3JMYRg3wNEo9+3UYuJ8QGe6nydI+cPh4mHGvobSx6RnzKC/MWl9NQtXd3bpg80Fy+jkKNxO9QJLRJDO9D6NHPUHsiou499Wbwtlt2RGDxxpiQxZJ0f6FilyE20/skARvmxF+WVeCkA3LITW5X/ljowZx7576PC3VIH4AIH+o5Fle978wsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QcsG/IztaXAeLt4txScE5wUFLui0DvFUOvhJMq+XYfk=; b=m3mlcRyn+M70+ANLZmknL2ZKi7I9HbdI9XM4WT5QQWOJGdkWNit2/sZz9SZIZfuwFjQMyagdoWwo6QWxBtxHoEsJbMyi8G1+Ie+jcWFzTjazggqWvxjOuylrB0YXIkWWfw4dEjuXyIj3R3Yq9ht1WtdnbIO2QqmBRZNV+8AIgzK7GIqKqe0O1dRS0CnfP+WQe2323ujYeWgVOPIC1YKtE7030PYAXlDBEEHUQwj5eZfuoNrF8mpyFISmYmmMSEOhtFnenRaEZnZChxS9cYNRsnH8Nd3DI4Ch/BYxEi1S2eCk9xEYpRFFbId4RMlBtGde/gN2OOHgdR1kxo/lsudKNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QcsG/IztaXAeLt4txScE5wUFLui0DvFUOvhJMq+XYfk=; b=Av/gQtWZs/2BVNi6702BejQjZA9mHqxQqDs5qR7WbqEjqFz374VuWv9GJNyeykhAuf6IgbSKKBFsHKKQwpPv58wFPKNnBP0+lQaAxo+WXf7vjnbQZ+1DkYnIjDuzSZ31hLyVUopvzvygjGOLqnooU3X3+0mIrwhyaYmMLb1uw58= Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM5PR0801MB1762.eurprd08.prod.outlook.com (2603:10a6:203:39::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Sun, 28 Mar 2021 10:52:19 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::253a:c74d:3408:25ce]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::253a:c74d:3408:25ce%6]) with mapi id 15.20.3977.030; Sun, 28 Mar 2021 10:52:19 +0000 From: "Sami Mujawar" To: Ilias Apalodimas , "devel@edk2.groups.io" , Pierre Gondois CC: "ardb+tianocore@kernel.org" , "sughosh.ganu@linaro.org" , "leif@nuviainc.com" , Ilias Apalodimas , nd Subject: Re: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA Thread-Topic: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA Thread-Index: AQHXGDc9U9n/i+pDB0ut/p2hz2yYVKqZSmXx Date: Sun, 28 Mar 2021 10:52:19 +0000 Message-ID: References: <20210313183139.3256104-1-ilias.apalodimas@linaro.org> In-Reply-To: <20210313183139.3256104-1-ilias.apalodimas@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.140.62.49] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dee10e03-8178-4e06-634a-08d8f1d79760 x-ms-traffictypediagnostic: AM5PR0801MB1762:|AS8PR08MB5990: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fI3heCf3E5c9wHS+PqnaDgnmHIcVV0DGKojnL7dSxQW27FOx50pHIQRPX+Y/1nVCwAxBQSHmxMYfxSxGKHILlzZB8d3yxbf7Wqj3IGPvXzkb5DuL/XaMvoUfWERutjwqE9wva2hhS7BjZNj1BS/M/kX9Aatg1ePMOinEyOgoXQrSXEFK24ggXHSxF37OF1HuPn05vcgI30Ad43d1ItA2ff8O+QTVMvxox4E+h6uDMp8ey16mf9t44IbPfY4iBMzQVomLHYb53MZnn7+Kfq0thP1QjzJeTu+3tfNkyZkFxc+mn62ZwxBi06t3CTTI+m3ObyZTPq8N0aoZrujd3fNQvHnfY6NFXFs8YfJEzj9hwyRxj9N5K0TDOESvtjMOVY9O2dSq2KUMMlykx43ABCiyhx0jhNs+uWoEt4+lZbw3aDfdS9tbaoGHbDuSHozstOI3HdcyZZVauNY3u9ZobLprWPCL7pTZqgH48s/PWrhNazncnS0Gu3L8eOc2kxKZZ1FZpXEP+I/O18n9IMYjd2oSGxKSMleNIBjol3nwRzFNDo/mXyHAOMLcR390A5dkoE1wdX8G+JGUP/TmGJxBRfXLjEIt4soVZXxRAoMKhsbwNhHxUwIwCaamuYcMbK/q+GkEyxGxm3M8VawfNKKyIUSWKJC4esLzVW5jfa2lD0mg1lSWlpB08VjLqaxJKV0G98O1/22IY0NHnxFw8PaxQ9K6xfN4pzOTCYMaXnQrNgSldz77IOiL2rTOzxRFGMMGLSBY X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(2906002)(8936002)(8676002)(26005)(86362001)(33656002)(38100700001)(186003)(91956017)(478600001)(966005)(66946007)(76116006)(52536014)(7696005)(54906003)(110136005)(316002)(66446008)(64756008)(66556008)(66476007)(83380400001)(6506007)(53546011)(166002)(9686003)(55016002)(4326008)(71200400001)(6636002)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6zgyqcehNZ0SCHrbQK/XIHFEFRRkQWHpq3p3yOW6AF6su5Q9G3P+KCT/NTm3?= =?us-ascii?Q?+hljozW0qB9Hl4unTFsC6f3fSVMjmXOSPuHm6Yv3IpVBdRjP7nR2csaC8kFb?= =?us-ascii?Q?NBpz6syc56Uf/uJs6P9T+s8XDYoowzjmx0L61gTBkolSQGjFanFtxMw64Tt3?= =?us-ascii?Q?8KE4NUSGTzFJt7BpUUOFwepl7RTLyHXixZZzwzaVsEUJzLfNz+3YUMKsHBUV?= =?us-ascii?Q?AW48eWRWxDmDuE8lrXUzR+CDQE6x0Q0aELJjBn3FcgGFbd4gkzla7kio68pp?= =?us-ascii?Q?ySUGemzzkPbbIcbq8LYEgujhTcd4JAIxR6BxhU7kVrNUQjYuuB1FG8TsDh35?= =?us-ascii?Q?pt0agB8VIZ9kcvW75XPd3ZgeFD0f66BSJkgrBynoBLNxslrT9IysEBIJpBNb?= =?us-ascii?Q?Z3ci4cyvz59XpVXjL5m7s67EJDQRqltYV7aImtNnWb2okT/jahFxrYn4NihU?= =?us-ascii?Q?69ZMjfXq8qZvf/ObDckLvQ34I6mDwXVlsT2oE/tkWpx3aidkn5rWYIwK5sc7?= =?us-ascii?Q?9ORneugnxqo8NYdtlyJ0dh6bDFtUsjzrT1mqgsJeLjJrBQWIFLnbvl7vqjS7?= =?us-ascii?Q?0eEPsQ9ue932g2SgQVU3rvz3J1R/Wn9N5Ty/iSIk4caGOMgI/XN/aTEN6ciQ?= =?us-ascii?Q?e/LLSs/tmqpYENbdSWbiJ/D9sjAteApYOhawhOYZZIFWGR1RF8C9zoxzoiNu?= =?us-ascii?Q?pHsWgIZe/K4iJgskZabLWWQG7p9dtu5IbZd0uXxfuphn+kLEf+Z+UzazcmNs?= =?us-ascii?Q?T/lpmqQqXoVlSmc0ydvNYzPyroKcuXF10lqH2VVA4llaWAeaCLbjYD8aTQph?= =?us-ascii?Q?NZ1aq3x0oBE0gWa16J0T4uhHeZb+EAjGI0IrupYO4wCRaWGUJS9vR1P30RmM?= =?us-ascii?Q?Ew1558czQjihsXC/Inhqx3CzBiCjekM4LwNUW4tOb3++F4nWyzIDtRnMVcKG?= =?us-ascii?Q?4LuGT4eR7M39hSeHfqs2JBVGvGrtPDqKk8419mfteSGJ1/Cp7G5JPnCtP6uy?= =?us-ascii?Q?Lg8T1/cFYAjqBiGgoB8qEIw54C5sPAcZBNFyEe830ZLSnsPuZ3H+/q3xHffq?= =?us-ascii?Q?o5F1jm1mbV08iKgeCgIho1i+lDzDwGb2YnBziqBD+tXNk+oI/pvnLXEHhSsb?= =?us-ascii?Q?aR22RcsA4vbVkmS7nsrhILnDLTYJgbTWne8OLbimiWCF/FPDEDjneh0WNdvX?= =?us-ascii?Q?ZjLuH65nxSXoU1hWgxbjOm+8Pgi0ZowjasZEx+BOW002bevM1A6CJKECYuOJ?= =?us-ascii?Q?3usuZQYBEhbIn8KTCtfpu77X7B79gL284SHL8j21EoOUr+oiCwVjCRpDYIa1?= =?us-ascii?Q?u/bm3E8YOWYsP2ADpe4GU4Uxryra1FdZ8rlWP++XISxCEQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1762 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 933a8656-a759-48fb-4f58-08d8f1d78f17 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4qHn/vQ2tVLHrMZ5ctkZDJB/jM6GumaHBAnerijbZC8NHjofqlKAmPpvYkEXI/zeHxvyC5lnfXVgZba77etfJjDJo0X3RgXJgYnP6gsfCyLhqHklOPaPwHrBUB7qXRgpbNUuduOs74RK1cumyI1CH5GW3uaA72DmJ4QifK4pSZbpFznDNpK2v3kZCmxR9HpllHrVEBlKut1m8p8EC5zAc5aHxVXaghYfEQN9YzVuzDaqG4Hr7ivcMQBpTtPtFqlKjohjfUbcBDl+t4ZTki9v0Xwjy2213Y2V8yeS1O3doFHGcmBdiE4coJwAbSkQ+7lzNr6FfPA/b8Cp4IwNWTYmYxWFIweI/26NNlKOJUSp2CFC+EgkK8D2nITwG4qYFVQvsm/TSFjXlbWNPifa96JljaTph+7QbhNpvpykZGzfftZI8a1SddfxLda11j8yrG81eJvLAdUV5hO+qcsA113lW3x6AnoRV9Z9RffsMG5qoXsxbhS3jwLB8fMN+lf0Rj0lkpjKbR+ifXyXu99nGyA664KChv6+4tTz+C9986rQyUP06UsvSfA8m2fGtaOe3EFYTQzRWpviIWkKY4cP6GvaoJ8pWvVUbNupCpV45NMObQto5V0oIS4OqnFV+QHsxuGQTN0o0cgtZL10+baU/DfD1SipaLFvxH92gS3DpOfRc6Jf2T09BL/j9JsWn0AkfAWveWFlGwrM1YdGRnt5B/ogkwf0NvTthCPeegYI4oD3qWU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(46966006)(36840700001)(53546011)(6506007)(166002)(81166007)(82310400003)(356005)(966005)(478600001)(26005)(2906002)(186003)(7696005)(336012)(33656002)(83380400001)(54906003)(82740400003)(6636002)(47076005)(9686003)(86362001)(52536014)(70586007)(5660300002)(8936002)(316002)(55016002)(70206006)(4326008)(110136005)(8676002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2021 10:52:33.2204 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dee10e03-8178-4e06-634a-08d8f1d79760 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5990 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM6PR08MB3784B6642C328B06FAC4C915847F9AM6PR08MB3784eurp_" --_000_AM6PR08MB3784B6642C328B06FAC4C915847F9AM6PR08MB3784eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi ilias, Thank you for this series. Pushed as afb0ce7e9756..89f6170d6686 Regards, Sami Mujawar From: Ilias Apalodimas Date: Saturday, 13 March 2021 at 18:32 To: devel@edk2.groups.io , Sami Mujawar , Pierre Gondois Cc: ardb+tianocore@kernel.org , sughosh.ganu@lin= aro.org , leif@nuviainc.com , I= lias Apalodimas Subject: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA Hi, This is v7 of [1] Changes since V6: - Added param[in,out] in comments - Fixed an error on Maintainers entry Changes since V5: - Addressed coding style fixes from Pierre - Removed redundant checks in memory allocation and block usage - Removed unused COMPRESSION_TOOL_GUID - Renamed the files and directories following Leif's sugestion - Added Sami and myself as maintainers Changes since V4: - More coding stule fixes proposed by Sami, which Ecc or Patchcheck didn't report. - Adding missing error handling in InitializeFvAndVariableStoreHeaders(). An allocation wasn't properly checked for success Changes since V3: - Coding style fixes proposed by Sami - Fixed all reported PatchCheck errors - Added overflow checks on the base aaddress allocated for EFI variables. The size of the partition is user defined (via Pcd's) and the memory lay= out and allocation address depends on OP-TEE. So let's make sure we won't ov= erflow when calculating the 3 partitions needed for FTW - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm= .dsc - Added reviewed-by tags on patch 2/2 Changes since V2: - Allocate a dynamic number of pages based on the Pcd values instead of a static number - Clean up unused structs in header file - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=3D0 Changes since V1: Some enhancements made by Ilias to the Optee Rpmb driver [1] https://edk2.groups.io/g/devel/message/66483?p=3D,,,20,0,0,0::Created,,= ilias+apalodimas,20,2,0,77703661 Ilias Apalodimas (3): Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver StMMRpmb: Add support for building StandaloneMm image for OP-TEE Maintainers: Add maintainers for StandAloneMM and RPMB driver Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c | 81 ++ Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf | 43 + Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf | 58 ++ Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 861 ++++++++++++++++++ Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h | 51 ++ Maintainers.txt | 10 + .../PlatformStandaloneMmRpmb.dsc | 162 ++++ .../PlatformStandaloneMmRpmb.fdf | 111 +++ 8 files changed, 1377 insertions(+) create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformS= tandaloneMmRpmb.dsc create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformS= tandaloneMmRpmb.fdf -- 2.30.1 --_000_AM6PR08MB3784B6642C328B06FAC4C915847F9AM6PR08MB3784eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi ilias,=

&nbs= p;

Thank you= for this series.

&nbs= p;

Pushed as= afb0ce7e9756..89f6170d6686

&nbs= p;

Regards,<= o:p>

&nbs= p;

Sami Muja= war

&nbs= p;

&nbs= p;

From: Ilias Apalodimas &l= t;ilias.apalodimas@linaro.org>
Date: Saturday, 13 March 2021 at 18:32
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar = <Sami.Mujawar@arm.com>, Pierre Gondois <Pierre.Gondois@arm.com>=
Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sug= hosh.ganu@linaro.org <sughosh.ganu@linaro.org>, leif@nuviainc.com <= ;leif@nuviainc.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>= ;
Subject: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-T= EE TA

Hi,
This is v7 of [1]

Changes since V6:
 - Added param[in,out] in comments
 - Fixed an error on Maintainers entry

Changes since V5:
 - Addressed coding style fixes from Pierre
 - Removed redundant checks in memory allocation and block usage
 - Removed unused COMPRESSION_TOOL_GUID
 - Renamed the files and directories following Leif's sugestion
 - Added Sami and myself as maintainers

Changes since V4:
 - More coding stule fixes proposed by Sami, which Ecc or Patchcheck d= idn't
   report.
 - Adding missing error handling in InitializeFvAndVariableStoreHeader= s().
   An allocation wasn't properly checked for success

Changes since V3:
 - Coding style fixes proposed by Sami
 - Fixed all reported PatchCheck errors
 - Added overflow checks on the base aaddress allocated for EFI variab= les.
   The size of the partition is user defined (via Pcd's) and the = memory layout
   and allocation address depends on OP-TEE. So let's make sure w= e won't overflow
   when calculating the 3 partitions needed for FTW
 - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing  - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandal= oneMm.dsc
 - Added reviewed-by tags on patch 2/2

Changes since V2:
 - Allocate a dynamic number of pages based on the Pcd values instead<= br>    of a static number
 - Clean up unused structs in header file
 - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=3D0

Changes since V1:
Some enhancements made by Ilias to the Optee Rpmb driver

[1] https://edk2.groups.io/g/devel/message/66483?p=3D,,,20,0,0,0::Created,,ilia= s+apalodimas,20,2,0,77703661

Ilias Apalodimas (3):
  Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
  StMMRpmb: Add support for building StandaloneMm image for OP-TEE
  Maintainers: Add maintainers for StandAloneMM and RPMB driver

 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c     &n= bsp;   |  81 ++
 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf     =   |  43 +
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf    |  = 58 ++
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c     | 8= 61 ++++++++++++++++++
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h     |&n= bsp; 51 ++
 Maintainers.txt         =             &nb= sp;         |  10 +
 .../PlatformStandaloneMmRpmb.dsc      &= nbsp;       | 162 ++++
 .../PlatformStandaloneMmRpmb.fdf      &= nbsp;       | 111 +++
 8 files changed, 1377 insertions(+)
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h
 create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/Plat= formStandaloneMmRpmb.dsc
 create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/Plat= formStandaloneMmRpmb.fdf

--
2.30.1

--_000_AM6PR08MB3784B6642C328B06FAC4C915847F9AM6PR08MB3784eurp_--