From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.47]) by mx.groups.io with SMTP id smtpd.web10.9922.1619084480404933744 for ; Thu, 22 Apr 2021 02:41:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Q5fGrdgy; spf=pass (domain: arm.com, ip: 40.107.5.47, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nEmEFS4GhM7WCPccmkS1ekQEgaVBWN11m6JMBgvwTAE=; b=Q5fGrdgyCLVtam5wD1OKUvefK3+FMKdjbkqujmQQudvl62F+bZRAMqNl5Ry+bpz9R0nHthCpgcKBmDTl2BrLlJ/xaFwC50wiceL/IALbc6a9zVTtaO+u2IPgYcHYWccSu8DPcMr2TvZ7xHQ4b6yU84A1rQYxt6uk/4gTr3lF8iE= Received: from MR2P264CA0104.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::20) by VI1PR08MB4126.eurprd08.prod.outlook.com (2603:10a6:803:e1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Thu, 22 Apr 2021 09:41:16 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:33:cafe::b4) by MR2P264CA0104.outlook.office365.com (2603:10a6:500:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20 via Frontend Transport; Thu, 22 Apr 2021 09:41:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Thu, 22 Apr 2021 09:41:16 +0000 Received: ("Tessian outbound 4ee49f77c636:v90"); Thu, 22 Apr 2021 09:41:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 59e1d8159c234dd1 X-CR-MTA-TID: 64aa7808 Received: from 1a0d213c439f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F254577-213B-4C5B-88F8-C4583A31385A.1; Thu, 22 Apr 2021 09:40:59 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a0d213c439f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 22 Apr 2021 09:40:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BiVrdaROC201dJQGPCe3iQjCJ5qzEo10o1OnoTZwFa1gHHHwwylJdno+eucb+6nCcjtCBgjxL4EbzEutUiiUt3Pym70wl467xioe+ZDGI5jvbBL5lCUTrjNGceqRmMEJ11YmLhfb+PLCbSZbjPkW2HdET2v72uUosilFlWO1zZXV8Vz3gyzS1jWMSllHgvnDTnjyYK8zMrYG9y6BY2q1RyOrwspa7Igm1UC9oOyCh9B1hP2Ez4nDGgs7cHxL8M3kLmI8/X5187kwI2zHjEADLFzVifTX0Rqze2GQc5fSpwj/hJzHzkdYldQ7dxCer/zQUO8MD6R75R99Qpy1YMa52Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nEmEFS4GhM7WCPccmkS1ekQEgaVBWN11m6JMBgvwTAE=; b=cN72moVRDf7uak75hqm3u+SvjJeX7b46cV0ES8R9aJ8C+fFGC9Hb7S62CD+MCRZt1R4X39obeH2ouh8Ikbemm/uc6Ii/rrBMLlm8IeXIKUTG7yVFiST5mfDU2NhOBY0gs0GbOvBHD15uf0SvZl+GPgeqH/gsphQcNeLE7YnSJQv16q2wawHVri+YQ3NxDdPh3ftv6qiDUTnBG7SqIZfO30p5OPuxK/jT/CpQ6dR86lkyzwIR5GjPAziTZ5JDLpKTh3r5KGzimVt2xgF5VtXwLSqrJ++q2irDE+PXNEW7TwVQklTDO9UpK+Segf0Ws8AYAVkoGvnTK50cXLk4KSd/Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nEmEFS4GhM7WCPccmkS1ekQEgaVBWN11m6JMBgvwTAE=; b=Q5fGrdgyCLVtam5wD1OKUvefK3+FMKdjbkqujmQQudvl62F+bZRAMqNl5Ry+bpz9R0nHthCpgcKBmDTl2BrLlJ/xaFwC50wiceL/IALbc6a9zVTtaO+u2IPgYcHYWccSu8DPcMr2TvZ7xHQ4b6yU84A1rQYxt6uk/4gTr3lF8iE= Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB6200.eurprd08.prod.outlook.com (2603:10a6:20b:292::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Thu, 22 Apr 2021 09:40:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::1cd5:e144:5ad7:eb0]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::1cd5:e144:5ad7:eb0%6]) with mapi id 15.20.4065.021; Thu, 22 Apr 2021 09:40:57 +0000 From: "Sami Mujawar" To: Pierre Gondois , "devel@edk2.groups.io" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , "sean.brogan@microsoft.com" , "Bret.Barkelew@microsoft.com" , nd Subject: Re: [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib Thread-Topic: [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib Thread-Index: AQHXNqjbkRHFuneYBEKCQUght2lq/KrASb5Y Date: Thu, 22 Apr 2021 09:40:57 +0000 Message-ID: References: <20210421122048.11729-1-Pierre.Gondois@arm.com>,<20210421122048.11729-3-Pierre.Gondois@arm.com> In-Reply-To: <20210421122048.11729-3-Pierre.Gondois@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [81.131.179.80] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8c84160c-a40b-42ad-2b18-08d90572c697 x-ms-traffictypediagnostic: AS8PR08MB6200:|VI1PR08MB4126: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5797;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2RnpbzDGpB5+6gnn8Gxta1+pdHypH+O8b2q7NmSZU2pNES8bGUsTECvQ6Rp1UFLNeBnbkW3D9bmeUx/sn+QwNxJbfHRGEfTRYIhxolCQtcFPOIwdOCG3rdnr6byunp4YxgF1osvnuuOf+xW4fQeDxOJ8OQrUQN/h/+9iPUwX/8RXeXQQw0PaJnD0x/2frcCKGQKVI0bhfTCMZwoanDvTfxA1/0fXRbBmZIjFzHwnVfnt9jVKkkh9JqKkBdopupJyw71NxHfWtLd11VNlcxhMdlFGfr0qG/cp2U1qVcSfO7DDVcgRb717NONtZzq3XwBFRGXBD7FPYW8IytuorVsRxSnKrQMJMik3a/A1E7iTHT7DvhNEnPMz+A+76+nNdePDilvV2Gtllh1oyXUkoWqowo7GQPcbEMsFsuVaS9PCLqWQnLGQBy9WgIRTQOLI/NBzIXKkdQpsMcKwNDaZSoSQ9aQ3LzJ+heN1x5zyiPP3yXcr//wYEdS/zilkByZBWLgFgCtx19jinhOFCqDV5+OobrZpzdJVxOzh67gWWXEmX4BD6zEWJ3r6P6zbsoqUuOnbXkhIQ/b4vI0cjynDt1/YSZ9V2robXeyRwVGgVhQsq/0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(39850400004)(396003)(346002)(366004)(376002)(8936002)(33656002)(71200400001)(66556008)(8676002)(9686003)(9326002)(66446008)(26005)(2906002)(6506007)(38100700002)(91956017)(7696005)(316002)(6636002)(110136005)(76116006)(122000001)(86362001)(186003)(52536014)(5660300002)(64756008)(83380400001)(66946007)(53546011)(478600001)(55016002)(66476007)(45080400002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?U1MDDAT1mI/UOlw3v3KJOaFyYSHi7lyH+/9kAUeEBKVMgnGyDffaOfauSVdu?= =?us-ascii?Q?DFwCoyUBfTFT3+8i/+YMKp/0qmAqTlp4aekl0KwTGJoxde14oxpaksB2o5Dh?= =?us-ascii?Q?dbsSEQKHXZ3lOX6qR9FQpiXsQFqH84nSQKpI1dMy531Jh+6RoU5LkPn7iZre?= =?us-ascii?Q?Wbpt+WSMTsgbW/9niwA1W/Xl+o7FgUavchsaXdecOOf6fGzf2+ULrGwLBwrS?= =?us-ascii?Q?lvlOECpw7kBXMPnpFG/X0xFNyX7rt4/heDynJmw+zKFaAZzcyHon4vcvCwzs?= =?us-ascii?Q?G5CF++GnJK9gMOXM54bVw+IUlmCZbuw4RZ3hjD2kiKLoOPWVHR16G2tz9Wt5?= =?us-ascii?Q?vg2R2LXwj2wvjWsCaMRrABuYwdmhxwVWX4EYXupf+kB5Ljqv8NnC48Y7ZlaZ?= =?us-ascii?Q?hDHniar9QJE2M6v6XWm4WA+0bRYdgQoGupXKqrJTDnUFQAmPmR2jyL9bCgNp?= =?us-ascii?Q?BmNoIIu3AAslzeuqEkvYyOdNYHMuxhMLeK8fM0y86Cajvgf7bGP9jFtuf/ew?= =?us-ascii?Q?Gc6UnoALU8UjCexaUlvRPJ695iUxIG+BI2pb7dgMpFzLfZeYTr8WozeCZVJe?= =?us-ascii?Q?8YH9xi0dqvZbROnV26WqhLqgCO8boMicjNFOFXdJFQ0cInv33gSfAlHnqb9W?= =?us-ascii?Q?eipbYQ67n75UFI1124THoJIWFQaOOWtuWkZ8go5hPiUjlG/P1ycUdRbCznBV?= =?us-ascii?Q?dXuOu9qWv01HD/gSCJwrjss8z8InZID7xf7sw5+Y8CZuOY8i1m7tx2wyiSuM?= =?us-ascii?Q?Ow68tMX1jEUeRtP6j4hiU/TB6BkspYaFoG8Sty/N+0ZpQt+yRBSuwFnEpF9F?= =?us-ascii?Q?pfvotfVdbOW5JaPC7N3VSVfSN1byWMdcHsuHufncHbyEf3hBPT8/IYG3R2KL?= =?us-ascii?Q?hB2TXy3neTj5x09NYAyUAHHZKQmK1pGWJzyFq9MgJpkrluUJf7LD3ASmkANK?= =?us-ascii?Q?DaKereqnK1DoWEx67RB9wmvIegBpryo5QBxH8JmcVJVwpNTcUjqVYKjbns8P?= =?us-ascii?Q?g3ovDNrSoZSF6zz/cgu9JhMGUgZgQjMiykFNutIU/pLsXvdP4wV4tUmp4EJt?= =?us-ascii?Q?GLgkODtJLf86e7H/sOiu+tT2bicB0VFhmYji4Uy3uDaZDftOZuInP1x3gW0Z?= =?us-ascii?Q?CKtwCB5IcYmfg/FPN4aWdsIw6Vjc0dSntbw4UFCEf9+eAhB8tO6u4jYvgbDE?= =?us-ascii?Q?cXLkIFbH6k0sBp3Y/fC9ixiYtPMgNi4zYNYC+g77qbV4s1nivP7b9dnkFexY?= =?us-ascii?Q?xyLOYbiVJNB3fE1tHzBOV+MskDff0k4WV5729bQb/9PX1sONGGnoIZgqhmjz?= =?us-ascii?Q?IzuejaIDjS27TAqwUP5dsJEcbofiDPpyTNacHZZuY9Yo1g=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6200 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 489aa99f-5c99-4032-736f-08d90572bb70 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YYrSaHH1sMY1FARuFD/TaMpQ+/7kvv0tzxNCfgW0b9eQg+Gw2ElgJcHDjuMX1oA6WNZhI6ggStPjveJAGyejoj1FsQfy+3BBtHdlOwQSPONFxL+0G9lemEHCgpkU4n4nEfArdyjIs/7AoHqyjIdattZwKDEql6tisayBBv+l0mItB3YfUgnvIUC6eFawebXGs0exPJ++KEhsFDRaVJB4j7O2E48zFaGWp7mPGF7FGGX6EkC6J2fcDMAjbM0YM6+CAD6F1tQ9V2Qvr5LDKiUqVd5k4qQ/1iO7t44R8/Fjjp35rds6hAtArtMxtyf/vDvySuDP2FDNVp4ABSqEvyXcE5aueJ4cqIA2VtiUOUMrLDPbp8SNYZTrDtNlnsOn0a+SGHkMhYO8x5HUMBN7+6r7ooKmMgQ80EeX8cMbXFSjI0c4fE17FBCRvGo6MZheV7hchgfZ7TH/LvhfaUoDGZS0H/2pEwtNUyjUYwyf2hPdUyOPrKA9TWR81wVPnF3sTMX9GLJzQo8Ld6W71ic5Z2zAlIkKMqHPdhQXrLTLmuzzuVBJkHHvoqyLbSwjW1DBComCB4qlCeR6G3mn2duLvuWKOdNHeL2NkCxlfvrJsdNVRYulXbZ5ywO7w5dllaD2Iz/8j8tQXXOn1wdM8n06STcxADDzU2plHCM/eNFZlXi2e7UrT2hQNcO5+mJCedzk3Vnh X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39850400004)(396003)(376002)(346002)(136003)(36840700001)(46966006)(5660300002)(33656002)(86362001)(53546011)(26005)(110136005)(55016002)(34070700002)(81166007)(316002)(52536014)(2906002)(47076005)(70586007)(70206006)(336012)(8936002)(6506007)(82740400003)(45080400002)(186003)(83380400001)(9326002)(8676002)(36860700001)(82310400003)(7696005)(9686003)(478600001)(6636002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2021 09:41:16.4103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c84160c-a40b-42ad-2b18-08d90572c697 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4126 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM6PR08MB3784D65F1AA5D87C9BD12FBD84469AM6PR08MB3784eurp_" --_000_AM6PR08MB3784D65F1AA5D87C9BD12FBD84469AM6PR08MB3784eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar From: Pierre.Gondois@arm.com Date: Wednesday, 21 April 2021 at 13:21 To: devel@edk2.groups.io , Sami Mujawar , leif@nuviainc.com , ardb+tianocore@kernel.org= , sean.brogan@microsoft.com , Bret.Barkelew@microsoft.com Subject: [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois --- .../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLi= b.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c index 5f453d18e415..31672ae5cf4d 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c @@ -101,7 +101,7 @@ SendMemoryPermissionRequest ( } // Check error response from Callee. - if (*RetVal & BIT31) { + if ((*RetVal & BIT31) !=3D 0) { // Bit 31 set means there is an error retured // See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and // Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64. -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. --_000_AM6PR08MB3784D65F1AA5D87C9BD12FBD84469AM6PR08MB3784eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Pierre= ,

&nbs= p;

Thank you= for this patch.

&nbs= p;

Reviewed-= by: Sami Mujawar <sami.mujawar@arm.com>

&nbs= p;

Regards,<= o:p>

&nbs= p;

Sami Muja= war

From: Pierre.Gondois@arm.= com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar = <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, = ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@mi= crosoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMm= MmuLib

From: Pierre Gondois = <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
Non-Boolean comparisons should use a compare operator
(=3D=3D, !=3D, >, < >=3D, <=3D)

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 .../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c  = | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLi= b.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 5f453d18e415..31672ae5cf4d 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -101,7 +101,7 @@ SendMemoryPermissionRequest (
   }
 
   // Check error response from Callee.
-  if (*RetVal & BIT31) {
+  if ((*RetVal & BIT31) !=3D 0) {
     // Bit 31 set means there is an error retured
     // See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUT= ES_GET_AARCH64 and
     // Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AA= RCH64.
--
2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_AM6PR08MB3784D65F1AA5D87C9BD12FBD84469AM6PR08MB3784eurp_--