From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.76]) by mx.groups.io with SMTP id smtpd.web12.5816.1616927451002928420 for ; Sun, 28 Mar 2021 03:30:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=iiAoyv5X; spf=pass (domain: arm.com, ip: 40.107.20.76, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZehepbZZNfFCAqRsijZGwrX74ug6qzaaVhOMsEebA+A=; b=iiAoyv5XrdGSwUmUpeoj60xBqJC3bxUTzWb70wt6qINH/HWtPNCGkMoLhhFdfHtoN4lxlnHncvyNU44IxJzeqy67QUEdYMTGYyufEWlnBobQBlJd2GqnIaxMNoh8cPe2pfppZK4sJ20cfiLWAs3vJjYOuLDq9T1RekCAyAame6g= Received: from AM7PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:100::20) by VI1PR08MB3438.eurprd08.prod.outlook.com (2603:10a6:803:82::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Sun, 28 Mar 2021 10:30:45 +0000 Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::45) by AM7PR02CA0010.outlook.office365.com (2603:10a6:20b:100::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Sun, 28 Mar 2021 10:30:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Sun, 28 Mar 2021 10:30:45 +0000 Received: ("Tessian outbound 2220e7a8bae2:v89"); Sun, 28 Mar 2021 10:30:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5f278a029690a033 X-CR-MTA-TID: 64aa7808 Received: from 7a72c518b230.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E662F3E-A29E-407C-A498-11C7C0E47EED.1; Sun, 28 Mar 2021 10:30:37 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7a72c518b230.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 28 Mar 2021 10:30:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRdPqA+qF1OAJbww/NTuKqkYYrxKmk7/eakCVwivhH6xre9BMTnwhWKU7VC86kZLJmPnPVcmL2CFE5m73Nmcv6P8Nyr9OH3RD+UIYPOWrfbGDoDi8ba3WLaV3iZe6gOVoNABJK2A3VD3dIMq60qUwZiNaDsJuZoEFjrdiuvRoN0/7h52ponxP8l+T4uDjme36wG9t76x9R1Ax9ABKr/2AUzhgJx2uy0+aKHtgQl7lZuymw8N5PngwFjHLwgLkLqiJfrhdub+3Mekjt22JnDpkSPaeiwK0dX+J0leNzI0DXaPk6xs8tmJUp4QlGXEfsDHD3Zxax+h9lhlo4agbtB8Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZehepbZZNfFCAqRsijZGwrX74ug6qzaaVhOMsEebA+A=; b=XebJszokq7a7UM7GklUVypMpM29ulRmdw9IcvOKEHA+79vdb6c1fr3ns8gJo2XwDepTnmDghEcrzCjlTlRYuBIspzVxJbIwVkvkoxrpcQgep+vhYDkfogBwtO9W0MUeEI6Mia6AuVvudASUOnVkObEN5p6aR/0XKU6AcXevPjVjkSEdvg6HeDY0FtKlC+R9pvmtg93BO8gw3HYtC32RGgLUJ536Iy6slLcGbBrCaf7iGpJ7oxENI7OZNefbiBqdyGKLuF95rR2hiG8CgbgeYWDW8clNMsSErABtyE/SlfnM0FPE8+36zc1/mNynA2LkMYNREBVEBG8fWkjPEfTSZhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZehepbZZNfFCAqRsijZGwrX74ug6qzaaVhOMsEebA+A=; b=iiAoyv5XrdGSwUmUpeoj60xBqJC3bxUTzWb70wt6qINH/HWtPNCGkMoLhhFdfHtoN4lxlnHncvyNU44IxJzeqy67QUEdYMTGYyufEWlnBobQBlJd2GqnIaxMNoh8cPe2pfppZK4sJ20cfiLWAs3vJjYOuLDq9T1RekCAyAame6g= Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3142.eurprd08.prod.outlook.com (2603:10a6:209:46::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Sun, 28 Mar 2021 10:30:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::253a:c74d:3408:25ce]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::253a:c74d:3408:25ce%6]) with mapi id 15.20.3977.030; Sun, 28 Mar 2021 10:30:36 +0000 From: "Sami Mujawar" To: Ilias Apalodimas CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver Thread-Topic: [edk2-devel] [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver Thread-Index: AQHXGDcr7gKjDnDSn06Jlqlzw163UaqYXkiAgAAGr4CAAOUFLQ== Date: Sun, 28 Mar 2021 10:30:36 +0000 Message-ID: References: <20210313183139.3256104-2-ilias.apalodimas@linaro.org> <14174.1616876741028136783@groups.io>, In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.140.62.49] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9d0a9aa7-11b6-44d9-edc9-08d8f1d48bba x-ms-traffictypediagnostic: AM6PR08MB3142:|VI1PR08MB3438: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QJOTeJ0/05aeEqvUk+61E3K0sRhg6agBNay5/vIpkgQZo+pryFZ4VdVC99nK8P2srJngl8Ne02Ch4ZGXEKLHgty1qtRZje2Ws7nQrz1z4uSRO5miRk20k37aI7/40l9nCuMtOFT1wwAU5F/VQA+lVZeTPrYWTKg6cfvf/xZZWYvIC+myt1fMg+TZzLFl1BD9O/f6nR+AqTlfrKxj88ms9xS4lf4H9CSyAs2vnI5mzRyGshYWMHWY0XbTMN/gph/i2xW3TXkF1TdvRSpZLxJ62X1t3y05zjF+TX0vXR4S41A3ba4YoXnGJ5LQI7sLkuV3FoCxNie9op8yiKCyGzMNxPvZjb9CIDVeCVgRaHjK6hbYJll22HlW5fBaMyN7KCmIdek1tlhufswazD6lF924QKBZJcEtRc3iElglIOsuSfg/57B62ELxgCO4HYOy3JvY4otG8i49QKp5V5QYCaGC02yQ50Nl7bLoUI1w+px3XsakYzg5A6px4FmFL1+g8Dhj+nr4gd0/i9iflvWF28HXxusIE5ZA4Hnv1CRGCpBB0vKvwAugxXM+l30yRq8Tr4u+WsX3ni3+8uDvyBpIwjwoYS59eCXLeLpDsE5QqqCq+Z/wwYhQ51GtiGMXsCUOgVpbrvdKtR0dfeQkwMPMPFmvbEZtBmXUb9cTf45kVttsouTKWOFCR7mM3eRhKobsOIHN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(33656002)(26005)(38100700001)(86362001)(4326008)(66476007)(8676002)(9326002)(55016002)(6916009)(9686003)(2906002)(52536014)(5660300002)(478600001)(6506007)(76116006)(83380400001)(316002)(8936002)(66446008)(66946007)(186003)(53546011)(66556008)(91956017)(64756008)(7696005)(71200400001)(299355004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0/WTSDxVi3J55EvP1O7+O/iRyL3L5l+2d2AnZoxKLQMHe8Vcg6xLDnPuhl7f?= =?us-ascii?Q?f0dDCo2n8VPcIev0Bb2WTq3/NDnDZ2j3osvuEbMJ0uE9vSPscVm/88I3fAQh?= =?us-ascii?Q?v7cKACFI1t1Xm690A8Ta6LAXswNmo0d2qdIFar604yKRpufaeZtekvuD4OtG?= =?us-ascii?Q?guFfNJTcghKguzbBNrL8/X8BhurDsF2+IXkSUomD8ragqJg+Tl3O+thjWiFJ?= =?us-ascii?Q?DCL1HTm+KBDr7es07eFjhXYP9km3JQ6vQ0amk4XtGVc/XugOWu3hnqn/U4t6?= =?us-ascii?Q?NBriOrT5h+CbJf5AOXya9zaKWSRH5nXina/aCCCs+Q6/SLxe5CIxKlgPZrJr?= =?us-ascii?Q?UMQRjuB51IYBHQUDJCcVNvRN8513ZyNXUL780j35GR0dFL8WaINc3mPqhR6o?= =?us-ascii?Q?0XjAi7CoEE/cuPra5J0CnSrtY/+cGqVKLYwbE6r+RiL/qk3IT2g0rsij7TfN?= =?us-ascii?Q?rmokhD1M2WdMFLyDlBnzbIMVm5SaSygX+BUas8aYMJaFDJHM3kYEA1+JLHRY?= =?us-ascii?Q?DFEfmNNE0SwN0WKxUq5IeNZd/Vpjps/6a95Ba8YJ2fYMNvNG3ey71O5oH39O?= =?us-ascii?Q?UsG15WuDn4xfJuyYMySGWoMyYk3ndzG6jYWGtPBwjOr8IqvOdpuKD5HFz9FV?= =?us-ascii?Q?/vw/V1aV1QgPsgotb4txUv4MKIqU5UNEbIztXlulTwzCGwACyL4MFXQFud8i?= =?us-ascii?Q?AUcr32HFsR67TjzETysAe/aA0c/VICKbuChzGEKMl6KCr62ir6KxsVhRjxcZ?= =?us-ascii?Q?Cf0QmZy3SvCwWDpfvhKhufUSAouFSuJT6Ya5UJMKig/sNuhKvB2y9T+P7AwG?= =?us-ascii?Q?iD/AeZMihBadojLEy941rQjrc1Pd2JKOrJr/F02tokzxwE1K4XBBrf89ScFG?= =?us-ascii?Q?zGSlapXtajWzwc9jCMryoUjuREK/1dvzW/9tmV7WyjhSrQvIjFrwvAygvRSi?= =?us-ascii?Q?5O0kEO+L/pUWPhm8c9FE0Jfwr0ItU9Y+s9/qP0V3Wt+5IdL4zAG1hS6sSQXq?= =?us-ascii?Q?5/9501LkdOo/v4aUfy6MOzKr1AIKh+uAlg6zqq64en7MdFTM0rCupdS1Ch7f?= =?us-ascii?Q?S+WD7gcqVjamxJmwKb7EPQ/vNB6kBZgjggN+b44W5sZmhT3SA1pjy4E9mwXz?= =?us-ascii?Q?eZD1EtDWcWuGubyOH0E/FUbVUEpngsJ2WgaTS0hXvvd1yISnbJKWTsV9vWuF?= =?us-ascii?Q?okoS7kpZCv51iFOMFgk87A/5u9kFGlKGHdMxfsyIZEoJiW0++U5ZOiZBNWPt?= =?us-ascii?Q?JMRF9iDVC99MiGSmb9sBWi9HeRtAv5OH/JpSG3A3IEyQ8lssOBg58BOko7zI?= =?us-ascii?Q?78kq4gdPF9tpL1WwySJpufvOGwsy3bVXp2e2HUfVdpI2RQ=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3142 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a9db3568-cc24-43af-b0ae-08d8f1d486c8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nySpnM1TosBLBT39D5QoO8XzdRT0zFnZeFpe3Y7p5pOYDGBqBajrQWudrQyocFiOs3V6YxcYHj0O/dxi9jt7dGEyU8bfjg5jcPiFWvuImKoPVc3hManEsJKjjQcHoSaHflhHH+jfNXGgPRzSeDlx1aINuY2Bq1J4RJCThfi4AD9/FM3Ei49JY7fMnFVUD6jk6yi/i4ANn3emcboLyFeDVwKfQKOJ0H+wZ9LmBTNelRwSPH3jFH6a7bJpuGht1uOU/Tyf+ZFXlLhI2lide611lKTgpb4PPN7pu/jpNOg+1T0qqTYZCZb8V0JQsjNr6kRRC4v6X08cGJkVvxMBZMkI4ulYksmGc/m4TdBn/44on6T6JJX9Ue7l9w6jo8J392l2rIq1ui2NgBTPYqZxAEwc8ZqLZZpJ1purE3yUnE5I7z9E9ira4/vrtZWEmFn5nqeBD2EhLaquCT+o0ws1g2/HzK9uj4zq3ucDySo8WpFD5NW2jPAmEaCaoGUBeQ+BQJpZMgHcAc0OIBbPJ9TJsjnMOjZrBDmEQZrZZHPC7N83smv2W3uimP/EGB9P5cgU3+tTU0DSa2JUTvstFS8FcpjyubIWsulnuFTeOQ1vBh9SrTvJsF1DbrCqe2EB/Gssq+WCHu8fhR03L+fx4z7jh76Mv5Yi7WZCN2M+AIMdZ/pJNEQpXQdH+ppjaeL07glDG14O X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(136003)(396003)(376002)(39860400002)(36840700001)(46966006)(55016002)(336012)(4326008)(81166007)(9326002)(356005)(70206006)(83380400001)(70586007)(8936002)(82740400003)(53546011)(186003)(6506007)(6862004)(86362001)(33656002)(52536014)(8676002)(47076005)(36860700001)(26005)(2906002)(5660300002)(478600001)(316002)(82310400003)(9686003)(7696005)(299355004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2021 10:30:45.0862 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0a9aa7-11b6-44d9-edc9-08d8f1d48bba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3438 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM6PR08MB3784E5F5078C1C6FFFAC92EC847F9AM6PR08MB3784eurp_" --_000_AM6PR08MB3784E5F5078C1C6FFFAC92EC847F9AM6PR08MB3784eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ilias, From: Ilias Apalodimas Date: Saturday, 27 March 2021 at 20:49 To: Sami Mujawar Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an OP-TEE b= acked RPMB driver On Sat, Mar 27, 2021 at 01:25:41PM -0700, Sami Mujawar wrote: > Hi Ilias, > > On Sat, Mar 13, 2021 at 10:31 AM, Ilias Apalodimas wrote: > > > > > + NumBytes =3D3D NumLba * Instance->BlockSize;=3D0D > > + Base =3D3D (VOID *)Instance->MemBaseAddress + Start * Instance->Block= Siz=3D > > e;=3D0D > > + Buf =3D3D AllocatePool (NumLba * Instance->BlockSize);=3D0D > > + if (Buf =3D3D=3D3D NULL) {=3D0D > > + return EFI_DEVICE_ERROR;=3D0D > > + }=3D0D > > + SetMem64 (Buf, NumLba * Instance->BlockSize, ~0UL);=3D0D > > + // Write the device=3D0D > > + Status =3D3D ReadWriteRpmb (=3D0D > > + SP_SVC_RPMB_WRITE,=3D0D > > + (UINTN)Buf,=3D0D > > + NumBytes,=3D0D > > + Start * Instance->BlockSize=3D0D > > + );=3D0D > > + if (EFI_ERROR (Status)) {=3D0D > > I think there is a memory leak here as Buf is not freed. If you agree, I = will fix this locally before merging the changes. Yes there is, please do and let me know if you need anything else. Thanks for the catch! [SAMI] I will change this before pushing. Reviewed-by: Sami Mujawar sami.mujawar@arm.com Regards, Sami Mujawar Cheers /Ilias > > > > > + return Status;=3D0D > > + }=3D0D > > + // Update the in memory copy=3D0D > > + SetMem64 (Base, NumLba * Instance->BlockSize, ~0UL);=3D0D > > + FreePool (Buf);=3D0D > > + }=3D0D > > +=3D0D > > + VA_END (Args);=3D0D > > +=3D0D > > + return EFI_SUCCESS;=3D0D > > +}=3D0D > > Regards, > > Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. --_000_AM6PR08MB3784E5F5078C1C6FFFAC92EC847F9AM6PR08MB3784eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Ilias,=

&nbs= p;

&nbs= p;

From: Ilias Apalodimas &l= t;ilias.apalodimas@linaro.org>
Date: Saturday, 27 March 2021 at 20:49
To: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an O= P-TEE backed RPMB driver

On Sat, Mar 27, 2021 at 01:25:41PM -0700, Sami Mujaw= ar wrote:
> Hi Ilias,
>
> On Sat, Mar 13, 2021 at 10:31 AM, Ilias Apalodimas wrote:
>
> >
> > + NumBytes =3D3D NumLba * Instance->BlockSize;=3D0D
> > + Base =3D3D (VOID *)Instance->MemBaseAddress + Start * Instan= ce->BlockSiz=3D
> > e;=3D0D
> > + Buf =3D3D AllocatePool (NumLba * Instance->BlockSize);=3D0D<= br> > > + if (Buf =3D3D=3D3D NULL) {=3D0D
> > + return EFI_DEVICE_ERROR;=3D0D
> > + }=3D0D
> > + SetMem64 (Buf, NumLba * Instance->BlockSize, ~0UL);=3D0D
> > + // Write the device=3D0D
> > + Status =3D3D ReadWriteRpmb (=3D0D
> > + SP_SVC_RPMB_WRITE,=3D0D
> > + (UINTN)Buf,=3D0D
> > + NumBytes,=3D0D
> > + Start * Instance->BlockSize=3D0D
> > + );=3D0D
> > + if (EFI_ERROR (Status)) {=3D0D
>
> I think there is a memory leak here as Buf is not freed. If you agree,= I will fix this locally before merging the changes.

Yes there is, please do and let me know if you need anything else.
Thanks for the catch!

[SAMI] I will change this before pushing.=

Reviewed-by: Sami Mujawar sami.mujawar@arm.com

 

Regards,

 

Sami Mujawar

 


Cheers
/Ilias
>
> >
> > + return Status;=3D0D
> > + }=3D0D
> > + // Update the in memory copy=3D0D
> > + SetMem64 (Base, NumLba * Instance->BlockSize, ~0UL);=3D0D > > + FreePool (Buf);=3D0D
> > + }=3D0D
> > +=3D0D
> > + VA_END (Args);=3D0D
> > +=3D0D
> > + return EFI_SUCCESS;=3D0D
> > +}=3D0D
>
> Regards,
>
> Sami Mujawar

IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_AM6PR08MB3784E5F5078C1C6FFFAC92EC847F9AM6PR08MB3784eurp_--