Re: [edk2-platforms][PATCH v5 1/5] Silicon/ARM/N1SoC: Add platform library implementation

["Pranav Madhu" <pranav.madhu@arm.com>]

Hi Leif,

> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Friday, July 24, 2020 10:59 PM
> To: Pranav Madhu <Pranav.Madhu@arm.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <Ard.Biesheuvel@arm.com>
> Subject: Re: [edk2-platforms][PATCH v5 1/5] Silicon/ARM/N1SoC: Add
> platform library implementation
>
> On Wed, Jul 22, 2020 at 20:55:20 +0530, Pranav Madhu wrote:
> > From: Deepak Pandey <deepak.pandey@arm.com>
> >
> > Add the initial Arm's Neoverse N1 System-on-Chip platform library
> > support. This includes the virtual memory map and helper functions for
> > platform initialization.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
> > ---
> >  Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec                    |  27 +++++
> >  Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf  |  43
> +++++++
> >  Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h              |  66
> +++++++++++
> >  Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c    |  67
> +++++++++++
> >  Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 125
> > ++++++++++++++++++++
> > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S |  84
> > +++++++++++++
> >  6 files changed, 412 insertions(+)


<...>

> > +// Base address to a structure of type NEOVERSEN1SOC_PLAT_INFO
> which
> > +is // pre-populated by a earlier boot stage
> > +#define NEOVERSEN1SOC_PLAT_INFO_STRUCT_BASE
> (NEOVERSEN1SOC_NON_SECURE_SRAM_BASE + \
> > +                                                      0x00008000)
> > +
> > +/*
> > + * Platform information structure stored in non-secure SRAM. Platform
>
> The architectural terms as Secure an Non-secure. I asked for the latter. I will
> fix this up before pushing, but please pay attention to case for architectural
> terminology.
>
> Other than this, the patch is fine, so:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Thanks for fixing this up and your review of the patches. I'll take care of the case for architectural terminology henceforth.

Regards,
Pranav

<...>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.