From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.43])
 by mx.groups.io with SMTP id smtpd.web10.31604.1595780498070308775
 for <devel@edk2.groups.io>;
 Sun, 26 Jul 2020 09:21:39 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=unH+rCHq;
 spf=pass (domain: arm.com, ip: 40.107.21.43, mailfrom: pranav.madhu@arm.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uEwlrlhmIOl0r23Vtirb3QbMctvNJZAfFjW+kTS7W88=;
 b=unH+rCHqo/F7dphpIUiuBx2aNyVUtGK9bzDt83pmD2VuUNh8PSf6WZwV1EVr2n7KHYy6sc+uNStgajX7CqQZtgROxlCPsbj2+pq230mxAi6Ul93/eij1tzyXy6htgEQw8YuqkFa8V46FbVKOSpjtEQEj1nSxmOHz5dXNShSGyCw=
Received: from DB7PR02CA0020.eurprd02.prod.outlook.com (2603:10a6:10:52::33)
 by VE1PR08MB5103.eurprd08.prod.outlook.com (2603:10a6:803:107::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.22; Sun, 26 Jul
 2020 16:21:34 +0000
Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:52:cafe::73) by DB7PR02CA0020.outlook.office365.com
 (2603:10a6:10:52::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23 via Frontend
 Transport; Sun, 26 Jul 2020 16:21:34 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.3216.10 via Frontend Transport; Sun, 26 Jul 2020 16:21:34 +0000
Received: ("Tessian outbound 2ae7cfbcc26c:v62"); Sun, 26 Jul 2020 16:21:34 +0000
X-CR-MTA-TID: 64aa7808
Received: from a7a5e1b31ed3.1
	by 64aa7808-outbound-1.mta.getcheckrecipient.com id 04C774C9-419E-4A80-B13B-53EB9F70DAB0.1;
	Sun, 26 Jul 2020 16:21:29 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
    by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7a5e1b31ed3.1
    (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
    Sun, 26 Jul 2020 16:21:28 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dRFO1apUd6CcdT3r0ESeaM8gusChI2zERMle+UvkY7pkH8cMT6kBFm7aQD9yyZt0jp/36F4HL88Q2AhbjyDJk5NHJ7CG2UGqUww7NQoU/K7VPWyg0/aYU/Rh5+oZFXCkvxJfHJzpqzLstQcnTIGSDuzYAaPTySvyA77rxA+VOXxDcaV82YgDdmZqccb4XvLV6wiDoUUSnvQ98GDKICOdUxHVFbv27GmbpYR88vVAxsAW4Yv5HJ+IR9GE5i8tG1JeHDEN1CqOpigFCZc3pYRE8H662iIMiiC1UZJeevlqwE14PC8TpAiqkttCEtXUnQxbSHF/UTJHnFOXgmwCNNG1Uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uEwlrlhmIOl0r23Vtirb3QbMctvNJZAfFjW+kTS7W88=;
 b=AlV6G390/hcazxcjetPW1QD2q2SJFsZZRMzNw8YFdSY38ZDUFtbre/12c/XvB7u4QU0C/GRwRQzQ1XC8boKZbbAhzM1LppCpcyiuNOhso8gnfmaR95GHorDLeILPX3EOGelF9Fv5yfdix6Hv7QcknS1Zsjr/grSANnyzN/AIMhbM9Fw1moRxtilpFcvlxU1O2BYsLZ15u+dAaBAIc5JN7t9XseRSviR6mNuNj8jVQsdPs/udM3QegvjaYdljMt2WbWwLCOGMbbE+cS+xJ+Y8+UDrQT1xNrIUKR2RKjcd6X4heh3wGdFE4+L21weCC5Wq7UKuTr7ughQQPHJYLYX1VA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uEwlrlhmIOl0r23Vtirb3QbMctvNJZAfFjW+kTS7W88=;
 b=unH+rCHqo/F7dphpIUiuBx2aNyVUtGK9bzDt83pmD2VuUNh8PSf6WZwV1EVr2n7KHYy6sc+uNStgajX7CqQZtgROxlCPsbj2+pq230mxAi6Ul93/eij1tzyXy6htgEQw8YuqkFa8V46FbVKOSpjtEQEj1nSxmOHz5dXNShSGyCw=
Received: from AM6PR08MB4549.eurprd08.prod.outlook.com (2603:10a6:20b:b6::12)
 by AM6PR08MB2998.eurprd08.prod.outlook.com (2603:10a6:209:4e::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Sun, 26 Jul
 2020 16:21:26 +0000
Received: from AM6PR08MB4549.eurprd08.prod.outlook.com
 ([fe80::f82d:7c8f:e95:1554]) by AM6PR08MB4549.eurprd08.prod.outlook.com
 ([fe80::f82d:7c8f:e95:1554%7]) with mapi id 15.20.3216.031; Sun, 26 Jul 2020
 16:21:26 +0000
From: "Pranav Madhu" <pranav.madhu@arm.com>
To: Leif Lindholm <leif@nuviainc.com>
CC: "devel@edk2.groups.io" <devel@edk2.groups.io>, Ard Biesheuvel
	<Ard.Biesheuvel@arm.com>
Subject: Re: [edk2-platforms][PATCH v5 1/5] Silicon/ARM/N1SoC: Add platform library implementation
Thread-Topic: [edk2-platforms][PATCH v5 1/5] Silicon/ARM/N1SoC: Add platform
 library implementation
Thread-Index: AQHWYd/6FCCddREM8Euy38RrznUZGqkaDIOg
Date: Sun, 26 Jul 2020 16:21:25 +0000
Message-ID: 
 <AM6PR08MB4549636FB3E594AE815F81748A750@AM6PR08MB4549.eurprd08.prod.outlook.com>
References: <1595431524-13782-1-git-send-email-pranav.madhu@arm.com>
 <1595431524-13782-2-git-send-email-pranav.madhu@arm.com>
 <20200724172910.GV1337@vanye>
In-Reply-To: <20200724172910.GV1337@vanye>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ts-tracking-id: 9300ba49-5489-4ea5-adfe-ddeb79e850ed.1
x-checkrecipientchecked: true
Authentication-Results-Original: nuviainc.com; dkim=none (message not signed)
 header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com;
x-originating-ip: [217.140.105.56]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: a293e364-83f2-43b3-f2fb-08d8317ff6c4
x-ms-traffictypediagnostic: AM6PR08MB2998:|VE1PR08MB5103:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: 
	<VE1PR08MB510300D025E84267E57ED33F8A750@VE1PR08MB5103.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: 
 W7gONVrAzqzxVpesgUx7NLdo7VofN0BXwwl1rKtR5T0/u6DxnS9bqBrF89+/Xuruk5TNYGC0sOpqJ7YASLTrQOHn7XrLgRShbWs23zLNiSfWEZepQL3UtuNN2FjUOQ8mdjOkCV/5OFY5/3HNQ0mwbE/ydtIctlaUbsqZ/01KwDRZz2YGChfwxCe/+GGUZV/uYO9y2Kn6XXtUo4IM+SlC01QFkHaA/MwM8U4qgeHajWlOUThkmykZL9HvXv7OWqVZTdsJ3uYBt22I0D4EXOgb2eTAxcglFm52dxSSxbTTULiqEwljYKoN8xAwha8DInjxjaEzgkchuIC5jaQcrxtWrA==
X-Forefront-Antispam-Report-Untrusted: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB4549.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(346002)(39850400004)(136003)(376002)(366004)(6916009)(66946007)(26005)(66556008)(66476007)(55016002)(66446008)(7696005)(64756008)(186003)(9686003)(8936002)(52536014)(86362001)(478600001)(6506007)(53546011)(5660300002)(8676002)(71200400001)(19627235002)(83380400001)(4326008)(76116006)(316002)(54906003)(33656002)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: 
 9jPAmzWVqwpvVsG/aZQxdOtrt9jIlJ/zdMVp9SKxzSNpHjF9tP4u1LABj1/cyDDkJeeDjUNUB/kjTOzadR14PBauxUyzVjTN+8MXBgsVLOpoJXUf7E5q0njxS9Sw7DfOUQuqvkm21ykV5Q6IGzyvy14N179PszYNY8xxcdVigMPGXjsl/78xKT/+wE0Tkp3NMsGcbGM3+CG0UHW9O3EI8UeMWlZHGaRQuHpqGlkSyLtxTN3DNBPLa4+PVwxEcidQ3hQ+0yYDNIWZO4DeQaN+CNRd+I+vvyQc/oW+Uh+hoWYLHjCq+DEVtDhLqrrc8/IyleLBLvQlCw+EX5P8v/geiF+r+ysLPCxfiIOMAm7TBD4y3TR81DkEurR18QNiRo9/3TfKNox6X0uzxf1YdREZCeQWn0GMINrNh/kQOjBLb71Rfcz7a00ip0OIPt4fNI/cwXJNFz5/MzI6Quk3x7ldG4SKnGsuecEXGsFr/3FSYY3AdPj0re+oUOa+9AZ4YIcE
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2998
Original-Authentication-Results: nuviainc.com; dkim=none (message not signed)
 header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com;
Return-Path: Pranav.Madhu@arm.com
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: 
 DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: 
	40b5464b-b1bf-41a4-e597-08d8317ff1db
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	NFxRNMlctEvYaslq7frk3iF9KnIWe5PGw7DQHLDfERRXR3knSOmfWJK0gnR+8hPjqKkNUVtsPtbr9EmDhCQxwxxWsDKnXEOhJAhUHno0J9ZAykabYzvLiD5IRIm2Ee5b/NSwCBqzLWBEOnbd0gxgQj6GOkVl0O+lyDKr2+QEG7lDX2FmUsLdLcIOKHXr63nACGAxoZ33TCQIGvbBlpFudvTqAbqSO+E7m7Lkn5949Jfdpk0FVyC0qRm4IsnQfDqLBiM9oh9ykCXDraQJg0RJO98usWiJRtKchQUvlk/jLLqBXOR4eli62r9keMYveolioScUB1eS1n1iGv22USSvSGlp46/U0PPaXzuHWlQ0UsU2RSdav0J6iidQEf5L1/Dpgqx93gkvepMREj7GN8TIGA==
X-Forefront-Antispam-Report: 
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(346002)(396003)(39850400004)(46966005)(26005)(8936002)(336012)(4326008)(186003)(82310400002)(47076004)(356005)(33656002)(83380400001)(82740400003)(2906002)(8676002)(86362001)(53546011)(5660300002)(6862004)(70206006)(70586007)(52536014)(6506007)(316002)(54906003)(55016002)(81166007)(7696005)(19627235002)(478600001)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2020 16:21:34.3475
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a293e364-83f2-43b3-f2fb-08d8317ff6c4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: 
	DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5103
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Leif,

> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Friday, July 24, 2020 10:59 PM
> To: Pranav Madhu <Pranav.Madhu@arm.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <Ard.Biesheuvel@arm.com>
> Subject: Re: [edk2-platforms][PATCH v5 1/5] Silicon/ARM/N1SoC: Add
> platform library implementation
>
> On Wed, Jul 22, 2020 at 20:55:20 +0530, Pranav Madhu wrote:
> > From: Deepak Pandey <deepak.pandey@arm.com>
> >
> > Add the initial Arm's Neoverse N1 System-on-Chip platform library
> > support. This includes the virtual memory map and helper functions for
> > platform initialization.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
> > ---
> >  Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec                    |  27 +=
++++
> >  Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf  |  43
> +++++++
> >  Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h              |  66
> +++++++++++
> >  Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c    |  67
> +++++++++++
> >  Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 125
> > ++++++++++++++++++++
> > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S |  84
> > +++++++++++++
> >  6 files changed, 412 insertions(+)


<...>

> > +// Base address to a structure of type NEOVERSEN1SOC_PLAT_INFO
> which
> > +is // pre-populated by a earlier boot stage
> > +#define NEOVERSEN1SOC_PLAT_INFO_STRUCT_BASE
> (NEOVERSEN1SOC_NON_SECURE_SRAM_BASE + \
> > +                                                      0x00008000)
> > +
> > +/*
> > + * Platform information structure stored in non-secure SRAM. Platform
>
> The architectural terms as Secure an Non-secure. I asked for the latter. =
I will
> fix this up before pushing, but please pay attention to case for architec=
tural
> terminology.
>
> Other than this, the patch is fine, so:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Thanks for fixing this up and your review of the patches. I'll take care of=
 the case for architectural terminology henceforth.

Regards,
Pranav

<...>
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.