From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.42]) by mx.groups.io with SMTP id smtpd.web10.49448.1595827744158119392 for ; Sun, 26 Jul 2020 22:29:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=NYXnwEF2; spf=pass (domain: oss.nxp.com, ip: 40.107.20.42, mailfrom: meenakshi.aggarwal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iWkUw8Z/8o8gtlzdWAm3QaV0+f4k2WdvYN8gXWbBC1m80cTx5iwc6/ViRAj8NYBtznxbgHgPaIcqndLbqbcr/ap4XA3zqxsdvsmPLkhUvST/zDTuAoOu44kNF7fwjfhB4mIvwsIFwG9ZteL6DfbX7Hf+VIR9Lea80WfVCt429Ofv2AAnfUcgAN4AW3ZFL1ioenlu3/EQTtTu2uyIgo/pwaTVvh8FPLhdu6IQ0zak6gJ/gJq/rqVfh+2ij6VCUbPX5noZuR5kf6qmpAOXkPqPJ9xMe4g3ZGwfMuI1kB8feKbZCcHVGf9gfhQVXjeJdWrLz393X9pRx7AApHCeC67uww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCcal07cg75Fn2CmACoq2CeTce1RXIdUNYgW3H+YJqk=; b=KAQmprT6P6AYko3ByvCn8al76CeMe+i4KDb9bJ9ZBUIDwYBTLrpAkxtfKNECHIc0qFOWPWRCIBiIf5JHqQboFiW2rWpOcde5lM141feBXYOvV459PfYQtPzh7/Q51n8qUn9TKlN45dzHv0yAiea//ey/wxYaX+knLsnBYAe6xoDWY/el8VdHPFg08LNXg6DnFbTIPYT/pUWT6R64l8gWFjrZoYOa11sqGyXB3kYbIz1b4okkguzHAflRl/JTlGsPWYYycCcvBoYuHD9Z6eBL/TNO1S0DD74mbgYWib+XIbqaFXqYB54OA4Qa0ORcGMgH5ezbVWSMsWxwksQphhhhvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCcal07cg75Fn2CmACoq2CeTce1RXIdUNYgW3H+YJqk=; b=NYXnwEF2G0WV9MDbHE/smcz2LEri4xQqkmoSaz5l6iMW89eosMgHajg0ieFruEii7mf3m5WpeR7kOz+sobhxesHSko9dhk9AXWfnnwMqqvkVmMtd5RbcSmqr07sW+To5vNYC1Ss8JGEl1+NhU55PURR19Ms2M0t5PBopoiazd5I= Received: from AM7PR04MB6885.eurprd04.prod.outlook.com (2603:10a6:20b:10d::24) by AM6PR04MB5191.eurprd04.prod.outlook.com (2603:10a6:20b:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.26; Mon, 27 Jul 2020 05:29:02 +0000 Received: from AM7PR04MB6885.eurprd04.prod.outlook.com ([fe80::55ce:fc95:27b8:7e9a]) by AM7PR04MB6885.eurprd04.prod.outlook.com ([fe80::55ce:fc95:27b8:7e9a%9]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 05:29:02 +0000 From: "Meenakshi Aggarwal (OSS)" To: Leif Lindholm , "Meenakshi Aggarwal (OSS)" CC: "ard.biesheuvel@arm.com" , "michael.d.kinney@intel.com" , "devel@edk2.groups.io" , Varun Sethi Subject: Re: [edk2-platforms] [PATCH v3 0/2] Add USB driver support Thread-Topic: [edk2-platforms] [PATCH v3 0/2] Add USB driver support Thread-Index: AQHWY9bVctpYUglHE02P/dMd87OD8A== Date: Mon, 27 Jul 2020 05:29:01 +0000 Message-ID: References: <1591200042-11232-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <1594325036-10606-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <20200724164702.GT1337@vanye> In-Reply-To: <20200724164702.GT1337@vanye> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [103.92.42.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bc564e33-850d-4903-97c4-08d831edf8b2 x-ms-traffictypediagnostic: AM6PR04MB5191: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 43iHnaRlfNG6ErPYfQPe4rZqByZSsNLnZk/oVZyMODmHO6Lw+MqmrBBcSdZFXpIafEibFuOOEP9ACwqlwaSe/UC7DtYZFDJgN+7eBqf2ZLV7FgJbmmPtqHoV+EBQT0dkSFsI3Lx4AMCqMwdAlo4Fx6NNNpcrGkYO1i+7cyM1y8VVCjDcJuvffUpNn/SPsgri1t310kC22W50MVfkV3QqAFt1UUDaIv6q8CqgW+QIHezVEU9DRoEqjvwfobREqISgUBZENVxoGvKxhUwlui+szNBNwADoDWNBkHo/PacinWsm4YbMW+Ipfa4kF5x5+i74YlFI30eaFknnkuRhz4H+OA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB6885.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(86362001)(6506007)(26005)(478600001)(53546011)(4326008)(186003)(7696005)(8936002)(5660300002)(54906003)(19627235002)(110136005)(83380400001)(33656002)(71200400001)(2906002)(8676002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(52536014)(55016002)(316002)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: ZZBPM3E0jXrms1YC0lRh1liz8uBesSGkb7Rgme+/dtmsXKPbCaQ0RrVgoQ0jQJ/D1OvEtbUhP0rEsWc9vnoJc1zdj2Gci37bljDmf0z6C/mfMmYpouVmoSgg4qGa9IUqtvZjWlRLxguyhETn0MzJN8xLN0CxSL8rIJkOuoimdwnRTAAzg/KZlZTNs9nzMkCCd/16p/0sO/hlIisuEcOe5FBfjCY48XkSjqQhEjvm53ydCaeEKSKAIuhzUhwBmDbMPTd47GVPr9KVN9GAkRWD8aAaSTGr0TbZmdDJgsQTLhyfRpnyD3sgi9BxsHVI315IzirH7x1SbqWErpePWjqBQJX6rlYtUlDahVAOTOXuOSIeWwn7E7/sCHzmTpLhZMHIIlVE/hu0tYJcpsKMDfkKwL8kjP4s0za2RWBxEdivTX/4EzEsk5T8auAayX21BHrQFq14FWe0zYVwovQmEHXGST/QlTDdOJdUvJM8Egppgl4= MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB6885.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc564e33-850d-4903-97c4-08d831edf8b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 05:29:02.1627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0y94vMU4WfV4CW6tS3zu6LNQKbrF+xW1YHd8Va7BXRr/ERZqpH8PBe2afcAckRALsNH5mgkkQUoBI5UyEFkzkRNNvPIUZyiH9K/AwwNWsOw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5191 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Leif, We will take care of same in future patches. > -----Original Message----- > From: Leif Lindholm > Sent: Friday, July 24, 2020 10:17 PM > To: Meenakshi Aggarwal (OSS) > Cc: ard.biesheuvel@arm.com; michael.d.kinney@intel.com; > devel@edk2.groups.io; Varun Sethi > Subject: Re: [edk2-platforms] [PATCH v3 0/2] Add USB driver support >=20 > On Fri, Jul 10, 2020 at 01:33:54 +0530, Meenakshi Aggarwal wrote: > > This patchset implement USB driver for DWC3 controller and enable USB > > for LX2160A Platform. > > > > Changes in v2: > > - Indentation changes > > - Incorporated review comments > > - create EndOfDxe event and initialize USB in EndOfDxe > > callback function. > > > > Changes in v3: > > - Passing Usb initialization function as init function > > of RegisterNonDiscoverableMmioDevice() > > > > Meenakshi Aggarwal (2): > > Silicon/NXP: Add DWC3 USB controller initialization driver > > Platform/NXP:LX2160: Enable support of USB controller >=20 > For series: > Reviewed-by: Leif Lindholm >=20 > However, in future, please rebase patches onto current master before > sumitting later revisions. This set conflicted with 7c552c1a2611 > ("Platform/NXP: LX2160aRdbPkg: Enable PlatformDxe driver") which was > pushed on 3 July. >=20 > Pushed (together with SATA series previously reviewed) as: > b972f17b329a..7de21b6aa3e0 >=20 > > Silicon/NXP/NxpQoriqLs.dec | 5 + > > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 4 + > > Silicon/NXP/NxpQoriqLs.dsc.inc | 12 + > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 1 + > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +- > > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf | 45 ++++ > > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h | 138 ++++++++++ > > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c | 275 > ++++++++++++++++++++ > > 8 files changed, 495 insertions(+), 3 deletions(-) create mode > > 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h > > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c > > > > -- > > 1.9.1 > >