Re: [PATCH v2 2/5] MdeMoudlePkg: introduce new PCD for Acpi/rsdp

["Jianyong Wu" <jianyong.wu@arm.com>]

Hi Sami,

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Wednesday, May 19, 2021 4:26 AM
> To: Jianyong Wu <Jianyong.Wu@arm.com>; devel@edk2.groups.io;
> lersek@redhat.com; ardb+tianocore@kernel.org
> Cc: hao.a.wu@intel.com; Justin He <Justin.He@arm.com>; Jian J Wang
> <jian.j.wang@intel.com>; nd <nd@arm.com>
> Subject: Re: [PATCH v2 2/5] MdeMoudlePkg: introduce new PCD for
> Acpi/rsdp
> 
> Hi Jianyon,
> 
> Thank you for this patch.
> 
> Please find my response inline marked [SAMI].
> 
> Regards,
> 
> Sami Mujawar
> 
> 
> On 17/05/2021 07:50 AM, Jianyong Wu wrote:
> > As there is lack of a machnism in Cloud Hypervisor to pass the base
> > address of Rsdp in Acpi, so a PCD varialbe is introduced here to
> [SAMI] Please fix the following typos: 'machnism' & 'varialbe'
> > feed it.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> > ---
> >   MdeModulePkg/MdeModulePkg.dec | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec index
> 148395511034..4c8baac35a9e
> > 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -910,6 +910,13 @@ [PcdsFixedAtBuild]
> >     # @Expression 0x80000001 |
> (gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable
> == 0xFFFFFFFFFFFFFFFF ||
> gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable <=
> 0x0FFFFFFFFFFFFFFF)
> >
> >
> gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable|0|
> UINT6
> > 4|0x30001015
> >
> > +  ##
> > +  # This is the physical address of rsdp which is the core struct of Acpi.
> > +  # Some hypervisor may has no way to pass rsdp address to the guest,
> > + so a PCD  # is worth for those.
> > +  #
> > +
> > +
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiRsdpBaseAddress|0x0|UINT64
> |0x3
> > + 0001056
> [SAMI] Can this PCD be defined in ArmVirtPkg\ArmVirtPkg.dec ?

Ok, It's better to do this change.

Thanks
Jianyong 
> > +
> >     ## Progress Code for OS Loader LoadImage start.<BR><BR>
> >     #  PROGRESS_CODE_OS_LOADER_LOAD   =
> (EFI_SOFTWARE_DXE_BS_DRIVER | (EFI_OEM_SPECIFIC | 0x00000000)) =
> 0x03058000<BR>
> >     # @Prompt Progress Code for OS Loader LoadImage start.