* [PATCH v1 0/1] Correct spelling error in SctPkg @ 2022-10-11 17:54 Sam Kaynor 2022-10-11 17:54 ` [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Sam Kaynor 0 siblings, 1 reply; 7+ messages in thread From: Sam Kaynor @ 2022-10-11 17:54 UTC (permalink / raw) To: devel 4 incorrect instances of "RANDOM_NAME_PROTOCOL" corrected to "RANDOM_NUMBER_PROTOCOL" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4065 Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Cc: Barton Gao <gaojie@byosoft.com.cn> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Cc: Eric Jin <eric.jin@intel.com> Cc: Arvin Chen <arvinx.chen@intel.com> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> Sam Kaynor (1): uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL 2022-10-11 17:54 [PATCH v1 0/1] Correct spelling error in SctPkg Sam Kaynor @ 2022-10-11 17:54 ` Sam Kaynor 2022-10-11 22:30 ` [edk2-devel] " Samer El-Haj-Mahmoud 2023-01-30 12:16 ` Rebecca Cran 0 siblings, 2 replies; 7+ messages in thread From: Sam Kaynor @ 2022-10-11 17:54 UTC (permalink / raw) To: devel Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in RandomNumberBBTestConformance and RandomNumberBBTestFunction to "RANDOM_NUMBER_PROTOCOL". Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Cc: Barton Gao <gaojie@byosoft.com.cn> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Cc: Eric Jin <eric.jin@intel.com> Cc: Arvin Chen <arvinx.chen@intel.com> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c index 2738a4899457..364aaca925e0 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_WARNING, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, AssertionType, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", L"%a:%d: Status - %r, RNGAlgorithmListSize - %d", __FILE__, (UINTN)__LINE__, diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c index 3d41085d2243..0ba003449dc6 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL 2022-10-11 17:54 ` [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Sam Kaynor @ 2022-10-11 22:30 ` Samer El-Haj-Mahmoud 2022-11-07 7:55 ` G Edhaya Chandran 2023-01-30 12:16 ` Rebecca Cran 1 sibling, 1 reply; 7+ messages in thread From: Samer El-Haj-Mahmoud @ 2022-10-11 22:30 UTC (permalink / raw) To: devel@edk2.groups.io, Sam Kaynor; +Cc: Samer El-Haj-Mahmoud [-- Attachment #1: Type: text/plain, Size: 5035 bytes --] Reviewed-By: Samer El-Haj-Mahmoud < samer.el-haj-mahmoud@arm.com> ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sam Kaynor via groups.io <sam.kaynor=arm.com@groups.io> Sent: Tuesday, October 11, 2022 1:54:43 PM To: devel@edk2.groups.io <devel@edk2.groups.io> Subject: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in RandomNumberBBTestConformance and RandomNumberBBTestFunction to "RANDOM_NUMBER_PROTOCOL". Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Cc: Barton Gao <gaojie@byosoft.com.cn> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Cc: Eric Jin <eric.jin@intel.com> Cc: Arvin Chen <arvinx.chen@intel.com> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c index 2738a4899457..364aaca925e0 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_WARNING, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, AssertionType, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", L"%a:%d: Status - %r, RNGAlgorithmListSize - %d", __FILE__, (UINTN)__LINE__, diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c index 3d41085d2243..0ba003449dc6 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, -- 2.34.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95008): https://edk2.groups.io/g/devel/message/95008 Mute This Topic: https://groups.io/mt/94264735/1945644 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-mahmoud@arm.com] -=-=-=-=-=-= IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. [-- Attachment #2: Type: text/html, Size: 9507 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL 2022-10-11 22:30 ` [edk2-devel] " Samer El-Haj-Mahmoud @ 2022-11-07 7:55 ` G Edhaya Chandran 0 siblings, 0 replies; 7+ messages in thread From: G Edhaya Chandran @ 2022-11-07 7:55 UTC (permalink / raw) To: Samer El-Haj-Mahmoud, devel [-- Attachment #1: Type: text/plain, Size: 189 bytes --] Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com> The solution is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/18a8ca0dda79a9348157d77083ba1e1b9b18081b [-- Attachment #2: Type: text/html, Size: 203 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL 2022-10-11 17:54 ` [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Sam Kaynor 2022-10-11 22:30 ` [edk2-devel] " Samer El-Haj-Mahmoud @ 2023-01-30 12:16 ` Rebecca Cran 2023-01-31 11:55 ` Sunny Wang 1 sibling, 1 reply; 7+ messages in thread From: Rebecca Cran @ 2023-01-30 12:16 UTC (permalink / raw) To: devel, sam.kaynor Cc: G Edhaya Chandran, Barton Gao, Carolyn Gjertsen, Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh [-- Attachment #1: Type: text/plain, Size: 4149 bytes --] It looks like the cc list wasn't populated correctly. I've cc'd the people mentioned in the commit message. On 10/11/22 11:54, Sam Kaynor wrote: > Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in > RandomNumberBBTestConformance and RandomNumberBBTestFunction > to "RANDOM_NUMBER_PROTOCOL". > > Cc: G Edhaya Chandran<Edhaya.Chandran@arm.com> > Cc: Barton Gao<gaojie@byosoft.com.cn> > Cc: Carolyn Gjertsen<Carolyn.Gjertsen@amd.com> > Cc: Samer El-Haj-Mahmoud<Samer.El-Haj-Mahmoud@arm.com> > Cc: Eric Jin<eric.jin@intel.com> > Cc: Arvin Chen<arvinx.chen@intel.com> > Cc: Supreeth Venkatesh<Supreeth.Venkatesh@amd.com> > Signed-off-by: Sam Kaynor<sam.kaynor@arm.com> > --- > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c > index 2738a4899457..364aaca925e0 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c > @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( > StandardLib, > EFI_TEST_ASSERTION_WARNING, > gConformanceTestAssertionGuid001, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > L"%a:%d: Status - %r", > __FILE__, > (UINTN)__LINE__, > @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( > StandardLib, > AssertionType, > gConformanceTestAssertionGuid001, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", > L"%a:%d: Status - %r, RNGAlgorithmListSize - %d", > __FILE__, > (UINTN)__LINE__, > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c > index 3d41085d2243..0ba003449dc6 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c > @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( > StandardLib, > EFI_TEST_ASSERTION_FAILED, > gTestGenericFailureGuid, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", > L"%a:%d: Status - %r", > __FILE__, > (UINTN)__LINE__, > @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( > StandardLib, > EFI_TEST_ASSERTION_FAILED, > gTestGenericFailureGuid, > - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", > + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", > L"%a:%d: Status - %r", > __FILE__, > (UINTN)__LINE__, [-- Attachment #2: Type: text/html, Size: 4997 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL 2023-01-30 12:16 ` Rebecca Cran @ 2023-01-31 11:55 ` Sunny Wang 2023-01-31 15:24 ` G Edhaya Chandran 0 siblings, 1 reply; 7+ messages in thread From: Sunny Wang @ 2023-01-31 11:55 UTC (permalink / raw) To: devel@edk2.groups.io, rebecca@bsdio.com, Sam Kaynor Cc: G Edhaya Chandran, Barton Gao, Carolyn Gjertsen, Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh, Sunny Wang [-- Attachment #1: Type: text/plain, Size: 5580 bytes --] Thanks for fixing the issue, Sam. The change looks good to me. However, I just did a quick search and found 9 instances of "RANDOM_NAME_PROTOCOL". Do we need to also change another 5 instances? Best Regards, Sunny From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io Sent: 30 January 2023 12:16 To: devel@edk2.groups.io; Sam Kaynor <Sam.Kaynor@arm.com> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com> Subject: Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL It looks like the cc list wasn't populated correctly. I've cc'd the people mentioned in the commit message. On 10/11/22 11:54, Sam Kaynor wrote: Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in RandomNumberBBTestConformance and RandomNumberBBTestFunction to "RANDOM_NUMBER_PROTOCOL". Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com><mailto:Edhaya.Chandran@arm.com> Cc: Barton Gao <gaojie@byosoft.com.cn><mailto:gaojie@byosoft.com.cn> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com><mailto:Carolyn.Gjertsen@amd.com> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com><mailto:Samer.El-Haj-Mahmoud@arm.com> Cc: Eric Jin <eric.jin@intel.com><mailto:eric.jin@intel.com> Cc: Arvin Chen <arvinx.chen@intel.com><mailto:arvinx.chen@intel.com> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com><mailto:Supreeth.Venkatesh@amd.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com><mailto:sam.kaynor@arm.com> --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c index 2738a4899457..364aaca925e0 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_WARNING, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, AssertionType, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", L"%a:%d: Status - %r, RNGAlgorithmListSize - %d", __FILE__, (UINTN)__LINE__, diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c index 3d41085d2243..0ba003449dc6 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. [-- Attachment #2: Type: text/html, Size: 12998 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL 2023-01-31 11:55 ` Sunny Wang @ 2023-01-31 15:24 ` G Edhaya Chandran 0 siblings, 0 replies; 7+ messages in thread From: G Edhaya Chandran @ 2023-01-31 15:24 UTC (permalink / raw) To: Sunny Wang, devel@edk2.groups.io, rebecca@bsdio.com, Sam Kaynor Cc: Barton Gao, Carolyn Gjertsen, Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh [-- Attachment #1: Type: text/plain, Size: 6786 bytes --] Hi Sunny, Have already raised a ticket for the remaining 9 instances. These shall be fixed by me: 4328 – Correct instances of RANDOM_NAME_PROTOCOL to RANDOM_NUMBER_PROTOCOL (tianocore.org)<https://bugzilla.tianocore.org/show_bug.cgi?id=4328> With Warm Regards, Edhay From: Sunny Wang <Sunny.Wang@arm.com> Sent: 31 January 2023 17:25 To: devel@edk2.groups.io; rebecca@bsdio.com; Sam Kaynor <Sam.Kaynor@arm.com> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>; Sunny Wang <Sunny.Wang@arm.com> Subject: RE: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Thanks for fixing the issue, Sam. The change looks good to me. However, I just did a quick search and found 9 instances of "RANDOM_NAME_PROTOCOL". Do we need to also change another 5 instances? Best Regards, Sunny From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Rebecca Cran via groups.io Sent: 30 January 2023 12:16 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Sam Kaynor <Sam.Kaynor@arm.com<mailto:Sam.Kaynor@arm.com>> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>; Barton Gao <gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com<mailto:Carolyn.Gjertsen@amd.com>>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com<mailto:Samer.El-Haj-Mahmoud@arm.com>>; Eric Jin <eric.jin@intel.com<mailto:eric.jin@intel.com>>; Arvin Chen <arvinx.chen@intel.com<mailto:arvinx.chen@intel.com>>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com<mailto:Supreeth.Venkatesh@amd.com>> Subject: Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL It looks like the cc list wasn't populated correctly. I've cc'd the people mentioned in the commit message. On 10/11/22 11:54, Sam Kaynor wrote: Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in RandomNumberBBTestConformance and RandomNumberBBTestFunction to "RANDOM_NUMBER_PROTOCOL". Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com><mailto:Edhaya.Chandran@arm.com> Cc: Barton Gao <gaojie@byosoft.com.cn><mailto:gaojie@byosoft.com.cn> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com><mailto:Carolyn.Gjertsen@amd.com> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com><mailto:Samer.El-Haj-Mahmoud@arm.com> Cc: Eric Jin <eric.jin@intel.com><mailto:eric.jin@intel.com> Cc: Arvin Chen <arvinx.chen@intel.com><mailto:arvinx.chen@intel.com> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com><mailto:Supreeth.Venkatesh@amd.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com><mailto:sam.kaynor@arm.com> --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c index 2738a4899457..364aaca925e0 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c @@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_WARNING, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 ( StandardLib, AssertionType, gConformanceTestAssertionGuid001, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size", L"%a:%d: Status - %r, RNGAlgorithmListSize - %d", __FILE__, (UINTN)__LINE__, diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c index 3d41085d2243..0ba003449dc6 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c @@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, @@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 ( StandardLib, EFI_TEST_ASSERTION_FAILED, gTestGenericFailureGuid, - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize", L"%a:%d: Status - %r", __FILE__, (UINTN)__LINE__, IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. [-- Attachment #2: Type: text/html, Size: 14964 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-01-31 15:25 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-11 17:54 [PATCH v1 0/1] Correct spelling error in SctPkg Sam Kaynor 2022-10-11 17:54 ` [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL Sam Kaynor 2022-10-11 22:30 ` [edk2-devel] " Samer El-Haj-Mahmoud 2022-11-07 7:55 ` G Edhaya Chandran 2023-01-30 12:16 ` Rebecca Cran 2023-01-31 11:55 ` Sunny Wang 2023-01-31 15:24 ` G Edhaya Chandran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox