From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: Sunny Wang <Sunny.Wang@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Barton Gao <gaojie@byosoft.com.cn>,
Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Sam Kaynor <Sam.Kaynor@arm.com>, Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [PATCH] UEFI-SCT: SctPkg: Replaced the incorrect references RANDOM_NAME_PROTOCOL to RANDOM_NUMBER_PROTOCOL
Date: Tue, 31 Jan 2023 17:56:27 +0000 [thread overview]
Message-ID: <AS1PR08MB7475ED40C52C8372BC3CEAD2E8D09@AS1PR08MB7475.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <AS8PR08MB7791F610DA5D1F9CC5A7BDA285D09@AS8PR08MB7791.eurprd08.prod.outlook.com>
Thank you Sunny.
The solution is upstreamed through the commit: https://github.com/tianocore/edk2-test/commit/56093929e99cadab5cd95f560d67fe61663d67d4
With Warm Regards,
Edhay
> -----Original Message-----
> From: Sunny Wang <Sunny.Wang@arm.com>
> Sent: 31 January 2023 22:55
> To: G Edhaya Chandran <Edhaya.Chandran@arm.com>;
> devel@edk2.groups.io
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Sam Kaynor
> <Sam.Kaynor@arm.com>; Sunny Wang <Sunny.Wang@arm.com>
> Subject: RE: [PATCH] UEFI-SCT: SctPkg: Replaced the incorrect references
> RANDOM_NAME_PROTOCOL to RANDOM_NUMBER_PROTOCOL
>
> Looks good to me. Thank for addressing my comments in another email
> thread, Edhaya.
> Reviewed-by: Sunny Wang <sunny.wang@arm.com> Cc Sam for his
> awareness.
>
> -----Original Message-----
> From: G Edhaya Chandran <edhaya.chandran@arm.com>
> Sent: 31 January 2023 17:04
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang
> <Sunny.Wang@arm.com>
> Subject: [PATCH] UEFI-SCT: SctPkg: Replaced the incorrect references
> RANDOM_NAME_PROTOCOL to RANDOM_NUMBER_PROTOCOL
>
> From: edhay <edhaya.chandran@arm.com>
>
> Replaced the incorrect references RANDOM_NAME_PROTOCOL to
> RANDOM_NUMBER_PROTOCOL
> 9 instances were replaced
>
> Please find more details in the ticket:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4328
>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sunny Wang <sunny.wang@arm.com>
>
> Signed-off-by: G Edhaya Chandran<edhaya.chandran@arm.com>
> ---
> .../BlackBoxTest/RandomNumberBBTestConformance.c | 10 +++++-----
> .../BlackBoxTest/RandomNumberBBTestFunction.c | 8 ++++----
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand
> omNumberBBTestConformance.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand
> omNumberBBTestConformance.c
> index 47e7800f..5e55f639 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand
> omNumberBBTestConformance.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTe
> +++ st/RandomNumberBBTestConformance.c
> @@ -223,7 +223,7 @@ BBTestGetRNGConformanceTestCheckpoint1 (
> StandardLib,
> EFI_TEST_ASSERTION_FAILED,
> gTestGenericFailureGuid,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not
> supported or EFI_DEVICE_ERROR",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not
> + supported or EFI_DEVICE_ERROR",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -303,7 +303,7 @@ BBTestGetRNGConformanceTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gConformanceTestAssertionGuid002,
> - L"RANDOM_NAME_PROTOCOL.GetRNG - GetRNG() returns
> EFI_INVALID_PARAMETER when RNGValueLength is 0",
> + L"RANDOM_NUMBER_PROTOCOL.GetRNG - GetRNG() returns
> + EFI_INVALID_PARAMETER when RNGValueLength is 0",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -326,7 +326,7 @@ BBTestGetRNGConformanceTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gConformanceTestAssertionGuid003,
> - L"RANDOM_NAME_PROTOCOL.GetRNG - GetRNG() returns
> EFI_INVALID_PARAMETER when RNGValue is NULL",
> + L"RANDOM_NUMBER_PROTOCOL.GetRNG - GetRNG() returns
> + EFI_INVALID_PARAMETER when RNGValue is NULL",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -352,7 +352,7 @@ BBTestGetRNGConformanceTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gConformanceTestAssertionGuid004,
> - L"RANDOM_NAME_PROTOCOL.GetRNG - GetRNG() returns
> EFI_INVALID_PARAMETER when RNGValueLength is 0",
> + L"RANDOM_NUMBER_PROTOCOL.GetRNG - GetRNG() returns
> + EFI_INVALID_PARAMETER when RNGValueLength is 0",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -375,7 +375,7 @@ BBTestGetRNGConformanceTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gConformanceTestAssertionGuid005,
> - L"RANDOM_NAME_PROTOCOL.GetRNG - GetRNG() returns
> EFI_INVALID_PARAMETER when RNGValue is NULL",
> + L"RANDOM_NUMBER_PROTOCOL.GetRNG - GetRNG() returns
> + EFI_INVALID_PARAMETER when RNGValue is NULL",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand
> omNumberBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand
> omNumberBBTestFunction.c
> index df879e4c..23c8e730 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand
> omNumberBBTestFunction.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTe
> +++ st/RandomNumberBBTestFunction.c
> @@ -248,7 +248,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gFunctionTestAssertionGuid002,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns
> EFI_SUCCESS with valid parameters",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns
> + EFI_SUCCESS with valid parameters",
> L"%a:%d: Status - %r, RNGAlgorithmListSize - %d",
> __FILE__,
> (UINTN)__LINE__,
> @@ -271,7 +271,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gFunctionTestAssertionGuid003,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() should returns
> valid algo",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() should
> + returns valid algo",
> L"%a:%d:",
> __FILE__,
> (UINTN)__LINE__
> @@ -316,7 +316,7 @@ BBTestGetRNGFunctionTestCheckpoint1 (
> StandardLib,
> EFI_TEST_ASSERTION_FAILED,
> gTestGenericFailureGuid,
> - L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not
> supported or EFI_DEVICE_ERROR",
> + L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not
> + supported or EFI_DEVICE_ERROR",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> @@ -400,7 +400,7 @@ BBTestGetRNGFunctionTestCheckpoint1 (
> StandardLib,
> AssertionType,
> gFunctionTestAssertionGuid004,
> - L"RANDOM_NAME_PROTOCOL.GetRNG - GetRNG() should
> returns EFI_SUCCESS with valid parameters",
> + L"RANDOM_NUMBER_PROTOCOL.GetRNG - GetRNG() should
> + returns EFI_SUCCESS with valid parameters",
> L"%a:%d: Status - %r",
> __FILE__,
> (UINTN)__LINE__,
> --
> 2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
prev parent reply other threads:[~2023-01-31 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <581a29ed01c7ebe261b0e36618bc2fa0443b5684.1675184375.git.edhaya.chandran@arm.com>
2023-01-31 17:24 ` [PATCH] UEFI-SCT: SctPkg: Replaced the incorrect references RANDOM_NAME_PROTOCOL to RANDOM_NUMBER_PROTOCOL Sunny Wang
2023-01-31 17:56 ` G Edhaya Chandran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS1PR08MB7475ED40C52C8372BC3CEAD2E8D09@AS1PR08MB7475.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox