Hi Abdul,

With the introduction of Uncrustify tool in the edk2 CI, I think you may have to
- rebase with latest edk2 master and resolve any conflicts
- run uncrustify on your patches
- re-submit your patches.

More information on using uncrustify can be found at https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting

Regards,

Sami Mujawar

From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Date: Tuesday, 14 December 2021 at 11:18
To: Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io <devel@edk2.groups.io>, Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>
Cc: nd <nd@arm.com>
Subject: RE: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
Hi Zhichao Gao, Ray Ni, Sami Mujawar,
   Please review and create PR if looks good.
Thanks
AbduL

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com>
Sent: Monday, November 22, 2021 11:24 PM
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; nd <nd@arm.com>
Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

[CAUTION: External Email]

Hi Abdul,

Thank you for this patch series.

This series looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote:
> Hi Sami, Zhichao,
>     Addressed all review comments.
> Created two different patches, one for bitfield parser and another for
> FADT Flags parser.
>
> Thanks
> AbduL
>
> REF :
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParser&amp;data=04%7C01%7CA
> bdulLateef.Attar%40amd.com%7C95999e9fce1346f1eb8608d9ade11d90%7C3dd896
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C637732004653569840%7CUnknown%7CTW
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C3000&amp;sdata=%2Btp2oW%2Bo3WoF7b4RnPFot3z5vggrUiwOaL%2FiPl4U
> WHY%3D&amp;reserved=0
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Abdul Lateef
> Attar (2):
>    ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
>    ShellPkg/AcpiView: PrintFormatter for FADT Flags field
>
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  45 +++++
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              | 177 ++++++++++++++++++++
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c |  59 ++++++-
>   3 files changed, 280 insertions(+), 1 deletion(-)
>