From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.51]) by mx.groups.io with SMTP id smtpd.web12.33372.1643642533782340005 for ; Mon, 31 Jan 2022 07:22:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DsLj7NyE; spf=pass (domain: arm.com, ip: 40.107.8.51, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/v3mxg/Y5k7+HrUcBUIN1k2K+sFm0EyJQ1AM5WNaH8=; b=DsLj7NyE8wlkgitPr5/fagz27ZkgbAfzENj41mwcnjkKig6q+lZKN8cJtjhapAeEVj/P/dpTHSMQu7Cd/vUVhdn+RIw+nQ4fOTHzRJa2hySJRJEpxP3Mrip3NNjun+RMf3Cy4qRlXT9+/oZlp8s663+lAYdh9cHX3wqQOG8PyUA= Received: from AM6P194CA0072.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::49) by AS8PR08MB7011.eurprd08.prod.outlook.com (2603:10a6:20b:34e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Mon, 31 Jan 2022 15:22:11 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:84:cafe::77) by AM6P194CA0072.outlook.office365.com (2603:10a6:209:84::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15 via Frontend Transport; Mon, 31 Jan 2022 15:22:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15 via Frontend Transport; Mon, 31 Jan 2022 15:22:10 +0000 Received: ("Tessian outbound 741ca6c82739:v113"); Mon, 31 Jan 2022 15:22:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f3393a3ee0967b07 X-CR-MTA-TID: 64aa7808 Received: from 02bcbdb81866.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5D4A14A0-84B6-4983-9EAB-CD130C0179E3.1; Mon, 31 Jan 2022 15:21:59 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02bcbdb81866.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 31 Jan 2022 15:21:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ji9hgPTsRvE88JQz3pdehzyb1ijWD3WST3zoZjoJLHsdGkiWzObK1xIIHDsA3i4wvUfXRjwSVXoFlntpsjaoR9zPT7zIjeEClPlLt1l66lge/+tvLqy3qgvupRJDkKxrspka+k4baG+20QubzVlWUp57rQlMMlN4VQt7Pkonuw3UDdhlJTFCfJKlyn2dTo1yjbjIbNrmxNBN2+csALY+zMDN9KeH/Sty/PEjYXr50OvnbUpHluKwA9GX4imyhTGFo0x9AbqOEw/jRAcfrUJCwIivTEfShMeSjDnduqAgY90gL8l3fT+QFCR4uVbRqInHe13FdYPsVd8GTZNm3dY+oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/v3mxg/Y5k7+HrUcBUIN1k2K+sFm0EyJQ1AM5WNaH8=; b=nTJBkjmKWGpVgYx9zY9DxahcpmwYDvLnfJMEG1ILsJdQnQpK5jbht2JIpW2+aNR7R6zkmJUj8iMmJHwo6OQEIEuVvOgJAH8/LM7kiReXYVC8CLZ9iQQrr2CMTfB11EzJgKsMhHg7WTZsBz9l8Phl6SjcE7g+01/d8ykDBnxtKOS2apHtP2OMHEAiFKrsgySNmRrw2GD6+lBwvvz06qD6xDzaEZkvHWQVukhgr10vaBLj3+1kT3GLi6/mipqJNB82vIz6RWTg2W4HwyIx8NPwg2vdpNGnZvxvgOLrYNiSGPVZTUYqDnpP1BQC4HaM+rd5OxmycrUoVK3hHOsR1LTPIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/v3mxg/Y5k7+HrUcBUIN1k2K+sFm0EyJQ1AM5WNaH8=; b=DsLj7NyE8wlkgitPr5/fagz27ZkgbAfzENj41mwcnjkKig6q+lZKN8cJtjhapAeEVj/P/dpTHSMQu7Cd/vUVhdn+RIw+nQ4fOTHzRJa2hySJRJEpxP3Mrip3NNjun+RMf3Cy4qRlXT9+/oZlp8s663+lAYdh9cHX3wqQOG8PyUA= Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBAPR08MB5686.eurprd08.prod.outlook.com (2603:10a6:10:1a1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Mon, 31 Jan 2022 15:21:57 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%8]) with mapi id 15.20.4909.019; Mon, 31 Jan 2022 15:21:57 +0000 From: "Sami Mujawar" To: Rebecca Cran , "devel@edk2.groups.io" , Pierre Gondois CC: Ard Biesheuvel , nd Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table Thread-Topic: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table Thread-Index: AQHYFF177FSfFlgxRkmqFCRnQGiGT6x9QncAgAAApVI= Date: Mon, 31 Jan 2022 15:21:57 +0000 Message-ID: References: <20220128154103.20752-1-Pierre.Gondois@arm.com> <20220128154103.20752-6-Pierre.Gondois@arm.com> <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> In-Reply-To: <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5e6d1730-9232-4661-9b0d-08d9e4cd7383 x-ms-traffictypediagnostic: DBAPR08MB5686:EE_|VE1EUR03FT022:EE_|AS8PR08MB7011:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CuONn2WyUSZb9nObiSjzmAV5v82e5BFgBEE00zbeQwLcuoLPn/EwByfguQWnnMsL8unmHu7IIG9bIG/KmpKuiVaurwBV4kb7UmcshGzmdzSJCFhz7bgonn6V28G03veBb484Yv3xwwQKES3pkOo643xEgPdG9SFhpcBsFc1NaxcyB/jC8l5LmFS90OIqwBGO0wKQPIhXE6uL3JlP7tnetcoDWuoGkQOWbEKmpDxfVIBX2VLwFCTUG9tKaDsIJ0dUZk0904h+72N+AGDb8EgHAXD+O5JTDH+wGFz03ty1BCc0Z/u1O1AS2AYLlDizFRX2NvbzmTQ19qKFMIDtotuMAs4uXYrVLp+jJFAnX5FTuLmrAvpviVGz1Xh/54V58kylJyu6fnmcGf4bYFL40xoJV9ytBtuwi8S6Js5543H4Yu+/mLCgdNDExrx4bC7wTheBb/oIgtOL6i5wzJ7ZGfp3ImSO+G1rJpKgiFhLvDwHy9zDMzgIj71KZbNUt4GvINR5np5EzO9GmhGL9yOCg6lbztk8HGEhCZY2wCbmePCashYAM87cPIo8NOX3rCi8jxIrwt8zOOXpdVfLn7H9ndF9ULm07EIorKflxZuFlRulFKjD/8rbOnSbRJR6ai2plt+WNzKutpcnnRjNwZJQVffLoDtBMwHXbjhKNDNFanypftTl9NSKdCP/qF+ICu9Hl9FBQZQWV8KugAUSw5mjfS/jsQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6636002)(54906003)(52536014)(110136005)(122000001)(508600001)(38100700002)(316002)(86362001)(38070700005)(71200400001)(66946007)(8936002)(66556008)(66446008)(5660300002)(186003)(91956017)(4326008)(83380400001)(8676002)(76116006)(6506007)(7696005)(55016003)(9326002)(53546011)(33656002)(2906002)(26005)(64756008)(9686003)(66476007)(20210929001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5686 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2c92a237-8226-498f-d17e-08d9e4cd6bab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: evJz4wnjTgd1D8Rj3Rcr3Emp4QfSJCsSFWoKjY1oN9JNm6upJumbj8wdjVN96bNy3kp7ca75U3vD3N0GeR81okjqZ4cD0URMySfgQjuCzqk+IdxVSFJndubkfF2DjIcSlevVMFOc9/wEE6rmmfG1dLkyyIeTRuoMPn4/X24TcSdOgXX26z6fn+k7xJNSMozCTppOe9Vy+1rAfuLQ9Q8c31bddxxiPsesDUfxGIGDPv+TPA1V3npzfol7ucdiJFBNJlaRBDYJIDrxVhu/Pm/uRvSVyCjQkH8Du0wO2IenN0q5FBOXUfNU12McD9AlFwT+uwt+qPjC5LoGwF5DjZD6NaK5GeQxUG9rb5beJHQl1wm/2v24HvTXcvrMWXaGsmKKCpPtFg9IkdR+xcj+7RyAVyQPAlTDJfcmJbTCzgGEbQDhCeaj2TZJNTS5iDOX7WAMlRHCB7Plp35DuboO0aSJMB5NOtSOJ4Tt/IYrmrO+ZDArRyTcQuFkzAKWTA17RMkO3YqAWLoBn2X6PrsxAtpmg7KRolvNRYJrx1YxUvyS/ICA5dDZH7XBBdNKaGS6GhFMpx2xkN+4Qr8pn9aEvBxCfG+8UmiIlb4RZDaxa3XcTm44YDNaZuqJRYfxOOdclTPn0Rq1iwndYZTgoDaq8ILFxYN/s+MqGwmTb1iX15egqtNitGIAzhNq3A7cjR4MMjN+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(40460700003)(8936002)(47076005)(316002)(86362001)(4326008)(356005)(81166007)(70586007)(70206006)(8676002)(6636002)(54906003)(110136005)(508600001)(6506007)(55016003)(9686003)(26005)(186003)(52536014)(9326002)(7696005)(53546011)(5660300002)(36860700001)(2906002)(82310400004)(336012)(83380400001)(33656002)(20210929001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 15:22:10.5706 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6d1730-9232-4661-9b0d-08d9e4cd7383 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7011 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AS8PR08MB68061AC2D3F8B0717B17166984259AS8PR08MB6806eurp_" --_000_AS8PR08MB68061AC2D3F8B0717B17166984259AS8PR08MB6806eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Thanks for catching this. I think we also need to add a check in Acpiview to report this issue. Howev= er, that would be another patch series. Regards, Sami Mujawar From: Rebecca Cran Date: Monday, 31 January 2022 at 15:17 To: devel@edk2.groups.io , Pierre Gondois Cc: Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI = table On 1/28/22 08:41, PierreGondois wrote: > + Differentiated System Description Table Fields (DSDT) > + > + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) { The Revision field should probably be 2, not 1. ACPI 6.4 says: 2. This field also sets the global integer width for the AML interpreter. Values less than two will cause the inter- preter to use 32-bit integers and math. Values of two and greater will cause the interpreter to use full 64-bit integers and math. -- Rebecca Cran --_000_AS8PR08MB68061AC2D3F8B0717B17166984259AS8PR08MB6806eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Rebecca,

 

Thanks for catching this.

I think we also need to add a check in Acpiview to report t= his issue. However, that would be another patch series.

 

Regards,

 

Sami Mujawar

 

From: Rebecca Cran <qu= ic_rcran@quicinc.com>
Date: Monday, 31 January 2022 at 15:17
To: devel@edk2.groups.io <devel@edk2.groups.io>, Pierre Gondoi= s <Pierre.Gondois@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, Sami Mujawar &= lt;Sami.Mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSD= T ACPI table

On 1/28/22 08:41, PierreGondois wrote:

> +  Differentiated System Description Table Fields (DSDT)
> +
> +  Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.<BR= >
> +    SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, &quo= t;ARMLTD", "ARM-KVMT", 1) {

The Revision field should probably be 2, not 1. ACPI 6.4 says:


2. This field also sets the global integer width for the AML
interpreter. Values less than two will cause the inter-
preter to use 32-bit integers and math. Values of two
and greater will cause the interpreter to use full 64-bit
integers and math.

--
Rebecca Cran

--_000_AS8PR08MB68061AC2D3F8B0717B17166984259AS8PR08MB6806eurp_--