From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.70]) by mx.groups.io with SMTP id smtpd.web11.30001.1643620060314556411 for ; Mon, 31 Jan 2022 01:07:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=SpvyliX0; spf=pass (domain: arm.com, ip: 40.107.20.70, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWMx8x6hFmbxElMMBnCA7h68wfRYiEzdg6h0yUsCu8A=; b=SpvyliX0VPh3n9x5182a+cx4YqKi+iwlgxFq/ETu4lfv7MwEtLB7XjSbfGrK+d9nPm5r4abYdEtq54dmJLEwztijtAOFIPkSV2Eiys9EQySntVrh3JckIGLTg3uJfiBmIzdOCl7IWGctljDKyo+IcEVAA8gd9tWrrHGnJL/3Y1E= Received: from AM6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::15) by HE1PR08MB2828.eurprd08.prod.outlook.com (2603:10a6:7:2e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Mon, 31 Jan 2022 09:07:33 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::4f) by AM6P195CA0002.outlook.office365.com (2603:10a6:209:81::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15 via Frontend Transport; Mon, 31 Jan 2022 09:07:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15 via Frontend Transport; Mon, 31 Jan 2022 09:07:32 +0000 Received: ("Tessian outbound 2877e54fe176:v113"); Mon, 31 Jan 2022 09:07:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8b6104c0d3220953 X-CR-MTA-TID: 64aa7808 Received: from 238305f8be16.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B6B063E3-16E3-4B10-AF9E-3C129864824E.1; Mon, 31 Jan 2022 09:07:18 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 238305f8be16.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 31 Jan 2022 09:07:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=au9ts/uN0Kb0kxYw/y0RYmSx7MO+FyIFC9T+OdZ/eFvRSmBvTyWqKYTD0v3YN2ujXpIpx4OQdIfcYaYsVbpWChqBf5XIl8kReH9pK3Te0U0KCfORfdJ05hIyk3G08dfJmgKzkPFYQhgLD6hEGYm5tk8VQ9L0ZY14mFQEgqx9lFGlWaH8I5xVphT7t3lPIm+wmcAeRFKp+vN6LIgHNw89UP4q3rnNURPeb9dOgnE5K9BPzEfdLlvNkTFIvJqXXhtIYXCbcePP+lLUWKx90cmLxUTCtDxJyGh0rPYmbM4kk2ibnxgOsVv8fhoWkIgzBLPxNKKPREed9LoGmqR0egImQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sWMx8x6hFmbxElMMBnCA7h68wfRYiEzdg6h0yUsCu8A=; b=QRAdgfuUEGAU+hR7eO4dpcawcHBpPhmCSN0UlZ7u5fER57GugEOy1cDJGjfZAU7DJ2xnh3oaloMDJAhpfDtrdX5yeW8mC51dZE2/Ke4XTswQb+IEDIHW59y/gyHdaLtkC3un350HIpXXQRo8OSBL0J+nOs7oA3fnzBG183n/quE+InScIGJul7r2wRtpqgvz5XA3uSyZXyQbMrpZV0JMRFLCo25ER0M0ccivfSAV9TPB6y/sJUreB1yJUPL6tLjuU/3Nzr1MYJF18lOKNUoB1GsMiYx+m6J8RNGZHOOqFlecvnQ+3/vSQpyUM03e3+0ITSywXi3wo0ufw6JcoITQ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWMx8x6hFmbxElMMBnCA7h68wfRYiEzdg6h0yUsCu8A=; b=SpvyliX0VPh3n9x5182a+cx4YqKi+iwlgxFq/ETu4lfv7MwEtLB7XjSbfGrK+d9nPm5r4abYdEtq54dmJLEwztijtAOFIPkSV2Eiys9EQySntVrh3JckIGLTg3uJfiBmIzdOCl7IWGctljDKyo+IcEVAA8gd9tWrrHGnJL/3Y1E= Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by HE1PR0802MB2619.eurprd08.prod.outlook.com (2603:10a6:3:d9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Mon, 31 Jan 2022 09:07:14 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%8]) with mapi id 15.20.4909.019; Mon, 31 Jan 2022 09:07:14 +0000 From: "Sami Mujawar" To: Ard Biesheuvel , Rebecca Cran , Thomas Abraham , Nishant Sharma CC: edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif Lindholm , Wenyi Xie , Peng Xie , Ling Jia , Yiqi Shu , Nhi Pham , Vu Nguyen , Thang Nguyen , Chuong Tran , Pete Batard , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki , Marcin Wojtas , nd Subject: Re: [PATCH v2 00/17] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 Thread-Topic: [PATCH v2 00/17] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 Thread-Index: AQHX8sl1jJviKraeQUmIITs4vHtbZax7q9qAgAFvqmE= Date: Mon, 31 Jan 2022 09:07:14 +0000 Message-ID: References: <20211216220800.9628-1-rebecca@nuviainc.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: dc52ccb7-ffe0-42b9-9f0a-08d9e4991d92 x-ms-traffictypediagnostic: HE1PR0802MB2619:EE_|VE1EUR03FT006:EE_|HE1PR08MB2828:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YhZvONPwKivBoZYGBuh6Upe+ywhyWo/DTUMrugtp3GYq+vOUwz9QHbTW4qmC0FGjaEVcD5wyk7KzwISSEi5c+9vnX//AzlMv69o7Io2+mPHeQlNln57/UqbSRasTPmrO67OiUxtypqiffQj8Am93k+vigzTT3a065K5eQYC8NjGGVAckdCjIf3dhr7OMrVanUSt/wHHjxGMopcSmvW3r9TD7AJnzzpf99GX/J9YQlaAIRuBZ6d4NuULtFvohXr14qhnv9hftq+HVsnnNq5CMBDKMUyXmXeVFkAarlaMPF92+sc38hjN2l1lNZE5utxUsKOfvukuF0haqtsCSW5wAzpSExc/bm49TF2vFTql7FxLPTyIeaCt67UTLDhd0ymOQRItslRfuVNG+/LaAott0vhjtVFItKHCP3+dlLnrQ0fzBEC7M9AzcTSWzJ0Rmv5sw7snM8/3X2kbt9SW9t/nSX70JTzQvIpAXkO3V2UDbLabgl4fGjWTTLyvCtFzfcFi6VlpI88gywAU5NWduchBL7pdAFKOmVRmA6tPwzzcCEOo8CANweN/FGV6KoIsS11NDziOlgRpb2MNGxjIk7ujZzEBAJv4a0XKH7I89UHUU8Dj6VvPhebtFRrcD1zbDj91Xd7yYbLIrSbMhyQ41ds7zu8I7jzIroh8aCfalIuJbrDVEzoE61MwCiHvirxVg0+6Em8lfVpXGlDaxDSrBAEcIzQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(83380400001)(186003)(26005)(2906002)(38100700002)(86362001)(38070700005)(9686003)(71200400001)(6506007)(33656002)(55016003)(76116006)(8936002)(7416002)(5660300002)(7696005)(8676002)(508600001)(64756008)(66446008)(53546011)(19627235002)(15650500001)(54906003)(110136005)(52536014)(6636002)(66946007)(9326002)(316002)(66556008)(66476007)(91956017)(4326008)(20210929001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2619 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a288f847-84a6-4703-f7b3-08d9e499129d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qaCDHdU/F5PEeIwXx1UrK+9EUw0EMHUawh+QB+CSWVTrbYdk8fovUQsLeUFA0vSsvp4IOhI4uuGdLZ1bRJe0MzAj2YTheUaQAKiPSp33iroXyBpDik0jshK2G3CEMvFq/YAYYhecjy7hFCf7AKRBhPloKSDoANYOgUHPNb392b3H90MI47F5fRE+gkNK+7BAriHL6yBfqvOiniSdLAhWtaGoLkkJq6rwfG27CtXHrL6sqcjn7VIB5ypHO2c4g/RKC7ovMmVqlxgdWpYw/mFZPExlFslFdHvH20N5dk/KzME19Ey7hRb7y8yGm+TFvZU2J6K2PmOKhPW++Q4JMzSsOGxXwfJ7Df/0goH37MGrMKabCcXpoyICtlfuHqPrnhFScFD+twJvcDXWrU0sDNAQolylu2Vo7eSMcvDivwT5dVf27xi/wOU8AHcvjZqi5qrUK6wcM35k55nM/ZIlbnEuN56Tl2uZcm1yj1YSx93dmh1/lp+P98c3L0eVjsusyl9W6k6Pb1I5qNP/gEX5u55yK6KjOdKAy2o3xJhkNVs+Pv8MtMQA10n8uWFQIpORDKTl23hpqr0f/qEIbgvJocg2VrUYPiFMKj5scOitgVLqRZnYoJQS0vrfiWgQ/7yY12UNMtt+GvUXG3Id2bNORKpu29du2eVcFMYrMvLKTWTg/ZgzbF7nCnEXJ4ZHqsWwtl12wB00jy2rKLemi14VSy0Dbw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(356005)(110136005)(6636002)(4326008)(6506007)(9686003)(7696005)(316002)(336012)(81166007)(33656002)(54906003)(2906002)(186003)(9326002)(5660300002)(86362001)(26005)(53546011)(30864003)(82310400004)(52536014)(19627235002)(15650500001)(47076005)(83380400001)(508600001)(55016003)(40460700003)(36860700001)(70206006)(8936002)(70586007)(8676002)(36900700001)(20210929001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 09:07:32.5507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc52ccb7-ffe0-42b9-9f0a-08d9e4991d92 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2828 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AS8PR08MB68061BD1F6F38D08CEE665C084259AS8PR08MB6806eurp_" --_000_AS8PR08MB68061BD1F6F38D08CEE665C084259AS8PR08MB6806eurp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Please find my response inline marked [SAMI]. Regards, Sami Mujawar From: Ard Biesheuvel Date: Sunday, 30 January 2022 at 11:01 To: Rebecca Cran Cc: edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif= Lindholm , Sami Mujawar , Wenyi X= ie , Peng Xie , Ling Jia , Yiqi Shu , Nhi Pham , Vu Nguyen , Thang Ngu= yen , Chuong Tran , Pete Batard , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki , Marcin Wojtas Subject: Re: [PATCH v2 00/17] Update Arm platforms following addition of EF= I_MP_SERVICES_PROTOCOL support in edk2 On Thu, 16 Dec 2021 at 23:08, Rebecca Cran wrote: > > Changes from v1: > > Fixed Platform/SoftIron, Platform/RaspberryPi, Silicon/AMD, > Silicon/Ampere, Silicon/Phytium, Silicon/Hisilicon. > > Patches 1/17 through 8/17 are the same as v1. > > -------- > > The following platforms are already broken: > > o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to Optio= nRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf. > > o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/E= xt4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod') > > o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM > > o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Li= brary/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: =91EmHilink0Hccs1X8= Width16=92 undeclared here (not in a function)) > > o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dscfor AARCH64 and ARM: er= ror C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/A= rmada7k8kCapsule.dsc] > > o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM. > > o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM. > > o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM. > > o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM. > > o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM. > > o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM. [SAMI] Thank you for reporting this issue. The firmware for Sgi platforms d= oes not support AARCH32 and we will provide patches to disable this in the = platform workspace files. [/SAMI] > > o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI > issue. > > o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to > use literal $(PLATFORM_NAME). > > o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH6= 4 > and ARM: VariablePolicyHelperLib issue. > > o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM= : > T91 not found. > > -------- > > This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support > for AARCH64" series which is in the process of being reviewed. > > With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers > of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series > adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf. > > Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field > where there were previously separate cluster and core fields. This > series updates the initializers and other code for the various instances. > I have pushed the ones that update the uses of ARM_CORE_INFO. The remaining ones are hopefully unneeded if we make the MP services protocol a separate driver. > > Rebecca Cran (17): > Platform/ARM: Add MpInitLib instance > Platform/Socionext: Add instance of MpInitLib > Silicon/Marvell: Add instance of MpInitLib > Platform/Qemu: Add instance of MpInitLib > Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change > Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change > Platform/AMD: Add instance of MpInitLib to OverdriveBoard.dsc > Platform/SoftIron: Add instance of MpInitLib to Overdrive1000Board.dsc > Platform/RaspberryPi: Add instance of MpInitLib to RPi3.dsc and > RPi4.dsc > Silicon/AMD: Update Styx code to work with changes ARM_CORE_INFO > struct > Silicon/Ampere: Add instance of MpInitLib to AmpereAltraPkg.dsc > Silicon/Ampere: Update ArmPlatformLib to work with changed > ARM_CORE_INFO > Silicon/Phytium: Add instance of MpInitLib to PhytiumCommonPkg.dsc.inf > Silicon/Phytium: Update FT2000-4Pkg PlatformLib for ARM_CORE_INFO > change > Silicon/Hisilicon: Add instance of MpInitLib to Hisilicon.dsc.inc > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | = 1 + > Platform/ARM/JunoPkg/ArmJuno.dsc | = 1 + > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | = 12 ++--- > Platform/ARM/Morello/MorelloPlatform.dsc.inc | = 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | = 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | = 1 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | = 1 + > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | = 16 +++---- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | = 16 +++---- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | = 1 + > Platform/RaspberryPi/RPi3/RPi3.dsc | = 1 + > Platform/RaspberryPi/RPi4/RPi4.dsc | = 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | = 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | = 1 + > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | = 1 + > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatform.c | = 3 +- > Silicon/AMD/Styx/Drivers/PlatInitPei/PlatInitPei.c | = 8 ++-- > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | = 22 ++++----- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | = 1 + > Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c | = 5 +- > Silicon/Hisilicon/Hisilicon.dsc.inc | = 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | = 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | = 8 ++-- > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c | = 2 +- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | = 1 + > Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | = 8 ++-- > Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | = 48 ++++++++++---------- > 27 files changed, 88 insertions(+), 76 deletions(-) > > -- > 2.31.1 > --_000_AS8PR08MB68061BD1F6F38D08CEE665C084259AS8PR08MB6806eurp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Hi Rebecca,

 

Please find my response inline marked [SAMI].

 

Regards,

 

Sami Mujawar

 

From: Ard Biesheuvel <= ardb@kernel.org>
Date: Sunday, 30 January 2022 at 11:01
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ard Biesheuve= l <ardb+tianocore@kernel.org>, Samer El-Haj-Mahmoud <Samer.El-Haj-= Mahmoud@arm.com>, Leif Lindholm <leif@nuviainc.com>, Sami Mujawar = <Sami.Mujawar@arm.com>, Wenyi Xie <xiewenyi2@huawei.com>, Peng Xie <xiepeng@phytium.com.cn>, Ling Jia <jialing@phytium.com.= cn>, Yiqi Shu <shuyiqi@phytium.com.cn>, Nhi Pham <nhi@os.ampere= computing.com>, Vu Nguyen <vunguyen@os.amperecomputing.com>, Thang= Nguyen <thang@os.amperecomputing.com>, Chuong Tran <chuong@os.amp= erecomputing.com>, Pete Batard <pete@akeo.ie>, Masami Hiramatsu <masami.hiramatsu@li= naro.org>, Graeme Gregory <graeme@nuviainc.com>, Radoslaw Biernack= i <rad@semihalf.com>, Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH v2 00/17] Update Arm platforms following additio= n of EFI_MP_SERVICES_PROTOCOL support in edk2

On Thu, 16 Dec 2021= at 23:08, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> Changes from v1:
>
> Fixed Platform/SoftIron, Platform/RaspberryPi, Silicon/AMD,
> Silicon/Ampere, Silicon/Phytium, Silicon/Hisilicon.
>
> Patches 1/17 through 8/17 are the same as v1.
>
> --------
>
> The following platforms are already broken:
>
> o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to Op= tionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf.
>
> o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pk= g/Ext4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod')
>
> o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM
>
> o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03= /Library/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: =91EmHilink0Hccs= 1X8Width16=92 undeclared here (not in a function))
>
> o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dscfor AARCH64 and ARM:= error C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8= k/Armada7k8kCapsule.dsc]
>
> o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM.
>
> o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM.

 

[SAMI] Thank you for reporting this issue. The firmware for Sgi pla= tforms does not support AARCH32 and we will provide patches to disable this= in the platform workspace files.

[/SAMI]


>
> o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI=
> issue.
>
> o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries t= o
> use literal $(PLATFORM_NAME).
>
> o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AAR= CH64
> and ARM: VariablePolicyHelperLib issue.
>
> o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and = ARM:
> T91 not found.
>
> --------
>
> This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL su= pport
> for AARCH64" series which is in the process of being reviewed. >
> With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consume= rs
> of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This serie= s
> adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf.
>
> Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR fie= ld
> where there were previously separate cluster and core fields. This
> series updates the initializers and other code for the various instanc= es.
>

I have pushed the ones that update the uses of ARM_CORE_INFO. The
remaining ones are hopefully unneeded if we make the MP services
protocol a separate driver.


>
> Rebecca Cran (17):
>   Platform/ARM: Add MpInitLib instance
>   Platform/Socionext: Add instance of MpInitLib
>   Silicon/Marvell: Add instance of MpInitLib
>   Platform/Qemu: Add instance of MpInitLib
>   Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR f= ield change
>   Silicon/Marvell: Update ARM_CORE_INFO initializer for MPID= R field
>     change
>   Silicon/Socionext: Update ARM_CORE_INFO initializer for MP= IDR field
>     change
>   Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR f= ield change
>   Platform/AMD: Add instance of MpInitLib to OverdriveBoard.= dsc
>   Platform/SoftIron: Add instance of MpInitLib to Overdrive1= 000Board.dsc
>   Platform/RaspberryPi: Add instance of MpInitLib to RPi3.ds= c and
>     RPi4.dsc
>   Silicon/AMD: Update Styx code to work with changes ARM_COR= E_INFO
>     struct
>   Silicon/Ampere: Add instance of MpInitLib to AmpereAltraPk= g.dsc
>   Silicon/Ampere: Update ArmPlatformLib to work with changed=
>     ARM_CORE_INFO
>   Silicon/Phytium: Add instance of MpInitLib to PhytiumCommo= nPkg.dsc.inf
>   Silicon/Phytium: Update FT2000-4Pkg PlatformLib for ARM_CO= RE_INFO
>     change
>   Silicon/Hisilicon: Add instance of MpInitLib to Hisilicon.= dsc.inc
>
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc   =             &nb= sp;        |  1 +
>  Platform/ARM/JunoPkg/ArmJuno.dsc     &n= bsp;            = ;            &n= bsp;       |  1 +
>  Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c  &nb= sp;            =       | 12 ++---
>  Platform/ARM/Morello/MorelloPlatform.dsc.inc   &n= bsp;            = ;          |  1 +
>  Platform/ARM/N1Sdp/N1SdpPlatform.dsc    &nbs= p;            &= nbsp;           &nbs= p;    |  1 +
>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc    &= nbsp;           &nbs= p;            &= nbsp; |  1 +
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc   &n= bsp;            = ;          |  1 +
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7= .c    | 16 +++----
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c =            | 16 +++---- >  Platform/Qemu/SbsaQemu/SbsaQemu.dsc     = ;            &n= bsp;            = ;     |  1 +
>  Platform/RaspberryPi/RPi3/RPi3.dsc     =             &nb= sp;            =       |  1 +
>  Platform/RaspberryPi/RPi4/RPi4.dsc     =             &nb= sp;            =       |  1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc  &nbs= p;            &= nbsp;      |  1 +
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc&nbs= p;         |  1 +
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc = ;          |  1 +
>  Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatform.c &nb= sp;            = |  3 +-
>  Silicon/AMD/Styx/Drivers/PlatInitPei/PlatInitPei.c  &n= bsp;            = ;     |  8 ++--
>  Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c&nbs= p;         | 22 ++++-----
>  Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc  =             &nb= sp;   |  1 +
>  Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatform= Lib.c |  5 +-
>  Silicon/Hisilicon/Hisilicon.dsc.inc     = ;            &n= bsp;            = ;     |  1 +
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc   &= nbsp;           &nbs= p;         |  1 +
>  Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c=       |  8 ++--
>  Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c&nb= sp;        |  2 +-
>  Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc &= nbsp;           |  1= +
>  Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c &nb= sp;            = |  8 ++--
>  Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c&nbs= p;         | 48 ++++++++++---------= -
>  27 files changed, 88 insertions(+), 76 deletions(-)
>
> --
> 2.31.1
>

--_000_AS8PR08MB68061BD1F6F38D08CEE665C084259AS8PR08MB6806eurp_--