From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.54]) by mx.groups.io with SMTP id smtpd.web11.1172.1622053259863591044 for ; Wed, 26 May 2021 11:21:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=o1P8E1Ej; spf=pass (domain: arm.com, ip: 40.107.7.54, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zUXBQo5iWAFzrntsXQI58hpOGbRqP6t+mTXFNXhBWZA=; b=o1P8E1Ejy8kefiqcEjfXkgj8nnkr/ENVvoe0wcL7NVj5+zenEWQO9kgGxutdLTdS7kJStiExve3CX6BngpMF2SAZZ1uH1Yg5feXbWyxfQK6XIyucdCT8VflZUzAKgbeJaCBVdOFgXemQRBbbCQ+OWgy3d1ZrRLloMNQMX6slc9A= Received: from DB6PR0301CA0001.eurprd03.prod.outlook.com (2603:10a6:4:3e::11) by DB9PR08MB6410.eurprd08.prod.outlook.com (2603:10a6:10:262::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Wed, 26 May 2021 18:20:57 +0000 Received: from DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::25) by DB6PR0301CA0001.outlook.office365.com (2603:10a6:4:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Wed, 26 May 2021 18:20:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT047.mail.protection.outlook.com (10.152.21.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 26 May 2021 18:20:56 +0000 Received: ("Tessian outbound 3050e7a5b95d:v92"); Wed, 26 May 2021 18:20:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dbab75d308322eca X-CR-MTA-TID: 64aa7808 Received: from 7f681cf2a9c4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCD59130-4E33-459B-B683-1FE77A4D87A4.1; Wed, 26 May 2021 18:20:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7f681cf2a9c4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 May 2021 18:20:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WotlMjNA26WiI4964ZVFzENCf2LqXM1BfmDRlgc+7UuRuoq0HzPkLSamq8jjEujKpOtxGthdGeRaV1+ncO6PS0TQYDwJgzxa5OFU4VjyZoRmhREvfqWds9xLekpJxvlhhwkUAtRg4k5YIFvT+/bOuJSZN+aE6TWM/SMM5Bxw2gym2/z509DnLy4x2RWVJX847irwXv2z7Lo8pV3sJBvugCT1LjdFXA0bP17Dm4FUF8qug+KZ0TFUqhr8pmeP/HnPW6VanFqucJP+4v0ccb54bLdAeQ1b060gIh/enCYiwKnVh+WggEooatMbo55mnBwgbSHJlPmNkvFey4nWVkuCVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zUXBQo5iWAFzrntsXQI58hpOGbRqP6t+mTXFNXhBWZA=; b=YuNznj/dASwM5DA0F3UZ21tH/gXJVxMfWCTbGleXObWX4GNf5A5IPg+SFffP6eDlZ2rZHDwNj0OljwqUsFoktaCgG+27y3k0+f2kNogBU9beUTyMtG0A0lhm9p9szkatR3Wrz0KaIDPmn+/f6eAMqSgYZ4/0/WRmcV5Aeh1fCr25gHxGbJ17VLj+i/mtRro8sLDQ26lrlCYBxh+kF5uLRzT6QC/O0a7mUpBPmPEQqPtpnW8r5wcrcboQkU6j9afn+FPHzH0TH5WyhMjbqplQTOlUa9N466ikCBtMfZfyP4VeI1nawpMl+eyq1atjbyU8sMUPSpCIiHRveotUf40eog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zUXBQo5iWAFzrntsXQI58hpOGbRqP6t+mTXFNXhBWZA=; b=o1P8E1Ejy8kefiqcEjfXkgj8nnkr/ENVvoe0wcL7NVj5+zenEWQO9kgGxutdLTdS7kJStiExve3CX6BngpMF2SAZZ1uH1Yg5feXbWyxfQK6XIyucdCT8VflZUzAKgbeJaCBVdOFgXemQRBbbCQ+OWgy3d1ZrRLloMNQMX6slc9A= Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1779.eurprd08.prod.outlook.com (2603:10a6:203:2f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Wed, 26 May 2021 18:20:49 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4173.020; Wed, 26 May 2021 18:20:49 +0000 From: "Sami Mujawar" To: Sayanta Pattanayak , "devel@edk2.groups.io" CC: Ard Biesheuvel , nd Subject: Re: [edk2-platforms][PATCH V1 3/3] Platform/Sgi: enable support for UEFI secure boot Thread-Topic: [edk2-platforms][PATCH V1 3/3] Platform/Sgi: enable support for UEFI secure boot Thread-Index: AQHXUMGAuyfPkXbH/0SE4ZhfVk9QZar0OyEAgAHZoYCAAAEXVg== Date: Wed, 26 May 2021 18:20:48 +0000 Message-ID: References: <20210524172300.28754-1-sayanta.pattanayak@arm.com> <20210524172300.28754-4-sayanta.pattanayak@arm.com> <540101a6-dad9-0b69-8477-62ee2f369825@arm.com>, In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.191.32.222] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: ebaab659-84f0-41af-afee-08d92073019c x-ms-traffictypediagnostic: AM5PR0801MB1779:|DB9PR08MB6410: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wZ/KPYlieh7yl9Pxdnwk6c7UPpoBYMy1abHqZxVglWI236DyzwtVgjGkEr23PJbPNlj3j0l2SIPLddPtACZTh1WGHI2YCl5nVbH9tyqIsvasvendddzx9wmTi6O/npTMfykIE4eINj+2PpVfewlkWH1FnNhneen2kPmlVa/aVxZo3+uM6C+rihMeu7vLpK8zbX58p0f918LD8Mpt+O9rcoIMaENuNklSCECv/XJPtJeWn/DRecFmFbc4i3IrIEV3VVyJVHL5odxT1qBqU6TwuVENdA6l8ZQeetMRhmowrUHz86AFapexY7tjJvdarKk+84Tb/iDqUhqcGQ3CRE7vmkeKCd+ygCvWLlSnlcTT4j5ir/DXYn6PAS1NezwkJ1+DDr3/f86UvMSXB1n1b0doIeGw3d+7sHUUIfAbV8tQDXRKYB9+53s0A1SZY69tUZvsHE2jPlOe6JJYdml4l7j+jARDwassLNPpHwUVwvLuTXJzK2AA/kOAxEh0J7ZFbVLzs56mkVvBAq7pRqHMf6iHW7qvTX7/O+GEvVRmukSPDmDWp3OkIWu8QQam13KXcFLlwF0T/hCd9+4oBftLT6TTsH8xTC4MpIVYOLXBvgXKtdG+jObxXzb6PKE0PSYxV/kr8m3WUfvxDNsN2DWAsSNy8k85z6bz0fI3il34QBoxMat2sS5+efMBgrg1llHRyaq425r3iMzEf65Ps4xYQozpGA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(366004)(136003)(39850400004)(9686003)(26005)(33656002)(52536014)(9326002)(66556008)(8676002)(64756008)(122000001)(76116006)(66446008)(66946007)(6506007)(53546011)(86362001)(91956017)(7696005)(83380400001)(4326008)(8936002)(66476007)(966005)(19627235002)(5660300002)(71200400001)(478600001)(38100700002)(2906002)(316002)(186003)(166002)(110136005)(54906003)(55016002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3/hQrt3GuTa4wHdMQPUqHubmtKpw0ZcEiTFQLaEuR6pVyvcGfaFp7YrI8XBq?= =?us-ascii?Q?ntYADURl5kmx2ter2j05lu1t9hMxf7im66zx8bnsRH7BWEiZIqPEQ2lbN9fw?= =?us-ascii?Q?Y3PCqIVEnYtgBXC+eunYoFUgKmXjpwdPx7KoVguhY6IlAv24cWUN7jLSk5eB?= =?us-ascii?Q?AqNlaw/3MjKFs3v1T6MrpMKbXYKmPcDFHN5FrQqwEjrZEpiFXnHC0Wks5f4L?= =?us-ascii?Q?zzRTWofTiR+MYoX4tW+Nq+Td5KUgaMfVbEWM+Pq3x3muzFbfKMoGLtGU9yZB?= =?us-ascii?Q?/s4F8P8GtsFc5WajHjkTmE2mB440cMSMepPZyYwyDWecI5YcIbwOvuy5tPns?= =?us-ascii?Q?p9XXPBI29fe4u+OhXV4fqrGq07U8GzQQNg8ri2ZVEM+wogz19mNN+Rvl0sVl?= =?us-ascii?Q?U+V+NkITdtswxsxVZkdOLBC54pH77V+aOBoPxPpPjDhNjQ/vVADGs1B3R1AS?= =?us-ascii?Q?NvTBXH7lajviPnTHhx7+5LlYj0P/qrxnaRAf/E4i8g2zm04GoLS5j9Zpn/JV?= =?us-ascii?Q?Fy/2rczn9VvxgEaio0ZAqckvS7+0Cyq/axAlZCI8ENJaGdsLbslPr3WN9GQO?= =?us-ascii?Q?Dbu7avXvz/r+O0JVKzW3AyGNaq8UKMM2hB1yD4IylCVo/bfd5XwMCYUVvatF?= =?us-ascii?Q?WfXWcOwZGGCZ7HcG11fYjSAYhjYCv6x4GdVKEANfD0w2zVy0Xcsx/J7qYaTF?= =?us-ascii?Q?vtMdFBRiHLOWrQtyNzm/Z4EOzuk8v6zDXqPkB/08Jmfs8UDV37avunblx0ou?= =?us-ascii?Q?airRqvMKm1hXkxSMufdoq4Njk3F93YwkwiqSJ2rfQq8OV4FtJ8bKc4qS/1rp?= =?us-ascii?Q?KcB4Pq2gUc9bkEeodpWMT0UNN7cb6eaVxtE8uReIY4ROGHa9t3epXAEyGY2I?= =?us-ascii?Q?K4RMf4laDk868ZU8Cc82B2mXOfPVFCdWPOK0WE0omS890m+MWdqjTvAl9hNf?= =?us-ascii?Q?9w/N/PUhlRGX6qH40VUY2q0miaeiokMqZyVucGznS4IJdzqnlZe0jFr3XYKp?= =?us-ascii?Q?WuyRCdaB3vOTLYZR87Lkfl7XtIKWly+b2HtCIhHmWnf5P+RJOxgIR2gVQhOQ?= =?us-ascii?Q?eeIyUZJeXwyD7Adgr4asK1N+8DvT4GFuz73dAwYCIkP/5X4jokKgZTgDx+eI?= =?us-ascii?Q?EWoAJvDZWj9U/Hpluf8RLSKVtBJtel2o6p5ulZC+lRlDJEDx4viNyRDpk4ih?= =?us-ascii?Q?tc/0eLzNthsTL/CiDMchQ+X9Zq00jBYM4vKeh9fHzc0lWyhCvpGTErDmBvkP?= =?us-ascii?Q?3Zqk5wXj0kVJEf/lP1Hhd+vch7Rtcs4c1OBLTOf7RKxISVJersQ5DpNwtoVC?= =?us-ascii?Q?nRielPGTmcI2S4+r6oWTpfJAeiMW3GNbgrlTPwAC9Chypg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1779 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8467fa08-130d-4ccb-625f-08d92072fcf1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /f/rtLsO4flWScAn8QPbmC1zbiGDhsKGHx2em0tBU4btfresKCyPR9t7PJtVjzFa6zlbQ+K+x+dge6SoC8s97U3ptWdDkS1OUrJ1A0pIpaUr59xmnLKsaOvh2fD6bUPHV6ueqDt97cMnJnNx3BDpqozbV0K11Po2V964imif29Ns/2VfJbp6vIxeXWEF+sciEEVIe+VgCystYjJ69ZKP8JXq9uHbtgasIJpKdUg2Yl9745IGvUVZ7k26ESP4me9QUeODM0tCG6JC7gkD1rp7scNYfVMhIl8RxBZD9aRSRpmT6G+3CJzqHwByvLgJCCyRv/kVhNAnzVSjFTyeYH5MJOb+5ebhdwGIcyCSr50rCae5HO1prT6I02+0baCosGLM8mZCjKifNLl0hI/loqeaI/vk6p2BxzjRzP71gvduT+F8dQ/YL05bwIDQTEsTXquThOCFb6C73mxmcEAh0hhhIJ2Bj+MbNSWgjsD+R+147MH79Aw79efQY9Fe2ewk5pRM8tAn6jdqet1uVQ7/LLFB0EueBQ4ws18XZs8TKi9mCPU2LvyDscjZ2qffOMiF7hmFD7Zls3NnW8PK4fVI1Y1q5Y1qfZJN2FZEZIDwL8JyOdYEdbObo3ITgZ3jBytLrNuhPHs3wsO4h0QlXEghi9xUIq/pzEtYfVj0+zIiIkmD0IxyulCm4nEgZQbbS8nE/eR3XsLSq0Y4LfYYuc3M4mEXUwmeWfbENXco4dMK4K2B+oWabww53sKv8hgN7xDSLb4Df6L14nMEp/B9yiyTCggLuA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39850400004)(396003)(376002)(346002)(36840700001)(46966006)(81166007)(86362001)(166002)(52536014)(356005)(478600001)(82740400003)(110136005)(4326008)(8936002)(186003)(47076005)(36860700001)(53546011)(82310400003)(2906002)(83380400001)(336012)(8676002)(5660300002)(70206006)(70586007)(33656002)(966005)(55016002)(7696005)(19627235002)(9326002)(26005)(6506007)(9686003)(54906003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2021 18:20:56.9929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebaab659-84f0-41af-afee-08d92073019c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6410 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AS8PR08MB68063262C546375B9F2498F084249AS8PR08MB6806eurp_" --_000_AS8PR08MB68063262C546375B9F2498F084249AS8PR08MB6806eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sayanta, Thanks for confirming. With that. Reviewed-by: Sami Mujawar Regards, Sami Mujawar From: Sayanta Pattanayak Date: Wednesday, 26 May 2021 at 19:15 To: Sami Mujawar , devel@edk2.groups.io Cc: Ard Biesheuvel , nd Subject: RE: [edk2-platforms][PATCH V1 3/3] Platform/Sgi: enable support fo= r UEFI secure boot Hi Sami, Thanks for the review and suggestion. Please find my reply inline. > > Hi Sayanta, > > Thank you for this patch. > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 24/05/2021 06:23 PM, Sayanta Pattanayak wrote: > > Enable the use of UEFI secure boot for Arm's Neoverse reference design > > platforms. The UEFI authenticated variable store uses NOR flash 2 > > which is accessible from Standalone MM context residing in a secure > partition. > > > > Signed-off-by: Sayanta Pattanayak > > --- > > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 31 > +++++++++++++++++++ > > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 32 > ++++++++++++++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 15 +++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm2.dsc | 15 +++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 5 +++ > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 9 +++++- > > 6 files changed, 106 insertions(+), 1 deletion(-) > > <...> > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > +!endif > > diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > index 3389ff676a91..6839ec35da8a 100644 > > --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > @@ -59,6 +59,19 @@ > > > HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmH > obLib.inf > > > MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Stan > daloneMmServicesTableLib.inf > > > > > MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAll > ocati > > onLib/StandaloneMmMemoryAllocationLib.inf > > +!if $(SECURE_STORAGE_ENABLE) =3D=3D TRUE > > + > > +AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.i > > +nf > > + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > + > > > +NorFlashPlatformLib|Platform/ARM/SgiPkg/Library/NorFlashLib/Standalon > > +eMmNorFlashLib.inf > > + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > [SAMI] There is a recent patch series that adds ARMv8.5 FEAT_RNG support > to BaseRngLib > see > https://github.com/tianocore/edk2/commit/9301e5644cef5a5234f71b178373 > dd508cabb9ee. > Can this be used instead of BaseRngLibTimerLib? BaseRngLibTimerLib is for > non-production use so it would be good to avoid. > Indeed, this would require that Sgi platforms are ARMv8.5 or above. If no= t, > then can we conditionally use BaseRngLibTimerLib for platforms that do no= t > support FEAT_RNG. > [/SAMI] Current SGI platforms with secureboot are of pre ARMv8.5. For ARMv8.5 and = above SGI platform, will follow the conditional approach. Regards, Sayanta <...> --_000_AS8PR08MB68063262C546375B9F2498F084249AS8PR08MB6806eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Sayanta,

 

Thanks for confirming.

 

With that.

 

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com&g= t;

&nbs= p;

Regards,<= o:p>

&nbs= p;

Sami Muja= war

&nbs= p;

From: Sayanta Pattanayak = <Sayanta.Pattanayak@arm.com>
Date: Wednesday, 26 May 2021 at 19:15
To: Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io = <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, nd <nd@arm.= com>
Subject: RE: [edk2-platforms][PATCH V1 3/3] Platform/Sgi: enable sup= port for UEFI secure boot

Hi Sami,

Thanks for the review and suggestion. Please find my reply inline.

>
> Hi Sayanta,
>
> Thank you for this patch.
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 24/05/2021 06:23 PM, Sayanta Pattanayak wrote:
> > Enable the use of UEFI secure boot for Arm's Neoverse reference d= esign
> > platforms. The UEFI authenticated variable store uses NOR flash 2=
> > which is accessible from Standalone MM context residing in a secu= re
> partition.
> >
> > Signed-off-by: Sayanta Pattanayak <sayanta.pattanayak@arm.com&= gt;
> > ---
> >   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc  &n= bsp;    | 31
> +++++++++++++++++++
> >   Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc  =    | 32
> ++++++++++++++++++++
> >   Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc  | = 15 +++++++++
> >   Platform/ARM/SgiPkg/PlatformStandaloneMm2.dsc | 15 ++= +++++++
> >   Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf  |&= nbsp; 5 +++
> >   Platform/ARM/SgiPkg/SgiPlatform.fdf   =         |  9 +++++-
> >   6 files changed, 106 insertions(+), 1 deletion(-)
> >

<...>

> >     ArmPkg/Drivers/MmCommunicationDxe/MmCommu= nication.inf
> > +!endif
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> > b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> > index 3389ff676a91..6839ec35da8a 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> > @@ -59,6 +59,19 @@
> >
> HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmH
> obLib.inf
> >
> MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Stan > daloneMmServicesTableLib.inf
> >
> >
> MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAll
> ocati
> > onLib/StandaloneMmMemoryAllocationLib.inf
> > +!if $(SECURE_STORAGE_ENABLE) =3D=3D TRUE
> > +
> > +AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariable= Lib.i
> > +nf
> > +  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.i= nf
> > +  IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.= inf
> > +
> >
> +NorFlashPlatformLib|Platform/ARM/SgiPkg/Library/NorFlashLib/Standalon=
> > +eMmNorFlashLib.inf
> > +  OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerL= ib.inf
> [SAMI] There is a recent patch series that adds ARMv8.5 FEAT_RNG suppo= rt
> to BaseRngLib
>   see
> https://github.com/tianocore/edk2/commit/9301e5644cef5a5234f71b178373 > dd508cabb9ee.
> Can this be used instead of BaseRngLibTimerLib? BaseRngLibTimerLib is = for
> non-production use so it would be good to avoid.
> Indeed, this would require that Sgi platforms are ARMv8.5 or above. If= not,
> then can we conditionally use BaseRngLibTimerLib for platforms that do= not
> support FEAT_RNG.
> [/SAMI]

Current SGI platforms with secureboot are of pre ARMv8.5.  For ARMv8.5= and above SGI platform, will follow the conditional approach.

Regards,
Sayanta

<...>

--_000_AS8PR08MB68063262C546375B9F2498F084249AS8PR08MB6806eurp_--