From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6DDE7941C22 for ; Thu, 10 Aug 2023 18:37:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KWdgXIT1DTKiZ6wnKLAOzK05Ua9HcxmX0e4UR7X6jb4=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:Authentication-Results-Original:nodisclaimer:MIME-Version:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1691692661; v=1; b=mEliTCY8AgT2MgvFXO8Sr7ghsiy70lYM04uOSMuDmGNsI9Zjbh+S52rf2vtKFNZyW51T144J 6oTa7aGtv8ykD4bdskwtUrOSNYPBCW0X2jabze+sgSPnI4Ju/6cRRU6wENh9bQMYBYZI+wC/ayJ DsX++LJomkjd2b4m9HDHRh6Q= X-Received: by 127.0.0.2 with SMTP id qRnjYY7687511xsTnqHj8aRH; Thu, 10 Aug 2023 11:37:41 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.78]) by mx.groups.io with SMTP id smtpd.web10.25647.1691692660686498092 for ; Thu, 10 Aug 2023 11:37:41 -0700 X-Received: from AS4P192CA0020.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5e1::6) by DB9PR08MB7625.eurprd08.prod.outlook.com (2603:10a6:10:309::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 18:37:34 +0000 X-Received: from AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5e1:cafe::c7) by AS4P192CA0020.outlook.office365.com (2603:10a6:20b:5e1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 18:37:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT060.mail.protection.outlook.com (100.127.140.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 18:37:34 +0000 X-Received: ("Tessian outbound 0b7d6027328f:v175"); Thu, 10 Aug 2023 18:37:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 394ada083e99edb8 X-CR-MTA-TID: 64aa7808 X-Received: from 4af7a688897f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FE4397C4-7BF8-42CD-BAE6-756800CAEDB8.1; Thu, 10 Aug 2023 18:37:28 +0000 X-Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4af7a688897f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 18:37:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHn4v4vNbovYWwH8DzkHmcyo88EeeWwBdvDTV3XSE9dC9b1DNpBwC6wxWT2byfxYR0qcPztNGyrG8L7i6yBDlb5jplwWWmmC8pu0kBkSjtaOmattPjz0XBTWsIePaTNJ24R3YAx9GK/8SbQ0la+ZPr0xwIPHoh771VbymiffPkfuOzTLkKJRN+g84L2Uo1wxKxJHt91Ep9qNs7ZW7bZCQ0x6NGyMhXAS+T5Bnou9hdEA2m7EFTiHhpsZc0ztIPgbV1p9rIfjNmUvqKFD2b2RvfZ3r7iTLK2QZen/31Sv0nugLfpqnUyZGxGSnABIYskdLctvN1D7frm9kYmBx+Vl/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=44WK9U+F8rH5FDDJsHoKlwOc+OO6tgApdA2SegeZUYM=; b=lbKaSHyVJ58vuKAGPMF/qxnpsrHTYy4Zv1ZdC9l71Tt68tN5qcEgCj3gkiO4yFolFIN1GZUHFJDDETZbBFVI2pHG60xCAPTjv8dw3BiaLn/0WlKTmMsTaCywcsSK20slU2UnkM/fnpVryY+3CgKUO1hc4AmiBzCO3VXQ1eKU0cDTm5rMxvZqHkJ8QE1olu220P+iOfizSJy9z9vlM+jEhBquVqGUNcwU/8V+THsvVdAAU+NaTjSvOMoRcYoj9TgikGSt5X5O7JEUxHU0BnInXMTQWM9h6ES7xrOCTAEoGGy2WaZiuNeuW+OFbbdEYBoct9eMWfVZ35bRY0fRt6mfog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBBPR08MB6298.eurprd08.prod.outlook.com (2603:10a6:10:1f7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 18:37:26 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 18:37:25 +0000 From: "Sami Mujawar" To: Pierre Gondois , "devel@edk2.groups.io" CC: nd Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib Thread-Topic: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib Thread-Index: AQHZuW5jn24bWVMpJkqdxIpgNpDFvq/ead+AgAU95gCAAFgyaw== Date: Thu, 10 Aug 2023 18:37:25 +0000 Message-ID: References: <20230718115156.1224842-9-pierre.gondois@arm.com> <16750.1691385409155473599@groups.io> <940a4419-5be4-a7dc-f677-2f0439235c7d@arm.com> In-Reply-To: <940a4419-5be4-a7dc-f677-2f0439235c7d@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB6806:EE_|DBBPR08MB6298:EE_|AM7EUR03FT060:EE_|DB9PR08MB7625:EE_ X-MS-Office365-Filtering-Correlation-Id: 6da733d3-c33f-4b4d-1cec-08db99d0dd00 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OcoVsa3rWxH3OCFs7idd2scwHxDmt2bt6jgMFoGHiN7lpggZcOArG05IY26H72Mreccef8bZIN80gz7DwutXLbJdUGtKo8Q6J723heRvq2V5DWhE//3cxEDtEUw1uRmt07stZDz6U3nnAxeYLlyjLykx+zVvd7jHVopROrbiYPx5PiouMSItIw9ZP2JsrUpbel5NBR2L+vGmtdCEIQ2uldcaoz3pP+GXXbkitsJrRwsPqd9VowbMfKrHXRE1GtVtuj72UPVnqBenfTZxQRx1yeEYaIvFkoCKQEUsIh2FRyr2cZeqG4ZNYL6hbbHCUecxWFYCJ1jFBSox1IEO/1U/6m1RNwk95ngAQXEdw64xU88kvbYREBd65QiMnCCZzDN82NgpDjVqTTghy6PmFeyhfIkW+r7ReC8HEXkY7SNDreTJpYF1mOJW6Mg8D3lC/AmdtHH9QT/eWxnZeVyqVfzJpJBW+vBGuoTQO35nekdV/jKPvTcfwH4Zm3gjxNhbyOdIqQnMAqQdfz4nNb2gZEExrKMJ1zjVwNH6SdMmoPDBoaaX/F2TW6IRb+mL4Hxz5+uFC2UDW2gLCNj04Ok3XAx8xk93rtJCj94m4A3hWNpklxs1cUbILAK5UKBPajCs7CYb X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(376002)(366004)(39860400002)(186006)(1800799006)(451199021)(4326008)(66446008)(76116006)(64756008)(66556008)(66946007)(66476007)(41300700001)(83380400001)(55016003)(5660300002)(71200400001)(7696005)(38100700002)(8676002)(86362001)(8936002)(52536014)(38070700005)(110136005)(15650500001)(122000001)(2906002)(478600001)(33656002)(9686003)(26005)(6506007)(53546011)(316002);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6298 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3d2028c9-871a-4fe6-64b5-08db99d0d794 X-Microsoft-Antispam-Message-Info: JsVjdgvr5fXOzjnOX5zRD8/fxQIgfnSocavzpDe/sLA80dA3lrmi89hcktgIWgERb15I3BGvOTiaVGPUpKzhMGPlnt6t4OAljZ4/zYJ58uvccFqWHonQwB0x9JJfW2q0Pr3QovYprl++OY6gmssODmOlGpeEqyuhVMaRUtUwFovKbZeUNH4UESm9dsVbmd4wAIes7UwlYn8lbhQ4faVd+3NKs4muPQ5FoEYPYALuXjAx+kzpr6jIaW3KsyG2Sg3IEkHSeXVICbIUBkp1emTh4x7EHCiVForLdE8iw0ICVB05AuNQvH1mvON7IiUqoNZ7crLFdnMMrIbDosHJdeulYFy8dczyNRm+nNIqmLcql8l2gUjmL4nSVlA+jHqXiNv/zXWPHKsCmdimyR08yb5V1UXZyk6ws1ZNBvql8ly4z1A1I+RWOjAD4tt2YYA/Jr0qxSzqmhHLpEUyfVkaHPN9+pydrAJNAYSCvYSkWz67SOUlNGY73doOFTvUNJUXxZZG17JjNlxTaGx+ciQePJOFzpA6ln4ttqEApa0AOGrd+MViHL9ANHDypthHWt2yvk/vHZy54BPsYMbcG8onWOlnkQOS6esrtUtoIxKlMA9Z237oGL+6CnLvg/tIzVTRWFvokEg760j5/6dM1IQ0EVXcjMF10d86EwbJ/EWpVi0TaXGTP8qtBpoMaQuz9sfjDbjMjkT9BCdfsIFLIcoyfJ9WisrXMBRrbtHvBRZrAXSctXfCZ0MWKDM3WG2g/qF3UVS6 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 18:37:34.2607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6da733d3-c33f-4b4d-1cec-08db99d0dd00 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7625 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5aPc03SMAlneOe2Exs9mWvsUx7686176AA= Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AS8PR08MB68063FA110A447D54EEE77D88413AAS8PR08MB6806eurp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mEliTCY8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_AS8PR08MB68063FA110A447D54EEE77D88413AAS8PR08MB6806eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Pierre, Please send an updated version with the r-b collected. That way it would be= less work for the maintainer. Regards, Sami Mujawar ________________________________ From: Pierre Gondois Sent: Thursday, August 10, 2023 6:49:40 PM To: Sami Mujawar ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid= () when probing RngLib Hi Sami, Yes indeed, this line should be removed, do you want me to send a new version of this patch ? Regards, Pierre On 8/7/23 07:16, Sami Mujawar wrote: > Hi Pierre, > > Thank you for this patch. > > On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote: > > + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID =3D > # Unique ID of the algorithm for RNG > > Can you check if the line above should be part of this patch, please? > Otherwise, this patch looks good to me. > > In either case, > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107699): https://edk2.groups.io/g/devel/message/107699 Mute This Topic: https://groups.io/mt/100213737/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_AS8PR08MB68063FA110A447D54EEE77D88413AAS8PR08MB6806eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Pierre,

Please send an updated version with the r-b collected. That way it would be= less work for the maintainer.

Regards,

Sami Mujawar
From: Pierre Gondois <pi= erre.gondois@arm.com>
Sent: Thursday, August 10, 2023 6:49:40 PM
To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io = <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use Get= RngGuid() when probing RngLib
 
Hi Sami,
Yes indeed, this line should be removed,
do you want me to send a new version of this patch ?

Regards,
Pierre

On 8/7/23 07:16, Sami Mujawar wrote:
> Hi Pierre,
>
> Thank you for this patch.
>
> On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote:
>
>     + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCE= S ## GUID =3D
>     # Unique ID of the algorithm for RNG
>
> Can you check if the line above should be part of this patch, please?<= br> > Otherwise, this patch looks good to me.
>
> In either case,
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#107699) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_AS8PR08MB68063FA110A447D54EEE77D88413AAS8PR08MB6806eurp_--