From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.51]) by mx.groups.io with SMTP id smtpd.web10.9084.1639387748554765007 for ; Mon, 13 Dec 2021 01:29:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=eUmNMSHf; spf=pass (domain: arm.com, ip: 40.107.21.51, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Opa6anonqgidKhrK3+P7OZ8/Tbb35K4cL9ZwSLd21Bo=; b=eUmNMSHf380hSSmLbMSJ2cVRku8XH6q9hT5bYNjCNLM3SHg/FTHgmlq6Yt10B5PlJfv/QFIWsW2bTVGOg4VQe//aL7soxo2bH1rLo5qCgHammmd1fgXkeFwf6VCTOBMKG0gUhDaKCAUMrFZIZB+Cz0+pMKPPMK2X6K96djWDNBU= Received: from AM6PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:20b:92::37) by AM6PR08MB4984.eurprd08.prod.outlook.com (2603:10a6:20b:ee::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec 2021 09:29:05 +0000 Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::f7) by AM6PR04CA0024.outlook.office365.com (2603:10a6:20b:92::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16 via Frontend Transport; Mon, 13 Dec 2021 09:29:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Mon, 13 Dec 2021 09:29:04 +0000 Received: ("Tessian outbound a33f292be81b:v110"); Mon, 13 Dec 2021 09:29:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 750002e66e826d24 X-CR-MTA-TID: 64aa7808 Received: from 4b22dea1f01f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1FD7FE39-40B8-4D51-91FA-D9B44EAC03D7.1; Mon, 13 Dec 2021 09:28:46 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4b22dea1f01f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Dec 2021 09:28:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lF5/AHlYAGFG6e41xDn1Sso+0iWt/gTAN/WR73vwGx2529JKKT6KSzhXFpMZjVc3jT0Mf8YCHHreuSeFzW1qHlQRmnZJXtiP2BZU6B9uHyzhrrhc+MW9AdXlS+zuSZlAgv7idfyGwqIbxXNJDrGNGuIivqFipU+p5xO29NbD1MX9p9L4Om3RnjjaVs9zNQ6pgSBehUYsS0gaDyy9PTKKNusEOaZHhf455E+IubKzKLWwFPXV7A8wGijmYF3nQvuvZv3KM9Y/Pkt/bMiYu7E2Pa9KD5XdnTWoeyKzbBjqwjfvY2GPxNm9/8ib7HgmeCPjslmtnTe9E4jPewVV4Etmag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Opa6anonqgidKhrK3+P7OZ8/Tbb35K4cL9ZwSLd21Bo=; b=IiBFJy+ImAz+G4kuWFFpF7uwSCCbVlObqmN/gG7JFqLsAlYd9I8+XyqPcdUuTXzZvb63TzYKmDM67o5dVRU6uBbM6fKELYvMvUwoghaaAryvhGiiX+mFVVWp03mxmbN2ZuM42o1uLGtDm+0zpD8ZAhWa5VASkNKqKFfGz4jBWhEMrumaPZNhXJWYJccXGehC20cT6HOIzNLklYy8/cuyqn4tGr6Vdwg9TrMPy9ja9SOtCBu99q1sFZQn1PZZ9NfOv2aOsH65whIaAyt0yafPYzbNHOOndh+lZrcGNxGe3V+sFuDgG2z2goVAcjt8aB/CC3lslBOAkumsdCk/4UQszg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Opa6anonqgidKhrK3+P7OZ8/Tbb35K4cL9ZwSLd21Bo=; b=eUmNMSHf380hSSmLbMSJ2cVRku8XH6q9hT5bYNjCNLM3SHg/FTHgmlq6Yt10B5PlJfv/QFIWsW2bTVGOg4VQe//aL7soxo2bH1rLo5qCgHammmd1fgXkeFwf6VCTOBMKG0gUhDaKCAUMrFZIZB+Cz0+pMKPPMK2X6K96djWDNBU= Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1649.eurprd08.prod.outlook.com (2603:10a6:203:38::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Mon, 13 Dec 2021 09:28:44 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Mon, 13 Dec 2021 09:28:44 +0000 From: "Sami Mujawar" To: "Yao, Jiewen" , "devel@edk2.groups.io" , "Xu, Min M" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Wang, Jian J" , "Lu, Ken" , Gerd Hoffmann , nd Subject: Re: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2 Thread-Topic: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2 Thread-Index: AQHX7pBUXKk5Tfg4ykarst4lLKc8uqwtTMLwgAC0ldCAAiasbw== Date: Mon, 13 Dec 2021 09:28:44 +0000 Message-ID: References: <16BFB74A32C27317.32732@groups.io> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1c2eba9e-1b3c-48e2-525c-08d9be1b0182 x-ms-traffictypediagnostic: AM5PR0801MB1649:EE_|VE1EUR03FT014:EE_|AM6PR08MB4984:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vc9ctLjXMaULGm3N7UX5hvGeNZLbqR6JfVrkEiUjQeKxucQyTvi3nUwtxnfzttSuQyvVc6gyUkBHcUg6GvzZuhUT3rogkyCxDBoxeifFYuh6Sx75ym0qOwqMAtJ3LgwY0jfgHA8I4yF3/7WnhsUqgbPDZkG5Wgqyc6xR4Lf9SqeNt8JQkIvvdWuTKBi4cFByq+3QjKkSnvtL1RyvK+YyTSqCYlGkBSrAgfw1gnPEGLgmOCHf/qQAdLR0ABrb8kwoVWrGqLKbDk+mHEGHQ3HG5lH9LOQdvt6+O8S6RiTZFIKjyevbRQFOZ67ZyoIBbGb65Gcq5ES7cNOEAFXbLEC2bGMHrZU6VJvJe3KBSL6F5AjdGyq1vfmEJAXmnlANOvcJ2FgPnB9dpKWI00r551lhSDacTOjKV8CTjjcwCCrFuyeNBBWqYUsnY4f+RBmqT/3OhZ2QuroLnUJGkTambdTLHlPSYhzHW6t5e/uS5w5zr96yS8zMXT1CnNZeq3S88oTzNBTqlqigQxZgFbg1D6MgMnAkxqOlw6DQRLogecW6AynjjLX9zLZNk1E7XrOo++bRknx0zHqykp90phF6WrruHdG7HH+TsejLwakFGpTZQnBQS4n+ye9+8axtJVKEHR82jQ8E6QYwjRGqMnMOHhNDCcOHDTZorXVntinxIL8xO7JsVBFd3K3J7YR59OOgwnZkvlTZerrVv280gZRDVkNieJWwfp//8GWRIdeUeDEty8WWg59pUP/AzJx7drrlhhDKtoCWrLMjjEJRx9/JkwXvs9Zk318KskasEcUlczAKHbcR0Trp6BI2zfoDSvYcnmZDsVbxX82b11TrCmQCDeF53uFpXdG7RPr59EQG+hLHYNl7lEUBsasc30ThJD+HbIr/ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(4326008)(6506007)(53546011)(66446008)(71200400001)(66556008)(66946007)(7696005)(55016003)(76116006)(9686003)(86362001)(64756008)(66476007)(19627235002)(52536014)(91956017)(166002)(316002)(83380400001)(54906003)(110136005)(38100700002)(5660300002)(508600001)(38070700005)(33656002)(8936002)(122000001)(966005)(2906002)(186003)(8676002);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1649 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e7655d56-8c73-436b-8160-08d9be1af55e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K3NZuPT+2qhPWFJWhPQxOOIz4LCpfHZSyA+u3+cxcqkYeLWmGcybG7rHVjxNQ4H3wgkzXctRxIIHBc/+vsM69XEk1zmhH6Ai94Jt17UF26NdFQTTmGdhk1O0iTneaOqDonRZudgVemcuRJi5kh+2aUDhgiBHipskJfbWLX/iKq6p8OETxjtB3d6Mskp1Or9PsMq1RXngRguBUhGDPvWBICPcSiVcEEIQ+gXpXbSkBwQ5txlyIStii+0TgSUve27WnoRvZF0Se8GdRODS4zEksfdzN69oa38U/t4yPjQdj4ONFU00Cc5qdZQxUOR3y9GJYbk8Jm6cyB/CD6F7rf+HwIaRBf1vLsJqBOOAmDDW7kk5oHLp190oYv/uO+7plgwsngv+6E/sV5C0gPX/aOCwUiHTvo+8MBSsabUwZDcY7jWVutN70Dnx7xCq0w3Hyu4UReXYeSX0CC1+FwCXDnPgJ+c32GEgx7gLr0NARMGFfeyvWylmUVU57tojMFSANkyC77AJrhtoUgxwhpkTaLA+beKCrIibLcnHiO9W7Y8y58G1wq/GJ5LOx1ioVGQ5sv0K11e+sRaPSJ1L6bCtwFXuYHZnzpk5rZh+HFtH8bspuFHHlNPZnJhe2nqHfkJrp6Kr6oYU8YZkMuKuRh7yEhRvDGAlTieaUUvcAMazHJf1+lWpOJLNNlsMlpMa/k3t7aU3E2DG1gTiKs3g2gLdl1DW1Avmi95qf3QS742JLP/oz0g0ZCJenKG/o1xLC7IPEG0dwkWme/HcBP6cJNcNl/6hJcEZ7/iLmLlPvqLztBVGqel56u1oRiEEjfvjRCef5vWY4LIKH9b6/BA4s7tcB4edfQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(46966006)(36840700001)(8936002)(356005)(30864003)(19627235002)(166002)(336012)(83380400001)(82310400004)(52536014)(9686003)(2906002)(7696005)(8676002)(86362001)(316002)(55016003)(81166007)(110136005)(36860700001)(70586007)(47076005)(54906003)(70206006)(53546011)(6506007)(966005)(26005)(5660300002)(4326008)(508600001)(33656002)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 09:29:04.6942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c2eba9e-1b3c-48e2-525c-08d9be1b0182 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4984 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AS8PR08MB6806583834EB2BDF211DA9FC84749AS8PR08MB6806eurp_" --_000_AS8PR08MB6806583834EB2BDF211DA9FC84749AS8PR08MB6806eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiewen, Min, Thank you for making the measurement protocol architecture neutral. I will monitor the mailing list for any further CC measurement interface/im= plementations. However, I request you to copy me, in case I miss any patche= s. Regards, Sami Mujawar From: Yao, Jiewen Date: Sunday, 12 December 2021 at 00:29 To: devel@edk2.groups.io , Yao, Jiewen , Xu, Min M Cc: Kinney, Michael D , Liming Gao , Liu, Zhiguang , Wang, Jian J , Lu, Ken , Sami Mujawar , Gerd Hoffmann Subject: RE: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol in= to EDK2 Merged - https://github.com/tianocore/edk2/pull/2291 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Saturday, December 11, 2021 9:45 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Wang, > Jian J ; Lu, Ken ; Sami Mujawar > ; Gerd Hoffmann > Subject: Re: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtocol > into EDK2 > > Series: Reviewed-by: Jiewen Yao > > > -----Original Message----- > > From: Xu, Min M > > Sent: Saturday, December 11, 2021 9:09 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Kinney, Michael D > > ; Liming Gao ; Li= u, > > Zhiguang ; Yao, Jiewen ; > > Wang, Jian J ; Lu, Ken ; Sami > > Mujawar ; Gerd Hoffmann > > Subject: [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2 > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3625 > > > > If Confidential Computing (Cc) firmware supports measurement and an > > event is created, CC-Guest firmware is designed to report the event > > log with the same data structure in TCG-Platform-Firmware-Profile > > specification with EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 format. > > > > The CC-Guest firmware supports measurement. It is designed to produce > > EFI_CC_MEASUREMENT_PROTOCOL with new GUID > > EFI_CC_MEASUREMENT_PROTOCOL_GUID to report event log and provides > > hash capability. > > > > Patch #1: > > Introduce the CC Measurement Protocol definition into MdePkg. > > > > Patch #2: > > Update DxeTpm2MeasureBootLib to support CC based measure boot. > > > > Patch #3: > > Update DxeTpmMeasurementLib to support CC based measurement. > > > > Code is at https://github.com/mxu9/edk2/tree/td_protocol.v6 > > > > This patch-set has been tested in Intel's internal hardware platform. > > Both TD and TPM pass the tests. > > > > v7 changes: > > - Rebase the code base (commit: e81a81e5846e) and update patch-set wit= h > > uncrustify. > > > > v6 changes: > > - Add ASSERT (sizeof (EFI_CC_EVENT) =3D=3D sizeof (EFI_TCG2_EVENT)) ch= eck. > > - Update the CcMeasureAndLogData () to add CcProtocol pointer as the > > input parameter. > > - Tpm20MeasureAndLogData () / Tpm12MeasureAndLogDat () > > / CcMeasureAndLogData () are made static according to Sami's > > comments. > > > > v5 changes: > > - Add gEfiCcFinalEventsTableGuid in [Guids] section of MdePkg.dec > > - DxeTpm2MeasureBootLib and DxeTpmMeasurementLib will first > > call CC protocol to do the measure boot / measurement. If it is not > > installed, TCG2 protocol will be located and called. > > - CreateCcEventFromTcg2Event is removed. This is because CcEvent is > > similar to Tcg2Event except the MrIndex and PcrIndex. So in the code > > Tcg2Event will be first created and intialized. If > > CcMeasurementProtocol is called to do the measure boot, then CcEvent > > points to Tcg2Event and the MrIndex is adjusted. > > - Some other minor changes. > > > > v4 changes: > > - Rename TeeMeasurementProtocol to CcMeasurementProtocol based > > on the discussion in below links: > > https://edk2.groups.io/g/devel/message/82876 > > https://edk2.groups.io/g/devel/message/82999 > > https://edk2.groups.io/g/devel/message/83000 > > With this protocol, CC based measure boot is supported. > > TD based measure boot is one of the CC based measure boot. > > - The spec will be updated according to the changes later. > > - TdProtocol.h is deleted. Its content is merged into CcMeasurement.h. > > - Add gEfiCcFinalEventsTableGuid definition in MdePkg.dec > > - Update the description in DxeTpm2MeasureBootLib.inf > > and DxeTpmMeasurementLib.inf > > > > v3 changes: > > - Rename TdProtocol to TeeMeasurementProtocol which is a neutral name. > > With this protocol, TEE based measure boot is supported. > > TD based measure boot is one of the TEE based measure boot. > > - The spec will be updated according to the changes later. > > - Fix errors in DxeTpm2MeasureBootLib. > > > > v2 changes: > > - TD based measure boot is implemented in DxeTpm2MeasureBootLib. > > This minimize the code changes. > > - TD based measurement is added. It is implemented in > > DxeTpmMeasurementLib. > > - Fix the typo in comments. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Ken Lu > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Reviewed-by: Sami Mujawar > > Tested-by: Min Xu > > Signed-off-by: Min Xu > > > > Min Xu (3): > > MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware > > SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib > > SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib > > > > MdePkg/Include/Protocol/CcMeasurement.h | 302 +++++++++++++++ > > MdePkg/MdePkg.dec | 6 + > > .../DxeTpm2MeasureBootLib.c | 343 ++++++++++++++---- > > .../DxeTpm2MeasureBootLib.inf | 3 +- > > .../DxeTpmMeasurementLib.c | 122 ++++++- > > .../DxeTpmMeasurementLib.inf | 9 +- > > 6 files changed, 686 insertions(+), 99 deletions(-) > > create mode 100644 MdePkg/Include/Protocol/CcMeasurement.h > > > > -- > > 2.29.2.windows.2 > > > >=20 > --_000_AS8PR08MB6806583834EB2BDF211DA9FC84749AS8PR08MB6806eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Jiewen, Min,

 

Thank you for making the measurement protocol architecture neutral.

I will monitor the mailing list for any further CC measurement inte= rface/implementations. However, I request you to copy me, in case I miss an= y patches.

 

Regards,

 

Sami Mujawar

 

From: Yao, Jiewen <jie= wen.yao@intel.com>
Date: Sunday, 12 December 2021 at 00:29
To: devel@edk2.groups.io <devel@edk2.groups.io>, Yao, Jiewen &= lt;jiewen.yao@intel.com>, Xu, Min M <min.m.xu@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>, Liming Gao= <gaoliming@byosoft.com.cn>, Liu, Zhiguang <zhiguang.liu@intel.com= >, Wang, Jian J <jian.j.wang@intel.com>, Lu, Ken <ken.lu@intel.= com>, Sami Mujawar <Sami.Mujawar@arm.com>, Gerd Hoffmann <kraxe= l@redhat.com>
Subject: RE: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProt= ocol into EDK2

Merged - https://github.com/tianocore/edk2/pull/2291

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Y= ao, Jiewen
> Sent: Saturday, December 11, 2021 9:45 PM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel= .com>; Wang,
> Jian J <jian.j.wang@intel.com>; Lu, Ken <ken.lu@intel.com>= ; Sami Mujawar
> <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@redhat.com><= br> > Subject: Re: [edk2-devel] [PATCH V7 0/3] Introduce CcMeasurementProtoc= ol
> into EDK2
>
> Series: Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu@intel.com>
> > Sent: Saturday, December 11, 2021 9:09 PM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byos= oft.com.cn>; Liu,
> > Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.y= ao@intel.com>;
> > Wang, Jian J <jian.j.wang@intel.com>; Lu, Ken <ken.lu@in= tel.com>; Sami
> > Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@re= dhat.com>
> > Subject: [PATCH V7 0/3] Introduce CcMeasurementProtocol into EDK2=
> >
> > BZ: https://bugzilla.tianocore.org= /show_bug.cgi?id=3D3625
> >
> > If Confidential Computing (Cc) firmware supports measurement and = an
> > event is created, CC-Guest firmware is designed to report the eve= nt
> > log with the same data structure in TCG-Platform-Firmware-Profile=
> > specification with EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 format.
> >
> > The CC-Guest firmware supports measurement. It is designed to pro= duce
> > EFI_CC_MEASUREMENT_PROTOCOL with new GUID
> > EFI_CC_MEASUREMENT_PROTOCOL_GUID to report event log and provides=
> > hash capability.
> >
> > Patch #1:
> > Introduce the CC Measurement Protocol definition into MdePkg.
> >
> > Patch #2:
> > Update DxeTpm2MeasureBootLib to support CC based measure boot. > >
> > Patch #3:
> > Update DxeTpmMeasurementLib to support CC based measurement.
> >
> > Code is at https://github.com/mxu9/edk2= /tree/td_protocol.v6
> >
> > This patch-set has been tested in Intel's internal hardware platf= orm.
> > Both TD and TPM pass the tests.
> >
> > v7 changes:
> >  - Rebase the code base (commit: e81a81e5846e) and update pa= tch-set with
> >    uncrustify.
> >
> > v6 changes:
> >  - Add ASSERT (sizeof (EFI_CC_EVENT) =3D=3D sizeof (EFI_TCG2= _EVENT)) check.
> >  - Update the CcMeasureAndLogData () to add CcProtocol point= er as the
> >    input parameter.
> >  - Tpm20MeasureAndLogData () / Tpm12MeasureAndLogDat ()
> >    / CcMeasureAndLogData () are made static accord= ing to Sami's
> >    comments.
> >
> > v5 changes:
> >  - Add gEfiCcFinalEventsTableGuid in [Guids] section of MdeP= kg.dec
> >  - DxeTpm2MeasureBootLib and DxeTpmMeasurementLib will first=
> >    call CC protocol to do the measure boot / measu= rement. If it is not
> >    installed, TCG2 protocol will be located and ca= lled.
> >  - CreateCcEventFromTcg2Event is removed. This is because Cc= Event is
> >    similar to Tcg2Event except the MrIndex and Pcr= Index. So in the code
> >    Tcg2Event will be first created and intialized.= If
> >    CcMeasurementProtocol is called to do the measu= re boot, then CcEvent
> >    points to Tcg2Event and the MrIndex is adjusted= .
> >  - Some other minor changes.
> >
> > v4 changes:
> >  - Rename TeeMeasurementProtocol to CcMeasurementProtocol ba= sed
> >    on the discussion in below links:
> >    https://edk2.groups.io/g/= devel/message/82876
> >    https://edk2.groups.io/g/= devel/message/82999
> >    https://edk2.groups.io/g/= devel/message/83000
> >    With this protocol, CC based measure boot is su= pported.
> >    TD based measure boot is one of the CC based me= asure boot.
> >  - The spec will be updated according to the changes later.<= br> > >  - TdProtocol.h is deleted. Its content is merged into CcMea= surement.h.
> >  - Add gEfiCcFinalEventsTableGuid definition in MdePkg.dec > >  - Update the description in DxeTpm2MeasureBootLib.inf
> >    and DxeTpmMeasurementLib.inf
> >
> > v3 changes:
> >  - Rename TdProtocol to TeeMeasurementProtocol which is a ne= utral name.
> >    With this protocol, TEE based measure boot is s= upported.
> >    TD based measure boot is one of the TEE based m= easure boot.
> >  - The spec will be updated according to the changes later.<= br> > >  - Fix errors in DxeTpm2MeasureBootLib.
> >
> > v2 changes:
> >  - TD based measure boot is implemented in DxeTpm2MeasureBoo= tLib.
> >    This minimize the code changes.
> >  - TD based measurement is added. It is implemented in
> >    DxeTpmMeasurementLib.
> >  - Fix the typo in comments.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Ken Lu <ken.lu@intel.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> > Tested-by: Min Xu <min.m.xu@intel.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> >
> > Min Xu (3):
> >   MdePkg: Introduce CcMeasurementProtocol for CC Guest = firmware
> >   SecurityPkg: Support CcMeasurementProtocol in DxeTpm2= MeasureBootLib
> >   SecurityPkg: Support CcMeasurementProtocol in DxeTpmM= easurementLib
> >
> >  MdePkg/Include/Protocol/CcMeasurement.h   &n= bsp;   | 302 +++++++++++++++
> >  MdePkg/MdePkg.dec       =             &nb= sp;         |   6 +
> >  .../DxeTpm2MeasureBootLib.c     &n= bsp;            = ; | 343 ++++++++++++++----
> >  .../DxeTpm2MeasureBootLib.inf     =             | &= nbsp; 3 +-
> >  .../DxeTpmMeasurementLib.c     &nb= sp;            =   | 122 ++++++-
> >  .../DxeTpmMeasurementLib.inf     &= nbsp;            |&n= bsp;  9 +-
> >  6 files changed, 686 insertions(+), 99 deletions(-)
> >  create mode 100644 MdePkg/Include/Protocol/CcMeasurement.h<= br> > >
> > --
> > 2.29.2.windows.2
>
>
>
>
>

--_000_AS8PR08MB6806583834EB2BDF211DA9FC84749AS8PR08MB6806eurp_--