From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre Gondois <Pierre.Gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"dandan.bi@intel.com" <dandan.bi@intel.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
"michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v1 0/2] Define AML_NAME_SEG_SIZE
Date: Wed, 2 Jun 2021 11:30:55 +0000 [thread overview]
Message-ID: <AS8PR08MB6806CAC7CCD75A679B4B0FDA843D9@AS8PR08MB6806.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210601220450.28003-1-Pierre.Gondois@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]
Pushed as b5379899b38e..1f515342d8d8
Thanks.
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Tuesday, 1 June 2021 at 23:05
To: devel@edk2.groups.io <devel@edk2.groups.io>, dandan.bi@intel.com <dandan.bi@intel.com>, gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>, michael.d.kinney@intel.com <michael.d.kinney@intel.com>, Sami Mujawar <Sami.Mujawar@arm.com>, Alexei Fedorov <Alexei.Fedorov@arm.com>
Subject: [PATCH v1 0/2] Define AML_NAME_SEG_SIZE
From: Pierre Gondois <Pierre.Gondois@arm.com>
There is currently multiple AML_NAME_SEG_SIZE define in the edk2
repository. One in the MdeModulePkg and one in the DynamicTablesPkg
package. Since the value can be inferred from the ACPI specification,
it could be moved to MdePkg/Include/IndustryStandard/ and avoid
re-definitions
The two patches should be merged at once to avoid having
multiple definitions of AML_NAME_SEG_SIZE.
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1750_Add_AML_NAMESEG_SIZE_v1
The results of the CI can be seen at:
https://github.com/tianocore/edk2/pull/1681
Pierre Gondois (2):
MdePkg/MdeModulePkg: Move AML_NAME_SEG_SIZE definition
DynamicTablesPkg: Use AML_NAME_SEG_SIZE define
.../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 4 ++--
.../AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 4 ++--
DynamicTablesPkg/Library/Common/AmlLib/AmlDefines.h | 9 +--------
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h | 1 -
MdePkg/Include/IndustryStandard/AcpiAml.h | 7 ++++++-
5 files changed, 11 insertions(+), 14 deletions(-)
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 4790 bytes --]
prev parent reply other threads:[~2021-06-02 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 22:04 [PATCH v1 0/2] Define AML_NAME_SEG_SIZE PierreGondois
2021-06-01 22:04 ` [PATCH v1 1/2] MdePkg/MdeModulePkg: Move AML_NAME_SEG_SIZE definition PierreGondois
2021-06-02 2:28 ` 回复: " gaoliming
2021-06-01 22:04 ` [PATCH v1 2/2] DynamicTablesPkg: Use AML_NAME_SEG_SIZE define PierreGondois
2021-06-02 6:13 ` [edk2-devel] [PATCH v1 0/2] Define AML_NAME_SEG_SIZE Zeng, Star
2021-06-02 8:33 ` Sami Mujawar
2021-06-02 11:30 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB6806CAC7CCD75A679B4B0FDA843D9@AS8PR08MB6806.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox