From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.71]) by mx.groups.io with SMTP id smtpd.web10.11542.1676284996183930480 for ; Mon, 13 Feb 2023 02:43:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=h+nwcmk7; spf=pass (domain: arm.com, ip: 40.107.22.71, mailfrom: sunny.wang@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A61JaFsgm5m8p7asUisL6miSIE2UEVNCsrmTE/7AEA8=; b=h+nwcmk7Qv1f4riiILIFKyG+f4v7jjiGkiUGOLUQoARFD3EycxlXU5zXNxuIFYk6F7yqt+zqTcJCDUxheFLOWs/oyW5VHMdBo51IJ3AMXhItVdgMfltw2qUCCoP6hdoN5dM71uYt+PrDBkZlqQnpF82n6MaRGztteBBXgJwdTro= Received: from AS9PR05CA0027.eurprd05.prod.outlook.com (2603:10a6:20b:488::18) by AS8PR08MB9956.eurprd08.prod.outlook.com (2603:10a6:20b:637::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 10:43:13 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::c3) by AS9PR05CA0027.outlook.office365.com (2603:10a6:20b:488::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 10:43:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 10:43:13 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Mon, 13 Feb 2023 10:43:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f99b5351c7fe8a38 X-CR-MTA-TID: 64aa7808 Received: from a662fc18000d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A59C8596-0403-4838-BD7D-892F81895739.1; Mon, 13 Feb 2023 10:43:06 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a662fc18000d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Feb 2023 10:43:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9HrBNq410wMIcJ56TDAVQh3vm7/SzmEbV3Mh4L0SlESvA6IAXNjzxzbb9Qbh6pPSOdfTFDCNixXH1UOt9WsRR05pb+lUtEngNP7aIIIp837ZhPsb2r6eJ+6l1PZpgovd/AwOqabqdf81jcZEnD2HyWwKrJPSCV/vVj3JkEquqkl8HNCY7m4CZbXaVvWviKp/mp+Uu3m4Wn6RMBvHlAzcDafAz9jyJKWU2VtRrwwQEuR0iZutu95+frvV9RE/81vXTsuQJXXHksoTcX2CDX66ZKidMns2ZKIB1qJnAvVlPQwkXxEPKS6A5mVFwOiXNfgREzVTocfZt1L2OXYk/OgSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A61JaFsgm5m8p7asUisL6miSIE2UEVNCsrmTE/7AEA8=; b=TO42CV2CsZTdBVp8/NpGZJcTNRL0UM0xNcjFxUK+PWgKFFnv87MYekZfq1nlqRfHPVpmuihBm1HeNGFRCdPPeKafvYl/4ZGWlQrBtazVUNEvY6xZkr/xpySWEdm7y58FvjIw4CASKa1aykEiZrBp7kj6xgn4fLS9CpRjNfG77dEbAmmAQWBj/3US+wBUJWGfsHFozkypZq/iEqNjdLsCT909viAvoKTYR3EJaiaBY5qZIdcOqp/tKWoBAJ4ql3IrlvTshxiXFeTpq/JtXk0H4wCy6Mrcz6DWa3hOu8+d5wmc5vBYR8Ecx1cmX97nyOtHbxfgWvi4DETWY12vV+4Hkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A61JaFsgm5m8p7asUisL6miSIE2UEVNCsrmTE/7AEA8=; b=h+nwcmk7Qv1f4riiILIFKyG+f4v7jjiGkiUGOLUQoARFD3EycxlXU5zXNxuIFYk6F7yqt+zqTcJCDUxheFLOWs/oyW5VHMdBo51IJ3AMXhItVdgMfltw2qUCCoP6hdoN5dM71uYt+PrDBkZlqQnpF82n6MaRGztteBBXgJwdTro= Received: from AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6) by GVXPR08MB8211.eurprd08.prod.outlook.com (2603:10a6:150:17::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 10:42:57 +0000 Received: from AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::84ca:d9e0:be2a:1a68]) by AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::84ca:d9e0:be2a:1a68%3]) with mapi id 15.20.6086.023; Mon, 13 Feb 2023 10:42:57 +0000 From: "Sunny Wang" To: Stuart Yoder , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" , "hao.a.wu@intel.com" , Sunny Wang Subject: Re: [PATCH] MdeModulePkg/Variable: Attribute combination should return EFI_UNSUPPORTED Thread-Topic: [PATCH] MdeModulePkg/Variable: Attribute combination should return EFI_UNSUPPORTED Thread-Index: AQHZPNZBAoRVP8NwhEGsv43z+b8kH67MtMxA Date: Mon, 13 Feb 2023 10:42:56 +0000 Message-ID: References: <20230209223058.199878-1-stuart.yoder@arm.com> In-Reply-To: <20230209223058.199878-1-stuart.yoder@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7791:EE_|GVXPR08MB8211:EE_|AM7EUR03FT032:EE_|AS8PR08MB9956:EE_ X-MS-Office365-Filtering-Correlation-Id: 82b3ec03-823b-4701-9fa1-08db0daf1b7d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3awcgOnRTm7RzNUYXZf5gMBSxMvsQUORaQDj1MAz/UAn5ZNMZO1RRP4Yh9ICaP/Jb7jCmFI3nNexxCeF65nktzntLMBdAzkOl7kHT0wyIQ9PD4ytTXX9O4K7qUlD0UbgMwHHGnb43ArnNQw5EgiGBP7ItUM/TI69b4Giuje59H/5wkpsSjb8s52pmJGBJxR9Cqw1/83Lf85s0BGzeQkA4k7qZD74XMSofKtEBN7uJU2loHmc8wn4ib4oLwbPxTFAjrNqyaE+pk9MA8LO1JJpta80GbIaCS9oeM0acC/+FluuKfirWxQeQK30rR9+dUqieR50W6DrRZM7SmCMmBKzYJj/8Gg0Gv9em85NUevW65ZyYb4AKojvSYNIxm2RAWLpD5keuNR2Pk5Ks3nWdbqJr0Dql5o4zVkAhzxLqtaSsOcjnAhleDkvA0lvhgoPyhdhGzVOaA4IZt01RFiOJA2c+l1eJDg9yQYmoPcZO84Y+PzrxPzd4Jwm11TCv88w/6EgsjYMRHwMot+58AAti+6GxczUGdjyWdEsN6gp8p0cwP38knV2he5IajmIFluh2kTfe89y10mOEPled2lmp81K2FIfE4VzUeresaLrGgT0HgJfCFfmgELnDSVZawJwGaZOuzfiBjArieI+1HmIipRFU17cFaLnTdFSDL2BPWi1Aq8ltWmzeBxHuCS1nBh4m6g9EB2g9vwInBIcnA04YxQ8yGCmQy8y35tbKIKQ2+DCbgg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7791.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199018)(66476007)(66446008)(64756008)(66556008)(66946007)(4326008)(83380400001)(8676002)(76116006)(41300700001)(316002)(52536014)(8936002)(110136005)(54906003)(7696005)(9686003)(71200400001)(55016003)(33656002)(2906002)(5660300002)(186003)(966005)(26005)(478600001)(6506007)(53546011)(38070700005)(38100700002)(86362001)(122000001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB8211 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 64a46ddb-316f-4f10-ca78-08db0daf11a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 37OdjBXbt5lGsyPM1dEGOMf03pbFjWWDDHfwIeOR0kgwwcqWu4qnw33xl7RyJ+i+AHBqECZBA0/zX0sNOVrYZvPJLgnEbZf4UK4ltoUWT4OIx3m0bTYXFYOHYhPqL0HH4dUdbEObqOaQngLwEL349byR5Ts5Q0ClM5CdCtesxultLlOPnhNtLo7VrV0vSydLisfPcsTxNX7xphJeXQfoG9t7+0pWSwDXTLd5PzuQQk/zEG3H4LpWUHOF/W6FoM0rpS6OF2ugy+TBQEghx9TNkvrZH3FTKIJOrU/T4vsnDCsxo0Q+U5I/p7uk5fZJK7pNc02b28Ojgwk0m5gRrG27pf6zzenMrxwXtIS+LPDSaBiTQKn0gXhLsKs3If/uCpgneetuEVSwbKy689EH43/mEXGnJ+C8Szz7rFD4oesMCoiLHViJ4jvlDbkMdtXddAIyEZYmK6EoTi4Rc19L5tH9YRHxTfMkkj12jToLV8PBQ18sau8H4TE4t2XoBKOt3vBessrw8TLitIiMKS6lPnrGN4vnXCBO/QMOv52JrZXANFnl48bG1F50nEI4jo6KnN+JTXW0sMOTG1DNMbTDCWXSVbKP+90fEL93ATNhjMIx9iNLJZW2hlnwv5Kz+bTTzPNM1/03KyDKcvSYoSo4nhKz57Lb5YOmIe1aDypuTx1NmbjgKtlw3HKUpYHAxW11GADLzjF6x4eccgth7R/HK1+kn207kHu1vEfyyX9oaaTf8W0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(83380400001)(36860700001)(4326008)(8676002)(81166007)(316002)(55016003)(41300700001)(110136005)(54906003)(82310400005)(82740400003)(70586007)(70206006)(47076005)(336012)(478600001)(40480700001)(33656002)(2906002)(5660300002)(8936002)(356005)(40460700003)(52536014)(7696005)(53546011)(9686003)(6506007)(186003)(86362001)(966005)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 10:43:13.4087 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 82b3ec03-823b-4701-9fa1-08db0daf1b7d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9956 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Thanks, Stuart. Reviewed-by: Sunny Wang -----Original Message----- From: Stuart Yoder Sent: 09 February 2023 22:31 To: devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn; hao.a.wu@intel.com; Sunny Wang Subject: [PATCH] MdeModulePkg/Variable: Attribute combination should return= EFI_UNSUPPORTED REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4341 Commit 21320ef66989 broke some tests in the AuthVar_Conf test in edk2-test. There are 2 testcases that invoke SetVariable with the following attribute value: (EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS) EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and the UEFI spec says this should return EFI_UNSUPPORTED. Cc: Liming Gao Cc: Hao A Wu Cc: Sunny Wang Signed-off-by: Stuart Yoder --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeMod= ulePkg/Universal/Variable/RuntimeDxe/Variable.c index 6c1a3440ac..14c176887a 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c @@ -2676,7 +2676,11 @@ VariableServiceSetVariable ( // // Only EFI_VARIABLE_NON_VOLATILE attribute is invalid // - return EFI_INVALID_PARAMETER; + if ((Attributes & EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS) !=3D 0) { + return EFI_UNSUPPORTED; + } else { + return EFI_INVALID_PARAMETER; + } } else if ((Attributes & VARIABLE_ATTRIBUTE_AT_AW) !=3D 0) { if (!mVariableModuleGlobal->VariableGlobal.AuthSupport) { // -- 2.34.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.