Thanks for fixing the issue, Sam.

The change looks good to me. However, I just did a quick search and found 9 instances of "RANDOM_NAME_PROTOCOL". Do we need to also change another 5 instances?

Best Regards,

Sunny

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: 30 January 2023 12:16
To: devel@edk2.groups.io; Sam Kaynor <Sam.Kaynor@arm.com>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL

It looks like the cc list wasn't populated correctly.

I've cc'd the people mentioned in the commit message.

On 10/11/22 11:54, Sam Kaynor wrote:

Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in

RandomNumberBBTestConformance and RandomNumberBBTestFunction

to "RANDOM_NUMBER_PROTOCOL".

Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>

Cc: Barton Gao <gaojie@byosoft.com.cn>

Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>

Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

Cc: Eric Jin <eric.jin@intel.com>

Cc: Arvin Chen <arvinx.chen@intel.com>

Cc: Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>

Signed-off-by: Sam Kaynor <sam.kaynor@arm.com>

---

 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++--

 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c    | 4 ++--

 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c

index 2738a4899457..364aaca925e0 100644

--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c

+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c

@@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (

                    StandardLib,

                    EFI_TEST_ASSERTION_WARNING,

                    gConformanceTestAssertionGuid001,

-                   L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",

+                   L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",

                    L"%a:%d: Status - %r",

                    __FILE__,

                    (UINTN)__LINE__,

@@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (

                  StandardLib,

                  AssertionType,

                  gConformanceTestAssertionGuid001,

-                 L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",

+                 L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",

                  L"%a:%d: Status - %r, RNGAlgorithmListSize - %d",

                  __FILE__,

                  (UINTN)__LINE__,

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c

index 3d41085d2243..0ba003449dc6 100644

--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c

+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c

@@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (

                    StandardLib,

                    EFI_TEST_ASSERTION_FAILED,

                    gTestGenericFailureGuid,

-                   L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",

+                   L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",

                    L"%a:%d: Status - %r",

                    __FILE__,

                    (UINTN)__LINE__,

@@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (

                    StandardLib,

                    EFI_TEST_ASSERTION_FAILED,

                    gTestGenericFailureGuid,

-                   L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",

+                   L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",

                    L"%a:%d: Status - %r",

                    __FILE__,

                    (UINTN)__LINE__,