From: "Sunny Wang" <Sunny.Wang@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Sam Kaynor <Sam.Kaynor@arm.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Sunny Wang <Sunny.Wang@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values
Date: Thu, 5 Jan 2023 16:28:57 +0000 [thread overview]
Message-ID: <AS8PR08MB77916A47F826B2B4B403DAEA85FA9@AS8PR08MB7791.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20221109151036.2164337-2-sam.kaynor@arm.com>
Looks good to me. Thanks, Sam.
Just for others' reference. I also had an offline discussion with Samer and got some clarifications below:
1. The default strings (SMBIOS PCDs) in ArmPkg\ArmPkg.dec are L"", so the UNI files should be changed to match the PCD values.
2. As for the case where system vendors want to use FWTS to catch the SMBIOS string issues (check if the data in FRU is updated properly) in the factory, they should change their default value rather than counting on these wrong default values in UNI files.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sam Kaynor via groups.io
Sent: 09 November 2022 15:11
To: devel@edk2.groups.io
Cc: Sam Kaynor <Sam.Kaynor@arm.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values
Current default value for DMI tables in uni files is "Not Specified".
This causes an error when running FWTS tests. To avoid these errors,
and align more accurately with the SMBIOS spec, this value should
be changed to "".
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Sam Kaynor <sam.kaynor@arm.com>
---
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++----
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++-------
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++-----
5 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni
index 22b3c64d9fe2..a86695ea3e29 100644
--- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni
+++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni
@@ -15,10 +15,10 @@
//
// Processor Information
//
-#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "Not Specified"
-#string STR_PROCESSOR_MANUFACTURE #language en-US "Not Specified"
-#string STR_PROCESSOR_VERSION #language en-US "Not Specified"
-#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "Not Specified"
-#string STR_PROCESSOR_ASSET_TAG #language en-US "Not Specified"
-#string STR_PROCESSOR_PART_NUMBER #language en-US "Not Specified"
+#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US ""
+#string STR_PROCESSOR_MANUFACTURE #language en-US ""
+#string STR_PROCESSOR_VERSION #language en-US ""
+#string STR_PROCESSOR_SERIAL_NUMBER #language en-US ""
+#string STR_PROCESSOR_ASSET_TAG #language en-US ""
+#string STR_PROCESSOR_PART_NUMBER #language en-US ""
#string STR_PROCESSOR_UNKNOWN #language en-US "Unknown"
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni
index a3f068cdcca2..6f1c360c0aaf 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni
@@ -11,8 +11,8 @@
/=#
-#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified"
-#string STR_MISC_BIOS_VERSION #language en-US "Not Specified"
-#string STR_MISC_BIOS_RELEASE_DATE #language en-US "Not Specified"
-#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified"
+#string STR_MISC_BIOS_VENDOR #language en-US ""
+#string STR_MISC_BIOS_VERSION #language en-US ""
+#string STR_MISC_BIOS_RELEASE_DATE #language en-US ""
+#string STR_MISC_BIOS_VENDOR #language en-US ""
#string STR_MISC_BIOS_RELEASE_DATE #language en-US "12/02/2020"
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
index 2b3b19cab2ea..d8f73a3ffc74 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
@@ -11,9 +11,9 @@
/=#
-#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified"
-#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified"
-#string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified"
-#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified"
-#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified"
-#string STR_MISC_SYSTEM_FAMILY #language en-US "Not Specified"
+#string STR_MISC_SYSTEM_MANUFACTURER #language en-US ""
+#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US ""
+#string STR_MISC_SYSTEM_VERSION #language en-US ""
+#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US ""
+#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US ""
+#string STR_MISC_SYSTEM_FAMILY #language en-US ""
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni
index 0f0fb1f93bbb..9f36e5ff1998 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni
@@ -11,10 +11,10 @@
/=#
-#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "Not Specified"
-#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "Not Specified"
-#string STR_MISC_BASE_BOARD_VERSION #language en-US "Not Specified"
-#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "Not Specified"
-#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "Not Specified"
-#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "Not Specified"
-#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "Not Specified"
+#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US ""
+#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US ""
+#string STR_MISC_BASE_BOARD_VERSION #language en-US ""
+#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US ""
+#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US ""
+#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US ""
+#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US ""
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni
index 9512b354fe9a..77cbe27d8f7a 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni
@@ -11,8 +11,8 @@
/=#
-#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "Not Specified"
-#string STR_MISC_CHASSIS_VERSION #language en-US "Not Specified"
-#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "Not Specified"
-#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "Not Specified"
-#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "Not Specified"
+#string STR_MISC_CHASSIS_MANUFACTURER #language en-US ""
+#string STR_MISC_CHASSIS_VERSION #language en-US ""
+#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US ""
+#string STR_MISC_CHASSIS_ASSET_TAG #language en-US ""
+#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US ""
--
2.34.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96134): https://edk2.groups.io/g/devel/message/96134
Mute This Topic: https://groups.io/mt/94914659/5985097
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com]
-=-=-=-=-=-=
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2023-01-05 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 15:10 [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Sam Kaynor
2022-11-09 15:10 ` [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Sam Kaynor
2023-01-05 16:28 ` Sunny Wang [this message]
2023-01-30 12:10 ` [edk2-devel] " Rebecca Cran
2024-09-06 17:38 ` [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Nhi Pham via groups.io
2024-09-09 8:00 ` Sami Mujawar
2024-09-10 0:08 ` Nhi Pham via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB77916A47F826B2B4B403DAEA85FA9@AS8PR08MB7791.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox