From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.84]) by mx.groups.io with SMTP id smtpd.web09.3885.1660920436967155848 for ; Fri, 19 Aug 2022 07:47:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0b/HQRvb; spf=pass (domain: arm.com, ip: 40.107.21.84, mailfrom: sunny.wang@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JvG1XNFJhm+YIVs8Hc0IRSs6JsOvlx1nQXPc3rNo/Ghzce11XZwMQW50QKLlVOE5US34YhA8tjeZZZSdRXS/5+ZJAwde7jE1J+dWYSjLpt4TLjR2JQM2b6385T8bH954otn2abBoaO/I1RsJxFROWROmmY7ef4IxOHJOcvnyvg1LA2Maofd5tdVQ8oK+SDOS898DpsJffe40pPh7hj/qcuULzBaNf3de2pcss8BO/YSvqtZFXydZMjPzXlweElq4ttZ7gzI3Vjzu8pIxz+m+Rd/hKW8COhY8tHcl4JE5zZjflcxEd9O4fYypE82bqViQCyLWsXQark3CaeN/z00GFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U39kjM9dG8lldx1j5hwY3vaJld42vDfuKvvc+PYTglM=; b=oPVo71h9qRWvlh8MmgRMBwd5c18al0L8LMd+WvzsKbhpVTP0S+dqe+iS8AxrW9d77iV6HuEE16xZBfWk2YLodu4BpekNFQjbj4XPHboPKsFfckjeKRbHj6UpT7npVvYAou9OQnmYrccThSg/1zExhIuEWBBXXX6MiJC9QxHghexbpyLNRpZ+HtdyQK+ba+SVCZyNk/9vifhhS9b91YPHjjpjgNKp+VY7HggtiskTG1uE3LqHUnrcDgTEiy/NpuJVlh7usspZm4RtvNsK8O7KVKLaRD8Ic5Vz2SeO0nP/VF6Ng6QCJfbiqpRiXPK2LeZaMrk+eNNJEMZVjC+DCWw2pg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U39kjM9dG8lldx1j5hwY3vaJld42vDfuKvvc+PYTglM=; b=0b/HQRvbGaTqGGZjQclaYPVduQp3qtp3kQXYTLrzC/bSYD4ej/4yd3Nf7mckUAkEkBRpKKyGaa3zj1awbTdq8y46iUnfkl7PWI6CkiMDBauiDZOpnBXohnqMiaXlWM/SRkwcwv7s3iHV5e+C4lmez5kus5Emea9ItxPwbOZOLkU= Received: from AS9PR04CA0098.eurprd04.prod.outlook.com (2603:10a6:20b:50e::29) by DB8PR08MB4169.eurprd08.prod.outlook.com (2603:10a6:10:ab::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Fri, 19 Aug 2022 14:47:13 +0000 Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::44) by AS9PR04CA0098.outlook.office365.com (2603:10a6:20b:50e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19 via Frontend Transport; Fri, 19 Aug 2022 14:47:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Fri, 19 Aug 2022 14:47:12 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Fri, 19 Aug 2022 14:47:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6595c53cbabda0e0 X-CR-MTA-TID: 64aa7808 Received: from 4472629eaffc.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 92618C3C-EB67-470A-810D-FD8DDC1FD08F.1; Fri, 19 Aug 2022 14:47:01 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4472629eaffc.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 19 Aug 2022 14:47:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bv5+SKwY1CgIvrx3h0TTTISVNnIVfwc+H/KGdV+g5MF1Z1YOR9U1uSkIsNCrxOk/Smfj0hbUUQSOFhTQ0iNqfvSvbJw3tdV06D2yVAXhgfONr866Ao+nK781OGDui31bvIYdlF6qwWtGLaApVFOFQ4u4wsH0AUe3Un8wC/Yv+L3uHyGOBz3J/kvl4knWhZFkzG/tcNiS9/G+9GV4J4bABWtmkPhpw37gSd3tHRs967X/L8PrdmhLizBEWOj6MxQdIqv0E7dXHJxP5ZAxqzwBqSlp2SupQj/QIiD8lUmgfBUu5Y8pB9SresiGFG34UNtbFs9Oz4sUJ+cw9cIwf22OHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U39kjM9dG8lldx1j5hwY3vaJld42vDfuKvvc+PYTglM=; b=EkO13b+e4RacOaFqaxhs7o3Ru375/NVJxZUPenahu3Z+ZTnb2MTP6o/iWBZj/z3CwsfNjR2pNwE35giwHRH4VuWbBhCkrYOHfJvy2BqPqvN30yfTayd7lLM1jvb+ij/q/cjyQLe1IKksr8OJu8KovoqOEW0t3fpbMrIJ0LE/zNv/4AdRfsSDfhGYePvJqUL3+WPEZ93m/2O19nCSvNrFmFyfOaX8SdJgknKVulQvkgpbG/VVeW5m30FqB0+XW3SqnCMNawWUzqrT9Ef4AQoZQhf7ev8Tepq1SCrveEDgtqUxO3BraaTSaujONWLebCu6t4niPRTmHC4S7xHem3YaEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U39kjM9dG8lldx1j5hwY3vaJld42vDfuKvvc+PYTglM=; b=0b/HQRvbGaTqGGZjQclaYPVduQp3qtp3kQXYTLrzC/bSYD4ej/4yd3Nf7mckUAkEkBRpKKyGaa3zj1awbTdq8y46iUnfkl7PWI6CkiMDBauiDZOpnBXohnqMiaXlWM/SRkwcwv7s3iHV5e+C4lmez5kus5Emea9ItxPwbOZOLkU= Received: from AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6) by AS8PR08MB7224.eurprd08.prod.outlook.com (2603:10a6:20b:347::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Fri, 19 Aug 2022 14:46:58 +0000 Received: from AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::c82b:abaa:ee57:a155]) by AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::c82b:abaa:ee57:a155%8]) with mapi id 15.20.5546.016; Fri, 19 Aug 2022 14:46:58 +0000 From: "Sunny Wang" To: Dimitrije Pavlov , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Liming Gao , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: Re: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName Thread-Topic: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName Thread-Index: AQHYskaUU8c00cDW102LsHCn8OvcTK22UAxw Date: Fri, 19 Aug 2022 14:46:58 +0000 Message-ID: References: <20220817143503.3279277-1-dimitrije.pavlov@arm.com> In-Reply-To: <20220817143503.3279277-1-dimitrije.pavlov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d256a0d4-ab43-42a8-83bd-08da81f1b3b7 x-ms-traffictypediagnostic: AS8PR08MB7224:EE_|VE1EUR03FT058:EE_|DB8PR08MB4169:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FVw3/XI9vakyoXTxi6xxPEpq2T78lVnkzpD1NzKhOPrlbzCIs5PklteLR6d7FJDTiByg6RPSXyCNIardjVS/Txxnrn7LyaE9VCTxXyUjkAZ0U5ojqt7tcoVSC7FQck16/80zBl0AwxmDbuL8NsWiLOochwmVtW+WeE8v8m59w8GFm2P6mi1ckNvHOOVfwu4KjYLd9G7oR5e1uH2x4N/1EP8nUG+9zW+71KjnW4LMPQ7Z68QwVsWEAK7Vh2e73qym/laqiGXtDNCs4Ghju9lL8922OomvrkzvKopucRMYmGkwsLZoKIx18l68S7ItclKnZtT6UHQ2nZSvnt+V776EGf/M5Ix93TDmh8yvH/T2LuVGQUQvYunqDw2MDiqdKQKZLNhCCaVWS9s1b2bFm7vJIzunck9fmqKHk4p9FWclweyzSOW/ZNklmFLNpPzstAUQ3UuRLgQEOX5bVD09Ul8uc3THKOfwLCeoc4J4fGo5r5CoYa1Ujv8KNjbsZl+tG4jueL5r7hJl/aYtroMDw+i4bH+t8kFIz5HSUpHxVB1xjLT55cMJ9Sl6ACCrLDutlWiqmNP/5XfbWjSYywe+7gQAyUMAD6yjMzTONXSUXv88O9IYX8PROcuJHdgkEBDnMZ1womobU/qaTdjlK3lIA0vGVhU4u2omGlFUF5ea+e6/rmG70idKYozkEPRScqkGkOhVvJjS3wFMIaIaRmkJgW1dYUPLe98eDsFatsHXVqa4J8AX/pOVQT5W77FIUsaCGX8brF1Vo1YEyX8iI8IMg5tZGg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7791.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(55016003)(8676002)(5660300002)(478600001)(71200400001)(54906003)(316002)(41300700001)(66556008)(2906002)(8936002)(66946007)(4326008)(64756008)(66446008)(52536014)(76116006)(66476007)(9686003)(86362001)(53546011)(38100700002)(38070700005)(7696005)(33656002)(110136005)(186003)(6506007)(122000001)(26005)(83380400001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7224 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 47ff6d7b-5fa6-4cd2-b768-08da81f1ab0f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ix986BCbK3El+Kc0fGDRFKJLyg0DBpwVxei0lxTFbGHO2NkCNrHHZ4yyacFFqUE9ElIUZK6cP/fsf5LTWsqigPdCmjZPnbPbQeVq6vxu8gPcK4dw8lPbh8DmZvk6OISBs9pkyWi7MPB3ZKEBDh5vsuJMjqiRQoEqGOpw0SM21rqQR13lzw6yvgUsD16ahCVFQUE+YzcAAzRiztRPUM4UHBAYRa+R+0GwyMwN3lcQYOAHVSRubXNIG2+1buqpoFqhd8tA+ivKSj+cxhOtLQdOGPZqCt4WEwb7wm0FRmiPydTso1NNTnZUUQW9OVE5XRz9pwXe/sSb/qBx6DGQWhnTwZHIvWFvJ8pZ0Hg/53aBoS/687ZmbVVJ0zunaNf3xwN2QfdCy6UbRiSoHwvf2uvdQxxeFzZ14c4UpA+rmCcBCfx19N0WFwxgmtGk0ij3tDuHakQUnBMSvtKYuddN0YYzglX3pc6GZgYoVZrvjI+8yfqS0r4lXYDe4IKpLwv8hYMBcj6mgu92PEQIGr3HdIq1t+cAcl6ZKG9F79W4YespoivwVy8ovpVrRZSD10AFz9UgPha4hcnoGgpJaPJB4KccpOrCMycsO3BG/P0UyYKqAdIitMIzXvaGOw5eKAS/kKPUBto5Gfk5Rb9WJAWS2+HgXAXqPDlZ3/K7VtCY+w6prfL7tPKN1qLdQcJVjfs+RaN7x11MpjfnNkWCwBWv06HxJ+6l+GIazh7gy4QDrEYCKUsrpyWzrtyyochb0+uIJGBfBK+0Yp6+/87OH1Bv1rL/Aw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(136003)(396003)(40470700004)(46966006)(36840700001)(55016003)(54906003)(9686003)(40480700001)(316002)(26005)(110136005)(478600001)(8676002)(356005)(4326008)(70586007)(81166007)(70206006)(5660300002)(41300700001)(82310400005)(83380400001)(36860700001)(82740400003)(8936002)(336012)(40460700003)(52536014)(53546011)(7696005)(6506007)(2906002)(86362001)(47076005)(186003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 14:47:12.7346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d256a0d4-ab43-42a8-83bd-08da81f1b3b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4169 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good. Reviewed-by: Sunny Wang -----Original Message----- From: Dimitrije Pavlov Sent: 17 August 2022 15:35 To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Jiewen Yao ; Liming Gao ; Sunny Wang ; Jeff Booher-Kaeding ; Samer El-Haj-Mahmou= d Subject: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in= GetControllerName Per the UEFI specification, a device driver implementation should return EFI_UNSUPPORTED if the ChildHandle argument in EFI_COMPONENT_NAME2_PROTOCOL.GetControllerName() is not NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov --- OvmfPkg/VirtioNetDxe/ComponentName.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/OvmfPkg/VirtioNetDxe/ComponentName.c b/OvmfPkg/VirtioNetDxe/Co= mponentName.c index e340ca2f8fe4..718096630f6f 100644 --- a/OvmfPkg/VirtioNetDxe/ComponentName.c +++ b/OvmfPkg/VirtioNetDxe/ComponentName.c @@ -129,6 +129,13 @@ VirtioNetGetControllerName ( return EFI_INVALID_PARAMETER; } + // + // This is a device driver, so ChildHandle must be NULL. + // + if (ChildHandle !=3D NULL) { + return EFI_UNSUPPORTED; + } + // // confirm that the device is managed by this driver, using the VirtIo // Protocol -- 2.37.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.