Looks good. Thanks, Edhaya.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>
-----Original Message-----
From: G Edhaya Chandran via
groups.io <edhaya.chandran=arm.com@groups.io>
Date: Tue, Oct 22, 2024 at 10:36 PM
Subject: [edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test
To: <devel@edk2.groups.io>
The DevicePathBBTest wrongly flags the failure for a valid VLAN device
path node. For e.g. value 4040
The range check for vlanId is corrected to fix this issue.
https://bugzilla.tianocore.org/show_bug.cgi?id=4710
Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
index c8757e958a22..21c286ea4096 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
@@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest (
//
else if ((Type == 3) && (SubType == 20)) {
Vlan = (VLAN_DEVICE_PATH *) DevicePath;
- if (Vlan->VlanId > 4094 || Vlan->VlanId) {
+ if (Vlan->VlanId > 4094) {
AssertionType = EFI_TEST_ASSERTION_FAILED;
} else {
AssertionType = EFI_TEST_ASSERTION_PASSED;
--
2.25.1
------------
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120661):
https://edk2.groups.io/g/devel/message/120661
Mute This Topic:
https://groups.io/mt/109165242/5907162
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [sunny.hsuanwen.wang@gmail.com]
------------