From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.80]) by mx.groups.io with SMTP id smtpd.web12.8189.1657808297365842792 for ; Thu, 14 Jul 2022 07:18:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=+KpQ+Jom; spf=pass (domain: arm.com, ip: 40.107.13.80, mailfrom: sunny.wang@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cH/buowjQ5VsuO5OLS7oRznhNOTXNugWsY86+N3TLxs5G5pH/EFxuaiKOhK9W9mK+MAlaVQrvfXNa+HobQV5jRKoib9K/Ht7LduEDQOirBRlYmX7/ZTp8Ekg2T7im/QEJnmEqzhG4qZWj4w7zgV6izsoLF0C2RfCJKzpUECHDroGn8Wiw6HiJ38N15mbvqb9B2bQjTz6wzaXUbQhGtu7/jW7tFkone+900lP1JHlbxQQ+BcvovMgD23p08P226xZ1NiYJx7jop2phxENA4DVQk75GVwEEmOLiIoAwXrsYeYrHeytVqknmr7R3qvtkxqoXYEoGR6VTHpDxdIAI9fbuA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ldm04IOPvn146SbAEQrnzO6Iga22PveUl+H154s0k2s=; b=oVdjgWbH7f1zQMDKXrfCwSfLhFlNXcgN9YkTCcdoQjDUz4QbJzvGpeW4xCv6a6MSHP6cZtuFTfl0yXQMp+MJHSn8oDvGXsXX0EM/Ox1zQCoPwEJdlIBUNM5vIAgwm8sjfNtUVHf90k6z7uwKCreK2juxwuSL/9codim3vM8xWMTI9U6+Ldif+o+Tma16CM+fQSdduy53qeUPoVXstx+sjZvfhp3NSkaoKMzS1gIo6jo1755Shv7nBxBIYmhxFZA96WIXXy0i01wT7/cgkjY6k3Qufvkr6BZe8WldZd5FLYI0OZuVJvFUvtHrtRqg6l3dYLkxgfH/6W4I91t2laI8fg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ldm04IOPvn146SbAEQrnzO6Iga22PveUl+H154s0k2s=; b=+KpQ+Joma+NCyJh53TIEmna/+Dejy5Fp135OKFvWBgcwz6qpeVf5LOC4KZZbEPaoE2ueIjzG/AkkeRigIoSjre6SKA6PHXt9lM5qFFSzcI9EuxdKgAqzxKrm8CdlNFQXdHF30AST+AImSP3rsvBYmMxhbT0ilMx+n3al3J5IHrs= Received: from AM6PR05CA0031.eurprd05.prod.outlook.com (2603:10a6:20b:2e::44) by AM6PR08MB5160.eurprd08.prod.outlook.com (2603:10a6:20b:ef::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Thu, 14 Jul 2022 14:18:13 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::3) by AM6PR05CA0031.outlook.office365.com (2603:10a6:20b:2e::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Thu, 14 Jul 2022 14:18:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 14:18:12 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Thu, 14 Jul 2022 14:18:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 262e169409a1100e X-CR-MTA-TID: 64aa7808 Received: from dbc2fec0bfb4.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8AA886A7-0475-4646-9A73-477CDF0CDA58.1; Thu, 14 Jul 2022 14:18:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbc2fec0bfb4.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 14:18:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiZ6G2iaGcHEKkJdO3fERxRsyZoLW5Z+jaem1t4pAXo42wXwYD+SMCkB/8HHv5sDlz04aPW/3szDiX6yxVLe6DhxJwinofXanpugksZW+VFE0wDuJn67XTCqPGYnqMdYGZv5yatWoJfz/ieykUx7ER2k2smJ8dAjiXVL71R15jC658v/vXXpF0PiMTbu9aD/tIZaOuXchX/VN7l2A1FMzfkjD4vWjQ/ZLz0y9iXEZ2S/vKLhoedaSPvVN04+MK1nQLcg3145slL3DVj3imzzGQUFzEAJ3jyiw6W1l9FxTiP7pjbwMjgGJSsu/SjQ8dlhElDfNMwYm3TuKn3cdu5Kdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ldm04IOPvn146SbAEQrnzO6Iga22PveUl+H154s0k2s=; b=D/WpsBoDLNrGurRKyhZgerQEAE6iBAMGjAgEWl306V9MSCT3MLfVA0CA7HSTNbciaGr5fv0YBcUACqUqjeDHWGfV3IIVHOVUDhdDlQZHN5zo+1Ewp6Sm1yonh45t2YFxYtRJF7v04KWGz9wqnWK/XXbf2ONppy/a8CXIuk/PyorRRmXxHnKF31mmDYVEMgyQPsH8at2w1yQexrJE+G94wMTLFXQ6C/ZJAkAmGk6YHTUDR3Va256kojnqPkTjPenyCJbcgx7ydakqPMhbJU1wpPDDWTsAGIDVCo18OYtYJU+TS42fwkezLn5yRIoHHp9sftVmSnyXCgrG89pAnMjzCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ldm04IOPvn146SbAEQrnzO6Iga22PveUl+H154s0k2s=; b=+KpQ+Joma+NCyJh53TIEmna/+Dejy5Fp135OKFvWBgcwz6qpeVf5LOC4KZZbEPaoE2ueIjzG/AkkeRigIoSjre6SKA6PHXt9lM5qFFSzcI9EuxdKgAqzxKrm8CdlNFQXdHF30AST+AImSP3rsvBYmMxhbT0ilMx+n3al3J5IHrs= Received: from AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6) by DB7PR08MB3180.eurprd08.prod.outlook.com (2603:10a6:5:1e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 14:18:04 +0000 Received: from AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::f53a:a7c8:f845:4b37]) by AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::f53a:a7c8:f845:4b37%7]) with mapi id 15.20.5417.023; Thu, 14 Jul 2022 14:18:04 +0000 From: "Sunny Wang" To: Dimitrije Pavlov , "devel@edk2.groups.io" CC: G Edhaya Chandran , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Jeremy Linton , Chandni Cherukuri , Sunny Wang Subject: Re: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation Thread-Topic: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation Thread-Index: AQHYi9E/WySOsCWxnUWRdf0D20dpNq19/usg Date: Thu, 14 Jul 2022 14:18:04 +0000 Message-ID: References: <20220629155928.5703-1-Dimitrije.Pavlov@arm.com> In-Reply-To: <20220629155928.5703-1-Dimitrije.Pavlov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 71e220e3-c2d0-400a-e5c3-08da65a3afb5 x-ms-traffictypediagnostic: DB7PR08MB3180:EE_|AM5EUR03FT033:EE_|AM6PR08MB5160:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bDADlSjFRy18QLManHYOqPreCORGxa0gnBezheehh2KZrk8r1zSyi5ZyAmhOD3ojJe7p0eZ10VR56iZi+dPS9B1K23x1RiIcY3p4alTNn57m6AFXf62RDU2yWpYxFZ9RycK4pAGYE7GrnXOTiEOU/J84SD6HciMnxFwB/aVbCz8uBLK+Qln+t9uFqwVHxJbKX/LJYQ7+cQkxw6fBT00HAH8DLgdOdu+W4MP8o50B4uJqSDjdUcBUtPMDqP9raTL1Zza4Wnck/gDLblsnPzGsrScO6opHKYQO0TrinHAd059gCJkhPF/kW+and61BkNUoxd2cK3M4EeCRmVymvpmbnHS4te/Tg31uK+3ZNIBhcqyWfe2wZgHp4ngaoG32Ghi8hJlDXFsQNbA1H/k0EmajuKbrh0S967czUsRNK4JR3NrR3L7UhUda4ehy7x34f2JKdt7JWdC9GX7WH6oTNiPjX4bqpZzHPZbG/K6SKXnEpyuym66DKruILuqgV0wHJITjQcaF2OPwK8WrycUoieXIZFYL6wYe4gMQydkfTzldEJJ+us4OFCSE3rMtZO2Vo+JyEMue6Dc6ru/PpDLsYqn+pce2x5fyN62DRoLuyc4DOsqPoZ4E6kcGQhdBw20gCQ6gVClnCZJwPh8i4qYqP5BHK10qWSNgP2eGMstQlLVKI7vFH9tm/r/T4+zd+mMlcXaiZzWo+UnwOPYhC/FYdwrq0vTV/XKhX+ksiMxr3Uv9bgLovwszDN1vkuVtpVRU4qEh1l5uHzGURIJem24YqD6PjAUWoEbcEj9wMsVmw9pNwXtCvSQLy9BohX1mjY07VwE4 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7791.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(478600001)(6506007)(41300700001)(9686003)(7696005)(186003)(83380400001)(122000001)(53546011)(26005)(38100700002)(38070700005)(66446008)(5660300002)(8676002)(8936002)(33656002)(2906002)(55016003)(52536014)(4326008)(64756008)(66556008)(66476007)(71200400001)(76116006)(316002)(110136005)(54906003)(86362001)(66946007);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3180 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 27b33a55-bc97-4014-17f2-08da65a3aaaf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2saaFmuseih5sXQJ/YHtSzh8QNwYFPt/j9xQnXASI05jsVrFwFCYqchonG38PjST6ijTu75hHEW6M8I3f19F3ClwrNZvcLY9TjHva+zVSbsfd5s5Og3fv3nmPosbV0QQk5ZAedCPV22xKukV/GrBXp/0On7Y71kDT3SoZYS+MgJ2P1R8oeUOZhwW8mhltIDD9gTfjduKj1oLNxOqrHQdr8J0ID13D07BEJCvoepoJHXz3vidz9LR1d0/cYtNj2WMLrlSk5kNjR/vDfdXIMrCxlGaSOylyYOJUsYN/6i2ksRMaCbH1bDlXovjvAsLru1B0vRh/hPt3Hy0OlgmFASseGkdZBOKz3Az7b1lvfveIj5LosLpvgquwI1Jfbu3VJvwsVr4mzdfN5qE8VJWJp9Mmmdy2U9IImmatcJBfB2idgVfjId7jVi4yaFgsJLzBJU7FPxdg2//ZIUFitf+IzigsTWhsdTktVDe3iDZBkEVCKMWbqueWbeDXazuAJERPyuaBjXXiZ8Fokaz54T5+Q2GbdG5HdRxzt6SuZ2AwL+dqHM58Yusay2hUDClH8P1EEIPAnv8pL/jZW5A+JOW6PNMpQPox9ubrDDjpsJGII3vqdVxpPMh+LUyus+/zp/l5W5m9n6Ab2pU9KAqavVj91fjYIxZWYYlnA+oTjzBY/56PUaYVnVUCfnGPyUE2mIjsTDcQLrnIMgxNt3hC8yZXinESN4M7dGgh5U9h+BRrTJy8R1IDVLeHUgaqeQq8cNWpdCKAqB7Gvmq6K+olsk/UHCpFQdU7nP7THzaYyjNTNd0PgzUTkk5lYxde421pvOLCogq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(46966006)(36840700001)(40470700004)(41300700001)(478600001)(53546011)(86362001)(6506007)(186003)(7696005)(9686003)(26005)(47076005)(336012)(356005)(81166007)(82740400003)(83380400001)(36860700001)(8936002)(5660300002)(52536014)(33656002)(82310400005)(40480700001)(55016003)(2906002)(110136005)(40460700003)(54906003)(8676002)(4326008)(70586007)(70206006)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 14:18:12.7573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71e220e3-c2d0-400a-e5c3-08da65a3afb5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5160 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Thanks for fixing the issue, Dimitrije. Add Chandni. She has run into this issue as well. Reviewed-by: Sunny Wang -----Original Message----- From: Dimitrije Pavlov Sent: 29 June 2022 16:59 To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Jeff Booher-Kaeding ; Samer El-Haj-Mahmoud ; Sunny Wang ; Jeremy Linton Subject: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check Pixe= lInformation According to UEFI 2.9 Section 12.9, the PixelInformation field of the EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is valid only if PixelFormat is PixelBitMask. The current implementation always checks the contents of PixelInformation field of the EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure returned by QueryMode, regardless of PixelFormat. Check PixelInformation only if PixelFormat is PixelBitMask. Cc: G Edhaya Chandran Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Cc: Sunny Wang Cc: Jeremy Linton Signed-off-by: Dimitrije Pavlov --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/Gra= phicsOutputBBTestConformance.c | 30 ++++++++++++++------ uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTest/Gra= phicsOutputBBTestFunction.c | 19 +++++++++---- 2 files changed, 35 insertions(+), 14 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/Blac= kBoxTest/GraphicsOutputBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/= EFI/Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestConformance.c index 13e7227f5845..b2bff9d756b1 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTes= t/GraphicsOutputBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTes= t/GraphicsOutputBBTestConformance.c @@ -493,16 +493,28 @@ Returns: ); if (Status !=3D EFI_SUCCESS) { AssertionType =3D EFI_TEST_ASSERTION_FAILED; - } else { + } else { AssertionType =3D EFI_TEST_ASSERTION_PASSED; - } - - if (SctCompareMem ( - (void *) info, - (void *) GraphicsOutput->Mode->Info, - sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION) - ) !=3D 0) { - AssertionType =3D EFI_TEST_ASSERTION_FAILED; + if (info !=3D NULL) { + // + // PixelInformation is checked only if PixelFormat is PixelBitMa= sk + // + if ( info->Version !=3D GraphicsOutput->Mode->Info-= >Version + || info->HorizontalResolution !=3D GraphicsOutput->Mode->Info-= >HorizontalResolution + || info->VerticalResolution !=3D GraphicsOutput->Mode->Info-= >VerticalResolution + || info->PixelFormat !=3D GraphicsOutput->Mode->Info-= >PixelFormat + || info->PixelsPerScanLine !=3D GraphicsOutput->Mode->Info-= >PixelsPerScanLine + || ( info->PixelFormat =3D=3D PixelBitMask + && ( info->PixelInformation.RedMask !=3D GraphicsOutput= ->Mode->Info->PixelInformation.RedMask + || info->PixelInformation.GreenMask !=3D GraphicsOutput= ->Mode->Info->PixelInformation.GreenMask + || info->PixelInformation.BlueMask !=3D GraphicsOutput= ->Mode->Info->PixelInformation.BlueMask + || info->PixelInformation.ReservedMask !=3D GraphicsOutput= ->Mode->Info->PixelInformation.ReservedMask))) + { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } + } else { + AssertionType =3D EFI_TEST_ASSERTION_FAILED; + } } if (info !=3D NULL) { diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/Blac= kBoxTest/GraphicsOutputBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI= /Protocol/GraphicsOutput/BlackBoxTest/GraphicsOutputBBTestFunction.c index da51fbc44596..f31ea8175af8 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTes= t/GraphicsOutputBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/GraphicsOutput/BlackBoxTes= t/GraphicsOutputBBTestFunction.c @@ -125,11 +125,20 @@ Returns: } else { AssertionType =3D EFI_TEST_ASSERTION_PASSED; if (Info !=3D NULL) { - if (SctCompareMem ( - (void *) Info, - (void *) GraphicsOutput->Mode->Info, - sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION) - ) !=3D 0) { + // + // PixelInformation is checked only if PixelFormat is PixelBitMask + // + if ( Info->Version !=3D GraphicsOutput->Mode->Info->V= ersion + || Info->HorizontalResolution !=3D GraphicsOutput->Mode->Info->H= orizontalResolution + || Info->VerticalResolution !=3D GraphicsOutput->Mode->Info->V= erticalResolution + || Info->PixelFormat !=3D GraphicsOutput->Mode->Info->P= ixelFormat + || Info->PixelsPerScanLine !=3D GraphicsOutput->Mode->Info->P= ixelsPerScanLine + || ( Info->PixelFormat =3D=3D PixelBitMask + && ( Info->PixelInformation.RedMask !=3D GraphicsOutput->= Mode->Info->PixelInformation.RedMask + || Info->PixelInformation.GreenMask !=3D GraphicsOutput->= Mode->Info->PixelInformation.GreenMask + || Info->PixelInformation.BlueMask !=3D GraphicsOutput->= Mode->Info->PixelInformation.BlueMask + || Info->PixelInformation.ReservedMask !=3D GraphicsOutput->= Mode->Info->PixelInformation.ReservedMask))) + { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } } else { -- 2.34.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.