Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

["Sunny Wang" <Sunny.Wang@arm.com>]

Looks good to me. Thanks for working on this, Abhi.
Cc people to the email. Somehow the people you added in your commit message haven't been automatically added to email's Cc list. I guess you might accidentally use " --suppress-cc=all" when you sent the patch out.

Reviewed-by: Sunny Wang <sunny.wang@arm.com>

Best Regards,
Sunny
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abhimanyu Singh via groups.io
Sent: Tuesday, August 22, 2023 7:24 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3759

HIIConfigAccess and HIIConfigRouting Protocol RouteConfig tests assertions
store a failure when RouteConfig returns EFI_ACCESS_DENIED. In the UEFI SPEC
RouteConfig in both protocols can return EFI_ACCESS_DENIED when the action
violates a system policy. The tests now record a pass with warning.

Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Sunny Wang <Sunny.Wang@arm.com>
Signed-off-by: Abhi Singh <Abhi.Singh@arm.com>
Change-Id: I8591c3d7b0855133141779d3c53a159129400815
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c   | 2 +-
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
index b3276487bb3c..8e46b547bdfe 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
@@ -521,7 +521,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 (
                  );

   if ( (EFI_SUCCESS == Status) && (Progress == Resp + SctStrLen (Resp)) ) {

     AssertionType = EFI_TEST_ASSERTION_PASSED;

-  } else if ( EFI_OUT_OF_RESOURCES == Status ) {

+  } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) {

     AssertionType = EFI_TEST_ASSERTION_WARNING;

   } else {

     AssertionType = EFI_TEST_ASSERTION_FAILED;

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.c
index d4bd23d1fd82..9d7a7dcf42e2 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.c
@@ -546,7 +546,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 (


   if ( (EFI_SUCCESS == Status) && (Progress == Resp2 + SctStrLen (Resp2)) ) {

     AssertionType = EFI_TEST_ASSERTION_PASSED;

-  } else if ( EFI_OUT_OF_RESOURCES == Status ){

+  } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) {

     AssertionType = EFI_TEST_ASSERTION_WARNING;

   } else {

     AssertionType = EFI_TEST_ASSERTION_FAILED;

--
2.34.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107958): https://edk2.groups.io/g/devel/message/107958
Mute This Topic: https://groups.io/mt/100899969/5985097
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com]
-=-=-=-=-=-=


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107973): https://edk2.groups.io/g/devel/message/107973
Mute This Topic: https://groups.io/mt/100899969/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-