From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 66262AC0983 for ; Wed, 23 Aug 2023 09:41:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SQXsfcxnW/CgqewIpIiQ/Qw+4MlbLsYg7NGgOwoFUkI=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:Authentication-Results-Original:nodisclaimer:MIME-Version:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692783679; v=1; b=Myeu+RBHCvyM+YPggRu2O0NQNbDjhl+wXRzbc/Kqcw3pc8jxO/AsQjiz5356QyPWdjx3XZGg f8dSBqwRkLMIqbpwuMhtK2HbQ7sUMEMUKx2rI76dlp6GdV81doD4iR/r3/QKA1M6LNTX/Y30XXy 5K4m4mlO36cE2jdes3Z3e65c= X-Received: by 127.0.0.2 with SMTP id zwVXYY7687511xANG51p5xQo; Wed, 23 Aug 2023 02:41:19 -0700 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.60]) by mx.groups.io with SMTP id smtpd.web11.7828.1692783677698940692 for ; Wed, 23 Aug 2023 02:41:18 -0700 X-Received: from DB7PR03CA0075.eurprd03.prod.outlook.com (2603:10a6:10:72::16) by AS8PR08MB6710.eurprd08.prod.outlook.com (2603:10a6:20b:397::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.26; Wed, 23 Aug 2023 09:41:13 +0000 X-Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::90) by DB7PR03CA0075.outlook.office365.com (2603:10a6:10:72::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.26 via Frontend Transport; Wed, 23 Aug 2023 09:41:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6723.16 via Frontend Transport; Wed, 23 Aug 2023 09:41:13 +0000 X-Received: ("Tessian outbound b5a0f4347031:v175"); Wed, 23 Aug 2023 09:41:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7f31734f9bf5a2ed X-CR-MTA-TID: 64aa7808 X-Received: from 9acc17bf3d60.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 129A32FE-ACC1-44DA-9C30-236C60088D75.1; Wed, 23 Aug 2023 09:40:30 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9acc17bf3d60.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Aug 2023 09:40:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LpEuWuOUioITbJdcKA/xKzJJpndLoRjAjYQMfhR4Hbado1bgu6p5tuLq5JaWY0jjIFad1AwvL564a3bkD4CCJ3c9HQjtqKDJ5PNIzUsrQIYemeQq8SJQ8uVeWCeyQI8vPIk0OgplBzFTzmVS3/yLW91fHYCJANJkGUSyKEk4VWbywAi2oMsqroS0/c0DKWP3E/XtArdrRjkq3/sZF8pz8gnFaq0OK73+TMpTowSeMHsCrpkLSZ78sQh9uABiORxgGE/R5Y2VBlnu+5TBaEG16yFWWG/SbVJnTkVsTjirGO+3t/syr4WxQoetd/1dw4R4ITr0SrxLFpl/MrGG9L/HYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CNeQMXpnvoce93Zs2csDGnrvoan+K9/1cOvvV4JNNmI=; b=AA5G8ikCH/3i3mLK3LrirUK0k8eJylHzL2vaExty/j4bt4JT/9yiQ5GLcupHvcdlg7AUtHGal87F3zA752jwEJN2rqyLRTgvqPDrtJJmAHzUUtfx0t/UTT/f9vcCqo8kWlK/TQkrolRdO4/Nf9Vzzxg7E/ElTxRaWbFl4LHrG2l8Wautp+fGLoUtKZV637LoXR82H5if6eHaiofrwaXRYCVPTIOUqZfN3M1hxxzElYcjwSbdU0+u76eeS+04xddYaLwC7eiwNdCJrkTi7w8Dx3Cuy9dnqiQoN1Algo8DZID7GinU2WmcsxBQIFwQacMssWDExd0Bdh8r+FRqB6a7eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none X-Received: from AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6) by AS2PR08MB8672.eurprd08.prod.outlook.com (2603:10a6:20b:55f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Wed, 23 Aug 2023 09:40:27 +0000 X-Received: from AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::464f:eb24:838d:e017]) by AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::464f:eb24:838d:e017%6]) with mapi id 15.20.6699.022; Wed, 23 Aug 2023 09:40:27 +0000 From: "Sunny Wang" To: "devel@edk2.groups.io" , Abhi Singh CC: G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud , Sureshkumar Ponnusamy , "Felixp@ami.com" , Sunny Wang Subject: Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning Thread-Topic: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning Thread-Index: AQHZ1SXn67Ui5QAYGkufyT4wUJqhB6/3nhgg Date: Wed, 23 Aug 2023 09:40:27 +0000 Message-ID: References: <20230822182354.79292-1-Abhi.Singh@arm.com> In-Reply-To: <20230822182354.79292-1-Abhi.Singh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 94DC5A4D8B0C6F4290E3F365F9E1FEF6.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7791:EE_|AS2PR08MB8672:EE_|DBAEUR03FT045:EE_|AS8PR08MB6710:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b682d8f-339e-4097-064e-08dba3bd174d x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QJ2nExKEhfMP+wtGjWC0aKttySSJ3EKOOTR8Nh8m/1YFU5mqZ4KDETtrwqOTRXRYPo6zXjMi1+9ruTjsMsPP2Y52JyPBYkdE1yxkCKho9rr8tl5laIrUD9rv03qp9NsdP8PVyDyA7sd6Cx2fc628fVv42YUk26tbOT6ZjYxWPOQBgdPPdtsZGdeZCDKSeDFSLC/pujkcwrbo5/4uPGVGxScU+by1yxIKvCAQ3m+ET9je1PdSS/Sm4Z7y9X9Wl09One4H4++2qySnFgespgxIdG3w/2rvg389oL8Qv3kCnT+exziN6B0xV9pfM+MPf5VqYuX2/xKx2ZgMychAwHN7QwKyS+kOaYHtwcwSrV5HolgebgRQlVIrllSgMa3lDfe0wf6pGDvaktF+XVlSXQ2GrMgvGqXS5lHfKXYG8Ivd2MhW1J+JC1OD2pDQ85l50/186TDt6AC2WHiJO4fEo7WGqt6fhb6wjWWUVoCApUjT+ihcOWpFlzSk0nZdIXv689wpIIzQu8v73aN6REbB9YQFLXcj/OyzNVI8G0dr9O3UVRUC4fKHIJFTicogs7Ii0pRLL67ip9w6zdkCytSenuCqaLv50k3LXGBoEb7tZAwugNgp1VRx6hp4cV+Zby0RViWQVf3ykP7jXbLd1f9AwINndQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7791.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(136003)(346002)(366004)(376002)(1800799009)(186009)(451199024)(76116006)(54906003)(66476007)(66446008)(66556008)(64756008)(66946007)(9686003)(316002)(66899024)(110136005)(6636002)(8676002)(8936002)(966005)(4326008)(41300700001)(478600001)(122000001)(55016003)(19627235002)(71200400001)(38100700002)(38070700005)(6506007)(53546011)(83380400001)(2906002)(7696005)(86362001)(5660300002)(26005)(52536014)(33656002);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8672 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0e240cc0-338a-4ad2-96ab-08dba3bcfb7d X-Microsoft-Antispam-Message-Info: fOmxvgkx4HRDcZv4OHr0GiRMn6yrsgCpxQdLCZCxJvZcnT+YSWDpPWTvkAd3OjiT51j+WIXopkje/iKmw5pfC5spWzKZNa6OpXxto+z08fcKtgQm3HHgrXbfhnZuAKbSbULjol3eNStNDk2oXCqOar1tj+QEdVB8VtH072NhEYKeQfuxbxSkqh3WE6Zu6oObFJzEOQSdvQukZ0poWRlHKXxCOhu9sVFCJ6Q3hxqQARcbXqWvngi4h4F7qh+oqUdcC12psjoeTVsEBDQVPJC/KXPkkiOc1zgs6hwkJeU9h8KLPl7NyTBcMEheq9D3cj60SQC0N/W5fKOUhYVL/mci5XCEP1u9taMZOFimMXvZsginjaKarPofGIMHUDjtxe5sPzAXah5aERZTFoE1SNZsj/KVE4b1SLjytP4f8CUtR/6LURNcgMsuE3tbjcYGcjM055c4DKTgycWkQLqckGUBU/RCjDVWL4RQSj1mpfeuZUMWMJiybMgqo/P/GQE1gDtvwvLTqwHv5iQ0/Qg6Ru09RMI8EBpzAFn7NZT1gH8KZ/10BXy1tfJ4/B4Ey2d/m8QjdYj68YIUcxJPJFF75FOaZUn34UAoOA6kql1VugkOpkHSt7k9kE7IoTogeZyRWJwKClZBIG4qUukXIe+6EMIAReXfuVyQzkQ9Wu8bIZ7h5wapgCWb0ecaIZaMSD+/jvPTGD5AnW65di1G8GsZSD7z5h7YJDicbtRYv7sE78rE9c/D1/2MAaQMODl5PnvA5nqTuim2GWj4ieGaViIgJO4lFw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2023 09:41:13.7971 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b682d8f-339e-4097-064e-08dba3bd174d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6710 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Sunny.Wang@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Hjz28T1Zl9D2XuVciMJjjfurx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Myeu+RBH; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Looks good to me. Thanks for working on this, Abhi. Cc people to the email. Somehow the people you added in your commit message= haven't been automatically added to email's Cc list. I guess you might acc= identally use " --suppress-cc=3Dall" when you sent the patch out. Reviewed-by: Sunny Wang Best Regards, Sunny -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abhimanyu Si= ngh via groups.io Sent: Tuesday, August 22, 2023 7:24 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns= EFI_ACCESS_DENIED passes with warning REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3759 HIIConfigAccess and HIIConfigRouting Protocol RouteConfig tests assertions store a failure when RouteConfig returns EFI_ACCESS_DENIED. In the UEFI SPE= C RouteConfig in both protocols can return EFI_ACCESS_DENIED when the action violates a system policy. The tests now record a pass with warning. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Sunny Wang Signed-off-by: Abhi Singh Change-Id: I8591c3d7b0855133141779d3c53a159129400815 --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HI= IConfigAccessBBTestFunction.c | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/H= IIConfigRoutingBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/Bla= ckBoxTest/HIIConfigAccessBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/E= FI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c index b3276487bb3c..8e46b547bdfe 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTe= st/HIIConfigAccessBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTe= st/HIIConfigAccessBBTestFunction.c @@ -521,7 +521,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 ( ); if ( (EFI_SUCCESS =3D=3D Status) && (Progress =3D=3D Resp + SctStrLen (R= esp)) ) { AssertionType =3D EFI_TEST_ASSERTION_PASSED; - } else if ( EFI_OUT_OF_RESOURCES =3D=3D Status ) { + } else if ( (EFI_OUT_OF_RESOURCES =3D=3D Status) || (EFI_ACCESS_DENIED = =3D=3D Status) ) { AssertionType =3D EFI_TEST_ASSERTION_WARNING; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/Bl= ackBoxTest/HIIConfigRoutingBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.= c index d4bd23d1fd82..9d7a7dcf42e2 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxT= est/HIIConfigRoutingBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxT= est/HIIConfigRoutingBBTestFunction.c @@ -546,7 +546,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 ( if ( (EFI_SUCCESS =3D=3D Status) && (Progress =3D=3D Resp2 + SctStrLen (= Resp2)) ) { AssertionType =3D EFI_TEST_ASSERTION_PASSED; - } else if ( EFI_OUT_OF_RESOURCES =3D=3D Status ){ + } else if ( (EFI_OUT_OF_RESOURCES =3D=3D Status) || (EFI_ACCESS_DENIED = =3D=3D Status) ) { AssertionType =3D EFI_TEST_ASSERTION_WARNING; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107958): https://edk2.groups.io/g/devel/message/107958 Mute This Topic: https://groups.io/mt/100899969/5985097 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -=3D-=3D-=3D-=3D-=3D-=3D IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107973): https://edk2.groups.io/g/devel/message/107973 Mute This Topic: https://groups.io/mt/100899969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-