From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DDBFCAC16FB for ; Thu, 4 Apr 2024 16:49:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pqhCtDOfkMdooMJcfC7M9LunjLIUgDm2tkerNkthCSU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:nodisclaimer:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712249363; v=1; b=YrdtRZt+cbud0EILP5b0ASsn1S55/wp1muBFVFnJcHXDDLFrC+x5B5JH8E3y7VAY0k/7DBHb ImRci9jCxmaCdrsVkra8TZttzAyEJx7vIOizypB+Y3+MgaNDFBV8zolWVXqLtuZ5nbTuIIkF8qE j5BxyKQ9pnN4VYNQJXpBMVM8XrY0nY9ohFaDP83l0/xpzhiwNsVR26gitOeLcI1YaskE8lMZFvq V+348lq1gMSwS3UmkpI1v83iFeEorrBAAGyuB1RpbbEAegtXLz5iL5qPWBF0rkSFhXIIukLj7Rl vZRG9fbWIIHA7JyYBGMuifbF7Q2PLSjNUT/FesZ3lPlpw== X-Received: by 127.0.0.2 with SMTP id xtlWYY7687511xOEQGdhVhAS; Thu, 04 Apr 2024 09:49:23 -0700 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.103]) by mx.groups.io with SMTP id smtpd.web10.43634.1712249361694066333 for ; Thu, 04 Apr 2024 09:49:22 -0700 X-Received: from AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6) by AS8PR08MB8945.eurprd08.prod.outlook.com (2603:10a6:20b:5b5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 16:49:18 +0000 X-Received: from AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::8ed9:ec8b:75b7:f127]) by AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::8ed9:ec8b:75b7:f127%6]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 16:49:18 +0000 From: "Sunny Wang" To: "devel@edk2.groups.io" , Abhi Singh CC: G Edhaya Chandran , Barton Gao , Carolyn Gjertsen , Stuart Yoder , Heinrich Schuchardt , Sunny Wang Subject: Re: [edk2-devel] [PATCH v4 0/6] EDK2-TEST TCG MOR Tests Thread-Topic: [edk2-devel] [PATCH v4 0/6] EDK2-TEST TCG MOR Tests Thread-Index: AQHab1YHpBE7dnwxpU6iPPfvz5SiY7FYgEqQ Date: Thu, 4 Apr 2024 16:49:18 +0000 Message-ID: References: <20240305233622.747522-1-Abhi.Singh@arm.com> In-Reply-To: <20240305233622.747522-1-Abhi.Singh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 47FD84388E680B42AC1E3F399B22CA81.0 x-checkrecipientchecked: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7791:EE_|AS8PR08MB8945:EE_ nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 19MDv4Nz2aR45JKWgTvE0OPDmlg8afT4ycvydLRI/jjzbhLOz2KqqxPc65FPEFlt2doSG7btuo0Bm0GoW8/hQoBXQeYK04X4bfn8liLiDCSumSLdahIcyZ0lsUKZP40eLMcdMBThobI5mBTnq7Jz9jZW1D+I+05PMvQQr5soXlvQRZ7NxXNh9AEW10N0nX6zOlbtwbhk0rhfC7iGLKv02XudW87UneyUL6hszw1B2rFVfQICygs4yQTFa39sSdBLGpvlSli7753azq4mN0QNhGgMOvSVRBooGAH7IyaWTfCWbRiHWP9lvhf3PmxkrBNtO3bKUv32oCHZGLct29xB6h5N+hBhKFmCOREObG+Bz+t5FvadBUF62TNr11urR7t7MSp+WdnqNh4iHy2xPxheLcMvxIhevDgQx43m9Via+HZPZCzdc4UHoyfsBuyW8najYuU7R58fUJPuIRTOSfDIo1DvNF/eZoPWFSNfdwBm6Pj7IYqYmaQe3cBQxWbXFaIJpI1UNhEMXxsfVlkvmhQzNnnHbDKwXTwl1VZqzFF93xD816li+xgwdIZDnAWhZ9W1SuCwIgBvhxXnbwiU5YW7g7O7Rq646rtDUSYjBAUAsaQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Ui+xcibMUbLXIbC/usRaHwlXvSkmCJkz7dRNm67rbx6dLTNetlWry6ATSYP?= =?us-ascii?Q?txpXm9Ki+SAH/1xdBDh45gMafRLr9bSNEOyHvzGOifLfiRljgYXeRuIE+/Iy?= =?us-ascii?Q?MZnYTePg0wq7CbZpbETED3L3DPB4bg3zdz2m4PIG3Mfxo3rfWcoCfNZEJ/s5?= =?us-ascii?Q?bRkEe8n1FQNTGCum6KOL9d2/DSFPrfBH+QFZPjIlXiEAiOhRB7imQVvQLcL/?= =?us-ascii?Q?OF5XMkHLNUDYavaGZ+lgbB/B87LOdMbsRb+0sgdk0pKVy40gKQGT6ba5vNhQ?= =?us-ascii?Q?/qWOC28/3FOQkC0fytoGKipA72lxmDmQ4o9tqLfsx5AUf9WFUw4KU+4/hA2r?= =?us-ascii?Q?pPaQUbtM2IJK9jVS6EKfG67JFT2Tw4sWjKQ7v1jLG2I42WVh5T3SAH6doa15?= =?us-ascii?Q?+s08bd7Vo+ekFq7Io5PCzubdvUBVMeE1/ui3YM37ucOGoa9iTsaJdDpugpkM?= =?us-ascii?Q?0dUxr1cC6EdVNLI6zjJw+5goFgeYlp75P/Ga663mSbeP+cV3EyWR4SkOLrNt?= =?us-ascii?Q?9EvVmnzp6DD4ft9dvY3iTHS3HZ2724kZHuKgTBkoS3fR7yRAyuSQqNma/ca3?= =?us-ascii?Q?NHZqy2U27Lb4OUxfgYtm3gtLksXz9ZsESd4Qr4g1HVQWyD1jiZlbxA34u05P?= =?us-ascii?Q?FyBwngGsSnXIoBpjSggmdiPV35BctFXHyZ1x4pPy8YUy5Jpoq7JzjyjPnNjd?= =?us-ascii?Q?mVHSulI4GhemxBmRUg6XU0gbhuT7LK6J/Az6wzyLqX5Key8euSD4kjpGI7pg?= =?us-ascii?Q?mQi0sCiDPqTJYDLMU14qMadc8fRC7Aly22jKlhgblOC3nJpaFLFHC2+EWzfd?= =?us-ascii?Q?z/DfE+DeBzuQSIugFTxQYX2K3tb4k0dTjqdMxPzs8a3BPX2xh5/w+G8eeewm?= =?us-ascii?Q?gQNd0+ArWRwCPvxf+ew5pQNVsJz3tLKhxjyFQEfCsgQgjMQ4mFhyAFVjy2DF?= =?us-ascii?Q?VCAW0WqhizEnY1ea0V+Xd9PmVpQK+swU6cNZCU9q31W7Ex1rUEyWwxyNmVZo?= =?us-ascii?Q?QadTKK+dgrp36Vh+ADrse3V9kSsD7DOEvJSyj4JDe5Y5QwMMeYYyAYxhcS8U?= =?us-ascii?Q?zTQSogEiUirog9EZ6DwYdog8NqXyEROMiJ3dAsA8TbgSbbIirsVL17J/5Rf6?= =?us-ascii?Q?sH8qQEzQENlDLfZTnfcZ6rJHDSaxwFVHIYJ2xDFf2aAhz/M26AXq+9lG/bJ7?= =?us-ascii?Q?z5Eh0orUwaFF3xAlnQDx+9TRFDAvCGhi8yu9xLS2TGMrMczwsd4uyAoedica?= =?us-ascii?Q?Zwsj3tosL1TDJnM73Wv/gS0Eqs3RG6GrKgbxdyA9X+44L5ZKuLQZ8xhlsV+V?= =?us-ascii?Q?yCntxEVZ+b1upzV+YCDMm9Z4BKehs4XkjVqn07Gc6MCCVi1p0g5V0QMt3z7r?= =?us-ascii?Q?vN6MSzcsELOLqzCQoxFQFofEpES3FwGftyJO5+a2BhEpINlhUryMCQQyYp/N?= =?us-ascii?Q?/sBoj/bWJszzI0BcqhB5hzWGBX0lN0MYcdlGcAylSoTNtMvUqvduB+BlrjWk?= =?us-ascii?Q?S2UmlsZG+1/aJvAn5nFw45jr0xAJQMS+O2dFPt8Vl5NkiffxpmUuz5oUTu44?= =?us-ascii?Q?zU69w96FabfuwPw4+zw=3D?= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7791.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7310f5db-3c02-42af-4723-08dc54c72b49 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2024 16:49:18.1092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yRxv0PnTfvx06eQpXsYB1nLE8G1lVxKTPxSTjLK6+APbyaVyYUGimWVBZYJY/RV5KHnRu5dOjTGr3/t1r5xk4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8945 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 04 Apr 2024 09:49:22 -0700 Resent-From: Sunny.Wang@arm.com Reply-To: devel@edk2.groups.io,Sunny.Wang@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VAgeFN8CxfCtyl8hEzIkMedjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=YrdtRZt+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io The patch series looks good to me. Thanks for your contributions to edk2-te= st, Abhi. I directly added some suggestions/comments to its Github pull request https= ://github.com/tianocore/edk2-test/pull/90. No need to update the patch seri= es. My suggestions/comments can be addressed in a separate new patch. Pleas= e go ahead to upstream the patch for the release. Reviewed-by: Sunny Wang -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abhimanyu Si= ngh via groups.io Sent: Tuesday, March 5, 2024 5:36 PM To: devel@edk2.groups.io Cc: Abhi Singh ; G Edhaya Chandran ; Barton Gao ; Carolyn Gjertsen ; Stuart Yoder ; Heinrich Schuchardt Subject: [edk2-devel] [PATCH v4 0/6] EDK2-TEST TCG MOR Tests Updates after feedback from Heinrich -updated deprecated useage of HandleProtocol() to OpenProtocol(). -added checks for unexpected values for Step and CheckpointStep values. -added check if system fails to cold reset, returns EFI_DEVICE_ERROR. -cast Attributes to (UINTN) when passing to RecordAssertion. -ack test is still missing a pattern write to memory and then check for clear upon reset. Patch series: These tests support platform firmware that implement MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock UEFI variables in accordance with TCG PC Platform Reset Attack Mitigation Specification. The patches are split according to the six sections documented in the SCT spec document referenced below. SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4419 PR: https://github.com/tianocore/edk2-test/pull/90 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Stuart Yoder Cc: Heinrich Schuchardt Abhi Singh (5): uefi-sct/SctPkg: TCG MOR SetVariable Test uefi-sct/SctPkg: TCG MORLOCK SetVariable Test uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test Abhi.Singh (1): uefi-sct/SctPkg: TCG Platform Reset Check Test uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc = | 1 + uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/TCGMemoryOverwriteRequestBBTest.inf | 53 + uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/Guid.h | 271 +++ uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h | 137 ++ uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/Guid.c | 127 ++ uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c | 2390 +++++++++++= +++++++++ uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.c | 115 + uefi-sct/SctPkg/CommonGenFramework.sh = | 1 + uefi-sct/SctPkg/Config/Data/Category.ini = | 7 + 9 files changed, 3102 insertions(+) create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMe= moryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTest.inf create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMe= moryOverwriteRequest/BlackBoxTest/Guid.h create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMe= moryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMe= moryOverwriteRequest/BlackBoxTest/Guid.c create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMe= moryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMe= moryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.c -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116406): https://edk2.groups.io/g/devel/message/116406 Mute This Topic: https://groups.io/mt/104756647/5985097 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -=3D-=3D-=3D-=3D-=3D-=3D IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117442): https://edk2.groups.io/g/devel/message/117442 Mute This Topic: https://groups.io/mt/104756647/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-