From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.83]) by mx.groups.io with SMTP id smtpd.web12.14549.1660649990731137246 for ; Tue, 16 Aug 2022 04:39:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ICgi5Cnl; spf=pass (domain: arm.com, ip: 40.107.6.83, mailfrom: sunny.wang@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NdkehAGaerRKEjyk0ojgmESSraJ8dBJ4AGihvXwS4AjZD5aiPU52wQHBjma3ISuoNgW8eWLbgoTnch45X+U4SuENEEH55UA4UQnfeC7Gaxc2kLE8+yL0phu+f7P7dn1PwTLxCT8jOpF1E1YAOQ40uyEL6QXZkLR0+Ra89Sn3n85qQl/2la3e4gTnnIKaV+69Qxzd1H7+ABR6yFm+ce9XUfzbG+AQuhnlhweoScsv/AeM+2eF6af2Gog9LKvg1R3IVRMbG5nl7j2ynsrVHHANR9WyAKOKEMdVoGQQJClBCBucnjRRDSlOUtafHEVml7SQPRPWqfJidZPsPxp8KQ3FFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuTGpMiELsu5jxYwm8AL4OkT4lMTU9n8AZl9+b/QSPM=; b=VJtlcx4ehOsKN9eHGv8CFHbTibuTb7dfZyE/OX79OTWtHBIKRYNWgVs2OJ5T6OajMWu+bwHRKGtImQKBFi5HxloftAazgaDyNSrq4knHKEUHDWCFlHa7ik7oeflh9A02gsbX2pdMPQzTCyePpW7Aq9BLfSGorpRV8HhDkmAvFPfg/2r0wfOlIx1RcdiysLBP/ysgPSDUkT9XHDhNbwEHEIOfvwdOEIv/e66a+v+OgHTVSiHtXv2ojvOnh1PccIDdMnpR6JAvH3C6vQi0Zr/xDe6i3ZleehRrRh9cCmy6UlDan1Sh3gtnoX+2WaimpM0l2TGYm26zrBf2FA8tKH5dFA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuTGpMiELsu5jxYwm8AL4OkT4lMTU9n8AZl9+b/QSPM=; b=ICgi5CnlPfVMUzsxJZ2wHiJ7HbJv7zSDX6ImaaS7zQXUezn6x2k0HUlGKDVIghUUbk7+iXGW2tmgdN6jGXWpoMEYCSpuTyx+mffsMHzmM/vKBJSOrP8lJVCrOEUoBjtxII9xtAgPyKEAP7V191Pnn3XLaEmDSqsmx0ShcQNE6sQ= Received: from AS9PR06CA0225.eurprd06.prod.outlook.com (2603:10a6:20b:45e::13) by DB8PR08MB5082.eurprd08.prod.outlook.com (2603:10a6:10:ec::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Tue, 16 Aug 2022 11:39:47 +0000 Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::fb) by AS9PR06CA0225.outlook.office365.com (2603:10a6:20b:45e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.12 via Frontend Transport; Tue, 16 Aug 2022 11:39:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Tue, 16 Aug 2022 11:39:46 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 16 Aug 2022 11:39:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 94904fecbe72ad9a X-CR-MTA-TID: 64aa7808 Received: from bcc4d4af77b6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5B45B920-29FF-47E9-8CCC-C0DD5DE6DB56.1; Tue, 16 Aug 2022 11:39:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bcc4d4af77b6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Aug 2022 11:39:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxJhfQpgrhcKL39CQfNhVDbuEiqgQAM915fRl+pLhrFyiqTGbd5/tN7DqJivqJo/09rWSYwJpW+9esIldfM9gWKZZMOcGaiVvpDBoeWRIVpPUIQFClkeKAkbm3mZC3w9VK72YXtFsHTzgV8zbxlJVNE+RckT0fYe4qIVfj34LSoL6vuprWh3R0rj7tinmpSzXkMzIW4+GbohdP8PhNju4C9XjROsbAo5q791ok39WOeoHYCwljDkH7AduyPaxFz6FcjIgoxFAPj/Qg7Uhd2wdIaBv1ig7nDu5ljPhfJYx/qDEbqjyVjBRB8fLQRtW04EzFBD9X1nqSusFdctxmv4pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuTGpMiELsu5jxYwm8AL4OkT4lMTU9n8AZl9+b/QSPM=; b=X8SHAn2IdcvVIWv/XZSS2WTvX/ryFayfNvM5EdAl6kGOCiwfcr+ph+7Tl+N8rh1GNIqjPCdTqqkNo4WXOL8mik9i9Xs5u1fN0rLAXC7crI6Vyv2Z9d8Ffdxm38rjTW+BN7kGKrK7b0oV/WsJCu0A1kSwAo7VPgeniTKeL3RhFCElxzCOzvdahEqi5NHYQ/rVa1Bx0Zn5hRYTj37Ah/YIezOy95Dxvz4UlcC3U8HUIFvGsmiLe7GP4NnmVIL+A4MC0OJ8EJeJ2jdRuv95ot/oWyhFpNxtG1yWaCvqTzHfFqXEChBAzRRTLCTZuo6/9+GJPZ7DLPw5Gnv0EkY4JV9Viw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuTGpMiELsu5jxYwm8AL4OkT4lMTU9n8AZl9+b/QSPM=; b=ICgi5CnlPfVMUzsxJZ2wHiJ7HbJv7zSDX6ImaaS7zQXUezn6x2k0HUlGKDVIghUUbk7+iXGW2tmgdN6jGXWpoMEYCSpuTyx+mffsMHzmM/vKBJSOrP8lJVCrOEUoBjtxII9xtAgPyKEAP7V191Pnn3XLaEmDSqsmx0ShcQNE6sQ= Received: from AS8PR08MB7791.eurprd08.prod.outlook.com (2603:10a6:20b:52d::6) by DU0PR08MB7947.eurprd08.prod.outlook.com (2603:10a6:10:3cb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Tue, 16 Aug 2022 11:39:30 +0000 Received: from AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::c82b:abaa:ee57:a155]) by AS8PR08MB7791.eurprd08.prod.outlook.com ([fe80::c82b:abaa:ee57:a155%6]) with mapi id 15.20.5525.010; Tue, 16 Aug 2022 11:39:30 +0000 From: "Sunny Wang" To: Dimitrije Pavlov , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Liming Gao , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: Re: [PATCH v2 0/3] OvmfPkg: Check arguments for validity Thread-Topic: [PATCH v2 0/3] OvmfPkg: Check arguments for validity Thread-Index: AQHYsMSG9o02NCuv90m0jE0Tmr5lKK2xLV0A Date: Tue, 16 Aug 2022 11:39:30 +0000 Message-ID: References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> In-Reply-To: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b06d92bd-6b40-4737-d9ac-08da7f7c0519 x-ms-traffictypediagnostic: DU0PR08MB7947:EE_|VE1EUR03FT040:EE_|DB8PR08MB5082:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dGl1s8686glR16o4nQbqraVd0+EBoEGyLgQ8rpugNrztAF/2LMw0rVRqvZUKi0ame+44iJ7lJLNZOsZnBvDeoIiPS9bY7c9+dwxUVEX4qCyQpigiljOGn6vI+xGIcG4odZTvn22qyid1JNY9ImLs6g6J93G8pk3pV9O4gq8WVVfoiXV8cMtkntu0a3RTosyAZvD392b07fJ2+LLX8ESuf8sZ+1clWAYsV6h7d9OpO/6xs+J+hTivgzQlygM5nKik7VYAyS0iJar1jShRDbmV1cPerKibEuti0lnW5JAsi/RMPYUvwTURctUQ+lhUws1blh6olikANey9+3i8zJgme5QL0fx0DDO0jo0MHmHITen5yKLpChbX96wlICxov9j8lb3A8z+lDSLVNKjC1x9zKIlP+QXjAidI5ehBTomY2kD1Q8IFrlTwk78+lhzUjAmsH3oJG15rtjzbOnnRP9aRLyKBk9C9OpAhlcFY22ikLcvSWo9BTLqLD9t8YAU8fFyCU98ZYcWb9FFpnnkPYZrBq09+F72+vzymxBjUwgax6X1b2Xql37k4FW93LudFyxMTdOIS3zLTHubkCMKRdVnOYlqlaR7kpQ6nWQYlel2SPy6sM5VW/0nWf3gNublgZF0xtxZjYbOF8SjeyogHAMgCoHmX9fauRm7ZH8ht+sZ7kU14VaFplVqp8yqhuQD7VNNgxheQ99g1N37PW8hnN3IYOOLkNQq4xO9sFsAnpsdBVlV9gZy/0EvdPm3hQJ8LCESrNxSiTaFCv98eVAINvPuw2v08tQLdt9DQ5qLrc2bubkfse4MINXjjMCQVDP2Xy31p X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7791.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(366004)(346002)(39860400002)(316002)(26005)(54906003)(6506007)(110136005)(7696005)(9686003)(41300700001)(71200400001)(53546011)(478600001)(64756008)(2906002)(86362001)(33656002)(55016003)(66946007)(66446008)(66476007)(8676002)(4326008)(76116006)(66556008)(8936002)(52536014)(5660300002)(83380400001)(38070700005)(38100700002)(122000001)(186003);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7947 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1e67ac32-b656-47a0-7296-08da7f7bfbbc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jQcWQykDvm0x0RVqObIpmeNosKqr569Obkfry5iVPVV25Pi4zGaK9GEDOe85Js4jSgVfW4BOP0WAXJmKQaI03xQjuQTXuP+XG6ahVPkhWmzRiFms20QadrH4PCXjCCTvBKwjS6hTa8e2kX8UWAkLmquo+F6su5WBMqdfJaQfNUV23CuRUHYpu2qEP9XMX4ddm/MJlPeVXtkAkEVpxJpV+NBySAs51rPgd47+KDgdVpeBNHLpOoGpasEjmJeHqePpjDEbdKDA4ZcPIohp/t7jZ4UFLJzG5wAhp2LOVfKGVL5UuZYeZPm76ykoYVqo0mtslu/Q7/gRbrCdHGusTcoJ3SN6vVd8WH3++/MgJt3XVm7CtIYDvsrD+SRGN0N9+tHPiGVuYTahtt8oPjstNCddLWZ28xCSH0L6teNgo6bBFjXJeh4KiyWtNLXEzdjlcGYwiIZgtu+P1WMaiACeEXsCO+VvuxmkajIgNdwsb1zMIOtZOuNHqNEos4tMKgb++e9dQj8GMj9ggpVgdkwyvMjGjiWJVVTTwhdhpPZvfhbZz96Dkb2LZhAxwba3rSjfeUnhX1sEm5hLaRdLtjV/jg5BB37HO3ZCUZOnlSGchdGHbvoYkVzdCXd4Pm4DIgnIQffSscgv7q+JMZK4AgmlcrhqmwjP+gwQrtpNDvww7NkOrfONo8nDMzhD2xh/ch5PwUR4M9PNabCKG6fUexbSbusSFpmb0d6pMOYTX0yO7YHq8gSOE8C6NNhp5D7RS/XTv91QjqDQFKp4zCrP7EbRJjw1F+PrHsfKzd2o9k5uiKjcfzq8+lMSh1aQRgMQ1PreH5bf X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(346002)(396003)(40470700004)(46966006)(36840700001)(54906003)(8676002)(110136005)(70586007)(70206006)(186003)(52536014)(55016003)(40460700003)(40480700001)(8936002)(2906002)(81166007)(5660300002)(82740400003)(82310400005)(356005)(4326008)(36860700001)(316002)(86362001)(33656002)(7696005)(6506007)(53546011)(478600001)(41300700001)(83380400001)(336012)(26005)(47076005)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 11:39:46.3525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b06d92bd-6b40-4737-d9ac-08da7f7c0519 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5082 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The series looks good to me. Reviewed-by: Sunny Wang -----Original Message----- From: Dimitrije Pavlov Sent: 15 August 2022 17:31 To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Jiewen Yao ; Liming Gao ; Sunny Wang ; Jeff Booher-Kaeding ; Samer El-Haj-Mahmou= d Subject: [PATCH v2 0/3] OvmfPkg: Check arguments for validity Some functions across OVMF don't check pointer arguments for validity, which causes null pointer dereferences and crashes in the SCT test suite. This series adds checks to return EFI_INVALID_PARAMETER if a pointer argument is NULL. v2: - Add Liming Gao to Cc [Ard] - Turn individual patches into a series [Ard] - Fix issue with corrupted patches [Ard] Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Dimitrije Pavlov (3): OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments OvmfPkg/VirtioGpuDxe: Check QueryMode arguments OvmfPkg/VirtioFsDxe: Check GetDriverName arguments OvmfPkg/PlatformDxe/Platform.c | 8 ++++++++ OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++ OvmfPkg/VirtioGpuDxe/Gop.c | 4 +++- 3 files changed, 15 insertions(+), 1 deletion(-) -- 2.37.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.