From: "Sunny Wang" <Sunny.Wang@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@bsdio.com" <rebecca@bsdio.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Cc: Sunny Wang <Sunny.Wang@arm.com>
Subject: Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames
Date: Mon, 11 Dec 2023 11:09:37 +0000 [thread overview]
Message-ID: <AS8PR08MB7791EE31A9AB6D7F62446FF4858FA@AS8PR08MB7791.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20231110190811.956645-3-rebecca@bsdio.com>
Looks good to me.
Better to add https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C#user-content-CamelCase in commit message for reference.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames
Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt} | 0
uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt} | 0
3 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/uefi-sct/HowToBuild/How to accelerate SCT execution.txt b/uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to accelerate SCT execution.txt
rename to uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT.txt b/uefi-sct/HowToBuild/HowToBuildSct.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT.txt
rename to uefi-sct/HowToBuild/HowToBuildSct.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT in UDK2017.txt b/uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT in UDK2017.txt
rename to uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
--
2.34.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112292): https://edk2.groups.io/g/devel/message/112292
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-11 11:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 19:08 [edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo Rebecca Cran
2023-11-10 19:08 ` [edk2-devel] [PATCH edk2-test v2 1/4] Unbreak buildzip.sh Rebecca Cran
2023-12-07 9:33 ` G Edhaya Chandran
2023-12-11 11:05 ` Sunny Wang
2023-11-10 19:08 ` [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames Rebecca Cran
2023-11-29 8:06 ` G Edhaya Chandran
2023-12-07 12:39 ` G Edhaya Chandran
2023-12-11 16:07 ` Rebecca Cran
2023-12-11 16:44 ` G Edhaya Chandran
2023-12-11 11:09 ` Sunny Wang [this message]
2023-11-10 19:08 ` [edk2-devel] [PATCH edk2-test v2 3/4] Point users to the URL for edk2-test-parser if it doesn't exist Rebecca Cran
2023-11-29 8:11 ` G Edhaya Chandran
2023-11-10 19:08 ` [edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo Rebecca Cran
2023-11-13 14:48 ` Laszlo Ersek
2023-11-29 8:15 ` G Edhaya Chandran
2023-12-11 11:12 ` Sunny Wang
2023-12-11 17:24 ` [edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo Rebecca Cran
2023-12-15 21:25 ` Rebecca Cran
2023-12-16 16:30 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB7791EE31A9AB6D7F62446FF4858FA@AS8PR08MB7791.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox