From: "Wang, Sunny (HPS SW)" <sunnywang@hpe.com>
To: Ruiyu Ni <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Michael Turner <Michael.Turner@microsoft.com>,
"Wang, Sunny (HPS SW)" <sunnywang@hpe.com>
Subject: Re: [PATCH v4 9/9] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()
Date: Wed, 4 Jul 2018 03:39:53 +0000 [thread overview]
Message-ID: <AT5PR8401MB0929BA86BC22CDB4D3895973A8410@AT5PR8401MB0929.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20180704015057.35908-10-ruiyu.ni@intel.com>
Looks good to me. This is clearer.
Reviewed-by: Sunny Wang <sunnywang@hpe.com>
-----Original Message-----
From: Ruiyu Ni [mailto:ruiyu.ni@intel.com]
Sent: Wednesday, July 04, 2018 9:51 AM
To: edk2-devel@lists.01.org
Cc: Sean Brogan <sean.brogan@microsoft.com>; Michael Turner <Michael.Turner@microsoft.com>; Wang, Sunny (HPS SW) <sunnywang@hpe.com>
Subject: [PATCH v4 9/9] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()
When no boot option can be launched, BDS core calls
PlatformBootManagerUnableToBoot() to let platform BdsDxe handle it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Sunny Wang <sunnywang@hpe.com>
---
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
index 39b643c77a..a25663ea43 100644
--- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
+++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
@@ -1043,6 +1043,7 @@ BdsEntry (
}
DEBUG ((EFI_D_ERROR, "[Bds] Unable to boot!\n"));
+ PlatformBootManagerUnableToBoot ();
CpuDeadLoop ();
}
--
2.16.1.windows.1
next prev parent reply other threads:[~2018-07-04 3:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 1:50 [PATCH v4 0/9] Add platform hook for ultimate boot failure Ruiyu Ni
2018-07-04 1:50 ` [PATCH v4 1/9] MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot Ruiyu Ni
2018-07-04 3:39 ` Wang, Sunny (HPS SW)
2018-07-04 1:50 ` [PATCH v4 2/9] CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot Ruiyu Ni
2018-07-04 1:50 ` [PATCH v4 3/9] OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot Ruiyu Ni
2018-07-04 1:50 ` [PATCH v4 4/9] Nt32Pkg/PlatformBDS: " Ruiyu Ni
2018-07-04 1:50 ` [PATCH v4 5/9] QuarkPlatform/PlatformBDS: " Ruiyu Ni
2018-07-04 1:50 ` [PATCH v4 6/9] ArmPkg/PlatformBDS: " Ruiyu Ni
2018-07-11 14:21 ` Ard Biesheuvel
2018-07-16 9:07 ` Ni, Ruiyu
2018-07-16 11:01 ` Ard Biesheuvel
2018-07-04 1:50 ` [PATCH v4 7/9] ArmVirtPkg/PlatformBDS: " Ruiyu Ni
2018-07-05 12:06 ` Laszlo Ersek
2018-07-04 1:50 ` [PATCH v4 8/9] MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging" Ruiyu Ni
2018-07-04 3:39 ` Wang, Sunny (HPS SW)
2018-07-04 1:50 ` [PATCH v4 9/9] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot() Ruiyu Ni
2018-07-04 3:39 ` Wang, Sunny (HPS SW) [this message]
2018-07-04 1:55 ` [PATCH v4 0/9] Add platform hook for ultimate boot failure Ni, Ruiyu
2018-07-05 12:07 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AT5PR8401MB0929BA86BC22CDB4D3895973A8410@AT5PR8401MB0929.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox