Yes. It doesn’t happen on .c file, only on INF file. Ok. I will submit this issue on BZ. Thanks From: gaoliming [mailto:gaoliming@byosoft.com.cn] Sent: Friday, October 16, 2020 9:16 AM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; bret.barkelew@microsoft.com Cc: 'Sean Brogan' Subject: 回复: [edk2-devel] CI test on copyright Abner: Do you mean the same Copyright in .c doesn’t trig the error message? But, this Copyright in .inf file will trig the error. If yes, this should be an issue in ECC checker. Can you submit one BZ? I will check it. # (C) Copyright 2020 Hewlett Packard Enterprise Development LP
Thanks Liming 发件人: bounce+27952+66300+4905953+8761045@groups.io > 代表 Abner Chang 发送时间: 2020年10月16日 9:08 收件人: devel@edk2.groups.io; bret.barkelew@microsoft.com 抄送: Sean Brogan > 主题: Re: [edk2-devel] CI test on copyright Hmm, it doesn’t work with below header. Still fail. ## @file # Implementation of EFI REST JSON Structure Protocol. # # (C) Copyright 2020 Hewlett Packard Enterprise Development LP
# SPDX-License-Identifier: BSD-2-Clause-Patent ## I had confirmed it again, CI test passed with below one, move “(C)” to behind Copyright. ## @file # Implementation of EFI REST JSON Structure Protocol. # # Copyright (C) 2020 Hewlett Packard Enterprise Development LP
# SPDX-License-Identifier: BSD-2-Clause-Patent ## From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io Sent: Friday, October 16, 2020 12:35 AM To: Chang, Abner (HPS SW/FW Technologist) >; devel@edk2.groups.io Cc: Sean Brogan > Subject: Re: [edk2-devel] CI test on copyright Try removing the extra line between “SPDX” and “##”. - Bret From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, October 15, 2020 9:32 AM To: Bret Barkelew; devel@edk2.groups.io Cc: Sean Brogan Subject: [EXTERNAL] RE: CI test on copyright ## @file # Implementation of EFI REST JSON Structure Protocol. # # (C) Copyright 2020 Hewlett Packard Enterprise Development LP
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## Or you can check the PR, https://github.com/tianocore/edk2/pull/1019 Abner From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] Sent: Friday, October 16, 2020 12:24 AM To: Chang, Abner (HPS SW/FW Technologist) >; devel@edk2.groups.io Cc: Sean Brogan > Subject: RE: CI test on copyright Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags. - Bret From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, October 15, 2020 9:21 AM To: devel@edk2.groups.io Cc: Bret Barkelew; Sean Brogan Subject: [EXTERNAL] CI test on copyright Hi Sean and Bret, I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below, (C) Copyright 2020 Hewlett Packard Enterprise Development LP
[cid:image001.png@01D6A39D.6BAB26E0] The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h. Copyright (C) 2020 Hewlett Packard Enterprise Development LP
Any idea on this? Abner