Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2431 bytes --]

Hi, all

Based on the discussion https://edk2.groups.io/g/devel/message/64493, we
make the conclusion to defer one week for edk2-stable202008 to include the
important patch for RiscV. Soft Feature Freeze (SFF) will start from today
(2020-08-24). Below is new edk2-stable202008 tag planning proposed schedule
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planni
ng>
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Plannin
g. If you have any comments, please raise it.

 

Date (00:00:00 UTC-8) Description

2020-06-03  Beginning of development

2020-08-07  Feature Planning Freeze

2020-08-24  Soft Feature Freeze

2020-08-28  Hard Feature Freeze

2020-09-04  Release

 

Because SFF date is changed, if the patches passed code review before SFF
date (2020-08-24), the patches can still be merged for this stable tag. Here
is the patch list those passed code review before new SFF date. For below
features, I will let the feature owner decides whether to merge it for this
stable tag.

 

Feature List:

https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add
strncmp macro to use AsciiStrnCmp

https://edk2.groups.io/g/devel/message/64363 [PATCH v5 0/3] UefiPayloadPkg:
Runtime MMCONF

https://edk2.groups.io/g/devel/message/64354 [PATCH v4 0/8] Need add a FSP
binary measurement

 

Bug List:

https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1] MdePkg/Include: Add
missing definitions of SMBIOS type 42h in SmBios.h

https://edk2.groups.io/g/devel/message/64507 [PATCH v2 1/1]
UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

https://edk2.groups.io/g/devel/message/64539 [PATCH] Maintainers.txt: Update
Liming mail address

https://edk2.groups.io/g/devel/message/64529 [PATCH] .pytool/EccCheck:
Disable Ecc error code 10014 for open CI

https://edk2.groups.io/g/devel/message/61938 [PATCH v2 1/1] MdePkg :
UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

 

The remaining patches can continue to review without break in edk2
community. If the patch is sent before Soft Feature Freeze, and plans to
catch this stable tag, the patch contributor need reply to his patch and
notify edk2 community. If the patch is sent after Soft Feature Freeze, and
plans to catch this stable tag, please add edk2-stable202008 key words in
the patch title and BZ, so the community know this patch target and give the
feedback.

 

Thanks

Liming


[-- Attachment #2: Type: text/html, Size: 10510 bytes --]

Re: Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Laszlo Ersek]

Hi Liming,

On 08/24/20 03:49, gaoliming wrote:
> Hi, all
>
> Based on the discussion https://edk2.groups.io/g/devel/message/64493,
> we make the conclusion to defer one week for edk2-stable202008 to
> include the important patch for RiscV. Soft Feature Freeze (SFF) will
> start from today (2020-08-24). Below is new edk2-stable202008 tag
> planning proposed schedule
> <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning>.
> If you have any comments, please raise it.
>
>
> Date (00:00:00 UTC-8) Description
> 2020-06-03            Beginning of development
> 2020-08-07            Feature Planning Freeze
> 2020-08-24            Soft Feature Freeze
> 2020-08-28            Hard Feature Freeze
> 2020-09-04            Release
>
> Because SFF date is changed, if the patches passed code review before
> SFF date (2020-08-24), the patches can still be merged for this stable
> tag. Here is the patch list those passed code review before new SFF
> date. For below features, I will let the feature owner decides whether
> to merge it for this stable tag.

As of this writing:

- Mon Aug 24 12:59:59 UTC 2020

we've entered the (new) Soft Feature Freeze. (The SFF date is 2020-08-24
00:00:00 UTC-8; in UTC, that's Mon Aug 24 08:00:00 UTC 2020 -- about
five hours ago.)

So:

> Feature List:
>
> https://edk2.groups.io/g/devel/message/63767
> [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp

I'm going to merge this soon (with Leif's review).

> https://edk2.groups.io/g/devel/message/64363
> [PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF

The UefiPayloadPkg patches in the series (#1, #3) have not received
reviews. We have to delay this until after the stable tag.

> https://edk2.groups.io/g/devel/message/64354
> [PATCH v4 0/8] Need add a FSP binary measurement

The SecurityPkg patches have not been approved yet, and Bret and Jiewen
are still testing / discussing (as far as I understand):
<https://edk2.groups.io/g/devel/message/64526>. Material for the next
tag.


On the other hand, I'm going to push two patches that had been reviewed
just before we entered the *delayed* SFF:

  https://edk2.groups.io/g/devel/message/64345
  [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix

  https://edk2.groups.io/g/devel/message/62561
  [PATCH] OvmfPkg/SmmControl2Dxe: negotiate ICH9_LPC_SMI_F_CPU_HOTPLUG

> Bug List:
>
> https://edk2.groups.io/g/devel/message/50406
> [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h

Liming, can you please merge this patch? For some reason I can't see it
in my local archives! (Only responses to it.)

> https://edk2.groups.io/g/devel/message/64507
> [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

I'm going to merge this soon.

> https://edk2.groups.io/g/devel/message/64539
> [PATCH] Maintainers.txt: Update Liming mail address

I'll merge this one as well.

> https://edk2.groups.io/g/devel/message/64529
> [PATCH] .pytool/EccCheck: Disable Ecc error code 10014 for open CI

Already merged as commit d4e0b9607c9a.

>
> https://edk2.groups.io/g/devel/message/61938
> [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

I'll merge it.

Thanks!
Laszlo

回复: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[gaoliming]

Laszlo:
  Thanks for your great support. 

  I merge SmBios type 42 patch @ 78ab44cb96808bd3ff0edf312599f94a6a92172a.

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64572+4905953+8761045@groups.io
> <bounce+27952+64572+4905953+8761045@groups.io> 代表 Laszlo Ersek
> 发送时间: 2020年8月24日 21:38
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; 'Leif Lindholm'
> <leif@nuviainc.com>; afish@apple.com; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Guptha, Soumya K'
> <soumya.k.guptha@intel.com>
> 抄送: devel@edk2.groups.io; announce@edk2.groups.io; 'Chang, Abner (HPS
> SW/FW Technologist)' <abner.chang@hpe.com>; qi1.zhang@intel.com;
> marcello.bauer@9elements.com
> 主题: Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24
for
> edk2-stable202008
> 
> Hi Liming,
> 
> On 08/24/20 03:49, gaoliming wrote:
> > Hi, all
> >
> > Based on the discussion https://edk2.groups.io/g/devel/message/64493,
> > we make the conclusion to defer one week for edk2-stable202008 to
> > include the important patch for RiscV. Soft Feature Freeze (SFF) will
> > start from today (2020-08-24). Below is new edk2-stable202008 tag
> > planning proposed schedule
> >
>
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Plann
> ing>.
> > If you have any comments, please raise it.
> >
> >
> > Date (00:00:00 UTC-8) Description
> > 2020-06-03            Beginning of development
> > 2020-08-07            Feature Planning Freeze
> > 2020-08-24            Soft Feature Freeze
> > 2020-08-28            Hard Feature Freeze
> > 2020-09-04            Release
> >
> > Because SFF date is changed, if the patches passed code review before
> > SFF date (2020-08-24), the patches can still be merged for this stable
> > tag. Here is the patch list those passed code review before new SFF
> > date. For below features, I will let the feature owner decides whether
> > to merge it for this stable tag.
> 
> As of this writing:
> 
> - Mon Aug 24 12:59:59 UTC 2020
> 
> we've entered the (new) Soft Feature Freeze. (The SFF date is 2020-08-24
> 00:00:00 UTC-8; in UTC, that's Mon Aug 24 08:00:00 UTC 2020 -- about five
> hours ago.)
> 
> So:
> 
> > Feature List:
> >
> > https://edk2.groups.io/g/devel/message/63767
> > [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> 
> I'm going to merge this soon (with Leif's review).
> 
> > https://edk2.groups.io/g/devel/message/64363
> > [PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF
> 
> The UefiPayloadPkg patches in the series (#1, #3) have not received
reviews.
> We have to delay this until after the stable tag.
> 
> > https://edk2.groups.io/g/devel/message/64354
> > [PATCH v4 0/8] Need add a FSP binary measurement
> 
> The SecurityPkg patches have not been approved yet, and Bret and Jiewen
> are still testing / discussing (as far as I understand):
> <https://edk2.groups.io/g/devel/message/64526>. Material for the next tag.
> 
> 
> On the other hand, I'm going to push two patches that had been reviewed
just
> before we entered the *delayed* SFF:
> 
>   https://edk2.groups.io/g/devel/message/64345
>   [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix
> 
>   https://edk2.groups.io/g/devel/message/62561
>   [PATCH] OvmfPkg/SmmControl2Dxe: negotiate
> ICH9_LPC_SMI_F_CPU_HOTPLUG
> 
> > Bug List:
> >
> > https://edk2.groups.io/g/devel/message/50406
> > [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h
> > in SmBios.h
> 
> Liming, can you please merge this patch? For some reason I can't see it in
my
> local archives! (Only responses to it.)
> 
> > https://edk2.groups.io/g/devel/message/64507
> > [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement
> > variable
> 
> I'm going to merge this soon.
> 
> > https://edk2.groups.io/g/devel/message/64539
> > [PATCH] Maintainers.txt: Update Liming mail address
> 
> I'll merge this one as well.
> 
> > https://edk2.groups.io/g/devel/message/64529
> > [PATCH] .pytool/EccCheck: Disable Ecc error code 10014 for open CI
> 
> Already merged as commit d4e0b9607c9a.
> 
> >
> > https://edk2.groups.io/g/devel/message/61938
> > [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in
> > FileHandleReadLine()
> 
> I'll merge it.
> 
> Thanks!
> Laszlo
> 
> 
> 

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Abner Chang]

Liming and Laszlo, many thanks to your helps on this! 

> -----Original Message-----
> From: gaoliming [mailto:gaoliming@byosoft.com.cn]
> Sent: Tuesday, August 25, 2020 9:20 AM
> To: devel@edk2.groups.io; lersek@redhat.com; 'Leif Lindholm'
> <leif@nuviainc.com>; afish@apple.com; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Guptha, Soumya K'
> <soumya.k.guptha@intel.com>
> Cc: announce@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; qi1.zhang@intel.com;
> marcello.bauer@9elements.com
> Subject: 回复: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-
> 24 for edk2-stable202008
> 
> Laszlo:
>   Thanks for your great support.
> 
>   I merge SmBios type 42 patch @
> 78ab44cb96808bd3ff0edf312599f94a6a92172a.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+64572+4905953+8761045@groups.io
> > <bounce+27952+64572+4905953+8761045@groups.io> 代表 Laszlo Ersek
> > 发送时间: 2020年8月24日 21:38
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; 'Leif Lindholm'
> > <leif@nuviainc.com>; afish@apple.com; 'Kinney, Michael D'
> > <michael.d.kinney@intel.com>; 'Guptha, Soumya K'
> > <soumya.k.guptha@intel.com>
> > 抄送: devel@edk2.groups.io; announce@edk2.groups.io; 'Chang, Abner
> (HPS
> > SW/FW Technologist)' <abner.chang@hpe.com>; qi1.zhang@intel.com;
> > marcello.bauer@9elements.com
> > 主题: Re: [edk2-devel] Soft Feature Freeze start date delays to
> > 2020-08-24
> for
> > edk2-stable202008
> >
> > Hi Liming,
> >
> > On 08/24/20 03:49, gaoliming wrote:
> > > Hi, all
> > >
> > > Based on the discussion
> > > INVALID URI REMOVED
> > >
> g_devel_message_64493&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > > cFv1I6pPqN8&s=EWWY74jVVLuAgol6-VxRBNCxlmUOyawSRBZc5PFPP-
> U&e= , we
> > > make the conclusion to defer one week for edk2-stable202008 to
> > > include the important patch for RiscV. Soft Feature Freeze (SFF)
> > > will start from today (2020-08-24). Below is new edk2-stable202008
> > > tag planning proposed schedule
> > >
> >
> <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-
> Plann
> > ing>.
> > > If you have any comments, please raise it.
> > >
> > >
> > > Date (00:00:00 UTC-8) Description
> > > 2020-06-03            Beginning of development
> > > 2020-08-07            Feature Planning Freeze
> > > 2020-08-24            Soft Feature Freeze
> > > 2020-08-28            Hard Feature Freeze
> > > 2020-09-04            Release
> > >
> > > Because SFF date is changed, if the patches passed code review
> > > before SFF date (2020-08-24), the patches can still be merged for
> > > this stable tag. Here is the patch list those passed code review
> > > before new SFF date. For below features, I will let the feature
> > > owner decides whether to merge it for this stable tag.
> >
> > As of this writing:
> >
> > - Mon Aug 24 12:59:59 UTC 2020
> >
> > we've entered the (new) Soft Feature Freeze. (The SFF date is
> > 2020-08-24
> > 00:00:00 UTC-8; in UTC, that's Mon Aug 24 08:00:00 UTC 2020 -- about
> > five hours ago.)
> >
> > So:
> >
> > > Feature List:
> > >
> > > INVALID URI REMOVED
> > >
> g_devel_message_63767&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > >
> cFv1I6pPqN8&s=DZ4LNCQI974irYanMafqUNTinVCebHjYzyjmNrzw44A&e=
> > > [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> >
> > I'm going to merge this soon (with Leif's review).
> >
> > > INVALID URI REMOVED
> > >
> g_devel_message_64363&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > >
> cFv1I6pPqN8&s=ticdzJnT3RUAQhR6PWJGg89mpw89bXziNJvmmBxDkAI&e=
> > > [PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF
> >
> > The UefiPayloadPkg patches in the series (#1, #3) have not received
> reviews.
> > We have to delay this until after the stable tag.
> >
> > > INVALID URI REMOVED
> > >
> g_devel_message_64354&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > > cFv1I6pPqN8&s=p-jAd4Mr-
> vHN_CpVOx3c7yEd2oGKeNZjGYgc461S5vk&e=
> > > [PATCH v4 0/8] Need add a FSP binary measurement
> >
> > The SecurityPkg patches have not been approved yet, and Bret and
> > Jiewen are still testing / discussing (as far as I understand):
> > <INVALID URI REMOVED
> 3A__edk2.groups.io_g_devel_message_64526&d=DwIFbw&c=C5b8zRQO1m
> iGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m
> =Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3AycFv1I6pPqN8&s=gFa0PtigKqGf1y8gQHp87UI_
> aO_4-U6WDGQjzKR6HdY&e= >. Material for the next tag.
> >
> >
> > On the other hand, I'm going to push two patches that had been
> > reviewed
> just
> > before we entered the *delayed* SFF:
> >
> >   INVALID URI REMOVED
> 3A__edk2.groups.io_g_devel_message_64345&d=DwIFbw&c=C5b8zRQO1m
> iGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m
> =Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3AycFv1I6pPqN8&s=O19EomxNTCrUwxTvj-
> ptq6b9rN99JlWABtfXdpRzP-s&e=
> >   [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix
> >
> >   INVALID URI REMOVED
> 3A__edk2.groups.io_g_devel_message_62561&d=DwIFbw&c=C5b8zRQO1m
> iGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m
> =Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3AycFv1I6pPqN8&s=l58Kk65BnkNkJTNnnRq1BnP
> uwN_E6MQhRROOVVJRBTg&e=
> >   [PATCH] OvmfPkg/SmmControl2Dxe: negotiate
> ICH9_LPC_SMI_F_CPU_HOTPLUG
> >
> > > Bug List:
> > >
> > > INVALID URI REMOVED
> > >
> g_devel_message_50406&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > >
> cFv1I6pPqN8&s=Y8zo0o30upzM0u4d_Zo_8nB1AjofDEEAZuyAHHVX130&e=
> > > [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type
> > > 42h in SmBios.h
> >
> > Liming, can you please merge this patch? For some reason I can't see
> > it in
> my
> > local archives! (Only responses to it.)
> >
> > > INVALID URI REMOVED
> > >
> g_devel_message_64507&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > > cFv1I6pPqN8&s=Y3X-
> hLUsJoLc2kmWhUC1RTJIJWhib9Nu6zvFwe2ukEk&e=
> > > [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the
> > > DoDecrement variable
> >
> > I'm going to merge this soon.
> >
> > > INVALID URI REMOVED
> > >
> g_devel_message_64539&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > >
> cFv1I6pPqN8&s=WcrK8E6Ev45Z8U6Demk_xfIfeox5TfHubECVjd7dkHA&e=
> > > [PATCH] Maintainers.txt: Update Liming mail address
> >
> > I'll merge this one as well.
> >
> > > INVALID URI REMOVED
> > >
> g_devel_message_64529&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > > cFv1I6pPqN8&s=opEb0cPmCfOMCuQ-
> NA_FFGjYBREml1l2ZerWZpc9Wgw&e=
> > > [PATCH] .pytool/EccCheck: Disable Ecc error code 10014 for open CI
> >
> > Already merged as commit d4e0b9607c9a.
> >
> > >
> > > INVALID URI REMOVED
> > >
> g_devel_message_61938&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> SN6FZBN4V
> > > gi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=Ezm_GF-
> Nrwz68WJSOEmoaYue4UtvI3Ay
> > > cFv1I6pPqN8&s=9YPHAg6xKUdunOt7W1yimEOAaW-24n-
> veTxCU1SSkoI&e=
> > > [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in
> > > FileHandleReadLine()
> >
> > I'll merge it.
> >
> > Thanks!
> > Laszlo
> >
> >
> > 
> 
> 

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Yao, Jiewen]

To clarify below:
I just notice this one week delay. It impacts us.

> https://edk2.groups.io/g/devel/message/64354
> [PATCH v4 0/8] Need add a FSP binary measurement

The SecurityPkg patches have not been approved yet, and Bret and Jiewen
are still testing / discussing (as far as I understand):
<https://edk2.groups.io/g/devel/message/64526>. Material for the next
tag.

[Jiewen] I think the security pkg is already approved by me and Jian (SecurityPkg maintainer)
Bret also provides feedback that it looks good.

I request to check in to stable202008, if possible.


Thank you
Yao Jiewen



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Monday, August 24, 2020 9:38 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; 'Leif Lindholm'
> <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Guptha, Soumya K
> <soumya.k.guptha@intel.com>
> Cc: devel@edk2.groups.io; announce@edk2.groups.io; 'Chang, Abner (HPS
> SW/FW Technologist)' <abner.chang@hpe.com>; Zhang, Qi1
> <qi1.zhang@intel.com>; marcello.bauer@9elements.com
> Subject: Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for
> edk2-stable202008
> 
> Hi Liming,
> 
> On 08/24/20 03:49, gaoliming wrote:
> > Hi, all
> >
> > Based on the discussion https://edk2.groups.io/g/devel/message/64493,
> > we make the conclusion to defer one week for edk2-stable202008 to
> > include the important patch for RiscV. Soft Feature Freeze (SFF) will
> > start from today (2020-08-24). Below is new edk2-stable202008 tag
> > planning proposed schedule
> > <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-
> Planning>.
> > If you have any comments, please raise it.
> >
> >
> > Date (00:00:00 UTC-8) Description
> > 2020-06-03            Beginning of development
> > 2020-08-07            Feature Planning Freeze
> > 2020-08-24            Soft Feature Freeze
> > 2020-08-28            Hard Feature Freeze
> > 2020-09-04            Release
> >
> > Because SFF date is changed, if the patches passed code review before
> > SFF date (2020-08-24), the patches can still be merged for this stable
> > tag. Here is the patch list those passed code review before new SFF
> > date. For below features, I will let the feature owner decides whether
> > to merge it for this stable tag.
> 
> As of this writing:
> 
> - Mon Aug 24 12:59:59 UTC 2020
> 
> we've entered the (new) Soft Feature Freeze. (The SFF date is 2020-08-24
> 00:00:00 UTC-8; in UTC, that's Mon Aug 24 08:00:00 UTC 2020 -- about
> five hours ago.)
> 
> So:
> 
> > Feature List:
> >
> > https://edk2.groups.io/g/devel/message/63767
> > [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> 
> I'm going to merge this soon (with Leif's review).
> 
> > https://edk2.groups.io/g/devel/message/64363
> > [PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF
> 
> The UefiPayloadPkg patches in the series (#1, #3) have not received
> reviews. We have to delay this until after the stable tag.
> 
> > https://edk2.groups.io/g/devel/message/64354
> > [PATCH v4 0/8] Need add a FSP binary measurement
> 
> The SecurityPkg patches have not been approved yet, and Bret and Jiewen
> are still testing / discussing (as far as I understand):
> <https://edk2.groups.io/g/devel/message/64526>. Material for the next
> tag.
> 
> 
> On the other hand, I'm going to push two patches that had been reviewed
> just before we entered the *delayed* SFF:
> 
>   https://edk2.groups.io/g/devel/message/64345
>   [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix
> 
>   https://edk2.groups.io/g/devel/message/62561
>   [PATCH] OvmfPkg/SmmControl2Dxe: negotiate
> ICH9_LPC_SMI_F_CPU_HOTPLUG
> 
> > Bug List:
> >
> > https://edk2.groups.io/g/devel/message/50406
> > [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in
> SmBios.h
> 
> Liming, can you please merge this patch? For some reason I can't see it
> in my local archives! (Only responses to it.)
> 
> > https://edk2.groups.io/g/devel/message/64507
> > [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement
> variable
> 
> I'm going to merge this soon.
> 
> > https://edk2.groups.io/g/devel/message/64539
> > [PATCH] Maintainers.txt: Update Liming mail address
> 
> I'll merge this one as well.
> 
> > https://edk2.groups.io/g/devel/message/64529
> > [PATCH] .pytool/EccCheck: Disable Ecc error code 10014 for open CI
> 
> Already merged as commit d4e0b9607c9a.
> 
> >
> > https://edk2.groups.io/g/devel/message/61938
> > [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in
> FileHandleReadLine()
> 
> I'll merge it.
> 
> Thanks!
> Laszlo
> 
> 
> 

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Laszlo Ersek]

Hi Jiewen,

On 08/26/20 03:19, Yao, Jiewen wrote:
> To clarify below:
> I just notice this one week delay. It impacts us.
>
>> https://edk2.groups.io/g/devel/message/64354
>> [PATCH v4 0/8] Need add a FSP binary measurement
>
> The SecurityPkg patches have not been approved yet, and Bret and
> Jiewen are still testing / discussing (as far as I understand):
> <https://edk2.groups.io/g/devel/message/64526>. Material for the next
> tag.
>
> [Jiewen] I think the security pkg is already approved by me and Jian
> (SecurityPkg maintainer) Bret also provides feedback that it looks
> good.

The series in question has three SecurityPkg patches:

  [PATCH v4 1/8] SecurityPkg/TcgEventLogRecordLib: add new lib for firmware measurement
  [PATCH v4 5/8] SecurityPkg/dsc: add FvEventLogRecordLib
  [PATCH v4 7/8] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

As I'm writing this, *none* of the listed patches have any kind of
Reviewed-by or Acked-by, either included in the patches themselves, or
posted in response to them.

> I request to check in to stable202008, if possible.

We can do that only if (a) we extend the SFF deadline again, and (b)
each of the SecurityPkg patches receives at least an Acked-by from one
of the SecurityPkg maintainers, until the new deadline.

I'm certainly not against the idea. I don't mind if the release slips
some more; it's OK to say that we're not ready to release yet. The point
is, as long as we're doing more work for completing the release, we
should prolong the stabilization period as well (opportunity for people
to test).

Thanks,
Laszlo

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Yao, Jiewen]

HI Laszlo
I checked the history.

Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with review-by on V3 patch series in August 15, with comment to rename FvEventLogRecordLib to TcgEventLogRecordLib.
Qi sent v4 series in August 17, with only naming change from FvEventLogRecordLib to TcgEventLogRecordLib.
Jian replied "[PATCH v3 0/8] Need add a FSP binary measurement" with reviewed-by on V3 patch series in August 18.

So I treat this patch series is qualified to check in (since V4 adopted my comment). But please let me know if there is any misunderstanding.


When I am about to merge, I am told that we are in SFF and I cannot check in.
According to the plan, I will check in after August 28, which is end of August. It is still OK for me.
2020-08-14  Soft Feature Freeze
2020-08-21  Hard Feature Freeze
2020-08-28  Release

But now, if we need delay one week, then the final release data will be September. If I cannot check in now, I will have to check in at September.
That is why I said, it impacts me, because of this one week delay.

Thank you
Yao Jiewen


> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, August 26, 2020 5:54 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming
> <gaoliming@byosoft.com.cn>; 'Leif Lindholm' <leif@nuviainc.com>;
> afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha,
> Soumya K <soumya.k.guptha@intel.com>
> Cc: announce@edk2.groups.io; 'Chang, Abner (HPS SW/FW Technologist)'
> <abner.chang@hpe.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> marcello.bauer@9elements.com
> Subject: Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for
> edk2-stable202008
> 
> Hi Jiewen,
> 
> On 08/26/20 03:19, Yao, Jiewen wrote:
> > To clarify below:
> > I just notice this one week delay. It impacts us.
> >
> >> https://edk2.groups.io/g/devel/message/64354
> >> [PATCH v4 0/8] Need add a FSP binary measurement
> >
> > The SecurityPkg patches have not been approved yet, and Bret and
> > Jiewen are still testing / discussing (as far as I understand):
> > <https://edk2.groups.io/g/devel/message/64526>. Material for the next
> > tag.
> >
> > [Jiewen] I think the security pkg is already approved by me and Jian
> > (SecurityPkg maintainer) Bret also provides feedback that it looks
> > good.
> 
> The series in question has three SecurityPkg patches:
> 
>   [PATCH v4 1/8] SecurityPkg/TcgEventLogRecordLib: add new lib for firmware
> measurement
>   [PATCH v4 5/8] SecurityPkg/dsc: add FvEventLogRecordLib
>   [PATCH v4 7/8] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY
> 
> As I'm writing this, *none* of the listed patches have any kind of
> Reviewed-by or Acked-by, either included in the patches themselves, or
> posted in response to them.
> 
> > I request to check in to stable202008, if possible.
> 
> We can do that only if (a) we extend the SFF deadline again, and (b)
> each of the SecurityPkg patches receives at least an Acked-by from one
> of the SecurityPkg maintainers, until the new deadline.
> 
> I'm certainly not against the idea. I don't mind if the release slips
> some more; it's OK to say that we're not ready to release yet. The point
> is, as long as we're doing more work for completing the release, we
> should prolong the stabilization period as well (opportunity for people
> to test).
> 
> Thanks,
> Laszlo

回复: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[gaoliming]

Jiewen:

For this patch set V3, I see you give reviewed-by on Aug 15th https://edk2.groups.io/g/devel/message/64299 
For V4, https://edk2.groups.io/g/devel/message/64354, it makes the change per your comment. 
So, I agree you as SecurityPkg maintainter reviewed-by is OK for V4 patch set. 

And, I also see Chiu, Chasel as IntelFsp2WrapperPkg maintainer gives reviewed-by on Aug 18th for the changes in IntelFsp2WrapperPkg

So, I think the latest patch set V4 finished code review before new SFF start date (2020-08-24). 
Based on SFF definition, I agree this patch set can be merged for this stable tag 202008. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64638+4905953+8761045@groups.io
> <bounce+27952+64638+4905953+8761045@groups.io> 代表 Yao, Jiewen
> 发送时间: 2020年8月26日 18:17
> 收件人: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; gaoliming
> <gaoliming@byosoft.com.cn>; 'Leif Lindholm' <leif@nuviainc.com>;
> afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha,
> Soumya K <soumya.k.guptha@intel.com>
> 抄送: announce@edk2.groups.io; 'Chang, Abner (HPS SW/FW Technologist)'
> <abner.chang@hpe.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> marcello.bauer@9elements.com
> 主题: Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for
> edk2-stable202008
> 
> HI Laszlo
> I checked the history.
> 
> Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with
> review-by on V3 patch series in August 15, with comment to rename
> FvEventLogRecordLib to TcgEventLogRecordLib.
> Qi sent v4 series in August 17, with only naming change from
> FvEventLogRecordLib to TcgEventLogRecordLib.
> Jian replied "[PATCH v3 0/8] Need add a FSP binary measurement" with
> reviewed-by on V3 patch series in August 18.
> 
> So I treat this patch series is qualified to check in (since V4 adopted my
> comment). But please let me know if there is any misunderstanding.
> 
> 
> When I am about to merge, I am told that we are in SFF and I cannot check in.
> According to the plan, I will check in after August 28, which is end of August. It
> is still OK for me.
> 2020-08-14  Soft Feature Freeze
> 2020-08-21  Hard Feature Freeze
> 2020-08-28  Release
> 
> But now, if we need delay one week, then the final release data will be
> September. If I cannot check in now, I will have to check in at September.
> That is why I said, it impacts me, because of this one week delay.
> 
> Thank you
> Yao Jiewen
> 
> 
> > -----Original Message-----
> > From: Laszlo Ersek <lersek@redhat.com>
> > Sent: Wednesday, August 26, 2020 5:54 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming
> > <gaoliming@byosoft.com.cn>; 'Leif Lindholm' <leif@nuviainc.com>;
> > afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>;
> Guptha,
> > Soumya K <soumya.k.guptha@intel.com>
> > Cc: announce@edk2.groups.io; 'Chang, Abner (HPS SW/FW Technologist)'
> > <abner.chang@hpe.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> > marcello.bauer@9elements.com
> > Subject: Re: [edk2-devel] Soft Feature Freeze start date delays to
> 2020-08-24 for
> > edk2-stable202008
> >
> > Hi Jiewen,
> >
> > On 08/26/20 03:19, Yao, Jiewen wrote:
> > > To clarify below:
> > > I just notice this one week delay. It impacts us.
> > >
> > >> https://edk2.groups.io/g/devel/message/64354
> > >> [PATCH v4 0/8] Need add a FSP binary measurement
> > >
> > > The SecurityPkg patches have not been approved yet, and Bret and
> > > Jiewen are still testing / discussing (as far as I understand):
> > > <https://edk2.groups.io/g/devel/message/64526>. Material for the next
> > > tag.
> > >
> > > [Jiewen] I think the security pkg is already approved by me and Jian
> > > (SecurityPkg maintainer) Bret also provides feedback that it looks
> > > good.
> >
> > The series in question has three SecurityPkg patches:
> >
> >   [PATCH v4 1/8] SecurityPkg/TcgEventLogRecordLib: add new lib for
> firmware
> > measurement
> >   [PATCH v4 5/8] SecurityPkg/dsc: add FvEventLogRecordLib
> >   [PATCH v4 7/8] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY
> >
> > As I'm writing this, *none* of the listed patches have any kind of
> > Reviewed-by or Acked-by, either included in the patches themselves, or
> > posted in response to them.
> >
> > > I request to check in to stable202008, if possible.
> >
> > We can do that only if (a) we extend the SFF deadline again, and (b)
> > each of the SecurityPkg patches receives at least an Acked-by from one
> > of the SecurityPkg maintainers, until the new deadline.
> >
> > I'm certainly not against the idea. I don't mind if the release slips
> > some more; it's OK to say that we're not ready to release yet. The point
> > is, as long as we're doing more work for completing the release, we
> > should prolong the stabilization period as well (opportunity for people
> > to test).
> >
> > Thanks,
> > Laszlo
> 
> 
> 

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Laszlo Ersek]

On 08/26/20 12:16, Yao, Jiewen wrote:
> HI Laszlo
> I checked the history.
> 
> Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with review-by on V3 patch series in August 15, with comment to rename FvEventLogRecordLib to TcgEventLogRecordLib.

You are correct:

https://edk2.groups.io/g/devel/message/64299

I have two comments on this.

First, because you authored the IntelFsp2WrapperPkg patches in the
series, you cannot R-b them (you cannot R-b your own patches, even if
they are resent by someone else). However, that's not necessary: the
IntelFsp2WrapperPkg is maintained by Chasel Chiu, and Chasel did review
those patches, under v4, in the end.

Second, the v4 submitter, Qi Zhang, should have picked up your R-b from
under v3, and included them in the v4 posting. (Assuming the v3->v4
changes were exactly as you requested, under v3.)

> Qi sent v4 series in August 17, with only naming change from FvEventLogRecordLib to TcgEventLogRecordLib.

OK. In this case, Qi should have posted the v4 SecurityPkg patches with
your R-b *already* present.

> Jian replied "[PATCH v3 0/8] Need add a FSP binary measurement" with reviewed-by on V3 patch series in August 18.

That's correct too:

https://edk2.groups.io/g/devel/message/64342

This means that Qi should have sent v4 with Jian's R-b on *every* patch.

> So I treat this patch series is qualified to check in (since V4 adopted my comment). But please let me know if there is any misunderstanding.

No, you are entirely correct. I was misled because v4 was not posted
correctly, with regard to the feedback tags given under v3.

So, what remains to do now is this: until the HFF (2020-08-28) we can,
and should, merge v4 of the series. As follows:

- apply Jian's R-b from under v3 to every patch in the series

- apply your R-b from under v3 to the patches you did *not* author (that
is, apply the tag to the SecurityPkg patches, plus to
"IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib")

- apply Chasel Chiu's R-b from under v4 to the IntelFsp2WrapperPkg patches.

This will make the series fully reviewed, and mergeable.

Note that Chasel requested a copyright year update when pushing, here:
<https://edk2.groups.io/g/devel/message/64382>. Given that Chasel
(maintainer/reviewer), Jiewen (original author) and Qi (poster) all work
for Intel, and the (C) notice in question is Intel's, I think that *any*
maintainer can satisfy Chasel's request, when merging the series.

So, I think I'll go ahead and merge v4. Thank you for the v3 pointers.

> When I am about to merge, I am told that we are in SFF and I cannot check in.
> According to the plan, I will check in after August 28, which is end of August. It is still OK for me.
> 2020-08-14  Soft Feature Freeze
> 2020-08-21  Hard Feature Freeze
> 2020-08-28  Release
> 
> But now, if we need delay one week, then the final release data will be September. If I cannot check in now, I will have to check in at September.
> That is why I said, it impacts me, because of this one week delay.

I'm going to merge the series for you, given the amount of work needed
for collecting the feedback tags.

Thanks!
Laszlo

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

[Yao, Jiewen]

Thank you very much, Laszlo and Liming!

Thank you
Yao Jiewen

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, August 26, 2020 10:49 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming
> <gaoliming@byosoft.com.cn>; 'Leif Lindholm' <leif@nuviainc.com>;
> afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha,
> Soumya K <soumya.k.guptha@intel.com>
> Cc: announce@edk2.groups.io; 'Chang, Abner (HPS SW/FW Technologist)'
> <abner.chang@hpe.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> marcello.bauer@9elements.com
> Subject: Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for
> edk2-stable202008
> 
> On 08/26/20 12:16, Yao, Jiewen wrote:
> > HI Laszlo
> > I checked the history.
> >
> > Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with
> review-by on V3 patch series in August 15, with comment to rename
> FvEventLogRecordLib to TcgEventLogRecordLib.
> 
> You are correct:
> 
> https://edk2.groups.io/g/devel/message/64299
> 
> I have two comments on this.
> 
> First, because you authored the IntelFsp2WrapperPkg patches in the
> series, you cannot R-b them (you cannot R-b your own patches, even if
> they are resent by someone else). However, that's not necessary: the
> IntelFsp2WrapperPkg is maintained by Chasel Chiu, and Chasel did review
> those patches, under v4, in the end.
> 
> Second, the v4 submitter, Qi Zhang, should have picked up your R-b from
> under v3, and included them in the v4 posting. (Assuming the v3->v4
> changes were exactly as you requested, under v3.)
> 
> > Qi sent v4 series in August 17, with only naming change from
> FvEventLogRecordLib to TcgEventLogRecordLib.
> 
> OK. In this case, Qi should have posted the v4 SecurityPkg patches with
> your R-b *already* present.
> 
> > Jian replied "[PATCH v3 0/8] Need add a FSP binary measurement" with
> reviewed-by on V3 patch series in August 18.
> 
> That's correct too:
> 
> https://edk2.groups.io/g/devel/message/64342
> 
> This means that Qi should have sent v4 with Jian's R-b on *every* patch.
> 
> > So I treat this patch series is qualified to check in (since V4 adopted my
> comment). But please let me know if there is any misunderstanding.
> 
> No, you are entirely correct. I was misled because v4 was not posted
> correctly, with regard to the feedback tags given under v3.
> 
> So, what remains to do now is this: until the HFF (2020-08-28) we can,
> and should, merge v4 of the series. As follows:
> 
> - apply Jian's R-b from under v3 to every patch in the series
> 
> - apply your R-b from under v3 to the patches you did *not* author (that
> is, apply the tag to the SecurityPkg patches, plus to
> "IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and
> Tpm2DeviceLib")
> 
> - apply Chasel Chiu's R-b from under v4 to the IntelFsp2WrapperPkg patches.
> 
> This will make the series fully reviewed, and mergeable.
> 
> Note that Chasel requested a copyright year update when pushing, here:
> <https://edk2.groups.io/g/devel/message/64382>. Given that Chasel
> (maintainer/reviewer), Jiewen (original author) and Qi (poster) all work
> for Intel, and the (C) notice in question is Intel's, I think that *any*
> maintainer can satisfy Chasel's request, when merging the series.
> 
> So, I think I'll go ahead and merge v4. Thank you for the v3 pointers.
> 
> > When I am about to merge, I am told that we are in SFF and I cannot check in.
> > According to the plan, I will check in after August 28, which is end of August. It
> is still OK for me.
> > 2020-08-14  Soft Feature Freeze
> > 2020-08-21  Hard Feature Freeze
> > 2020-08-28  Release
> >
> > But now, if we need delay one week, then the final release data will be
> September. If I cannot check in now, I will have to check in at September.
> > That is why I said, it impacts me, because of this one week delay.
> 
> I'm going to merge the series for you, given the amount of work needed
> for collecting the feedback tags.
> 
> Thanks!
> Laszlo