From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.1569.1616633178716156025 for ; Wed, 24 Mar 2021 17:46:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=gDA4RpHb; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0718a92a40=abner.chang@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12P0gw7O006634; Thu, 25 Mar 2021 00:46:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=zOzMPekPgjl0R0rOYU9aKKFJtjTBt11wJGWJoW/ITK4=; b=gDA4RpHbbpXGRJqcgcoSxsOGRmQt7/9NKBfi+WkZc5iwEnYS8cXdXUKouWyyHpuT4Gpt LahA2gtCbjqv8zmabbpLjii/mAdCzYe+Iocpd41q1jaTZa99oc3P1x9ndQIwyGm3n/Z9 Vfmn/0YIKZ3Muw9/g3JFCm6SEIOFns8YXshvkUJwqeZeIpEzRXQeJ155wXiG4FsjhUZE NMIORPiguf6jR4frJjlLqan9f9WJi4bWDNh0/x8ksQaufDYg/DrkiUvfANVddJi1MJYR YFQ7rYjAhwTtJu2tnKYeiXuajcarsJBpbQavXYlKKjtAf/UfJ9dGm2KS0SG9Gz5pD+b9 bA== Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 37g93tu4mv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 00:46:18 +0000 Received: from G2W6310.americas.hpqcorp.net (g2w6310.austin.hp.com [16.197.64.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 49BEF9C; Thu, 25 Mar 2021 00:46:17 +0000 (UTC) Received: from G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) by G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Mar 2021 00:46:16 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (15.241.52.13) by G4W9121.americas.hpqcorp.net (16.210.21.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 25 Mar 2021 00:46:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YaCR159ydvR6xrHu2ZktPeBz9lHQRBqVj0thYEhGfC2m00HzkZOHDxmRLlXFfSzjdg6Lo8vSOmDrIexeCQmpvh6WCifazAUF4MJ1A85YWKNvwXDYdT6GYzfBjwyscSKUEEsfEa9UGy6vde9Uf21/26BC2DdiKp41MX3zVDLCJNtNTnKNca1LZiYLIxSVUhAg+jqZ+tF+Nj5lsbYDP25uZEPAntyjNIb9797zZr6oG6cOeXd8GAJrDhwOUxw0VJWAvem65BVtuo8MB9fKsjrFbB8BWWWRhzfHV4yPavPaGLO+T5JwOR6aoijx34k9yBV1Tic3mTU8l6LEy0vO9mL4bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BAO7G9cdHb3BLWYkioWsaHe3CE6iSutUbutPnScHSh0=; b=d509JhlFwTNbc0twt1EmibaVN1klCkE93CS0u5b2b0NXHqApyP0cIiS8S5NKRqRW5WAciNE4hek2PRya1/sD15FeKmhD3GBv1EcrldOnXZmaePJZfeVNiSK08p6th+oo0lram+IRIhvA7TVUwEDa1qMHKOFZaNfhlfc4IFr9Scfdd7xKOMqxICljuvYDCTjPUo+CuDQDQfRUwDuQrjAwGeZ5/sN8SPfYPnt0D2seYe7P3KUBCCR6djMyw0oQhmXxZRb9DK+U3xskSwlnupYEyo2Dz2u/NJxct7AUJNxwGooaBkennEiAgelhRCCUvpoZmgSNlvFd7Xxn4rDUHvIBWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:742a::13) by AT5PR8401MB0738.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7422::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 25 Mar 2021 00:46:11 +0000 Received: from AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9eb:d246:6345:68f8]) by AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9eb:d246:6345:68f8%5]) with mapi id 15.20.3977.024; Thu, 25 Mar 2021 00:46:11 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "ldevulder@suse.com" Subject: Re: [edk2-devel] [PATCH] RISC-V/PlatformPkg: Fix compilation breakage in OpenSBI Thread-Topic: [edk2-devel] [PATCH] RISC-V/PlatformPkg: Fix compilation breakage in OpenSBI Thread-Index: AQHXILdUq+WSgxdq+0Gr0mvS5l74TKqT2+Vw Date: Thu, 25 Mar 2021 00:46:11 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2f72d2c7-7411-40ef-c33c-08d8ef2762ba x-ms-traffictypediagnostic: AT5PR8401MB0738: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:549; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m1WmhOT74TB+DQC/bFP/4zAoJYcdSe2vaNd8LAoER/lZomdAiZeamiqmGIKgE+OiDD/BYRreJ12UcbAy8dIlPkaYFrk5jTTAxsOKDTGsUnNEnBcGQ4fRZ0WLpaFa05YOA7Xtcybi0pA+ZhQFwS3AbXgTGBHh1jYSMzjs4y8kzpErVxLvOZufz0CbNsTx9GwqMjM6rsisKsseYVrf/H6UVVhH2NCU0oqo/5KNTzpCaaENML8Es7SPuZtiODswzFfZzhD6D2E6eBumQhUIWxgWdUeLEv1nFnNSbhk+Olk4z8AeHy8WnzFi9QXBFC/Uj+2iF5XMIs6viRzx7f9E4R6JFhV+3SSt8qutajbHhfPjDWBPMKw1HJjuDuDc2LyfkTzgRiorvOpN2f+HoizPPi96kD/ywoDmzud4y3SCskSvwBSwpOyGM9s5pdYJFHRJ1N1eO0xg4dQ5pcV7BlC8Vrby1ScDLhON7gNjc4Lo6PHlt90+Y5oryLAOVQeEsYOXucQhjn4w2dQyVVaaqaCqTJWRkh45z8Gsxgrkwxw2G8gv0N79FaYYBuLRYOjcWUKNVgbYJyBfrmy16Yb2mN2wagcS8LtKhT0WGjeDXZm2ohEn/ciBp9D7cSV5UoQgwnsIdndaCzUB7VRw9HrARGGuqFvmva9qpO3ZIPPHDmTjrFwVcdbkRA+g9aqynjayVrZ57AYPSqgA4a4qIUIXxQD6spUXl3tuZh5jpwafQtzUCeIsvGMy1mnHYBntVGSkfH+m4oXm x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(136003)(396003)(376002)(346002)(366004)(39860400002)(66946007)(966005)(66556008)(64756008)(19627235002)(2906002)(66476007)(8936002)(76116006)(8676002)(33656002)(186003)(6506007)(53546011)(55016002)(52536014)(83380400001)(9686003)(86362001)(110136005)(38100700001)(71200400001)(7696005)(478600001)(5660300002)(316002)(26005)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rmMZGgpIiCYlfi9y2UJ2c6fJt/oqwaETOL8Sjkf/W+PEYjNqhvJPspSyoLDM?= =?us-ascii?Q?qjAQhiW01QBzqY+NPl5TPUXDb0cdOJdRwgzLU+FUcoCjKbQW4/09waKWpSvD?= =?us-ascii?Q?+JaNCO17sLn1d4PMApXu8UYgOkdc930bkR+x60b3Gw29KPTUfrflMz1bGSWK?= =?us-ascii?Q?djsaHcwgu+irJ+nzliBZf4HUBv0box2PBCfPMSyeEpkEnzNiKyPw1uWD45zg?= =?us-ascii?Q?3ZVW/umddHthu3ThI3EPRkLHoHxKvMK5koqqkUcWtXy641opEanuLl31U4HM?= =?us-ascii?Q?pTUb14SzQK49KddxBWrM9mL3FiZ+3BvR6OJmModAXS2ZeUVhJKmSUypQn69i?= =?us-ascii?Q?cKN7NRGgOdfTzUhTldDk4s6iJ8BkbSMzKzm5bnsjCoFypFfhZCQ4ABxm05cw?= =?us-ascii?Q?DI/SJecWKHKDNVX6hHIt+4xtw1LnyvMCT+16MuHGh8WaFf/0Oinh70bc+O7a?= =?us-ascii?Q?Ztgkp4ZutKz9+4490V6U9+S1k5Dxf6mXrLTKLSmghBgB0Wzd+3FYjpjugbDE?= =?us-ascii?Q?E1CxkfSDrn0UoZp9PcaIahw8WeXN8NdxVUfyhFCd92bNTGO7yKlZ0GAe8uZx?= =?us-ascii?Q?MuGnslXyFKoGZK/mKOjL3AQLUmMfe6E+1m+D/scNco1FwbmNOMv3djUKtVFy?= =?us-ascii?Q?WnTbpzn/EXPGCwCh3dm/3cvcqhw8n5rMOM2mID0UZWUket+yzhujHduTve8a?= =?us-ascii?Q?jR38d0Y/5uLSezj6a6Gukal+vK4xUPPV7lW9ZF4GQ76Ctr8IiIvzDeiGK2uc?= =?us-ascii?Q?tDOLjv0N/mMDfb6DvSyJdNiD0feXDxddn62Ea82yPER4Q4zwAOMWFQJs6dYk?= =?us-ascii?Q?BIEZrDAZVi1STKnD+4bT9pxyPVa0L1IKrus03rHICiCQ9Ebb2PEdJdxlEGhV?= =?us-ascii?Q?vtQKrLq44COjceqMx98UObGVmqjwwnH/HNDQtKtQXSy1Jg73aRn1WFoOxTBt?= =?us-ascii?Q?bZEnicUXeZIx10YfxhwWxIwhkhojf/b/CN5w6n36OAMOdUk7/UK3aHtbGLgz?= =?us-ascii?Q?OSqY8RCN5IuawQxJJ5haMNpLcAWdj1nq/tw2fcCQpPb53a3JDiBcljM5bvTq?= =?us-ascii?Q?dxxj5sDBZTeiigPkMBBcGge9+sslFE37kTnJZTzs/SznluoHbaUbfW077cNt?= =?us-ascii?Q?s0a1DSEjGSyDRnn8D6ilMnz8BKU0FwRh/OrTGwpeBZgDV56pMlmjoVt6uxyP?= =?us-ascii?Q?RNbmkl1bxpWbrE9pj3k+MKgW00GAbbgfEI7XVs5ekr3lYggjkDyV9nBld+N/?= =?us-ascii?Q?UrHsITQSJr/OLlNEZHFXJzxg501oMQWNt6NaqdX9IHaBfca38IEIrkUOnt+9?= =?us-ascii?Q?M8WkXQLsCySi/X/HoKhfxUAq?= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2f72d2c7-7411-40ef-c33c-08d8ef2762ba X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 00:46:11.0685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jHichx4rP/AFfrCvvuR5Mv4J7vdc1vf413IbH8KlNYu0X6Vh11FYvnPTKvrDlspzU6hJOEW936CxjmERJbTNbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0738 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-24_14:2021-03-24,2021-03-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 phishscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103250001 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Loic, The current edk2 RISC-V is incorporated with opensbi v0.8, please check be= low link https://github.com/riscv/riscv-uefi-edk2-docs We have to update below library with the latest opensbi with your changes, https://github.com/tianocore/edk2-platforms/tree/master/Silicon/RISC-V/Pro= cessorPkg/Library/RiscVOpensbiLib=20 I believe your changes don't impact the build and the functionalities beca= use we don't use those parameters in edk2. However, this change should be a= dopted with Edk2OpenSbiLib upgrade. Daniel is currently working on edk2 RISC-V OVMF and also updated opensbi t= o the latest version. However there is a compatible issue when switching mo= de and we are fixing it now. We can share more information with you if you would like to know. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Loic Devulder via groups.io > Sent: Wednesday, March 24, 2021 9:59 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] RISC-V/PlatformPkg: Fix compilation breaka= ge > in OpenSBI >=20 > platform_ops and platform structures have older entries that don't exist > anymore on recent OpenSBI versions, so we can remove them. >=20 > Cc: Abner Chang > Cc: Daniel Schaefer > Cc: Gilbert Chen >=20 > Signed-off-by: Loic Devulder > --- > .../PlatformPkg/Library/OpensbiPlatformLibNull/Platform.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/Platform/RISC- > V/PlatformPkg/Library/OpensbiPlatformLibNull/Platform.c b/Platform/RISC- > V/PlatformPkg/Library/OpensbiPlatformLibNull/Platform.c > index e78d811f4c..84b5f5dec8 100644 > --- a/Platform/RISC- > V/PlatformPkg/Library/OpensbiPlatformLibNull/Platform.c > +++ b/Platform/RISC-V/PlatformPkg/Library/OpensbiPlatformLibNull/Platfor > +++ m.c > @@ -28,8 +28,7 @@ const struct sbi_platform_operations platform_ops =3D = { > .timer_event_stop =3D NULL, > .timer_event_start =3D NULL, > .timer_init =3D NULL, > - .system_reboot =3D NULL, > - .system_shutdown =3D NULL > + .system_reset =3D NULL > }; >=20 > const struct sbi_platform platform =3D { > @@ -39,6 +38,5 @@ const struct sbi_platform platform =3D { > .features =3D 0, > .hart_count =3D 0, > .hart_stack_size =3D 0, > - .disabled_hart_mask =3D 0, > .platform_ops_addr =3D 0 > }; > -- > 2.30.1 >=20 >=20 >=20 >=20 >=20