From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"bret.barkelew@microsoft.com" <bret.barkelew@microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] CI test on copyright
Date: Fri, 16 Oct 2020 01:07:46 +0000 [thread overview]
Message-ID: <AT5PR8401MB1137D26014549BDCC18DC22DFF030@AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <MW4PR21MB18573149568DA2D72F66D2F6EF020@MW4PR21MB1857.namprd21.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 3289 bytes --]
Hmm, it doesn't work with below header. Still fail.
## @file
# Implementation of EFI REST JSON Structure Protocol.
#
# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
I had confirmed it again, CI test passed with below one, move "(C)" to behind Copyright.
## @file
# Implementation of EFI REST JSON Structure Protocol.
#
# Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] CI test on copyright
Try removing the extra line between "SPDX" and "##".
- Bret
From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] RE: CI test on copyright
## @file
# Implementation of EFI REST JSON Structure Protocol.
#
# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0>
Abner
From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: RE: CI test on copyright
Can you share the entire copyright header? In my experience, It's actually complaining about one of the '#' or '/*' tags.
- Bret
From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright
Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
[cid:image001.png@01D6A39B.CE9B2220]
The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
Any idea on this?
Abner
[-- Attachment #1.2: Type: text/html, Size: 11503 bytes --]
[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]
next prev parent reply other threads:[~2020-10-16 1:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 16:21 CI test on copyright Abner Chang
2020-10-15 16:24 ` Bret Barkelew
2020-10-15 16:32 ` Abner Chang
2020-10-15 16:34 ` Bret Barkelew
2020-10-16 1:07 ` Abner Chang [this message]
2020-10-16 1:15 ` 回复: [edk2-devel] " gaoliming
2020-10-16 1:19 ` Abner Chang
[not found] ` <163E54449E0DFAB5.31077@groups.io>
2020-10-16 1:25 ` Abner Chang
2020-10-17 4:45 ` Sean
2020-10-19 1:01 ` 回复: " gaoliming
2020-10-19 1:24 ` Bob Feng
2020-10-19 1:28 ` 回复: " gaoliming
2020-10-19 2:24 ` Bob Feng
2020-10-19 2:48 ` Abner Chang
2020-10-19 3:01 ` Bob Feng
2020-10-19 3:25 ` Abner Chang
2020-10-19 4:56 ` 回复: " gaoliming
2020-10-19 5:08 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AT5PR8401MB1137D26014549BDCC18DC22DFF030@AT5PR8401MB1137.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox