From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0129.outbound.protection.outlook.com [104.47.42.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C185F21A0910B for ; Mon, 5 Jun 2017 17:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HP.onmicrosoft.com; s=selector1-hp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DEFzjuG+ZObNou7w91TYD6kPcr8oT4vKuxaIFUy5KE0=; b=j9sqLMrrjdv9elwOLRr7AAYwB+UK9JicZLUsi/JZ4a52gEnTalwo7OfLNFsHli1j8Si7g7+kG7/557LnhFF8/6rDLPnGZop1qAJoBXvwL5J710RuQ3BX3BG8oka/+k+nMRes6pTeFcnD1m8kMVlAeztUeAYJeSEj9ri+tf7QAJU= Received: from AT5PR84MB0002.NAMPRD84.PROD.OUTLOOK.COM (10.162.137.12) by AT5PR84MB0003.NAMPRD84.PROD.OUTLOOK.COM (10.162.137.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1143.10; Tue, 6 Jun 2017 00:33:36 +0000 Received: from AT5PR84MB0002.NAMPRD84.PROD.OUTLOOK.COM ([fe80::210a:70e4:4598:7009]) by AT5PR84MB0002.NAMPRD84.PROD.OUTLOOK.COM ([fe80::210a:70e4:4598:7009%14]) with mapi id 15.01.1143.019; Tue, 6 Jun 2017 00:33:36 +0000 From: "Alcantara, Paulo" To: "edk2-devel@lists.01.org" CC: Michael D Kinney , Liming Gao Thread-Topic: [PATCH] MdePkg/Ftp4: Fix wrong function pointer declaration Thread-Index: AdLeXGAVHzpKaSvbRUOGbV+sbkWGLA== Date: Tue, 6 Jun 2017 00:33:36 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=hp.com; x-originating-ip: [179.178.31.110] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AT5PR84MB0003; 7:y4QO90PB+TsyfEmTVAxG4fCMs/dyzpvjRJTZOXcf82ttG/bkb9yWyLMX5I83EmZQy4aK9qkLnk7kCUODdQ5FwaU+e1VwqxWPtR1QZwHVnE3yrDjA7tvga/KYZSCXcjJiK3mTnfWZEmMURBDGipMnBsUPVi1rwMnfEeA5FbXZ/dr7GozgZlSTLX9Lf7yXvSLXAYJ4hRDXKa7syMXh0NYaUCErhnmkS22R1l3/bGV82HLEV3Nle3kSkTHgZVfnuMxXfoJTsvs7GQ0AHMepomAWH4Qff9R9pWLImPrAcGrDmytZ5jp8ZNabI6ni3hTaCSXaj2Y5dOqQec/q0B4vj495IA== x-ms-traffictypediagnostic: AT5PR84MB0003: x-ms-office365-filtering-correlation-id: da648dba-3a50-472f-02c2-08d4ac73ab82 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:AT5PR84MB0003; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699)(73583498263828); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AT5PR84MB0003; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AT5PR84MB0003; x-forefront-prvs: 033054F29A x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39840400002)(39450400003)(39850400002)(39410400002)(39400400002)(6602003)(7696004)(2501003)(81166006)(6916009)(6116002)(3846002)(102836003)(2351001)(50986999)(305945005)(5250100002)(86362001)(7736002)(54356999)(74316002)(55016002)(66066001)(53936002)(5660300001)(54906002)(9686003)(5640700003)(38730400002)(478600001)(3660700001)(2906002)(6506006)(6436002)(110136004)(4326008)(25786009)(3280700002)(8676002)(8936002)(33656002)(2900100001)(14454004)(189998001)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:AT5PR84MB0003; H:AT5PR84MB0002.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2017 00:33:36.1840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0003 Subject: [PATCH] MdePkg/Ftp4: Fix wrong function pointer declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 00:32:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable EFI_FTP4_DATA_CALLBACK is a function pointer and defined as follows: > typedef > EFI_STATUS > (EFIAPI *EFI_FTP4_DATA_CALLBACK)( > IN EFI_FTP4_PROTOCOL *This, > IN EFI_FTP4_COMMAND_TOKEN *Token > ); And EFI_FTP4_COMMAND_TOKEN structure declared it as: > EFI_FTP4_DATA_CALLBACK *DataCallback Which ended up being a pointer to function pointer and clearly wrong. This patch fixes it by removing the misleading '*' from declaration. It's also fixed in new UEFI 2.7 spec. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- MdePkg/Include/Protocol/Ftp4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/Ftp4.h b/MdePkg/Include/Protocol/Ftp4.= h index 1c4a5db..536b3f3 100644 --- a/MdePkg/Include/Protocol/Ftp4.h +++ b/MdePkg/Include/Protocol/Ftp4.h @@ -204,7 +204,7 @@ struct _EFI_FTP4_COMMAND_TOKEN { /// DataBufferSize, again. If there is no data remained,=20 /// DataBufferSize should be set to 0. ///=20 - EFI_FTP4_DATA_CALLBACK *DataCallback; + EFI_FTP4_DATA_CALLBACK DataCallback; ///=20 /// Pointer to the parameter for DataCallback. ///=20 --=20 2.9.4