Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

["Sajjan, Vikas C" <vikas.cha.sajjan@hpe.com>]

Hi Ard,

-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 
Sent: Monday, August 22, 2016 2:19 PM
To: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>
Cc: Laszlo Ersek <lersek@redhat.com>; edk2-devel@ml01.01.org; leif.lindholm@linaro.org; Wei, Dong (Office of the CTO) <dong.wei@hpe.com>
Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

On 22 August 2016 at 10:01, Sajjan, Vikas C <vikas.cha.sajjan@hpe.com> wrote:
>
> Hi Ard,
>
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Monday, August 22, 2016 12:46 PM
> To: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; edk2-devel@ml01.01.org; 
> leif.lindholm@linaro.org; Wei, Dong (Office of the CTO) 
> <dong.wei@hpe.com>
> Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg 
> platforms
>
> On 22 August 2016 at 09:07, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> On 20 August 2016 at 05:01, Sajjan, Vikas C <vikas.cha.sajjan@hpe.com> wrote:
>>>
>>>
>>> -----Original Message-----
>>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>>> Sent: Friday, August 19, 2016 6:58 PM
>>> To: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>; 
>>> edk2-devel@ml01.01.org; ard.biesheuvel@linaro.org; 
>>> leif.lindholm@linaro.org
>>> Cc: Wei, Dong (Office of the CTO) <dong.wei@hpe.com>
>>> Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg 
>>> platforms
>>>
>>> On 08/19/16 08:55, Vikas C Sajjan wrote:
>>>> This series adds ramdisk driver support to ArmVirtPkg platforms.
>>>> It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg.
>>>>
>>>> changes since v2:
>>>>    - Made changes as suggested by Laszlo Ersek <lersek@redhat.com>
>>>>       a] Moved inclusion of AcpiTableDxe.inf to end of file
>>>>       b] Moved gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol to proper location
>>>>         c] fixed minor nits
>>>>
>>>> changes since v1:
>>>>    - Made changes as suggested by Laszlo Ersek <lersek@redhat.com>
>>>>       a] clarified in the commit message (including the subject line)
>>>>          that this patch is actually about adding the RAM Disk driver to the
>>>>          ArmVirtPkg platforms, not just the NFIT reporting feature of the driver
>>>>       b] enabled feature for all of ArmVirtQemu, ArmVirtQemuKernel, and ArmVirtXen.
>>>>       c] prepended a patch to the series that extracts
>>>>          "MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf"
>>>>          from all of the DSC files, into "ArmVirt.dsc.inc"
>>>>
>>>>
>>>> Vikas C Sajjan (2):
>>>>   ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc
>>>>   ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms
>>>>
>>>>  ArmVirtPkg/ArmVirt.dsc.inc           | 17 +++++++++++++++++
>>>>  ArmVirtPkg/ArmVirtQemu.dsc           |  1 -
>>>>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc |  5 +++++
>>>>  ArmVirtPkg/ArmVirtQemuKernel.dsc     |  1 -
>>>>  ArmVirtPkg/ArmVirtRules.fdf.inc      |  2 ++
>>>>  ArmVirtPkg/ArmVirtXen.dsc            |  1 -
>>>>  ArmVirtPkg/ArmVirtXen.fdf            |  5 +++++
>>>>  7 files changed, 29 insertions(+), 3 deletions(-)
>>>>
>>>
>>> Series
>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>
>>> Thank you, Laszlo.
>>>
>>> Ard, can you please commit the series for Vikas? My brain is fried, 
>>> I need to get out. :)
>>>
>>> Thanks!
>>> Laszlo
>>
>> Committed as
>>
>> fde03c8065ea ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to 
>> ArmVirt.dsc.inc
>> d36447418d32 ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms
>>
>
> These patches have no broken ArmVirtXen, since it has no resolution for FileExplorerLib, which RamDiskDxe depends on.
>
> Could you propose a fix please?
>
> My bad,
> I somehow missed the below line in ArmVirtPkg/ArmVirt.dsc.inc
> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.i
> FileExplorerLib|nf
>
> Will send out v4 now.
>

Hello Vikas,

I already committed your v3 patches. So instead of a v4, could you please propose a new patch that fixes ArmVirtXen.dsc?

See if this helps - https://www.mail-archive.com/edk2-devel@lists.01.org/msg16049.html

Thanks and Regards
Vikas Sajjan

Thanks,
Ard.