Re: [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for ramdisks

["Sajjan, Vikas C" <vikas.cha.sajjan@hpe.com>]

Hi Laszlo,

Thank you for reviewing the patch.

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Tuesday, August 16, 2016 2:08 AM
To: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>
Cc: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>; ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Shannon Zhao (Linaro address) <shannon.zhao@linaro.org>
Subject: Re: [edk2] [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for ramdisks

On 08/09/16 11:55, Sajjan, Vikas C wrote:
> Adding Maintainers.
> 
> -----Original Message-----
> From: Sajjan, Vikas C
> Sent: Tuesday, August 09, 2016 1:28 PM
> To: edk2-devel@lists.01.org
> Cc: Sajjan, Vikas C <vikas.cha.sajjan@hpe.com>
> Subject: [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg 
> for ramdisks
> 
> Adds NFIT report feature for ArmVirtPkg for ramdisks of reserved memory type.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Vikas C Sajjan <vikas.cha.sajjan@hpe.com>
> ---
>  ArmVirtPkg/ArmVirtQemu.dsc      | 4 ++++
>  ArmVirtPkg/ArmVirtQemu.fdf      | 2 ++
>  ArmVirtPkg/ArmVirtRules.fdf.inc | 2 ++
>  3 files changed, 8 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc 
> index 9f88786..35a3d8f 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -103,6 +103,9 @@
>    # Activate KVM workaround for now.
>    gArmVirtTokenSpaceGuid.PcdKludgeMapPciMmioAsCached|TRUE
>  
> +  # Activate AcpiSdtProtocol.
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE
> +
>  !if $(PURE_ACPI_BOOT_ENABLE) == TRUE
>    gArmVirtTokenSpaceGuid.PcdPureAcpiBoot|TRUE
>  !endif
> @@ -397,6 +400,7 @@
>    # ACPI Support
>    #
>    MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> +  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>    OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
>      <LibraryClasses>
>        
> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf 
> index c6a22dc..7d6737b 100644
> --- a/ArmVirtPkg/ArmVirtQemu.fdf
> +++ b/ArmVirtPkg/ArmVirtQemu.fdf
> @@ -110,6 +110,8 @@ READ_LOCK_STATUS   = TRUE
>    INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
>    INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
>    INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
> +  INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> +  INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
>  
>    FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
>      SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF 
> PROCESSING_REQUIRED = TRUE { diff --git 
> a/ArmVirtPkg/ArmVirtRules.fdf.inc b/ArmVirtPkg/ArmVirtRules.fdf.inc 
> index 8952c67..5ff3004 100644
> --- a/ArmVirtPkg/ArmVirtRules.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtRules.fdf.inc
> @@ -85,6 +85,8 @@
>      DXE_DEPEX    DXE_DEPEX              Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
>      PE32         PE32                   $(INF_OUTPUT)/$(MODULE_NAME).efi
>      UI           STRING="$(MODULE_NAME)" Optional
> +    RAW          ACPI  Optional               |.acpi
> +    RAW          ASL   Optional               |.aml
>    }
>  
>  [Rule.Common.DXE_RUNTIME_DRIVER]
> --
> 1.9.1

(1) Please clarify in the commit message (including the subject line) that this patch is actually about adding the RAM Disk driver to the ArmVirtPkg platforms, not just the NFIT reporting feature of the driver.

    Sure will do.

(2) Please mention that this patch ports OvmfPkg commit 259d87146b07 to ArmVirtPkg.

   OK.

(3) Please investigate whether the RAM Disk driver makes any sense for 32-bit ARM (note that only AARCH64 platforms include the ACPI Table Protocol). This will have an impact on (4b) below.

I think RAM Disks make sense for 32-bit ARM as well, even without the NFIT table.

(4) I think this feature should be enabled for all of ArmVirtQemu, ArmVirtQemuKernel, and ArmVirtXen.

(4a) In preparation for that, please prepend a patch to the series that extracts "MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf"
from all of the DSC files, into "ArmVirt.dsc.inc", section [Components.AARCH64].

 OK.

The FDF files are fine already.

(4b) Please add RamDiskDxe.inf to "ArmVirtQemuFvMain.fdf.inc" and "ArmVirtXen.fdf", and "ArmVirt.dsc.inc". This ensures that the RAM Disk driver is built for all platforms. Restrict this as needed to AARCH64 (see (3)).

OK.

(4c) In the second patch, PcdInstallAcpiSdtProtocol should go into "ArmVirt.dsc.inc", section [PcdsFeatureFlag.AARCH64], for matching (4a).

OK.

(4d) The DXE_DRIVER build rules should also be updated in "ArmVirtXen.fdf".
OK.

Thanks
Laszlo

Thanks and Regards
Vikas Sajjan