From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0725.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe46::725]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6F74A1A1E0F for ; Mon, 15 Aug 2016 19:32:56 -0700 (PDT) Received: from AT5PR84MB0052.NAMPRD84.PROD.OUTLOOK.COM (10.162.137.15) by AT5PR84MB0052.NAMPRD84.PROD.OUTLOOK.COM (10.162.137.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Tue, 16 Aug 2016 02:32:53 +0000 Received: from AT5PR84MB0052.NAMPRD84.PROD.OUTLOOK.COM ([10.162.137.15]) by AT5PR84MB0052.NAMPRD84.PROD.OUTLOOK.COM ([10.162.137.15]) with mapi id 15.01.0549.027; Tue, 16 Aug 2016 02:32:53 +0000 From: "Sajjan, Vikas C" To: Laszlo Ersek CC: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" , "Shannon Zhao (Linaro address)" Thread-Topic: [edk2] [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for ramdisks Thread-Index: AQHR8hTWknBmvUAJLUiXa6IXT39EuaBASNNAgAo89QCAAGAZsA== Date: Tue, 16 Aug 2016 02:32:53 +0000 Message-ID: References: <1470729485-14478-1-git-send-email-vikas.cha.sajjan@hpe.com> In-Reply-To: Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vikas.cha.sajjan@hpe.com; x-originating-ip: [59.99.72.94] x-ms-office365-filtering-correlation-id: f799e4b9-65b6-4b18-eaaa-08d3c57da017 x-microsoft-exchange-diagnostics: 1; AT5PR84MB0052; 6:Ap2LssaHYRCoeAax2mP7SpXQ3wAHaldpFZk26LMuxUK53s1KD9tYG2kskgPcWSh7iwww66ySxAu83VJPnk63nW5BEu37ugB3n5aLYJKAywcdlmsw44+AOG5tMgkwzrXw/gRsxuuYdLCT/0itm7bCw3S3U07DoHyTsMEZLBhp6WO318alkzDntfX/sXVTuORTuPAp3lUSMjCOemTFEfb9YQTkd5rUhWtsqGeeQTNX/EKCQiL2kO3sev0hZUr29JarwFGHkh4WIOjxnlCSjQ8jMVEBkYTL8TW96LmGSASeCZ1yU7gmngkrKgFY9w7atJbUrI+OAFi8fNLu2Xs8HBhm5g==; 5:x2vEQ9NzG5N1SLkVeTiHUEZGR9WJ3taExJ5kIkB6o5BhGgL47qlD4Gcrnqxz0DJEJ/TbfIMSaVjIf0j3ab5RGX82u2Frr+IpQQ2T2pG1JyqJrjU/e4Ul6XzOObD+5micphU92z0jF4O26EMgowvUMA==; 24:NXWx1qwLCJKqt7iPWq/u9O8A+NDU+4qCDbIVPoz3nethJrYMEq9NNoZElIfNcFRq3+DMIauaETMt0oXJkS/AzvuHoRGusewod/SkH2XklDI=; 7:kjjJir67Q97t3ECbp/UH+U7PBzknhLnVv5bKUA3SDrb3J3ZEsw318l3dLn537t9JXmhnXqW5CHg6gMJF/fOBFXpJ1m2aWOilZ5kAPcHydKRAdNEWEUngCORBWhNJWt5JGySDz1jQOjWZQ3N479KHckMYhSzBBfXk1A3Ma4qhfulQic23Anoco21og9FIEtWwhnVyMUsfz4X2nEo4plCrrjb8w/GnGaWJ+eY/rqG/anU27D+dbFalQYB2sP0wyb5W x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0052; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(211171220733660); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:AT5PR84MB0052; BCL:0; PCL:0; RULEID:; SRVR:AT5PR84MB0052; x-forefront-prvs: 0036736630 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(24454002)(13464003)(377454003)(199003)(189002)(99286002)(105586002)(101416001)(86362001)(189998001)(106116001)(10400500002)(97736004)(11100500001)(92566002)(7736002)(4326007)(305945005)(3846002)(74316002)(81166006)(6116002)(7696003)(102836003)(3900700001)(586003)(110136002)(7846002)(2900100001)(81156014)(106356001)(122556002)(68736007)(33656002)(87936001)(3280700002)(19580405001)(2950100001)(77096005)(8936002)(31430400001)(2906002)(3660700001)(76176999)(66066001)(5002640100001)(54356999)(19580395003)(9686002)(345774005)(8676002)(50986999); DIR:OUT; SFP:1102; SCL:1; SRVR:AT5PR84MB0052; H:AT5PR84MB0052.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2016 02:32:53.5136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0052 Subject: Re: [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for ramdisks X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 02:32:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, Thank you for reviewing the patch. -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Tuesday, August 16, 2016 2:08 AM To: Sajjan, Vikas C Cc: edk2-devel@lists.01.org ; ard.biesheuvel@linaro= .org; leif.lindholm@linaro.org; Shannon Zhao (Linaro address) Subject: Re: [edk2] [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirt= Pkg for ramdisks On 08/09/16 11:55, Sajjan, Vikas C wrote: > Adding Maintainers. >=20 > -----Original Message----- > From: Sajjan, Vikas C > Sent: Tuesday, August 09, 2016 1:28 PM > To: edk2-devel@lists.01.org > Cc: Sajjan, Vikas C > Subject: [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg=20 > for ramdisks >=20 > Adds NFIT report feature for ArmVirtPkg for ramdisks of reserved memory t= ype. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Vikas C Sajjan > --- > ArmVirtPkg/ArmVirtQemu.dsc | 4 ++++ > ArmVirtPkg/ArmVirtQemu.fdf | 2 ++ > ArmVirtPkg/ArmVirtRules.fdf.inc | 2 ++ > 3 files changed, 8 insertions(+) >=20 > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc=20 > index 9f88786..35a3d8f 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -103,6 +103,9 @@ > # Activate KVM workaround for now. > gArmVirtTokenSpaceGuid.PcdKludgeMapPciMmioAsCached|TRUE > =20 > + # Activate AcpiSdtProtocol. > + gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > + > !if $(PURE_ACPI_BOOT_ENABLE) =3D=3D TRUE > gArmVirtTokenSpaceGuid.PcdPureAcpiBoot|TRUE > !endif > @@ -397,6 +400,7 @@ > # ACPI Support > # > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > + MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > =20 > NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf=20 > index c6a22dc..7d6737b 100644 > --- a/ArmVirtPkg/ArmVirtQemu.fdf > +++ b/ArmVirtPkg/ArmVirtQemu.fdf > @@ -110,6 +110,8 @@ READ_LOCK_STATUS =3D TRUE > INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf > INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf > INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > + INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > + INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > =20 > FILE FV_IMAGE =3D 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { > SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF=20 > PROCESSING_REQUIRED =3D TRUE { diff --git=20 > a/ArmVirtPkg/ArmVirtRules.fdf.inc b/ArmVirtPkg/ArmVirtRules.fdf.inc=20 > index 8952c67..5ff3004 100644 > --- a/ArmVirtPkg/ArmVirtRules.fdf.inc > +++ b/ArmVirtPkg/ArmVirtRules.fdf.inc > @@ -85,6 +85,8 @@ > DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_= NAME).depex > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING=3D"$(MODULE_NAME)" Optional > + RAW ACPI Optional |.acpi > + RAW ASL Optional |.aml > } > =20 > [Rule.Common.DXE_RUNTIME_DRIVER] > -- > 1.9.1 (1) Please clarify in the commit message (including the subject line) that = this patch is actually about adding the RAM Disk driver to the ArmVirtPkg p= latforms, not just the NFIT reporting feature of the driver. Sure will do. (2) Please mention that this patch ports OvmfPkg commit 259d87146b07 to Arm= VirtPkg. OK. (3) Please investigate whether the RAM Disk driver makes any sense for 32-b= it ARM (note that only AARCH64 platforms include the ACPI Table Protocol). = This will have an impact on (4b) below. I think RAM Disks make sense for 32-bit ARM as well, even without the NFIT = table. (4) I think this feature should be enabled for all of ArmVirtQemu, ArmVirtQ= emuKernel, and ArmVirtXen. (4a) In preparation for that, please prepend a patch to the series that ext= racts "MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf" from all of the DSC files, into "ArmVirt.dsc.inc", section [Components.AARC= H64]. OK. The FDF files are fine already. (4b) Please add RamDiskDxe.inf to "ArmVirtQemuFvMain.fdf.inc" and "ArmVirtX= en.fdf", and "ArmVirt.dsc.inc". This ensures that the RAM Disk driver is bu= ilt for all platforms. Restrict this as needed to AARCH64 (see (3)). OK. (4c) In the second patch, PcdInstallAcpiSdtProtocol should go into "ArmVirt= .dsc.inc", section [PcdsFeatureFlag.AARCH64], for matching (4a). OK. (4d) The DXE_DRIVER build rules should also be updated in "ArmVirtXen.fdf". OK. Thanks Laszlo Thanks and Regards Vikas Sajjan