From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0728.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe48::728]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BE2D81E0B for ; Mon, 14 Nov 2016 05:46:11 -0800 (PST) Received: from AT5PR84MB0276.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.22) by AT5PR84MB0275.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.721.10; Mon, 14 Nov 2016 13:46:13 +0000 Received: from AT5PR84MB0276.NAMPRD84.PROD.OUTLOOK.COM ([10.162.138.22]) by AT5PR84MB0276.NAMPRD84.PROD.OUTLOOK.COM ([10.162.138.22]) with mapi id 15.01.0721.015; Mon, 14 Nov 2016 13:46:13 +0000 From: "Anbazhagan, Baraneedharan" To: "Tian, Feng" , "edk2-devel@lists.01.org" Thread-Topic: USB hub port reset Thread-Index: AdI9P9a4p+GKnaQeTV6wi4G+bYD8YgA2K+ggAABY8XAABZq8YAARLQ7Q Date: Mon, 14 Nov 2016 13:46:13 +0000 Message-ID: References: <7F1BAD85ADEA444D97065A60D2E97EE566E4F108@SHSMSX101.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE566E4F285@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE566E4F285@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anbazhagan@hp.com; x-originating-ip: [66.135.176.178] x-microsoft-exchange-diagnostics: 1; AT5PR84MB0275; 7:T6K5XvrEcray0nLPXJSWfav+whikG/ucXlEk61e9w5K3QFHKRqgSEVo2gkI0yGtCIUFHtmMBVrPESbs8/GlZ4mmPoFz0HqvLkeBBqZHNzQOYmVDJSJ2Y9ArQmazh4R8mJtlS3dapX0wKw3s4iSCtRMQrYj96ToqK1YU5/tIepYdKFr3Q6EkxZECipHt8aIgb7BRgAtGaa8qdufOOTIffn6W8Egb97Tj6uPJx6Sq/66AsnjgJ8oc2BBautiH/dtwsvcsB5TCX+Ywbj1GfZTEa8k8ymGbx/lonrX6ol92iQG93HvX4X2A+lgauqk5NLhdx4CvWH6+qQ5YVAtlNyx1iNCVNpR+992WvAJHOmPCarUk= x-ms-office365-filtering-correlation-id: b249fd70-d57d-40d7-4569-08d40c949981 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AT5PR84MB0275; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(162533806227266)(228905959029699)(73583498263828); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6060326)(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6072148); SRVR:AT5PR84MB0275; BCL:0; PCL:0; RULEID:; SRVR:AT5PR84MB0275; x-forefront-prvs: 0126A32F74 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(336003)(199003)(189002)(13464003)(377454003)(6602003)(305945005)(3480700004)(8936002)(8676002)(5660300001)(74316002)(9686002)(2906002)(106356001)(3846002)(81166006)(586003)(81156014)(68736007)(105586002)(7696004)(93886004)(7846002)(87936001)(86362001)(107886002)(189998001)(2950100002)(5001770100001)(97736004)(229853002)(76176999)(77096005)(50986999)(33656002)(7736002)(2900100001)(3280700002)(3660700001)(54356999)(92566002)(122556002)(101416001)(6116002)(99286002)(102836003)(2501003)(66066001); DIR:OUT; SFP:1102; SCL:1; SRVR:AT5PR84MB0275; H:AT5PR84MB0276.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2016 13:46:13.3248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0275 Subject: Re: USB hub port reset X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 13:46:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In case of XHCI, TRB_TYPE_ADDRESS_DEV/SetAddress occurs within XhcPollPortS= tatusChange. Seem we don't have 10ms/TRSTRCY for the devices behind hub con= nected to XHCI or am missing something here? In EDK2, 10ms(TRSTRCY) delay occurs before clear port status and in case of= Linux TRSTRCY delay is after clearing port status. Thanks Baranee > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ti= an, > Feng > Sent: Sunday, November 13, 2016 10:38 PM > To: Anbazhagan, Baraneedharan ; edk2- > devel@lists.01.org > Cc: Tian, Feng > Subject: Re: [edk2] USB hub port reset >=20 > I don't catch what you mean. We have had 10ms delay for port reset. Which= line of > UsbHub.c do you think there is problem? >=20 > Quote from USB2.0 spec: > "Hubs must be able to accept all hub requests and devices must be able to= accept a > SetAddress() request (refer to Section 11.24.2 and Section 9.4 respective= ly) after the > reset recovery time 10 ms (TRSTRCY) after the reset is removed." >=20 > Thanks > Feng >=20 > -----Original Message----- > From: Anbazhagan, Baraneedharan [mailto:anbazhagan@hp.com] > Sent: Monday, November 14, 2016 11:33 AM > To: Tian, Feng ; edk2-devel@lists.01.org > Subject: RE: USB hub port reset >=20 > I didn't mean to have extra delays. Am asking whether EDKII have to be up= dated for > 10ms reset recovery time regardless of port status to align with spec? >=20 >=20 > >From: Tian, Feng [mailto:feng.tian@intel.com] > >Sent: Sunday, November 13, 2016 7:46 PM > >To: Anbazhagan, Baraneedharan ; > >edk2-devel@lists.01.org > >Cc: Tian, Feng > >Subject: RE: USB hub port reset > > > >Hi, Baranee > > > >Linux wait 10 + 40 ms (TRSTRCY =3D 10 ms, plus extra 40 ms). Do you mean= EDKII > should be same with linux to wait more time? > > > >Thanks > >Feng > > > >From: Anbazhagan, Baraneedharan [mailto:anbazhagan@hp.com] > >Sent: Sunday, November 13, 2016 11:53 AM > >To: mailto:edk2-devel@lists.01.org; Tian, Feng > > > >Subject: USB hub port reset > > > >EDK2 have reset recovery time of 10ms for hub port based on port status = reset bit > but USB spec doesn't mention that port status can be used for t6/reset re= covery > time. Could you please clarify? > > > >USB vendor mentions EDK2 doesn't have reset recovery time on hub port > >reset and also highlighting EDK2 hub port reset differs from > >https://github.com/torvalds/linux/blob/master/drivers/usb/core/hub.c#L2 > >789 > > > >-Baranee > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel