public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Cohen, Eugene" <eugene@hp.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: IP4 Config Troubles with DHCP
Date: Tue, 16 Aug 2016 19:44:44 +0000	[thread overview]
Message-ID: <AT5PR84MB029125AA7E698047A8D5DDF1B4130@AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <895558F6EA4E3B41AC93A00D163B7274137C7C7A@SHSMSX103.ccr.corp.intel.com>

Jiaxin,

> Yeah. When I was drafting the UDP APP to test the new fix, I found the
> same case you mentioned. We must issue another UDP Configure () to
> clean the previous state once the  Ip4Mode.IsConfigured is TRUE. So,
> the above example is not accurate with my the current
> implementation:(. But I'm still not recommend to loop the UDP
> configuration every time if Ip4Mode.IsConfigured is false. The right
> behavior for UDP/TCP is 1) timer check the Ip4Mode.IsConfigured, 2)
> Once Ip4Mode.IsConfigured is TRUE, reconfigure the instance again.
> Sorry for the above example was troubling you. Also use UDP as
> example, correct as below:

Can't we just call this a defect and make it so the first Configure() that returns IsConfigured=TRUE works?  It seems much safer to handle this in the stack than to expect hundreds or thousands of different network applications and services to try to implement this sequence correctly.

I don't see where in the UEFI spec it states that you must call Configure(cfg) Configure(NULL) Configure(cfg) just to make it work...

Thanks,

Eugene


      reply	other threads:[~2016-08-16 19:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 18:13 IP4 Config Troubles with DHCP Cohen, Eugene
2016-08-11  6:57 ` FW: " Wu, Jiaxin
2016-08-11 14:31   ` Cohen, Eugene
2016-08-12  0:19     ` Wu, Jiaxin
2016-08-12  8:27     ` Wu, Jiaxin
2016-08-12 12:34       ` Cohen, Eugene
2016-08-13  7:51         ` Wu, Jiaxin
2016-08-15 14:10   ` Cohen, Eugene
2016-08-16  1:27     ` Wu, Jiaxin
2016-08-16 19:44       ` Cohen, Eugene [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AT5PR84MB029125AA7E698047A8D5DDF1B4130@AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox