From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0710.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe49::710]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B29781A1DEF for ; Fri, 5 Aug 2016 09:12:23 -0700 (PDT) Received: from AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.25) by AT5PR84MB0290.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Fri, 5 Aug 2016 16:12:21 +0000 Received: from AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM ([10.162.138.25]) by AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM ([10.162.138.25]) with mapi id 15.01.0549.023; Fri, 5 Aug 2016 16:12:21 +0000 From: "Cohen, Eugene" To: Larry Cleeton , "Ye, Ting" , "edk2-devel@lists.01.org" Thread-Topic: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] Thread-Index: AdHs//Fgg3Y+nYxXTkizzBcV2CsIsgBxp7tgABoTPYAAAUylcA== Date: Fri, 5 Aug 2016 16:12:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=eugene@hp.com; x-originating-ip: [174.19.99.119] x-ms-office365-filtering-correlation-id: 56926bac-ecd2-4109-08a9-08d3bd4b47a9 x-microsoft-exchange-diagnostics: 1; AT5PR84MB0290; 6:ZmSMORBPYuZBJuUo5ZRt49K/8PSMtQCBgiS8c0mFJI4MGQkPHYBN6za3AvmilRObP/8EGCgd5PNB41QzsnkQ7ZZqzB5OEDY+0+l8qCfC2EAuaX630wFxSp7EeiTtbpTMcZ1H1CoVrTzd0pURmtD262vvHyzOCnYQOhJ55D7pX/hLtyBf5pCbzZW3IQXN79YBePx6JLf65zbyecVZFLrurT76INKQv/Q/KtNQ+UwP081900uPcw6ibsoGyljB6wdrKdIjz6AWTlnFO0MLBDHDwir131upNTV428y8q+PGlkY=; 5:gsae5wkutJeVptWCdjSO6R7vhUKYClzFaPezaXVnxOhYbonihmJfNAT9lJjdrwnLqDz9qcx5jvYsO82+zIo1zKdPE9ChK54i88yvgn0MCqR6GZGIp8sv3fu/ZIMCj3uP/3aVP/TGTMzHsdLpjuDD9A==; 24:Fj68HNaP30N11G9rNnvYbdgeRMZM2BfARREiTrgO20NAbRM6fByRBtY333GEOh2TPldJaDE53pcyUY3poG1prorNr+nvo1Zr0pvHHQ41VW8=; 7:hQ8PJn3E/z8tITwQAyVZlJn+OmuknEdEAoiA9ANH8FTostryjguEY79UF7/OTjbbUyhfQaSBuBfuM9v3dGgLI0VgV6HRgdkPFP27uqUikiwdCd/PHMx15y8lUCRzMJap+GrBnXXGPcD5R+yJ7kgLwEoA6Jd9YL3o8bcHaHwQqM2KErbdjQvHRY1XLoADmlQimxWQoqS0cy7HcUzTg87qyIuNf2fmFtrChcuISeXt5aM2v90LhAQdWxpn7d392TTj x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0290; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:AT5PR84MB0290; BCL:0; PCL:0; RULEID:; SRVR:AT5PR84MB0290; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(189002)(377454003)(13464003)(199003)(6602003)(76104003)(102836003)(3280700002)(2906002)(3846002)(10400500002)(19580395003)(1511001)(19580405001)(3660700001)(5002640100001)(87936001)(8676002)(74316002)(33656002)(6116002)(11100500001)(106356001)(575784001)(86362001)(586003)(2561002)(105586002)(81156014)(81166006)(99286002)(50986999)(54356999)(77096005)(92566002)(76176999)(97736004)(2501003)(2421001)(15975445007)(2950100001)(2900100001)(66066001)(68736007)(5001770100001)(122556002)(7736002)(189998001)(7846002)(107886002)(8666005)(7696003)(101416001)(305945005)(8936002)(9686002); DIR:OUT; SFP:1102; SCL:1; SRVR:AT5PR84MB0290; H:AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2016 16:12:21.1428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0290 Subject: Re: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 16:12:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable We've been hit by this same kind of issue and it's really painful, especial= ly as it affects shipping systems. Long term I think we need an extensible/revisioned data format so we can ge= t forwards and backwards compatibility between NVRAM data and FW. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Larry Cleeton > Sent: Friday, August 05, 2016 9:35 AM > To: Ye, Ting ; edk2-devel@lists.01.org > Subject: Re: [edk2] Breaking change issue with > NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] >=20 > I agree with your assessment about leaving the data structure as it is. = I just > wanted to highlight it as it may impact others. >=20 > The bottom line is my development group is entirely responsible for vetti= ng > any changes coming from the EDK2 into our product. This one slipped by u= s. >=20 > --Larry >=20 > -----Original Message----- > From: Ye, Ting [mailto:ting.ye@intel.com] > Sent: Thursday, August 4, 2016 8:25 PM > To: Larry Cleeton ; edk2-devel@lists.01.org > Subject: RE: Breaking change issue with > NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] >=20 > Hi Larry, >=20 > We are very sorry about the impact you suffered today. We made the > change in early 2013 to support the existing NVRAM variable when firmware > image was updated from IA32 to X64. Unfortunately we introduced an > incompatibility issue as you raised. Now we prefer to keep the existing > definition, since if we change it back that would introduce another simil= ar > incompatibility issue. What do you think about this? >=20 > Best Regards, > Ye Ting >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Larry Cleeton > Sent: Wednesday, August 03, 2016 4:55 AM > To: edk2-devel@lists.01.org > Subject: [edk2] Breaking change issue with > NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] >=20 > This commit (fdc4b0b147b386e966e99893526181dfae9eaeef) changed a data > structure that is stored in an NVRAM variable. > See NetworkPkg/Ip6Dxe/Ip6ConfigImpl.[c,h] >=20 > This data structure: >=20 > typedef struct { > UINT16 Offset; > UINTN DataSize; > EFI_IP6_CONFIG_DATA_TYPE DataType; > } IP6_CONFIG_DATA_RECORD; >=20 > Is now: >=20 > typedef struct { > UINT16 Offset; > UINT32 DataSize; <---------------- changed size = in 64bit > environments > EFI_IP6_CONFIG_DATA_TYPE DataType; > } IP6_CONFIG_DATA_RECORD; >=20 > Unfortunately with a 64bit implementation this current structure is now > *not* compatible with an existing NVRAM variable written with the previou= s > version of the structure. It's causing me considerable grief so I'm just = sharing > the discovery. It would only impact you if you update some 64bit machine= 's > firmware with a new version containing this change. >=20 > --Larry > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel