From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0730.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe42::730]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A248C1A1DF3 for ; Wed, 10 Aug 2016 11:26:38 -0700 (PDT) Received: from AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.25) by AT5PR84MB0289.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Wed, 10 Aug 2016 18:26:35 +0000 Received: from AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM ([10.162.138.25]) by AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM ([10.162.138.25]) with mapi id 15.01.0549.025; Wed, 10 Aug 2016 18:26:35 +0000 From: "Cohen, Eugene" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" CC: "lersek@redhat.com" Thread-Topic: [PATCH 05/26] ArmPkg: introduce ASM_FUNC, MOV32/MOV64 and ADRL/LDRL macros Thread-Index: AQHR8xp7KglcmmBgv0OctfuKUBEpJKBCgobA Date: Wed, 10 Aug 2016 18:26:35 +0000 Message-ID: References: <1470842282-8415-1-git-send-email-ard.biesheuvel@linaro.org> <1470842282-8415-6-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1470842282-8415-6-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=eugene@hp.com; x-originating-ip: [15.65.254.4] x-ms-office365-filtering-correlation-id: f360ccf0-0b2b-457b-a0c0-08d3c14bdc84 x-microsoft-exchange-diagnostics: 1; AT5PR84MB0289; 6:rqG/q23X5jZj+vQFM4CHz1GhdhQLKujITT0ZaxBKSRit5KJ2QHq5gYGFffDhLQCQzjwW7JtcIGeYnvYvCwWq2hrdLlmLlz9Oxd7lWUtosaPQBxdGPsrEHv/dN+xNiHrnJKy/ggrIkYb3o7xCLtoYOkKuwck+Qi0vBpO2yeMDBgfKxNYjo4XrpSZd+3alvG3GEeyvAexbS7kZMeNn5D2an3UwnaH/atKSjwWjG6Zh6atniJgypXuOf9pI737/zfp1BCcAP1N7oeb/0+qlCL/5ZbM1jgZsoTdQs2speb7z/dA=; 5:RJ0cQoPaTekEKkVQRYp3OIAu7C2xnJolEMSet9ZFPH3eOg1QSk7knfiiMjfAYR5X9PfVQWO9b5A6mmWurVhuXKlOOzDIm0T6LIhcqOEDDrkohdETJnq6eBtuxx/Coara4qffHNkEOZv73mueVxx3rQ==; 24:7Y8IePJMItub5O7xBVimwOpCdoK2eKXunOQ+D8AWMSIrcdCiPWbIe4qqAd8We3idzP91err6VH5UzRyh6vwVMKdVk8KOmfg46aXvJ2CtbQo=; 7:MaDrnoYkgteo5v1eP+v7Rd2h+O+7Fpm9GQDu2YBw6y0kpALhFq4Le0oV6RhUyVVMqOXme+n2Rk26wfoJmLzYi7ASO17J6mJwUqYzJVHXg3DGMTY6EyxraOT08qHV14q3uq1JUrxDopjJvX+5NOeoihNVLv1wExxGhQK4f745JGc4eBZkAMO3sz0JMP8O9eaIFD19pMwaxAZKTFImXwr1sofPQSRSFnpImwTv0CVANjH0KhtLGvkhxZqWyw9KHuAr x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0289; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:AT5PR84MB0289; BCL:0; PCL:0; RULEID:; SRVR:AT5PR84MB0289; x-forefront-prvs: 0030839EEE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(69224002)(189002)(199003)(6602003)(5002640100001)(11100500001)(102836003)(6116002)(76176999)(50986999)(101416001)(4326007)(3846002)(54356999)(99286002)(2906002)(105586002)(3280700002)(3660700001)(66066001)(92566002)(68736007)(106116001)(2950100001)(106356001)(87936001)(2900100001)(86362001)(189998001)(74316002)(9686002)(8936002)(2201001)(7696003)(81166006)(7736002)(77096005)(7846002)(5001770100001)(97736004)(8676002)(122556002)(305945005)(81156014)(10400500002)(2501003)(33656002)(586003); DIR:OUT; SFP:1102; SCL:1; SRVR:AT5PR84MB0289; H:AT5PR84MB0291.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2016 18:26:35.5148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0289 Subject: Re: [PATCH 05/26] ArmPkg: introduce ASM_FUNC, MOV32/MOV64 and ADRL/LDRL macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 18:26:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Ard, > +#define _ASM_FUNC(Name, Section) \ > + .global Name ; \ > + .section #Section, "ax" ; \ > + .type Name, %function ; \ > + Name: > + > +#define ASM_FUNC(Name) _ASM_FUNC(ASM_PFX(Name), > .text. ## Name) Why does this work? In my experimentation the C preprocessor would collaps= e the stuff onto a single line (the backslash being a continuation on the p= reprocessor input, but preprocessor output revealed the newlines being remo= ved), thereby violating the assembly requirement that labels appear in colu= mn 1. Thanks for all your work on this, now I'm just trying to understand what I'= m looking at! Eugene