From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=17.151.62.66; helo=nwk-aaemail-lapp01.apple.com; envelope-from=afish@apple.com; receiver=edk2-devel@lists.01.org Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1897521962301 for ; Wed, 16 Jan 2019 13:00:35 -0800 (PST) Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.27/8.16.0.27) with SMTP id x0GKuhos036742 for ; Wed, 16 Jan 2019 13:00:34 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=mime-version : content-type : sender : from : subject : message-id : date : to; s=20180706; bh=Be/zOnh4ARwDK+0Op2y0nyhcv3ntJzPhoPD2xNgMics=; b=pFlqlFwxZAiB8rXvwh/QV7iPqOW6vo3jeAGAUQRmONFDU8cz6TO1YUpq47udjrcTscfP UiwTJbz957b4w9cdfrC2cMm7/fpU8FbQffuIqet7kCQ9Bfy3XIoqBmZc2KS8RmeNPliZ QCRCOYkuwF08g/UWdFxefktUc4i8NTXW6zD1irhOe2bQ57G46MoJ3XdWYC0vBacUOdMM cDf6g64fWKtYjTvXRPsXVDZGv21npl0Z5LuQ0NaRh/PfyhFnnICNUDr/A1/s+1IrpMRR sHwNo8/g+hFYjUn4qcLrlYcEzL3KO/l8K0tmslJnhYdKuFxzaE61N02wweT8h58Anda4 xg== Received: from ma1-mtap-s01.corp.apple.com (ma1-mtap-s01.corp.apple.com [17.40.76.5]) by nwk-aaemail-lapp01.apple.com with ESMTP id 2pyg26ynsf-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Wed, 16 Jan 2019 13:00:34 -0800 MIME-version: 1.0 Received: from nwk-mmpp-sz12.apple.com (nwk-mmpp-sz12.apple.com [17.128.115.204]) by ma1-mtap-s01.corp.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPS id <0PLF00JV7ZOX1G90@ma1-mtap-s01.corp.apple.com> for edk2-devel@lists.01.org; Wed, 16 Jan 2019 13:00:33 -0800 (PST) Received: from process_viserion-daemon.nwk-mmpp-sz12.apple.com by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0PLF00M00Z9JJB00@nwk-mmpp-sz12.apple.com> for edk2-devel@lists.01.org; Wed, 16 Jan 2019 13:00:33 -0800 (PST) X-Va-A: X-Va-T-CD: 3b266a2f6a8b2663ff6662a8ca2180b2 X-Va-E-CD: 6174e7376a63475bb0d9e9aee6fcfe2b X-Va-R-CD: be5ee3a8c2a971789fd8a99ca962598e X-Va-CD: 0 X-Va-ID: 1407053c-887b-41c0-8a3b-4c79bc230243 X-V-A: X-V-T-CD: 3b266a2f6a8b2663ff6662a8ca2180b2 X-V-E-CD: 6174e7376a63475bb0d9e9aee6fcfe2b X-V-R-CD: be5ee3a8c2a971789fd8a99ca962598e X-V-CD: 0 X-V-ID: 0ac161e0-12b4-40ca-8313-8da741463269 Received: from process_milters-daemon.nwk-mmpp-sz12.apple.com by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0PLF00700ZL4LR00@nwk-mmpp-sz12.apple.com> for edk2-devel@lists.01.org; Wed, 16 Jan 2019 13:00:32 -0800 (PST) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-16_08:,, signatures=0 Received: from [17.226.41.14] (unknown [17.226.41.14]) by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPSA id <0PLF001XIZOWNO90@nwk-mmpp-sz12.apple.com> for edk2-devel@lists.01.org; Wed, 16 Jan 2019 13:00:32 -0800 (PST) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Wed, 16 Jan 2019 13:00:07 -0800 To: edk2-devel X-Mailer: Apple Mail (2.3445.6.18) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-16_08:, , signatures=0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: History question about Base.h and its alternate parallel name space.... Should we change it? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 21:00:35 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT I had some one ask me recently why EFI_GUID does not work with #include . I explained they needed to use GUID vs. EFI_GUID. That prompted the question of why we have 2 names for the same thing..... Well the historical answer was kind of political as some team wanted to use edk2, but not implement EFI. Thus we have EFI types without the EFI_ prefix in Base.h. So all this got me thinking.... Maybe it makes sense to move some of the renaming from MdePkg/Include/Uefi/UefiBaseType.h to Base.h? Removing the Base.h duplicate types would potentially hit lots of code [1] and break merges with other code bases (break other peoples Base libs etc.). These lines in MdePkg/Include/Uefi/UefiBaseType.h would get moved to MdePkg/Include/Base.h: typedef GUID EFI_GUID; typedef RETURN_STATUS EFI_STATUS; #define EFIERR(_a) ENCODE_ERROR(_a) #define EFI_ERROR(A) RETURN_ERROR(A) #define EFI_SUCCESS RETURN_SUCCESS #define EFI_LOAD_ERROR RETURN_LOAD_ERROR #define EFI_INVALID_PARAMETER RETURN_INVALID_PARAMETER #define EFI_UNSUPPORTED RETURN_UNSUPPORTED #define EFI_BAD_BUFFER_SIZE RETURN_BAD_BUFFER_SIZE #define EFI_BUFFER_TOO_SMALL RETURN_BUFFER_TOO_SMALL #define EFI_NOT_READY RETURN_NOT_READY #define EFI_DEVICE_ERROR RETURN_DEVICE_ERROR #define EFI_WRITE_PROTECTED RETURN_WRITE_PROTECTED #define EFI_OUT_OF_RESOURCES RETURN_OUT_OF_RESOURCES #define EFI_VOLUME_CORRUPTED RETURN_VOLUME_CORRUPTED #define EFI_VOLUME_FULL RETURN_VOLUME_FULL #define EFI_NO_MEDIA RETURN_NO_MEDIA #define EFI_MEDIA_CHANGED RETURN_MEDIA_CHANGED #define EFI_NOT_FOUND RETURN_NOT_FOUND #define EFI_ACCESS_DENIED RETURN_ACCESS_DENIED #define EFI_NO_RESPONSE RETURN_NO_RESPONSE #define EFI_NO_MAPPING RETURN_NO_MAPPING #define EFI_TIMEOUT RETURN_TIMEOUT #define EFI_NOT_STARTED RETURN_NOT_STARTED #define EFI_ALREADY_STARTED RETURN_ALREADY_STARTED #define EFI_ABORTED RETURN_ABORTED #define EFI_ICMP_ERROR RETURN_ICMP_ERROR #define EFI_TFTP_ERROR RETURN_TFTP_ERROR #define EFI_PROTOCOL_ERROR RETURN_PROTOCOL_ERROR #define EFI_INCOMPATIBLE_VERSION RETURN_INCOMPATIBLE_VERSION #define EFI_SECURITY_VIOLATION RETURN_SECURITY_VIOLATION #define EFI_CRC_ERROR RETURN_CRC_ERROR #define EFI_END_OF_MEDIA RETURN_END_OF_MEDIA #define EFI_END_OF_FILE RETURN_END_OF_FILE #define EFI_INVALID_LANGUAGE RETURN_INVALID_LANGUAGE #define EFI_COMPROMISED_DATA RETURN_COMPROMISED_DATA #define EFI_HTTP_ERROR RETURN_HTTP_ERROR #define EFI_WARN_UNKNOWN_GLYPH RETURN_WARN_UNKNOWN_GLYPH #define EFI_WARN_DELETE_FAILURE RETURN_WARN_DELETE_FAILURE #define EFI_WARN_WRITE_FAILURE RETURN_WARN_WRITE_FAILURE #define EFI_WARN_BUFFER_TOO_SMALL RETURN_WARN_BUFFER_TOO_SMALL #define EFI_WARN_STALE_DATA RETURN_WARN_STALE_DATA #define EFI_WARN_FILE_SYSTEM RETURN_WARN_FILE_SYSTEM I'm interested what folks think about a change like this? This change makes the alternate names optional. I guess we could also leave the old Base.h definitions in Base.h and cleanup the code to only use the EFI form, but that is a much bigger change? [1] RETURN_SUCCSS usage: git grep -w RETURN_SUCCESS Thanks, Andrew Fish