Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData

["Guomin Jiang" <guomin.jiang@intel.com>]

Hi Michael, Liming,

Could you help review the patch.

Thanks.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 1:58 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for
> pointer BinData
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531
> 
> AllocatePool may fail and BinData may be invalid, check it before use.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> index 6f7c31cab4..933d2b40e0 100644
> --- a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> +++ b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> @@ -252,6 +252,9 @@ RfcDecodeTest(
>    BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE);
> 
>    BinData = AllocatePool (BinSize);
> +  if (BinData == NULL) {
> +    return UNIT_TEST_ERROR_TEST_FAILED;  }
>    Btc->BufferToFree = BinData;
> 
>    ReturnSize = BinSize;
> --
> 2.17.1
> 
> 
>