Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments

["Guomin Jiang" <guomin.jiang@intel.com>]

Hi Ray, Rangasai,

Could you help review the patch.

Thanks.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Monday, March 9, 2020 9:21 AM
> To: devel@edk2.groups.io; newexplorerj@gmail.com
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add
> periods in comments
> 
> Reviewed-By: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Thanks,
> Shenglei
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > GuoMinJ
> > Sent: Thursday, March 5, 2020 1:47 PM
> > To: devel@edk2.groups.io
> > Cc: GuoMinJ <newexplorerj@gmail.com>
> > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add
> > periods in comments
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2518
> >
> > ECC need '.' character at the end of line.
> >
> > Ray Ni <ray.ni@intel.com>
> > Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > ---
> >  .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h  | 6 +++---
> >  .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c         | 6 +++---
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git
> > a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> > index 99b8ae4b5a..37a3968168 100644
> > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> > @@ -10,7 +10,7 @@
> >  #define _CONFIG_BLOCK_LIB_H_
> >
> >  /**
> > -  Create config block table
> > +  Create config block table.
> >
> >    @param[in]     TotalSize                    - Max size to be allocated for the Config
> > Block Table
> >    @param[out]    ConfigBlockTableAddress      - On return, points to a
> pointer
> > to the beginning of Config Block Table Address @@ -27,7 +27,7 @@
> > CreateConfigBlockTable (
> >    );
> >
> >  /**
> > -  Add config block into config block table structure
> > +  Add config block into config block table structure.
> >
> >    @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of
> > Config Block Table Address
> >    @param[out]    ConfigBlockAddress           - On return, points to a pointer
> to
> > the beginning of Config Block Address
> > @@ -44,7 +44,7 @@ AddConfigBlock (
> >    );
> >
> >  /**
> > -  Retrieve a specific Config Block data by GUID
> > +  Retrieve a specific Config Block data by GUID.
> >
> >    @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of
> > Config Block Table Address
> >    @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to
> > search specific Config Block
> > diff --git
> > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB
> > lockLi
> > b.c
> > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB
> > lockLi
> > b.c
> > index 33e0c81e9d..c89699ea46 100644
> > ---
> > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB
> > lockLi
> > b.c
> > +++
> > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB
> > lockLi
> > b.c
> > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > #include <Library/DebugLib.h>
> >
> >  /**
> > -  Create config block table
> > +  Create config block table.
> >
> >    @param[in]     TotalSize                    - Max size to be allocated for the Config
> > Block Table
> >    @param[out]    ConfigBlockTableAddress      - On return, points to a
> pointer
> > to the beginning of Config Block Table Address @@ -51,7 +51,7 @@
> > CreateConfigBlockTable (  }
> >
> >  /**
> > -  Add config block into config block table structure
> > +  Add config block into config block table structure.
> >
> >    @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of
> > Config Block Table Address
> >    @param[out]    ConfigBlockAddress           - On return, points to a pointer
> to
> > the beginning of Config Block Address
> > @@ -94,7 +94,7 @@ AddConfigBlock (
> >  }
> >
> >  /**
> > -  Retrieve a specific Config Block data by GUID
> > +  Retrieve a specific Config Block data by GUID.
> >
> >    @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of
> > Config Block Table Address
> >    @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to
> > search specific Config Block
> > --
> > 2.17.1
> >
> >
> >
> 
> 
>